Commit Graph

16341 Commits

Author SHA1 Message Date
James Bardin 888af93356 Have S3 check the lockID on Unlock
This needs to be improved to happen in a transaction, but it gets the
implementation passing the new tests.
2017-02-15 14:44:43 -05:00
James Bardin 67bbebce08 Have consul state reutrn the lock ID
The lock ID isn't used because the lock is tied to the client, but
return the lock ID to match the behavior of other locks.
2017-02-15 14:44:43 -05:00
James Bardin f2e496a14c Have backend operations properly unlock state
Make sure unlock is called with the correct LockID during operations
2017-02-15 14:41:55 -05:00
James Bardin 08cff7cc13 have LocalState check Lock ID on Unlock
Have LocalState store and check the lock ID, and strictly enforce
unlocking with the correct ID.

This isn't required for local lock correctness, as we track the file
descriptor to unlock, but it does provide a varification that locking
and unlocking is done correctly throughout terraform.
2017-02-15 14:41:55 -05:00
James Bardin 6aa1066f7c Store and use the correct IDs in TestRemoteLocks 2017-02-15 14:41:55 -05:00
James Bardin f5ed8cd288 Use NewLockInfo to get a pre-populated value
Using NewLockInfo ensure we start with all required fields filled.
2017-02-15 14:41:55 -05:00
James Bardin 52b2343672 make state test pass with new state.Locker 2017-02-15 14:41:55 -05:00
James Bardin 4f0c465187 make command tests pass with new state.Locker 2017-02-15 14:41:55 -05:00
James Bardin cd233fef6a make consul client pass state.Locker tests 2017-02-15 14:41:55 -05:00
James Bardin 67dc16c9ca Make backend/local test pass 2017-02-15 14:41:55 -05:00
James Bardin 6d32b70637 Make S3 remote state pass tests
TODO: update S3Client to make full use of the state.Locker interface
2017-02-15 14:41:55 -05:00
James Bardin 0ad6f08204 Make remote state test run
Make them compile against the new interface.
The tests will be updated later to check new behavior.
2017-02-15 14:41:55 -05:00
James Bardin 200c8de4e9 Update the state.Locker interface
Remove CacheState rather than update it, since it's no longer used.
2017-02-15 14:41:55 -05:00
Mitchell Hashimoto bbae22007d Merge pull request #11921 from hashicorp/b-untarget-output
terraform: outputs should not be included if not targeted
2017-02-15 10:47:14 -08:00
Paul Stack cae76db1ba provider/aws: Bump SDK version fo 1.6.22 (#11968)
Adds support for EBS Elastic Volumes
2017-02-15 16:49:14 +00:00
Paul Stack 168c334bc8 Update CHANGELOG.md 2017-02-15 16:37:57 +00:00
Paul Stack da2202277d provider/aws: Enable snapshotting by default on aws_redshift_cluster (#11695)
This extends the work in #11668 to enable final snapshots by default.
This time it's for redshift

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRedshiftCluster_withFinalSnapshot'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/04 13:53:02 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRedshiftCluster_withFinalSnapshot -timeout 120m
=== RUN   TestAccAWSRedshiftCluster_withFinalSnapshot
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (859.96s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	859.986s
```
2017-02-15 16:37:06 +00:00
Sander van Harmelen ceb817b8f4 Update CHANGELOG.md 2017-02-15 16:13:10 +01:00
Paul Stack f681fbf4f6 provider/digitalocean: Bump SDK version of godo for loadbalancer support (#11964) 2017-02-15 14:35:41 +00:00
Laurens Vanderhoven d29f2d6f6d provider/azurerm: Remove location argument from loadbalancer_backend_address_pool (#11963)
Applying a Terraform execution plan containing a loadbalancer_backend_address_pool
with a location argument throws a warning:

----
Warnings:

  * azurerm_lb_backend_address_pool.test: "location": [DEPRECATED] location is no longer used

  No errors found. Continuing with 1 warning(s).
----
2017-02-15 13:50:19 +00:00
James Nugent c455cccb68 Merge pull request #11958 from hashicorp/b-datadog-spelling-mistake
provider/datadog: Fix spelling mistake of monitor in datadog_monitor error message
2017-02-15 04:48:44 -06:00
Paul Stack 8df5fcd0bd provider/aws: Add default_cooldown to the autoscaling_group docs (#11957)
Fixes: #11947
2017-02-15 10:46:17 +00:00
stack72 b6f67b2374
provider/datadog: Fix spelling mistake of monitor in datadog_monitor
error message

Fixes: #11951
2017-02-15 10:41:37 +00:00
Radek Simko 0e8997f369 Merge pull request #11954 from hashicorp/f-google-compute-zones
provider/google: Add google_compute_zones data source
2017-02-15 10:00:39 +00:00
Traver Tischio e0aae4392b provider/fastly Allows for conditional settings across fastly (#11843)
* Adds response conditions for papertrail in fastly

* Adds cache conditional for gzip in fastly

* Opens up conitionals under fastly headers

* Adds request conditions to s3 logging for fastly

* Creates conditionals properly for testing

* Clarifies conditionals documentation for the website

* Clarifies resource descriptions for conditionals

* Formats papertrail testing properly

* Fizes syntax issues in gzip and s3 fastly testing

* Tests full schemas for gzip basic testing

* Updates header testing to check full schema

* Fixes gzip and headers testing

* Fixes s3 conditional testing
2017-02-15 09:53:59 +00:00
Raphaël Pinson c3042765a0 rancher: parse Rancher client cli.json config file (#11658)
* rancher: parse Rancher client cli.json config file

* Make it work
2017-02-15 09:51:56 +00:00
Radek Simko 76c40ac451
provider/google: Add google_compute_zones data source 2017-02-15 09:50:25 +00:00
Joe Topjian 47bf2eff09 provider/openstack BlockStorage v1 availability_zone Fix (#11949)
* vendor: Updating Gophercloud

* provider/openstack: Fix upstream AvailabilityZone field

This commit complements an upstream fix where "availability" was being sent instead of
"availability_zone".
2017-02-15 09:37:05 +00:00
youyo 1c3d812d94 typo? (#11933)
That worked fine!
2017-02-15 09:33:55 +00:00
Mitchell Hashimoto 235b7eb38e Merge pull request #11944 from hashicorp/f-state-slow
show message if state lock acquisition/release is slow
2017-02-14 14:00:23 -08:00
Jake Champlin 7fa5731ad5 Merge pull request #11946 from hashicorp/website-type-update-fixes
Website type update fixes
2017-02-14 15:32:58 -05:00
Mitchell Hashimoto 5e4f6cf2b1
backend/local: fix could not to did not to prevent error look 2017-02-14 12:09:45 -08:00
Jason Costello c6baf92ded typo 2017-02-14 11:59:01 -08:00
Mitchell Hashimoto b7a143fffb
command/state: improved error message on state lock fail 2017-02-14 11:44:43 -08:00
Jason Costello fdc82fc5aa improve klavika declaration 2017-02-14 11:37:11 -08:00
Mitchell Hashimoto 18bc77c359
command/state: up the threshold for showing lock info 2017-02-14 11:36:21 -08:00
Mitchell Hashimoto 90f3d40c1f
command: use new state lock/unlock helpers for better UX 2017-02-14 11:33:55 -08:00
Jason Costello 824893ed9d add typekit classes to hide FOUC 2017-02-14 11:28:43 -08:00
Mitchell Hashimoto 65982bd412
backend/local: use new command/state package for better UX 2017-02-14 11:17:28 -08:00
Mitchell Hashimoto 34f438b635
command/state: helpers for UX with lock/unlock state 2017-02-14 11:17:18 -08:00
Mitchell Hashimoto 2124135287
helper/slowmessage 2017-02-14 09:27:23 -08:00
Mitchell Hashimoto a7cfb8062b
state: just style changes in the code itself (newlines, moving methods) 2017-02-14 08:51:20 -08:00
Radek Simko 52dff703ad website: Fix wrong font URL and decrease size 2017-02-14 10:52:49 +00:00
Mitchell Hashimoto 3e2f324b20 Merge pull request #11927 from hashicorp/typographic-updates
Website typographic updates
2017-02-13 17:26:56 -08:00
Jason Costello e498aa0408 bold active docs nav item 2017-02-13 16:28:37 -08:00
Jason Costello f068146d30 oops 2017-02-13 16:17:57 -08:00
Jason Costello 9754a32146 lighter body copy for hierarchy via utility classes 2017-02-13 16:16:20 -08:00
Jason Costello f07d89d4e4 Klavika for docs nav 2017-02-13 16:15:55 -08:00
Mitchell Hashimoto b393f0ac0a Update CHANGELOG.md 2017-02-13 15:27:19 -08:00
Mitchell Hashimoto d2f9df37f5 Merge pull request #11922 from hashicorp/f-tf-cli
command: add TF_CLI_ARGS to specify additional CLI args
2017-02-13 15:26:25 -08:00