3fa063b8dc
command/format: concise diff is now the default ( #27079 )
...
* command/format: concise diff is no longer an experiment
Since state formatting goes through the "diff" printer, I have
repurposed the concise flag as a verbose flag, used only when printing
state. It's silly but it works!
* remove helper/experiment
With this experiment concluded, we no longer need helper/experiment. The
shadow experiment had not been touched in many years, so I removed all
references, and removed the package entirely. Any new experiments are
expected to be configuration experiments handled by our (other)
experiments package.
* check for the verbose flag consistently, in case we end up using it in plans in the future
2020-12-02 15:42:41 -05:00
6529659455
internal/providercache: staticcheck
2020-12-02 13:59:20 -05:00
313d3e5c4d
builtin/provisioners/remote-exec: staticcheck
2020-12-02 13:59:20 -05:00
0b4c96fa92
command/jsonprovider: staticcheck
2020-12-02 13:59:20 -05:00
63b521b8b7
communicator/ssh: staticcheck
2020-12-02 13:59:19 -05:00
aeb96384fd
configs/configload: staticcheck
2020-12-02 13:59:19 -05:00
9c3ece40f7
configs/configschema: staticcheck
2020-12-02 13:59:19 -05:00
82305bf1c8
configs: staticcheck
2020-12-02 13:59:19 -05:00
8925d94387
dag: staticcheck
2020-12-02 13:59:19 -05:00
89a8624d8c
instances: staticcheck
2020-12-02 13:59:19 -05:00
d22e08bd32
internal/earlyconfig: staticcheck
2020-12-02 13:59:19 -05:00
f0c3ddf5a1
internal/getproviders: staticcheck
2020-12-02 13:59:19 -05:00
4ad7c41ab4
unused
2020-12-02 13:59:19 -05:00
276dfe634f
internal/providercache: staticcheck
2020-12-02 13:59:19 -05:00
1f359bab03
internal/typeexpr: staticcheck
...
diagnostics were appended to diags shadowing the intended value.
2020-12-02 13:59:19 -05:00
e08422511e
lang/funcs: staticcheck
2020-12-02 13:59:19 -05:00
a5f013830f
plans: staticcheck
2020-12-02 13:59:19 -05:00
fa3e534142
plans/planfile: staticcheck
2020-12-02 13:59:19 -05:00
b5e5adda01
plugin/discovery: staticcheck
2020-12-02 13:59:19 -05:00
3deeb94aac
registry: staticcheck
2020-12-02 13:59:19 -05:00
e347b012df
registry/test: staticcheck
2020-12-02 13:59:19 -05:00
c6cea8efc3
states/statefile: staticcheck
2020-12-02 13:59:19 -05:00
c2f8b06594
states/statemgr: staticcheck
2020-12-02 13:59:19 -05:00
0fb7d19191
states/statemgr: t.Fatal from goroutine
2020-12-02 13:59:19 -05:00
3a6c32cb1c
terraform: staticcheck
2020-12-02 13:59:19 -05:00
41d4dd82d6
format staticcheck
2020-12-02 13:59:19 -05:00
a1d41504f2
e2etest staticcheck
2020-12-02 13:59:19 -05:00
1c58c6ba48
command staticcheck
2020-12-02 13:59:19 -05:00
ccf0d8815f
staticcheck
2020-12-02 13:59:19 -05:00
2016b6bd1c
validate is no longer called from there
2020-12-02 13:59:19 -05:00
8b08ebc4b5
consistent recievers
2020-12-02 13:59:19 -05:00
6f577abc72
unused
2020-12-02 13:59:19 -05:00
f521fcca97
cleanup error handling and some for loops
2020-12-02 13:59:19 -05:00
96436f526a
unused err value and nil context
...
Incorrect err assignment had no effect.
Never use a nil context.
2020-12-02 13:59:19 -05:00
d2c2d58f09
unused
2020-12-02 13:59:19 -05:00
ddb5b9ee53
fix break from switch in loop
2020-12-02 13:59:19 -05:00
44ccb94e2e
remove unused
2020-12-02 13:59:18 -05:00
bdfea50cc8
remove unused
2020-12-02 13:59:18 -05:00
1e8537b8d4
remove unused
2020-12-02 13:59:18 -05:00
1b530b7d9d
remove unused
2020-12-02 13:59:18 -05:00
11e5ab0376
unchecked error
...
We don't need the nil checks if we check the error
2020-12-02 13:59:18 -05:00
810ab0386f
remove unused
2020-12-02 13:59:18 -05:00
729c9b6f10
consistent reciever names
2020-12-02 13:59:18 -05:00
c5299b5745
consistent reciever names
2020-12-02 13:59:18 -05:00
b2d0e20759
Merge pull request #27078 from hashicorp/jbardin/remove-netrpc-plugin
...
Remove netrpc plugin
2020-12-02 13:23:29 -05:00
0c107e502f
Merge pull request #27077 from hashicorp/jbardin/internal-provisioners
...
Internal, in-process provisioners
2020-12-02 13:23:13 -05:00
f2c5aa6d28
Merge pull request #27076 from hashicorp/jbardin/legacy-cleanup
...
Legacy types cleanup
2020-12-02 13:22:41 -05:00
381cc0b5d6
Merge pull request #26961 from hashicorp/jbardin/internal-legacy-packages
...
Move deprecated packages to internal/legacy
2020-12-02 13:19:50 -05:00
df56a5f8ae
remove dead code from tf provider
2020-12-02 13:07:10 -05:00
6aae0a94bd
remove netrpc plugins
...
Provisioner plugins were the last remaining use of the legacy netrpc
plugin interface (even though it was wrapped in shimmed into the grpc
protocol). Now that these types are no longer being used, we can remove
the old code from the plugin package entirely.
2020-12-02 13:07:10 -05:00
Kristin Laemmert