staticcheck

command/012_config_upgrade.go

@@ -1,7 +1,6 @@
 package command
 
 import (
-	"fmt"
 	"strings"
 )
 
@@ -10,10 +9,10 @@ type ZeroTwelveUpgradeCommand struct {
 }
 
 func (c *ZeroTwelveUpgradeCommand) Run(args []string) int {
-	c.Ui.Output(fmt.Sprintf(`
+	c.Ui.Output(`
 The 0.12upgrade command has been removed. You must run this command with
 Terraform v0.12 to upgrade your configuration syntax before upgrading to the
-current version.`))
+current version.`)
 	return 0
 }
 

command/013_config_upgrade.go

@@ -1,7 +1,6 @@
 package command
 
 import (
-	"fmt"
 	"strings"
 )
 
@@ -12,10 +11,10 @@ type ZeroThirteenUpgradeCommand struct {
 }
 
 func (c *ZeroThirteenUpgradeCommand) Run(args []string) int {
-	c.Ui.Output(fmt.Sprintf(`
+	c.Ui.Output(`
 The 0.13upgrade command has been removed. You must run this command with
 Terraform v0.13 to upgrade your provider requirements before upgrading to the
-current version.`))
+current version.`)
 	return 0
 }
 

command/clistate/state_test.go

@@ -2,7 +2,6 @@ package clistate
 
 import (
 	"context"
-	"fmt"
 	"testing"
 
 	"github.com/hashicorp/terraform/states/statemgr"
@@ -18,7 +17,7 @@ func TestUnlock(t *testing.T) {
 
 	err := l.Unlock(nil)
 	if err != nil {
-		fmt.Printf(err.Error())
+		t.Log(err.Error())
 	} else {
 		t.Error("expected error")
 	}