Commit Graph

2640 Commits

Author SHA1 Message Date
Sander van Harmelen 40ca4c1c81 Merge pull request #676 from svanharmelen/f-fix-expand-bug
core: fix expand bug
2014-12-16 11:04:25 +01:00
Mitchell Hashimoto 8426f5140b Update CHANGELOG 2014-12-15 22:14:08 -08:00
Mitchell Hashimoto 675eab11d3 Merge pull request #679 from hashicorp/b-fix-module=type
config: validate that module variables can go to ints, convert [GH-624]
2014-12-15 22:13:02 -08:00
Mitchell Hashimoto d24082da1e config: validate that module variables can go to ints, convert [GH-624] 2014-12-15 22:10:16 -08:00
Mitchell Hashimoto 913f9a923e helper/schema: remove unnecessary code 2014-12-15 17:39:07 -08:00
Mitchell Hashimoto e5877543b2 helper/schema: track map element counts
This adds "field.#" values to the state/diff with the element count of a
map. This fixes a major issue around not knowing when child elements are
computed when doing variable access of a computed map.

Example, if you have a schema like this:

    "foo": &Schema{
        Type:     TypeMap,
        Computed: true,
    }

And you access it like this in a resource:

    ${type.name.foo.computed-field}

Then Terraform will error that "field foo could not be found on resource
type.name". By adding that "foo.#" is computed, Terraform core will pick
up that it WILL exist, so its okay.
2014-12-15 17:35:16 -08:00
Mitchell Hashimoto 41dabd7abc Update CHANGELOG 2014-12-15 16:41:09 -08:00
Mitchell Hashimoto 4f70630c52 Merge pull request #525 from pmoust/patch-2
provider/aws: update to support more regions
2014-12-15 16:40:35 -08:00
Sander van Harmelen 43a30e7d13 Finishing up the needed changes
Also executed the acceptance tests successfully now.
2014-12-16 00:59:47 +01:00
Sander van Harmelen ee7b33acf4 Fixing the flipflop problem
Actually meant as a PoC, but it works perfectly so let’s just merge
this…
2014-12-16 00:40:43 +01:00
Mitchell Hashimoto 5987ce30f9 up version for dev 2014-12-15 15:36:19 -08:00
Mitchell Hashimoto 935bc08003 update CHANGELOG 2014-12-15 15:36:07 -08:00
Mitchell Hashimoto c2385a5012 Merge pull request #632 from KushalP/master
config: do not read temporary editor files, fixes #548
2014-12-15 15:07:03 -08:00
Sander van Harmelen 528167513b Looking at issue #639 this seems to be the root cause
After fixing this part, there also needs to be made a change to the
example given or the schema of aws_elb.
2014-12-15 23:38:46 +01:00
Sander van Harmelen 820476ef61 Merge pull request #675 from svanharmelen/f-fix-typo/style
Fixed a type and reordered the case statements
2014-12-15 23:11:05 +01:00
Sander van Harmelen 40fa6c3aaa Fixed a type and reordered the case statements
Making in more inline with the existing code…
2014-12-15 23:02:16 +01:00
Mitchell Hashimoto 6a663796d5 Merge pull request #663 from svanharmelen/f-fix/change-set-logic
core: refactoring the way sets work internally v2
2014-12-15 13:38:00 -08:00
Armon Dadgar f6bfbac3d1 website: Add link to heroku_cert in the docs 2014-12-15 12:14:00 -08:00
Armon Dadgar f923368fc5 Merge pull request #672 from plan3-labs/heroku_cert_support
Heroku SSL certificate support
2014-12-15 12:12:57 -08:00
Sander van Harmelen 9f0c8874b9 Merge pull request #674 from svanharmelen/f-make-func-names-consistent
Making all function names consistent
2014-12-15 15:57:02 +01:00
Sander van Harmelen 4ace4865d7 Making all function names consistent
Before all providers were using the helper.Schema approach the helper
function had these names. Now they all use names consistent with the Go
naming conventions except for these last few…
2014-12-15 15:26:17 +01:00
Jakub Janczak 765cd1f494 Heroku SSL support: fixes after code review of @svanharmelen 2014-12-15 15:10:59 +01:00
Jakub Janczak 3c0e9970e5 Heroku SSL certificate support added 2014-12-15 12:21:47 +01:00
Armon Dadgar 6098809ec5 Merge pull request #665 from gosuri/master
Fix for #664, crashed due to ig.Attachements being 0
2014-12-14 18:15:27 -08:00
Armon Dadgar 5535767989 Merge pull request #666 from donjohnson/patch-1
Usage info for graph command was actually that of output
2014-12-14 17:43:30 -08:00
Greg Osuri 9b9d147585 Setting the VPC id to blank for unattached igws 2014-12-14 14:05:38 -08:00
Sander van Harmelen cbd913259a Merge pull request #667 from svanharmelen/f-fix-schema-aws-internet-gateway
provider/aws: fixing the aws_internet_gateway resource
2014-12-14 12:42:13 +01:00
Sander van Harmelen 27a97c4498 Small gofmt update... 2014-12-14 12:32:17 +01:00
Sander van Harmelen d9af954c60 provider/aws: fixing the aws_internet_gateway resource
The resource is build so it can attach and detach the Internet Gateway
from a VPC, but as the schema has `Required` and `ForceNew` both set
to `true` for the vpc_id field it will never use these capabilities.
2014-12-14 12:20:59 +01:00
Don Johnson e02c62347d Usage info for graph command was actually that of output 2014-12-14 17:21:43 +09:00
Greg Osuri 3883e47902 Fix for #664, crashed due to ig.Attachements being 0 2014-12-13 22:14:23 -08:00
Sander van Harmelen 83c760fcb3 core: refactoring the way sets work internally v2
This is a refactored solution for PR #616. Functionally this is still
the same change, but it’s implemented a lot cleaner with less code and
less changes to existing parts of TF.
2014-12-12 23:21:20 +01:00
Sander van Harmelen 69b2c245dd Merge pull request #662 from svanharmelen/master
core: fixing new test
2014-12-12 15:44:49 +01:00
Sander van Harmelen 4c23019ab7 core: fixing new test
Removed the ‘hashcode’ function so we didn’t need to import it here,
but also removed the needed type assertion.
2014-12-12 15:42:01 +01:00
Sander van Harmelen db640cb1dc Merge pull request #661 from svanharmelen/f-fix-difflist-logic-error
core: fixing a small logic bug in diffList
2014-12-12 15:31:22 +01:00
Sander van Harmelen 54db46ef1b Fixing a small logic bug in diffList
It’s not enough to only check if no new value is set. It can also be
that a new value is set, but contains a variable that cannot be
interpolated until a depending resource is created during the apply
fase.

I actually found this one as one of the acceptance tests for the AWS
ELB resource was failing. It failed with the following error:

```
--- FAIL: TestAccAWSELB_InstanceAttaching (177.83 seconds)
  testing.go:121: Step 1 error: Error applying: aws_elb.bar: diffs
didn't match during apply. This is a bug with the resource provider,
please report a bug.
FAIL
exit status 1
FAIL  github.com/hashicorp/terraform/builtin/providers/aws  177.882s
```

After a quick look I noticed it was actually a bug in core TF so added
the test and made sure all unit tests and AWS acceptance tests are now
running successfully.
2014-12-12 15:24:29 +01:00
Sander van Harmelen afe2cf8580 Merge pull request #660 from svanharmelen/f-fix-aws-network-acl
Fixing up the tests so they actually pass
2014-12-12 13:32:30 +01:00
Sander van Harmelen cc4710c952 Fixing up the tests so they actually pass
Running the tests without these changes results in this error first:

```
--- FAIL: TestAccAWSNetworkAclsOnlyIngressRulesChange (24.92 seconds)
  testing.go:121: Step 0 error: Check failed: Invalid number of ingress
entries found; count = %!s(int=3)
FAIL
exit status 1
FAIL  github.com/hashicorp/terraform/builtin/providers/aws  24.974s
```

And after fixing that one you also get a few unexpected values due to
an expected order mismatch between the items in the set versus the
items in the config.

Those are also fixed, so the test is passing now.
2014-12-12 13:25:44 +01:00
Armon Dadgar 7a3b4fa7ce Merge pull request #648 from yahyapo/master
Adding tag support to AWS EC2 route table resource.
2014-12-10 19:24:38 -08:00
Mitchell Hashimoto 9e6ce4b961 Merge pull request #643 from pmoust/patch-3
bump to 0.3.5
2014-12-10 13:36:04 -08:00
Sander van Harmelen 17bc60fb68 Merge pull request #645 from svanharmelen/f-cloudstack-provider
First release of a provider for CloudStack
2014-12-10 22:33:09 +01:00
Mitchell Hashimoto 8cb3e5715b remote: respect ATLAS_TOKEN 2014-12-10 13:27:12 -08:00
Mitchell Hashimoto f0de69b3c5 provider/atlas: bin 2014-12-10 13:27:12 -08:00
Mitchell Hashimoto aeecabbb33 v0.3.5 2014-12-10 13:27:12 -08:00
Mitchell Hashimoto d4722f4fdf Update CHANGELOG 2014-12-10 13:27:12 -08:00
Mitchell Hashimoto 14318059b8 Update CHANGELOG 2014-12-10 13:27:12 -08:00
Armon Dadgar 1e8b930b83 website: Adding newline 2014-12-10 13:27:11 -08:00
Mitchell Hashimoto edc4a277d6 provider/atlas: fix required token 2014-12-10 13:27:11 -08:00
Armon Dadgar 0ff62016ee provider/aws: Fixing ASG handling of not found 2014-12-10 13:27:11 -08:00
Mitchell Hashimoto 124d9fc0bd providers/atlas: make errors more readable 2014-12-10 13:27:11 -08:00