ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Heroku SSL support: fixes after code review of @svanharmelen

This commit is contained in:
Jakub Janczak 2014-12-15 15:10:59 +01:00
parent 3c0e9970e5
commit 765cd1f494
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builtin/providers/heroku/resource_heroku_cert.go
View File

@ -70,7 +70,7 @@ func resourceHerokuCertCreate(d *schema.ResourceData, meta interface{}) error {
func resourceHerokuCertRead(d *schema.ResourceData, meta interface{}) error {
client := meta.(*heroku.Service)
cert, err := resource_heroku_ssl_cert_retrieve(
cert, err := resourceHerokuSSLCertRetrieve(
d.Get("app").(string), d.Id(), client)
if err != nil {
return err
@ -79,8 +79,6 @@ func resourceHerokuCertRead(d *schema.ResourceData, meta interface{}) error {
d.Set("certificate_chain", cert.CertificateChain)
d.Set("name", cert.Name)
d.Set("cname", cert.CName)
d.Set("created_at", cert.CreatedAt)
d.Set("updated_at", cert.UpdatedAt)
return nil
}
@ -125,7 +123,7 @@ func resourceHerokuCertDelete(d *schema.ResourceData, meta interface{}) error {
return nil
}
func resource_heroku_ssl_cert_retrieve(app string, id string, client *heroku.Service) (*heroku.SSLEndpoint, error) {
func resourceHerokuSSLCertRetrieve(app string, id string, client *heroku.Service) (*heroku.SSLEndpoint, error) {
addon, err := client.SSLEndpointInfo(app, id)
if err != nil {

5
builtin/providers/heroku/resource_heroku_cert_test.go
View File

@ -21,11 +21,6 @@ func TestAccHerokuCert_Basic(t *testing.T) {
resource "heroku_app" "foobar" {
name = "terraform-test-cert-app"
region = "eu"
organization = {
name = "plan3-labs"
locked = false
private = false
}
}
resource "heroku_addon" "ssl" {