Commit Graph

4706 Commits

Author SHA1 Message Date
Paul Hinze f2368428d3 helper/schema: write "attr.#": "0" for empty maps
This fixes some perpetual diffs I saw in Atlas AccTests where an empty
map (`map[string]interface{}{}`) was being `d.Set` for "metadata_full".

Because the MapFieldWriter was not distinguishing between empty and nil,
this trigger the "map delete" logic and no count was written to the
state. This caused subsequent plans to improperly report a diff.

Here we redefine the map delete functionality to explicitly trigger only
on `nil`, so we catch the `.#` field for empty maps.
2015-05-06 10:21:22 -05:00
Paul Hinze 010a39a58e provider/aws: remove placement_group from acctest
Depends on there being an existing placement group in the account called
"terraform-placement-group" - we'll need to circle back around to cover
this with AccTests after TF gets an `aws_placement_group` resource.
2015-05-06 10:13:24 -05:00
Clint Shryock 34609c6c22 provider/aws: Change Route 53 record test name, so it can be ran individually 2015-05-06 09:48:15 -05:00
Paul Hinze 66fa633b80 provider/aws: move EBS test into us-west-2 2015-05-06 09:22:34 -05:00
Paul Hinze bcb4067cb3 provider/aws: update test name 2015-05-06 09:20:40 -05:00
Paul Hinze 7303568469 providers/aws: update test name 2015-05-06 09:18:41 -05:00
Paul Hinze b91796368f provider/aws: update test name 2015-05-06 09:18:00 -05:00
Paul Hinze 6c6eafa232 provider/aws: removing stray "Ecache" in tests 2015-05-06 08:33:05 -05:00
Paul Hinze cebcee5c63 Merge pull request #1778 from josharian/template-provider
providers: add template provider
2015-05-05 20:09:27 -05:00
Mitchell Hashimoto 1a2bac7645 provider/aws: main route table refresh handles VPC being gone [GH-1806] 2015-05-05 18:07:22 -07:00
Paul Hinze b085342274 Merge pull request #1816 from hashicorp/b-validate-plan-graph-not-verbose-graph
core: validate graph w/ diff during plan phase
2015-05-05 19:57:59 -05:00
Mitchell Hashimoto 56e92f7f02 website: document state 2015-05-05 17:52:28 -07:00
Paul Hinze 0fff7d1673 core: validate graph w/ diff during plan phase
This reimplements my prior attempt at nipping issues where a plan did
not yield the same cycle an apply did. My prior attempt was to have
ctx.Validate generate a "Verbose" worst-case graph. It turns out that
skipping PruneDestroyTransformer to generate this graph misses important
heuristics that prevent cycles by dropping destroy nodes that are
determined to be unused.

This resulted in Validate improperly failing in scenarios where these
heuristics would have broken the cycle.

We detected the problem during the work on #1781 and worked around the
issue by reverting to the non-Verbose graph in Validate.

This commit accomplishes the original goal in a better way - by
generating the full graph and checking it once Plan has calculated the
diff. This guarantees that any graph issue that would be caught by Apply
will be caught by Plan.
2015-05-05 17:24:44 -05:00
Clint df7603520b Update CHANGELOG.md
provider/aws: Add Security Group Rule as a top level resource #1620
2015-05-05 17:13:44 -05:00
Clint 9510c716aa Merge pull request #1620 from hashicorp/f-aws-security-group-rule-resource
provider/aws: Add Security Group Rule as a top level resource
2015-05-05 17:12:15 -05:00
Clint Shryock 885efa0837 provider/aws: Add Security Group Rule as a top level resource
- document conflict with sg rules and sg in-line rules
- for this to work, ingress rules need to be computed
2015-05-05 16:56:39 -05:00
Clint 96e91c1cbd Update CHANGELOG.md 2015-05-05 16:48:48 -05:00
Clint a4000941c2 Merge pull request #1765 from hashicorp/f-aws-security-group-remove-default-egress
provider/aws: Remove default egress rule from Security Group on creation
2015-05-05 16:47:23 -05:00
Mitchell Hashimoto febc8643af website: add prpogating_vgws 2015-05-05 14:44:07 -07:00
Mitchell Hashimoto 9161454e78 update CHANGELOG 2015-05-05 14:43:23 -07:00
Mitchell Hashimoto fb4ac42c65 Merge pull request #1516 from henrikhodne/aws-propagating-vgws
provider/aws: add propagating_vgws to route tables
2015-05-05 14:42:45 -07:00
Clint Shryock eb7c1bb218 fix go formatting 2015-05-05 16:42:08 -05:00
Clint Shryock e9b08cf31f revert the required part 2015-05-05 16:23:26 -05:00
Clint Shryock 1ed81da9a9 update ENI test for SG egress constraint 2015-05-05 16:23:26 -05:00
Clint Shryock 85b1756c27 revise tests and check for vpc_id 2015-05-05 16:23:26 -05:00
Clint Shryock 8ded3c2d1b Move block for deleing default rule into the create method; only invoke once 2015-05-05 16:23:26 -05:00
Clint Shryock ee65684abe Add spec for removing default egress rule 2015-05-05 16:23:26 -05:00
Clint Shryock b145ce88b7 Document Egress+VPC change, update link 2015-05-05 16:23:26 -05:00
Clint Shryock 1558fd1c3e provider/aws: Remove default egress rule from Security Group on creation 2015-05-05 16:23:25 -05:00
Mitchell Hashimoto 27a616ade1 update cHANGELOG 2015-05-05 13:30:57 -07:00
Mitchell Hashimoto b40c87391b update cHANGELOG 2015-05-05 13:29:22 -07:00
Mitchell Hashimoto 412a2dca0b Merge pull request #1575 from freshbooks/aws-eni-route
provider/aws: Add Elastic Network Interfaces as route destination
2015-05-05 13:28:48 -07:00
Mitchell Hashimoto d582d0eb13 update CHANGELOG 2015-05-05 13:26:29 -07:00
Mitchell Hashimoto 379895931d website: network interface for EIP 2015-05-05 13:25:45 -07:00
Mitchell Hashimoto 7a22376742 Merge branch 'jstremick-f-aws-associate-eip-to-eni' 2015-05-05 13:24:58 -07:00
Mitchell Hashimoto 1c2d5fbd0a Merge branch 'f-aws-associate-eip-to-eni' of https://github.com/jstremick/terraform into jstremick-f-aws-associate-eip-to-eni 2015-05-05 13:24:50 -07:00
Mitchell Hashimoto c8635654cb Merge pull request #1781 from hashicorp/b-module-deps
Flatten modules into main graph
2015-05-05 13:19:41 -07:00
Clint ad539d3c96 Update CHANGELOG.md 2015-05-05 15:10:34 -05:00
Mitchell Hashimoto a07f07bbf2 Merge pull request #1813 from svanharmelen/b-aws-creds-fix
Fixing PR #1804
2015-05-05 13:05:35 -07:00
Mitchell Hashimoto 0f40cebc0f Merge pull request #1814 from svanharmelen/b-fix-small-vet-warning
Fixing a small vet warning introduced by PR #1796
2015-05-05 13:05:11 -07:00
Clint 18b43b78cb Merge pull request #939 from bitglue/iam
Implement a subset of IAM resources
2015-05-05 15:05:05 -05:00
Mitchell Hashimoto 8c34e9a36a terraform: provisionedby prefixed 2015-05-05 13:04:27 -07:00
Clint Shryock 7b082d007e Merge commit '33183c0'
* commit '33183c0':
  Implement a hash function for string sets
2015-05-05 15:01:02 -05:00
Sander van Harmelen 3881c81a66 Added the exit code as well... 2015-05-05 21:56:20 +02:00
Mitchell Hashimoto d503cc2d82 terraform: flattenable graphNodeMissingProvisioner 2015-05-05 12:45:28 -07:00
Sander van Harmelen 48f4d499f9 Fixing a small vet warning introduced by PR #1796
While fixing the vet warning also tried to improve any feedback by
showing the actual output/error instead of just the error code.

While testing this I noticed only adding stderr output is not enough as
not all error info is send to stderr, but sometimes also to stdout.
2015-05-05 21:26:28 +02:00
Mitchell Hashimoto 6d4969f64c terraform: run prune destroy on validate 2015-05-05 12:11:49 -07:00
Sander van Harmelen 897bf5e53d Added `SharedCredentialsProvider` and `EC2RoleProvider` as well... 2015-05-05 20:38:35 +02:00
Sander van Harmelen 5435815524 Fixing PR #1804 2015-05-05 20:30:35 +02:00
Mitchell Hashimoto 1045fb9eac Merge pull request #1811 from hashicorp/b-aws-auth
providers/aws: chain credentials
2015-05-05 10:55:40 -07:00