Commit Graph

92 Commits

Author SHA1 Message Date
Chris Johnson 98f6d410a4 Ensure the tests for heroku_cert work (#14371)
See the test for details.
2017-05-11 06:08:06 -05:00
Chris Johnson d1b5eac587 provider/heroku: Fix heroku_cert update of ssl cert (#14240)
* Attempt to write a new test for cert update

Trying to surface this bug with a test:
https://github.com/hashicorp/terraform/issues/5930

* Fix the error

* Fix the test for the update operation

* Break apart tests for EU vs US to cleanse test run

* Refactor Update to more closely match create, increase debug logging

* Reflect differences of EU and US regions via separate tests

* Add comment re: why of test breakout

* Removed the “SetId” as it was unnecessary

* Ensure the SSL Addon has been provisioned
2017-05-10 15:52:55 -05:00
Bernerd Schaefer 5b085f4c44 providers/heroku: import heroku_app resource (#14248)
Adds support for importing normal and organization apps with the
heroku_app resource.

The resource itself depends on an `organization` value in the
configuration to switch behavior for the different kinds of apps, so
`schema.ImportStatePassthrough` is not sufficient.
2017-05-05 22:26:04 +03:00
Justin Campbell 61f45dd585 provider/heroku: scope valid stage names to func 2017-05-01 10:20:51 -04:00
Justin Campbell 02bb1e6907 provider/heroku: Output IDs on failure 2017-05-01 10:20:28 -04:00
Justin Campbell 3d4f1ba4f3 provider/heroku: Remove unused argument in test 2017-05-01 10:20:04 -04:00
Justin Campbell 3a87ca4a43 provider/heroku: Prefer struct for required attrs 2017-05-01 10:19:44 -04:00
Justin Campbell e2b361f603 provider/heroku: Allow renaming a pipeline 2017-05-01 10:15:08 -04:00
Justin Campbell dd48b5b7e7 provider/heroku: heroku_pipeline_coupling
Also adds validators for UUID and pipeline stage names
2017-05-01 10:15:08 -04:00
Justin Campbell 40805bb80c provider/heroku: Add heroku_pipeline resource 2017-05-01 10:15:07 -04:00
Dan Peterson 8ec67413be providers/heroku: wait for spaces to be allocated (#14052) 2017-04-28 08:40:18 -05:00
Dan Peterson 3b47f9439b providers/heroku: use resourceHerokuAppFeature prefix (#14051)
Change eg resourceAppFeatureRead to resourceHerokuAppFeatureRead to
conform to common style.
2017-04-27 14:18:55 -05:00
Dan Peterson e495c6bacc providers/heroku: add heroku_app_feature resource (#14035) 2017-04-27 09:55:07 -05:00
Dan Peterson cf6e86a127 providers/heroku: use a helper for common app post-create tasks (#13990)
Buildpacks were being configured post-create for non-org apps but not
for org apps. Consolidate post-create tasks into a helper used by both
paths.
2017-04-26 17:02:53 -05:00
Jake Champlin 22ed31c7a6 Merge pull request #13921 from bernerdschaefer/bs-create-space
providers/heroku: add heroku_space resource
2017-04-25 18:43:42 -04:00
Bernerd Schaefer e7c904a87d Add note about type conversion 2017-04-25 15:32:27 -07:00
Bernerd Schaefer c55a4b3a51 Merge branch 'master' into bs-heroku-app-space 2017-04-25 11:04:13 -07:00
Bernerd Schaefer dbf82e651e Implementation 2017-04-24 17:34:34 -07:00
Bernerd Schaefer 43257492b9 Add first failing test for heroku_space 2017-04-24 17:08:22 -07:00
Bernerd Schaefer acdb5c659a provider/heroku: set app buildpacks from config
Many apps deployed to Heroku require that multiple buildpacks be
configured in a particular order to operate correctly.

This updates the builtin Heroku provider's app resource to support
configuring buildpacks and the related documentation in the website.

Similar to config vars, externally set buildpacks will not be altered if
the config is not set.
2017-04-24 11:40:29 -07:00
Bernerd Schaefer fd98f1e0c5 providers/heroku: create app in space 2017-04-21 14:22:42 -07:00
Andy Lindeman fa18174713 Updates heroku-go to the latest revision (#12575) 2017-03-10 14:00:03 +02:00
Radek Simko 2077869be4 provider/heroku: Fix failing acceptance test (#11374) 2017-01-24 14:10:11 +02:00
Paul Hinze 108ccf0007 builtin: Refactor resource.Retry to clarify return
Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.

Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.

This makes it eminently clear whether or not a given error is
retryable from inside the client code.

Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
2016-03-09 17:37:56 -06:00
Trevor Pounds 79742fc367 Enable `go vet -composites` check and fix warnings. 2016-02-17 11:59:50 -08:00
Paul Hinze 97bae0ea30 provider/heroku: address cert test failure
* Randomize app name in test
 * Return error and don't panic when there is a problem

It's possible there may still be an underlying problem that caused the
error that made the cert leak in the first place - this should help us
diagnose it.
2016-02-04 09:58:27 -06:00
Paul Hinze b537e5e966 provider/heroku: retry drain create until log channel is assigned
Should fix the build error encountered here:

https://travis-ci.org/hashicorp/terraform/builds/104548513
2016-01-25 09:59:41 -06:00
Paul Hinze 19d90ae00f heroku: randomize the remaining appnames in tests
Should take care of the remaining flapping acceptance test failures like
this:

https://travis-ci.org/hashicorp/terraform/builds/104012729
2016-01-22 09:26:34 -06:00
Paul Hinze d1010f40c5 heroku: randomize names in acctests
Should fix build failures seen here:

https://travis-ci.org/hashicorp/terraform/builds/103764448
2016-01-21 09:31:48 -06:00
Paul Hinze 7cd955e3a1 provider/heroku: fix typo in organization struct
"personal", not "private"
2016-01-08 08:20:19 -06:00
Paul Hinze c52765417a provider/heroku: add acctest covering orgs; fixup issues
Switching up ResourceData interaction to not reach into the internal
dot-notation nesting.
2016-01-04 16:13:52 -06:00
Jakub Janczak 81779aa1d4 Fixing the situation when you've got an organization app, and want to have it in a private area instead 2016-01-04 16:13:52 -06:00
Paul Hinze 24d15820c1 provider/heroku: fix acc test
depends_on requires a list of strings. the old parser would silently
ignore this field, but the new one returned a syntax error.
2015-11-20 10:51:34 -06:00
Sander van Harmelen 2ba8dc38fa Switch to go-multierror
It seems there are 4 locations left that use the `helper/multierror`
package, where the rest is TF settled on the `hashicorp/go-multierror`
package.

Functionally this doesn’t change anything, so I suggest to delete the
builtin version as it can only cause confusion (both packages have the
same name, but are still different types according to Go’s type system.
2015-09-27 18:58:48 -07:00
Paul Hinze 28875f49cd provider/heroku: fix config_vars in addons
These were never read properly - on Addons they show up as just a list
of var names, not a Map.

Fixes one issue in Addon acceptance tests.
2015-05-07 09:11:31 -05:00
Mitchell Hashimoto e5a375ae58 providers/heroku: empty config vars block shouldn't panic [GH-1211] 2015-03-26 09:45:37 -07:00
Mitchell Hashimoto 0281d73686 Revert "Heroku returns config_vars for addon as string array." 2015-02-23 14:04:58 -08:00
Mitchell Hashimoto 9599861350 Merge pull request #1006 from smp-labs/proper_heroku_config_vars_type
providers/heroku: heroku returns config_vars for addon as string array.
2015-02-23 13:59:10 -08:00
Mitchell Hashimoto 523639b5cd fmt 2015-02-20 10:22:26 -08:00
Jakub Janczak b99179a5a0 The type returned from heroku API is a string array, while our schema says []map[string]interface{}. 2015-02-19 10:31:04 +01:00
Jeff Mitchell f2bd1f45ab Move duplicated envDefaultFunc out of each provider and into Schema. 2015-01-16 17:25:39 +00:00
Emil Hessman 7b704fb77d builtin/providers/heroku: vet fix
Fixes the following vet reports:

builtin/providers/heroku/resource_heroku_app.go:192: arg vs for printf verb %s of wrong type: bool
builtin/providers/heroku/resource_heroku_app.go:198: arg vs for printf verb %s of wrong type: bool
2014-12-17 12:58:12 +01:00
Armon Dadgar f923368fc5 Merge pull request #672 from plan3-labs/heroku_cert_support
Heroku SSL certificate support
2014-12-15 12:12:57 -08:00
Sander van Harmelen 4ace4865d7 Making all function names consistent
Before all providers were using the helper.Schema approach the helper
function had these names. Now they all use names consistent with the Go
naming conventions except for these last few…
2014-12-15 15:26:17 +01:00
Jakub Janczak 765cd1f494 Heroku SSL support: fixes after code review of @svanharmelen 2014-12-15 15:10:59 +01:00
Jakub Janczak 3c0e9970e5 Heroku SSL certificate support added 2014-12-15 12:21:47 +01:00
Sander van Harmelen 1b6f37b6eb Fixed tests and updated the provider schema to use a DefaultFunc
The default stack changed from ‘cedar’ to ‘cedar-14’, so updated the
acceptance tests to reflect this.

Updating the schema makes testing easier and gives you a way to
configure the provider using env variables. It also makes the provider
more inline following the TF 0.2 approach.
2014-11-19 14:25:18 +01:00
Mitchell Hashimoto 1792334ec4 fmt 2014-10-21 11:00:12 -07:00
Clint Shryock 98667d1b12 update error message 2014-10-14 17:28:25 -05:00
Clint Shryock b850f8bc65 proposal for making orgs a structure with fields instead of just a name field 2014-10-14 17:28:24 -05:00