Paul Stack
8ed809456d
Merge pull request #5830 from hashicorp/phinze/asg-health-check-grace-period-default
...
provider/aws: set ASG health_check_grace_period default to 300
2016-03-30 19:05:06 -05:00
stack72
197c6fa143
provider/aws: Test to validate that db subnet group description
...
can be updated
2016-03-30 18:53:52 -05:00
Paul Stack
1801904e36
Merge pull request #5921 from ColinHebert/rds_subnet_group_description
...
provider/aws: DB subnet group description modification
2016-03-30 18:50:33 -05:00
Colin Hebert
1389bb2f5e
Do not check only whether the subnet_ids have changed
2016-03-31 10:37:26 +11:00
Ethan Gunderson
1c5c58d072
Redshift master usernames may contain underscores
2016-03-30 17:41:58 -05:00
Colin Hebert
3ae21f0891
Add the description as a part of the update request
2016-03-31 09:36:42 +11:00
Paul Stack
53434ae09c
Merge pull request #5904 from keymon/bugfix/5661_fix_codecommit_default_branch
...
AWS: codecommit set default_branch only if defined
2016-03-30 11:18:22 -05:00
Hector Rivas Gandara
29c9b8497d
provider/aws: Add tests for default_branch in new codecommit repos
...
The provider should, when working on a new repository without branches:
* Able to create a new repository even with default_branch defined.
* Able to create a new repository without default_branch, and do not fail
if default_branch is defined.
2016-03-30 16:41:20 +01:00
Hector Rivas Gandara
0c49b17f72
provider/aws: codecommit check default_branch before update
...
In AWS codecommit the default branch must have a value unless there are
no branches created, in which case it is not possible to set it to any value.
We query the existing branches and do not update the default branch
if there are none defined remotely.
This solves the issue of the initial creation of the repository with a
resource with `default_branch` defined.
2016-03-30 16:40:41 +01:00
Hector Rivas Gandara
1afd3a53b2
provider/aws: codecommit set default_branch only if defined
...
Do not try to update or reaad the AWS codecommit repository default branch if
the resource definition is not set it or is an empty string.
Fixes #5641
2016-03-30 16:40:37 +01:00
Colin Hebert
d7a7db9c5a
provider/aws: Subnet group description modification
...
Do not force a new resource when changing the description of a subnet group
2016-03-30 09:33:44 +11:00
Alex Gray
50c050bb92
Elasticsearch times out. It takes a while to create. lets increase the timeout.
2016-03-29 15:58:40 -04:00
Paul Hinze
faba2b7d31
Merge pull request #5867 from hashicorp/phinze/fix-route-crash
...
provider/aws: fix potential aws_route crashes
2016-03-29 13:20:36 -05:00
Paul Hinze
70096c5ac0
provider/aws: fix potential aws_route crashes
...
Fixes #5865
2016-03-29 09:57:29 -05:00
Clint
163173df7a
Merge pull request #5881 from hashicorp/b-aws-sg-r-protocols
...
provider/aws: Convert protocols to standard format for Security Groups
2016-03-28 13:23:52 -05:00
clint shryock
1a2846072c
update tests to cover icmp
2016-03-28 13:08:53 -05:00
clint shryock
e98d7d706f
provider/aws: Convert protocols to standard format for Security Groups
...
Convert network protocols to their names for keys/state, fixing issue(s) when
using them interchangeably.
2016-03-28 10:32:39 -05:00
Radek Simko
a2c59f071f
Merge pull request #5838 from hashicorp/b-aws-lambda-guard
...
provider/aws: Guard against empty responses from Lambda Permissions
2016-03-25 20:35:57 +00:00
Paul Hinze
6c2b511152
provider/aws: Fix launch_config waiting for IAM instance profile
...
AWS changed their error message, which was being used for detection of
the specific error that indicates we need to wait for IAM propagation.
Behavior is covered by a test now.
Fixes #5862
2016-03-25 13:10:10 -05:00
clint shryock
01f868d3e6
provider/aws: Guard against empty responses from Lambda Permissions
2016-03-24 16:30:21 -05:00
Christopher Tiwald
2cf6afa6c1
aws_autoscaling_policy: Add tests for StepScaling policies.
2016-03-24 16:35:54 -04:00
Christopher Tiwald
305a450239
aws_autoscaling_policy: Add support for StepScaling policies.
...
Unlike SimpleScaling policies, StepScaling policies require one or more
"steps", which are interval ranges in which a tracked metric can lie.
Policies can then execute scaling adjustments wedded to these steps.
This commit also adds a slew of additional policy attributes which are
only applicable to step policies.
2016-03-24 16:35:54 -04:00
Jeff Tang
88de250615
style updates to documentation and nil checks
2016-03-24 08:08:01 -04:00
Paul Hinze
6f76fb0702
provider/aws: set ASG health_check_grace_period default to 300
...
Closes #5658
2016-03-23 18:55:37 -05:00
Andy Chan
4115249ce3
ISSUE-5702: Fixed the testing
2016-03-23 11:15:06 -07:00
Andy Chan
76adbefb95
ISSUE-5702: 2nd attempt to impl the target_id be optional
2016-03-23 10:42:53 -07:00
Andy Chan
0eee165a2b
ISSUE-5702: Fixed a bug on target_id generation and related test case
2016-03-23 10:25:13 -07:00
Andy Chan
92590d1ac8
Fixed the test case to check if the targetId is created
2016-03-23 10:25:13 -07:00
Andy Chan
7dc5a272be
ISSUE-5702: Making the CloudWatch Event Rule Target ID optional
2016-03-23 10:25:13 -07:00
Clint
ccb9693994
Merge pull request #5676 from Originate/mb-ensure-iops-is-provided
...
provider/aws: Provide iops when changing storage type to io1 on RDS
2016-03-23 08:31:21 -05:00
Paul Hinze
e5e6b571a5
provider/aws: Fix aws_route panic when destination CIDR block is nil
...
Fixes #5754
2016-03-22 10:35:22 -05:00
Edmund Craske
edbc4fad13
Fail if failover set when set_identifier unset
...
Added as per
https://github.com/hashicorp/terraform/pull/5777#issuecomment-199802514
2016-03-22 13:19:24 +00:00
edmundcraske
4aa7d4f7db
Fail when weight set and set_identifier not set
...
Resolves https://github.com/hashicorp/terraform/issues/5776
2016-03-22 12:20:47 +00:00
James Nugent
22a409e4cc
Merge pull request #5774 from stack72/f-aws-iam-user-sshkey
...
provider/aws: Add `aws_iam_user_ssh_key` resource
2016-03-22 10:29:08 +00:00
Paul Stack
12546c6fca
Merge pull request #5065 from tpounds/fix-aws-elb-access-logs-type
...
provider/aws: Change ELB access_logs to list type
2016-03-22 01:40:14 +00:00
stack72
7e61947c0a
provider/aws: Scaffold `aws_iam_user_ssh_key` resource
2016-03-22 01:19:16 +00:00
Paul Hinze
20e517475b
Merge pull request #5724 from paulodeininger/feature/fix_aws_opsworks_windows
...
Add DefaultOs on Stack creation (fix Windows stack issue)
2016-03-21 15:10:03 -05:00
stack72
fb92896326
Merge branch 'master' of github.com:hashicorp/terraform
2016-03-21 18:48:47 +00:00
Andy Chan
d6cd47fd5e
Reformat the kms alias test code
2016-03-21 18:48:00 +00:00
Clint
f715c91666
Merge pull request #5756 from hashicorp/b-beanstalk-configuration-update
...
provider/aws: Fix crasher in Elastic Beanstalk Configuration with Options
2016-03-21 12:59:22 -05:00
Radek Simko
5c21422f7d
Merge pull request #5712 from bjss/master
...
Use timeout_in_minutes for Terraform timeout in AWS CloudFormation
2016-03-21 17:06:20 +00:00
James Nugent
f946695187
Merge pull request #5444 from TimeIncOSS/f-aws-logs-metric-filter
...
provider/aws: Add support for CloudWatch Log Metric Filter
2016-03-21 16:43:38 +00:00
clint shryock
9ae8e85640
provider/aws: Fix crasher in Elastic Beanstalk Configuration with option settings
2016-03-21 11:43:31 -05:00
James Nugent
6732659fe9
provider/aws: Fix panic in VPN connection resource
...
Check to ensure that vpnConnection.CustomerGatewayConfiguration is not
nil prior to dereferencing it on read.
Fixes #5647 .
2016-03-21 13:52:14 +00:00
Andrew Tarry
c3b3feaf11
Set cloudformation timeout to more than timeout_in_minutes
...
updated cloudformation timeout to use timeout_in_minutes if greater than 30 minutes
set the retry timeout as int64 when created
2016-03-21 09:08:52 +00:00
Paul Hinze
d60bf93b4d
Merge pull request #5723 from hashicorp/phinze/rds-instance-generate-identifier
...
provider/aws: ability to generate unique RDS identifier
2016-03-18 16:16:35 -05:00
Paul Hinze
4e5429a140
provider/aws: ability to generate unique RDS identifier
...
Needed to truncate the identifier for SQL Server engines to keep it at
max 15 chars per the docs. Not a full UUID going into it, but should be
"unique enough" to not matter in practice.
Modified the basic test to use the generated value. Other tests are
still working w/ explicitly specified identifiers.
2016-03-18 16:07:37 -05:00
Paulo Eduardo Deininger Messias Alves
0a0ccb84f2
Add DefaultOs on Stack creation (fix Windows stack issue)
2016-03-18 17:51:25 -03:00
stack72
12ac0761b7
provider/aws: Modify `aws_redshift_cluster` now allows
...
`publicly_accessible` to be changed
Also updated the AWS Go SDK from 1.1.9 -> 1.1.12 as this was required to
allow the new behavior for the Redshift API
2016-03-19 01:05:09 +05:30
Paul Hinze
17775205f7
provider/aws: fix crash when Aurora instance disappears
...
Usage of a helper function was assuming that an error would be returned
in a not found condition, when in fact a nil pointer was
returned.
Attached test crashes w/o fix, passes with it.
Fixes #5350
Refs #5418
2016-03-18 12:27:57 -05:00
Maxime Bury
210eb3571e
Provide iops when changing storage type to io1
2016-03-16 18:32:11 -04:00
Maxime Bury
ec749d964f
Correctly handle missing lambda function
2016-03-16 14:26:14 -04:00
Radek Simko
af93183459
provider/aws: Add validation for CW Log Metric Filter
2016-03-15 15:01:21 +00:00
Radek Simko
7eba8f6f66
provider/aws: Add tests for CloudWatch Log Metric Filter
2016-03-15 15:01:20 +00:00
Radek Simko
3bfcd47238
provider/aws: Add support for CloudWatch Log Metric Filter
2016-03-15 15:01:20 +00:00
Jeff Tang
bcd5904eea
Add support for Opsworks Instances
...
New resource checklist
- [x] Acceptance testing
- [x] Documentation
- [x] Well-formed code
2016-03-14 15:12:43 -04:00
Paul Hinze
25fce81bfc
provider/aws: log HTTP req/resp at DEBUG level
...
This should be quite helpful in debugging aws-sdk-go operations.
Required some tweaking around the `helper/logging` functions to expose an
`IsDebugOrHigher()` helper for us to use.
2016-03-14 12:26:37 -05:00
Paul Hinze
fff441b4ac
provider/aws: send Terraform version in User-Agent
2016-03-14 12:16:49 -05:00
Paul Hinze
60b239d7d1
provider/aws: Switch to session.Copy to build up configs
...
Found this function which makes the config setup much nicer - looks like
it's meant to be used for the very thing we're doing, which is starting
w/ a base config and customizing it slightly.
https://docs.aws.amazon.com/sdk-for-go/api/aws/session/Session.html#Copy-instance_method
This will make the User-Agent setting code to follow much simpler.
2016-03-14 11:42:37 -05:00
Pierre Carrier
a8865b8901
provider/aws: optional fields in aws_autoscaling_lifecycle_hook
...
See hashicorp/terraform/issues/5614
2016-03-14 11:45:17 +00:00
Radek Simko
189e9b5ceb
Merge pull request #5605 from nicolai86/bugfix/verify-ecs-elb-count
...
provider/aws validate number of load_balancers before creating aws_ecs_service
2016-03-13 15:15:00 +00:00
Raphael Randschau
fc0c2c0ea7
Validate number of load_balancers
...
see #5336
2016-03-13 12:51:51 +01:00
Oleg Chunikhin
25383ad5a3
aws: Fix CloudFormation update for parameters & capabilities if not modified
2016-03-13 08:10:57 +00:00
Radek Simko
8612cc3373
aws: Improve acceptance test for CloudFormation w/ all attributes
2016-03-13 08:10:54 +00:00
clint shryock
66eb7c6055
provider/aws: Guard against Nil Reference in Redshift Endpoints
2016-03-11 12:16:29 -06:00
Radek Simko
d8b36532ef
Merge pull request #5239 from TimeIncOSS/f-aws-lambda-func-updates
...
provider/aws: Add support for updating Lambda function
2016-03-11 16:59:18 +00:00
Paul Hinze
82765ea589
Merge pull request #5453 from bigkraig/aws-s3-kms-key
...
provider/aws: Support KMS encryption of S3 objects
2016-03-10 15:44:10 -06:00
Paul Hinze
5ce68fd1bd
Merge pull request #5571 from hashicorp/revert-5193-f-aws-instance-security-groups-updates
...
Revert "provider/aws: Support additional changes to security groups of instance without forcing new"
2016-03-10 15:09:16 -06:00
Paul Hinze
e9c4d4f6d5
Revert "provider/aws: Support additional changes to security groups of instance without forcing new"
2016-03-10 14:51:30 -06:00
clint shryock
02ba1bf2d4
provider/aws: More Acc test updates
...
Working on the green
- randomize some Autoscaling lifecycle hook test names
- use vpc_security_group_ids for this test
2016-03-10 14:33:54 -06:00
Clint
99ddea503d
Merge pull request #5495 from nicolai86/bugfix/aws_security_group-protocol-case-sensitivity
...
provider/aws Always transform aws_security_group protocol to lower case
2016-03-10 09:34:55 -06:00
Clint
239b3e4f5f
Merge pull request #5533 from hashicorp/pr-5184
...
provider/aws: Fix EC2 Classic SG Rule issue
2016-03-10 08:56:29 -06:00
Radek Simko
d777141a7b
provider/aws: Add tests for Lambda function updates
2016-03-10 12:31:35 +00:00
Radek Simko
fdc21aad25
provider/aws: Simplify update logic for Lambda function
2016-03-10 12:31:35 +00:00
Chris Marchesi
b5c7521f52
aws_lambda_function: Force code update on SHA sum mismatch
2016-03-10 12:31:35 +00:00
Rob Zienert
4aeb5bb8e9
Adding support for Lambda function updates
2016-03-10 12:31:35 +00:00
Kraig Amador
76b3c74a58
Providing a more informative error message when combining kms_key_id and etag as well as using aws_kms_key to test aws_s3_bucket's kms_key_id.
2016-03-09 19:06:36 -08:00
Paul Hinze
d12944797a
Merge pull request #3928 from TimeIncOSS/aws-kms
...
provider/aws: Add support for KMS
2016-03-09 18:30:06 -06:00
Paul Hinze
108ccf0007
builtin: Refactor resource.Retry to clarify return
...
Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.
Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.
This makes it eminently clear whether or not a given error is
retryable from inside the client code.
Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
2016-03-09 17:37:56 -06:00
Paul Stack
ab075bca60
Merge pull request #5193 from innossh/f-aws-instance-security-groups-updates
...
provider/aws: Support additional changes to security groups of instance without forcing new
2016-03-10 00:28:32 +01:00
James Nugent
7436cf7f89
Merge pull request #5376 from stack72/b-aws-ELBListner
...
provider/aws: Fixes the use of Uppercase chars in ELB Listeners
2016-03-09 23:18:56 +00:00
Paul Hinze
ffa5db4f52
Merge pull request #5538 from hashicorp/phinze/retryerror-pointers-are-evil
...
provider/aws: Fix all pointer RetryError returns
2016-03-09 16:53:19 -06:00
Brad Sickles
3f41515d2b
Fixing noop differences in aws_route.
2016-03-09 23:27:09 +01:00
Brad Sickles
16f94ed4b7
Added failing aws_route test that shows diff after apply.
2016-03-09 23:27:09 +01:00
clint shryock
f96ec46681
update comments
2016-03-09 15:50:01 -06:00
Clint
d14920adaf
Merge pull request #5515 from hashicorp/b-aws-acc-test-updates
...
provider/aws: Retry DB Creation on IAM propigation error
2016-03-09 15:08:13 -06:00
clint shryock
23c42cd6cf
Add test for flattenSecurityGroups
2016-03-09 15:00:30 -06:00
Paul Hinze
de656942ae
provider/aws: Fix all pointer RetryError returns
...
All of these RetryErrors were meant to fail right away, but instead
caused retry looping because the typecheck in the implementation of
`resource.Retry()` only catches the value type, and not the pointer
type.
Refs #5537
2016-03-09 14:59:55 -06:00
Maxime Bury
9e0bac6c9f
Terraform should keep track of the publicly accessible attribute
2016-03-09 13:33:00 -05:00
ephemeralsnow
54cb5ffe00
provider/aws: Fix EC2 Classic SG Rule issue
...
Fixes an issue where security groups would fail to update after applying an
initial security_group, because we were improperly saving the id of the group
and not the name (EC2 Classic only).
This is a PR combining https://github.com/hashicorp/terraform/pull/4983 and
https://github.com/hashicorp/terraform/pull/5184 . It's majority
@ephemeralsnow's work.
2016-03-09 09:51:41 -06:00
Paul Stack
4601d371e1
Merge pull request #5524 from stack72/f-aws-ecr-repository_name
...
provider/aws: `repository_url` is computed for `aws_ecr_repository`
2016-03-09 09:38:09 +00:00
stack72
7c5ab40b74
provider/aws: Add support for the `repository_url` to be computed for
...
ECR
2016-03-09 09:29:23 +00:00
Paul Stack
b5e6cb5f88
Merge pull request #5520 from bsiegel/aws_rds_cluster_encryption
...
Add storage_encrypted as an optional parameter to aws_rds_cluster
2016-03-09 00:21:26 +00:00
stack72
cad550e63d
provider/aws: Add support for `description` to `aws_network_interface`
...
resource
2016-03-08 23:28:37 +00:00
Brandon Siegel
fc7e9fcd53
Ensure aws_rds_cluster can have storage_encrypted set to true
2016-03-08 17:28:44 -05:00
Brandon Siegel
0085bf6ae8
Ensure aws_rds_cluster has storage_encrypted set to false by default
2016-03-08 17:28:32 -05:00
Brandon Siegel
b3864db462
fixup! Add storage_encrypted as an optional parameter to aws_rds_cluster
2016-03-08 17:15:01 -05:00
Brandon Siegel
8aadf1d56d
Add storage_encrypted as an optional parameter to aws_rds_cluster
2016-03-08 16:48:04 -05:00
clint shryock
c29e1f24b8
provider/aws: Retry DB Creation on IAM propigation error
2016-03-08 14:09:42 -06:00
clint shryock
5dc387354d
provider/aws: Randomize tests more to reduce conflicts
...
- ASG placement tests
- Randomize DynamoDB names in tests
- tag the sg created in this test to help identify in the console
- randomize policy and role names
2016-03-08 09:56:14 -06:00
Radek Simko
d4d20a9f5a
kms: Treat keys in PendingDeletion state as deleted
2016-03-08 09:30:47 +00:00
Radek Simko
6f8a9c0f77
aws: kms_key - Add support for is_enabled + enable_key_rotation
2016-03-08 09:30:47 +00:00
Radek Simko
347913a3be
aws: kms_key - Iterate over all aliases (not just 50)
2016-03-08 09:30:47 +00:00
Radek Simko
ff2d040d28
aws: kms_key + kms_alias - Add acceptance tests
2016-03-08 09:30:47 +00:00
Radek Simko
ccedb36a86
aws: kms_key - add forgotten policy read call + normalize
2016-03-08 09:30:47 +00:00
Radek Simko
4c1f8db32d
aws: kms_key - Change field name (deletion_window -> deletion_window_in_days)
2016-03-08 09:30:47 +00:00
Radek Simko
fccffbcbb1
aws: kms_alias - Remove unnecessary default ForceNew state
2016-03-08 09:30:47 +00:00
Radek Simko
5c9fe668f5
aws: kms resources - Simplify error handling
2016-03-08 09:30:47 +00:00
Radek Simko
2b244e21bc
aws: kms validation - Add missing placeholders for Errorf
2016-03-08 09:30:47 +00:00
Radek Simko
5466d69450
aws: kms resources - gofmt all the code
2016-03-08 09:30:47 +00:00
Philip Witty
5e18031367
Update AWS KMS with respect to key deletion features
2016-03-08 09:30:47 +00:00
Philip Witty
6648df7acc
Added AWS KMS key & alias support
2016-03-08 09:30:47 +00:00
Raphael Randschau
2c698d2cb0
Always transform aws_security_group protocol to lower case
...
fixes #5489
2016-03-07 22:40:29 +01:00
clint shryock
f0d3176999
provider/aws: Add Elastic Beanstalk Application, Configuration Template, and Environment
...
This adds support for Elastic Beanstalk Applications, Configuration Templates,
and Environments.
This is a combined work of @catsby, @dharrisio, @Bowbaq, and @jen20
2016-03-07 14:43:23 -06:00
Paul Stack
46e4717428
Merge pull request #5474 from kjmkznr/skip-normalize-empty-policy
...
provider/aws: Fix error parsing JSON in S3 bucket policy
2016-03-07 18:53:51 +01:00
Michael H. Oshita
00288c36b9
fix indentation
2016-03-07 22:18:58 +09:00
Kazunori Kojima
8d1292d608
Return empty string when input empty S3 bucket policy
...
Before:
"" -> "Error parsing JSON: unexpected end of JSON input"
After:
"" -> ""
2016-03-07 09:31:33 +09:00
Radek Simko
c6c2752211
provider/aws: Sort API Gateway resources alphabetically
2016-03-06 09:29:31 +00:00
Radek Simko
fa0d6af524
provider/aws: Remove unnecessary GetChange in Delete funcs
2016-03-06 09:29:31 +00:00
Radek Simko
a338eae72a
provider/aws: Guard APIGateway resource & REST API against deletion
2016-03-06 09:29:30 +00:00
Radek Simko
ce5324b341
Merge pull request #4295 from nicolai86/feature/aws-api-gateway
...
provider/aws: API Gateway resources
2016-03-06 09:00:02 +00:00
Raphael Randschau
6430fca7f6
Add aws_api_gateway_deployment resource
2016-03-05 23:21:58 +01:00
Raphael Randschau
8c59d0861e
Add aws_api_gateway_api_key resource
2016-03-05 23:21:54 +01:00
Raphael Randschau
b4c99f1009
Add aws_api_gateway_model resource
2016-03-05 23:21:51 +01:00
Raphael Randschau
4da8b3d03a
Add aws_api_gateawy_integration_response resource
2016-03-05 23:21:48 +01:00
Raphael Randschau
1593dbe9c8
Add aws_api_gateway_integration resource
2016-03-05 23:21:44 +01:00
Raphael Randschau
91f5206f8d
Add aws_api_gateway_method_response resource
2016-03-05 23:21:41 +01:00
Raphael Randschau
032e6081cb
Add aws_api_gateway_method resource
2016-03-05 23:21:38 +01:00
Raphael Randschau
7ead800f6a
Add aws_api_gateway_resource resource
2016-03-05 23:21:35 +01:00
Raphael Randschau
a73721d248
Add aws_api_gateway_rest_api resource
2016-03-05 23:13:38 +01:00
Raphael Randschau
fdf0cfa66d
Vendor AWS APIGateway API
2016-03-05 23:12:19 +01:00
Paul Stack
b66b9c92a2
Merge pull request #5401 from Originate/mb-fix-kinesis-stream-shard-count
...
provider/aws: Report the correct number of shards for Kinesis streams
2016-03-05 19:19:16 +01:00
stack72
d63166c025
provider/aws: Adding a test for AWS Kinesis Stream Shard Count
2016-03-05 18:40:47 +01:00
Kraig Amador
74de6531fe
Return an error when conflicting etag & kms_key_id parameters are provided and now with ServerSideEncryption we can go back to the higher level PutObject.
2016-03-04 09:22:43 -08:00
Kraig Amador
db91aebd8e
Added a kms_key_id parameter which will allow you to encrypt objects that are put into a bucket.
2016-03-03 16:20:01 -08:00
Maxime Bury
ae8627f92a
Report the correct number of shards
2016-03-01 10:46:39 -08:00
Radek Simko
dc45f84a8f
Allow recovering from failed CW Event Target creation in state
2016-03-01 12:37:36 +00:00
Radek Simko
5a786d52d9
Fix: Do not store ID of CW Event Target if creation fails
2016-03-01 12:35:15 +00:00
stack72
d3697fa50b
provider/aws: Combine AWS Metrics Collection resource and AWS
...
Autoscaling Group
2016-02-29 20:58:41 +00:00
stack72
4fc1391303
Scaffold the AWS Autoscaling Group Metrics Collection
2016-02-29 19:24:30 +00:00
stack72
ffbb59a73e
provider/aws: Fixes the use of Uppercase chars in ELB Listeners
2016-02-29 18:04:47 +00:00
Paul Stack
e6f3fafcd6
Merge pull request #5361 from stack72/b-aws-es-tags
...
provider/aws: `aws_elastisearch_domain` tags not being set correctly.
2016-02-29 17:38:06 +00:00
Maxime Bury
0290884fdc
Lambda S3 object version defaults to '$LATEST' if unspecified
2016-02-29 14:31:47 +00:00
stack72
7b61567bf6
provider/aws: `aws_elastisearch_domain` tags not being set correctly.
...
The top level object was used not the tags within
2016-02-28 18:31:58 +00:00
Paul Stack
a372800cd0
Merge pull request #5318 from stack72/f-aws-route53zone-updateComment
...
provider/aws: Add ability to update r53 zone comment
2016-02-26 19:43:13 +00:00
James Nugent
f249a432fc
Merge pull request #5329 from hashicorp/b-5310
...
provider/aws: Fix crash creating rules in aws SGs
2016-02-26 14:42:01 -05:00
Radek Simko
5b4fccaa73
provider/aws: Add acceptance test for IAM Account Password Policy
2016-02-26 13:29:34 +00:00
stack72
d750d4d1cc
provider/aws: Add ability to update r53 zone comment
2016-02-26 13:26:25 +00:00
Radek Simko
f7f3d95a9b
provider/aws: Add support for AWS Account Password Policy
2016-02-26 11:04:25 +00:00
James Nugent
5b548e938c
Merge pull request #5327 from Originate/s3-website-routing-rules
...
Added routing rules to s3 buckets
2016-02-25 14:43:55 -05:00
James Nugent
3adae0216c
provider/aws: Fix crash creating rules in aws SGs
...
This commit uses Group Name in preference to Group ID where appropriate
in the aws_security_group_rule resource. This fixes the crash reported
in #5310 .
Fixes #5310 .
2016-02-25 13:50:24 -05:00
Drew Minnear
ef50479e8a
added routing rules to s3 buckets
2016-02-25 10:19:23 -08:00
Radek Simko
4b8726dc2b
Merge pull request #5305 from TimeIncOSS/f-s3-obj-update-and-versioning
...
provider/aws: Enable updates & versioning for s3_bucket_object
2016-02-25 12:19:34 +00:00
Radek Simko
44246ca126
provider/aws: Add tests for s3_bucket_object w/ versioning enabled
2016-02-25 12:04:18 +00:00
Radek Simko
ef85147559
provider/aws: Add tests for s3_bucket_object updates
2016-02-25 12:04:18 +00:00
Radek Simko
9377b301ca
provider/aws: Cleanup s3_bucket_object acceptance tests
...
- the goal was to allow running tests in parallel and to get rid of global variables in the aws package
2016-02-25 12:04:18 +00:00
Radek Simko
24ac996963
provider/aws: Add support for versioned objects
2016-02-25 12:04:18 +00:00
Radek Simko
2f8b9edaf8
provider/aws: Add support for s3_bucket_object updates
2016-02-25 12:04:16 +00:00
James Nugent
74e5711f08
Merge pull request #5182 from Originate/mb-fix-lambda-vpc-implementation
...
provider/aws: Fixes terraform crash when lambda VpcId is nil
2016-02-24 17:52:38 -05:00
Paul Hinze
893bfb3ff4
provider/aws: Fix int overflow on 386 builds
...
386 architecture builds were failing with:
```
builtin/providers/aws/resource_aws_sns_topic_subscription.go:216: constant 60000000000 overflows int
```
2016-02-24 13:55:01 -06:00
Paul Hinze
cb8f0f04b5
fix go vet warnings
...
```
go tool vet -all .
builtin/providers/aws/resource_aws_elasticache_security_group.go:130: arg apierr.Code in printf call is a function value, not a function call
builtin/providers/aws/resource_aws_elasticache_subnet_group.go:155: arg apierr.Code in printf call is a function value, not a function call
```
2016-02-24 09:48:32 -06:00
Radek Simko
ebf2fd54e5
provider/aws: Clean up whitespaces
2016-02-24 14:58:17 +00:00
Radek Simko
70f045e46e
provider/aws: Breaking change - Trim off quotes for aws_s3_bucket_object.etag
2016-02-24 14:58:17 +00:00
Maxime Bury
f92b2b7c58
Also ignore empty VPC config after all
2016-02-23 12:56:46 -08:00
Paul Stack
e454b21100
Merge pull request #5271 from stack72/f-aws-dynamodb-stream-arn
...
provider/aws: Enable DynamoDB Table to output `stream_arm` when streams are enabled
2016-02-23 17:27:22 +00:00
Paul Stack
039065f63a
Merge pull request #5223 from stack72/f-aws-kinesis-retention-period
...
provider/aws: Implement RetentionPeriod Changes for Kinesis Stream
2016-02-23 17:26:12 +00:00
stack72
8d6cfe8e89
Implement RetentionPeriod Changes for AWS Kinesis Stream
2016-02-23 17:15:33 +00:00
stack72
0ce4aed52a
provider/aws: Enable DynamoDB Table to output `stream_arm` when streams
...
are enabled
2016-02-23 15:40:41 +00:00
Paul Hinze
b5e6a4fac7
Merge pull request #5101 from tpounds/fix-read-aws-asg-termination-policies
...
provider/aws: Fix reading auto scaling group termination policies
2016-02-23 08:03:18 -06:00
Trevor Pounds
066a60debe
Add termination policies acceptance test.
2016-02-22 17:05:10 -08:00
Trevor Pounds
b39cc55f37
Cleanup termination policy update logic.
2016-02-22 17:05:09 -08:00
Trevor Pounds
44b00782c3
Fix termination policies read logic.
2016-02-22 17:05:09 -08:00
Paul Hinze
ce948c0dea
Merge pull request #5120 from paybyphone/paybyphone_igw_destroyfix
...
IGW detatch waiter tweak, 30 not found checks w/15 min max
2016-02-22 18:17:12 -06:00
Paul Hinze
9c0e52bc4b
Merge pull request #5100 from hashicorp/b-aws-sg-drift-updates
...
provider/aws: Security Group drift updates
2016-02-22 18:10:49 -06:00
Paul Stack
57f58dec98
Merge pull request #5262 from stack72/b-aws-redshift-cluster-public
...
provider/aws: `aws_redshift_cluster` publicly_accessible now defaults true
2016-02-22 23:19:30 +00:00
stack72
e822d46843
provider/aws: `aws_redshift_cluster` publicly_accessible now defaults to
...
true
2016-02-22 23:11:55 +00:00
Paul Hinze
5528abb51e
Merge pull request #5255 from hashicorp/phinze/improve-vpc-cidr-errmsg
...
provider/aws: improve vpc cidr_block err message
2016-02-22 16:54:47 -06:00
Paul Hinze
ce74e3d8f0
provider/aws: improve vpc cidr_block err message
...
Pull CIDR block validation into a shared func ready to be used elsewhere
Example of new err message:
```
Errors:
* aws_vpc.foo: "cidr_block" must contain a valid network CIDR,
expected "10.0.0.0/16", got "10.0.1.0/16"
```
2016-02-22 16:44:33 -06:00
Paul Stack
d5fb018250
Merge pull request #4945 from stack72/aws-rds-enhanced-monitoring
...
provider/aws: Enabled Enhanced Monitoring for RDS
2016-02-22 22:02:09 +00:00
James Nugent
a285ae1e2c
Fix format string making vet fail
2016-02-22 13:34:15 -05:00
James Nugent
16b18df1fd
Merge pull request #5238 from stack72/f-aws-redshift-calculate-cluster
...
provider/aws: Change Redshift Cluster cluster_type to be computed
2016-02-22 13:18:09 -05:00
Paul Stack
30dcc45635
Merge pull request #5178 from hashicorp/f-aws-iam-server-updates
...
provider/aws: Update IAM Server Cert
2016-02-22 18:07:22 +00:00
Paul Stack
c4dd1a9a64
Merge pull request #5197 from hashicorp/f-aws-db-snapshot-copy
...
provider/aws: Fix copy_tags_to_snapshot for DB Instance
2016-02-22 18:05:41 +00:00
Paul Stack
0214319333
Merge pull request #4882 from stack72/f-aws-asg-getAutoscaleGroup
...
provider/aws: Autoscaling Group Code Refactor
2016-02-22 09:58:53 +00:00
Trevor Pounds
f83c81dbb5
Change AWS ELB access_logs to list type.
...
There can only be a single access_log configuration per load balancer
so choosing to use a list over a set is only relevant when comparing
changes during a plan. A list makes it much easier to compare updates
since the index is stable (0 vs. computed hash).
2016-02-21 15:16:09 -08:00
Paul Stack
1e7f10d3a3
Merge pull request #5066 from tpounds/fix-aws-elb-health-check-type
...
provider/aws: Change ELB health_check to list type
2016-02-21 22:38:10 +00:00
stack72
628fb1a37c
provider/aws: Add test to ECS Service to make sure deployment values are
...
set
2016-02-21 22:33:48 +00:00
stack72
5f7060e9f5
Merge branch 'ecs_service_deployment_cfg' of https://github.com/joshgarnett/terraform into joshgarnett-ecs_service_deployment_cfg
2016-02-21 22:09:20 +00:00
stack72
e6e18a4a9e
provider/aws: Change Redshift Cluster cluster_type to be computed
...
It will be based off the number of nodes. Can only be multi-node (>1
node) or single-node (nodes=1)
2016-02-21 19:42:02 +00:00
innossh
564dd360a2
provider/aws: Support additional changes to security groups of instance without forcing new
2016-02-21 14:24:33 +09:00
James Nugent
c91b648c15
core: Test fix for mismatched diffs from GH-4965
...
This test presents itself in an awkward manner as part of the AWS test
suite rather than the core test suite - this is because you cannot use
real providers in context tests because of circular references, and
simplistic test providers in that package do not demonstrate the issue.
In the interests of getting this fix in quickly and still having
regression coverage for it, it was agreed to include the change here
instead.
Running the test TestAccAWSVPC_coreMismatchedDiffs without the changes
in d95ab75
applied leads to the following output:
```
$ make testacc TEST=./builtin/providers/aws TESTARGS="-run TestAccAWSVPC_coreMismatchedDiffs"
==> Checking that code complies with gofmt requirements...
/Users/James/Code/go/bin/stringer
GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/)
TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/aws -v -run TestAccAWSVPC_coreMismatchedDiffs -timeout 120m
=== RUN TestAccAWSVPC_coreMismatchedDiffs
--- FAIL: TestAccAWSVPC_coreMismatchedDiffs (2.26s)
testing.go:148: Step 0 error: Error applying: 1 error(s) occurred:
* aws_vpc.test: diffs didn't match during apply. This is a bug with Terraform and should be reported.
FAIL
exit status 1
FAIL github.com/hashicorp/terraform/builtin/providers/aws 2.281s
make: *** [testacc] Error 1
```
Applying the changes in d95ab75
(pull request GH-4965) yields the
following result when running the test:
```
$ make testacc TEST=./builtin/providers/aws TESTARGS="-run TestAccAWSVPC_coreMismatchedDiffs"
==> Checking that code complies with gofmt requirements...
/Users/James/Code/go/bin/stringer
GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/)
TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/aws -v -run TestAccAWSVPC_coreMismatchedDiffs -timeout 120m
=== RUN TestAccAWSVPC_coreMismatchedDiffs
--- PASS: TestAccAWSVPC_coreMismatchedDiffs (15.17s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 15.183s
```
The test has a rather misleading name ("AWS") such that it is actually run as
part of the nightly acceptance testing. The VPC resource is quick and free to
create, hence the selection.
2016-02-19 21:24:49 -05:00
clint shryock
280054a387
provider/aws: Security Rules drift and sorting changes
...
This commit adds failing tests to demonstrate the problem presented with AWS
aggregating the security group rules
2016-02-19 16:51:08 -06:00
Joshua Garnett
12958fb5e7
Added support for the deployment configuration settings to the ecs service resource.
2016-02-19 15:32:39 -05:00
Maxime Bury
288ba868e4
Harden things around VPC config
2016-02-18 13:45:32 -08:00
clint shryock
ca29437581
provider/aws: Fix copy_tags_to_snapshot for DB Instance
2016-02-18 11:33:21 -06:00
Maxime Bury
f0f3c430a8
Generalize fix to ignore empty VPC config
2016-02-17 21:45:13 -05:00
Maxime Bury
eb2aaef016
VpcId can be nil in the wild
2016-02-17 20:06:18 -05:00
clint shryock
fce562ba0b
update name length
2016-02-17 17:03:31 -06:00
clint shryock
c8178ad31c
provider/aws: Update IAM Server Cert to allow name_prefix, auto generated namesprovider/aws: Update IAM Server Cert to allow name_prefix, auto generated namesdiff
2016-02-17 16:34:02 -06:00
James Nugent
f7504f7f9f
Merge branch 'master' of https://github.com/vincer/terraform into vincer-master
2016-02-17 13:16:16 -08:00
James Nugent
bc6107508d
Fix additional vet warnings
2016-02-17 11:59:50 -08:00
Trevor Pounds
e130b2c2dc
Fix `go vet` printf verb warnings.
...
e.g. arg trail.LogFileValidationEnabled for printf verb %t of wrong type: *bool
2016-02-17 11:59:50 -08:00
Clint
37a708a2f0
Merge pull request #5155 from hashicorp/b-aws-route-error
...
provider/aws: Return an error if no route is found for an AWS Route
2016-02-17 10:02:48 -06:00
Clint
52e0cd82bd
Merge pull request #5116 from hashicorp/b-aws-acc-tests
...
provider/aws: Update some tests to introduce more randomization
2016-02-17 10:02:20 -06:00
Radek Simko
35345c92af
fix: Return non-aws errors if bucket creation fails
2016-02-17 13:49:41 +00:00
Paul Stack
cd28433c2a
Merge pull request #4826 from TimeIncOSS/f-aws-lambda-permission
...
[WIP] provider/aws: Add aws_lambda_permission
2016-02-17 13:31:29 +00:00
Radek Simko
f8fac710ad
Randomize name of S3 bucket in acctest
2016-02-17 12:36:19 +00:00
Radek Simko
db0d48eb84
Add retry-logic and mutexes to work around inconsistent nature of IAM
2016-02-17 11:38:24 +00:00
Radek Simko
8481625596
Add retry logic to s3_bucket to prevent OperationAborted errors
2016-02-17 11:38:20 +00:00
Paul Stack
ec0e445c25
Merge pull request #4973 from paultyng/pt/elasticsearch-tags
...
AWS - Tag support for Elasticsearch
2016-02-17 10:35:18 +00:00
clint shryock
a706b7c8a4
provider/aws: Return an error if no route is found for an AWS Route
2016-02-16 16:08:02 -06:00
Paul Stack
77deff1194
Merge pull request #5135 from TimeIncOSS/f-aws-cloudtrail-tags
...
provider/aws: Add support for CloudTrail tags
2016-02-16 21:55:45 +00:00
vince rosso
3baabb0186
VPC config support in Lambda functions
...
fixes #5105
2016-02-16 10:43:51 -08:00
clint shryock
320dc3ddf4
provider/aws: Err on failure to attach elb in OpsWorks layer update
2016-02-16 10:31:30 -06:00
Paulo Schreiner
923f7dca37
Added error checking and removed debug statement
2016-02-16 09:44:15 -06:00
Paulo Schreiner
7293ab99d3
Added option to attach an ELB to Opsworks layer
2016-02-16 09:44:15 -06:00
Radek Simko
b7a63c15f9
provider/aws: Add tests for new validators
2016-02-15 17:16:41 +00:00
Radek Simko
d2a3799158
provider/aws: Add tests for aws_lambda_permission
2016-02-15 17:16:41 +00:00
Radek Simko
64539d30bc
provider/aws: Add aws_lambda_permission
2016-02-15 17:16:41 +00:00
Radek Simko
3f66347025
provider/aws: Add tests for CloudTrail tags
2016-02-15 14:10:36 +00:00
Radek Simko
fb0838ce1b
provider/aws: Add support for CloudTrail tags
2016-02-15 14:10:19 +00:00
Radek Simko
fdd9c3b2b8
Merge pull request #4711 from srikalyan/master
...
Added support for http/https endpoints that auto confirms SNS topic subscription.
2016-02-14 21:13:22 +00:00
Srikalyan Swayampakula
345dbce77a
Made the necessary changes to ensure the variable name represents right value.
2016-02-13 12:15:29 -08:00
Radek Simko
30082a4c85
provider/aws: Add acc tests for CloudWatch Event Target
2016-02-13 13:21:33 +00:00
Radek Simko
61afc6d34d
provider/aws: Add CloudWatch Event Target
2016-02-13 13:21:33 +00:00
Radek Simko
b5039dd897
provider/aws: Add acc tests for CloudWatch Event Rule
2016-02-13 13:21:33 +00:00
Radek Simko
ab89e5e528
provider/aws: Add CloudWatch Event Rule
2016-02-13 13:21:32 +00:00
Chris Marchesi
c24fbc3f24
IGW detatch waiter tweak, 30 not found checks w/15 min max
2016-02-12 17:31:49 -08:00
clint shryock
e7fa0952de
provider/aws: Add some randomization for this IAM test
2016-02-12 14:38:23 -06:00
Srikalyan Swayampakula
f21dc995c5
Update code based on the review suggestions.
...
1. Used resource.Retry instead of custom solution
2. Removed unnecessary variables and added required variable to resource.Retry.
2016-02-12 12:21:52 -08:00
clint shryock
9c3699d905
provider/aws: Add some randomization to this test
2016-02-12 14:17:19 -06:00
clint shryock
2a860ff564
provider/aws: Switch format for error message to utilize Go Stringer
2016-02-12 14:16:20 -06:00
clint shryock
a344204cc7
provider/aws: format and randomize RDS Cluster Instance tests
2016-02-12 11:43:07 -06:00
clint shryock
a7af4c46b2
rename test
2016-02-12 11:21:03 -06:00
Clint
169b63e401
Merge pull request #5032 from clstokes/f-aws-gateway-tunnel-info
...
provider/aws: Expose additional VPN Connection attributes.
2016-02-12 10:31:23 -06:00
Hasan Türken
766dac4d79
update documentation
2016-02-12 09:56:48 -06:00
Hasan Türken
e41266e971
Move endpoint options into endpoints block
2016-02-12 09:38:21 -06:00
Hasan Türken
231604e8b7
support custom endpoints for AWS EC2 ELB and IAM
2016-02-12 09:35:50 -06:00
Paul Hinze
66ec38b2d9
Merge pull request #5046 from tpounds/use-built-in-schema-string-hash
...
Use built-in schema.HashString instead of custom hash functions.
2016-02-12 07:58:34 -06:00
clint shryock
8b4a366b43
Merge branch 'pr-4969'
...
* pr-4969:
provider/aws: All security group mods on first run when restoring from snapshot
2016-02-11 16:40:29 -06:00
clint shryock
21a59fc708
provider/aws: All security group mods on first run when restoring from snapshot
2016-02-11 16:39:53 -06:00
Paul Stack
06fdadf491
Merge pull request #5099 from tpounds/cleanup-aws-type-conversions
...
provider/aws: Consolidate duplicate list/set type conversions
2016-02-11 22:29:50 +00:00
Clint
934c31f76b
Merge pull request #4969 from Chili-Man/bugfix/aws_provider_rds_security_groups
...
provider/aws: apply security group changes in EC2 Classic RDS for aws_db_instance
2016-02-11 16:12:12 -06:00
Clint
e04450d95f
Merge pull request #4958 from hashicorp/b-aws-r53-record-tests
...
provider/aws: Add a regression test for Route53 records
2016-02-11 13:32:29 -06:00
Trevor Pounds
57a9048510
Consolidate duplicate list/set type conversions.
2016-02-11 00:48:58 -08:00
Trevor Pounds
164596880a
Update acceptance test to use t2.micro instances.
...
The AWS free tier allows up to 750 hours on t2.micro
instance types. It's better to use cheaper instances
in case the resources are not cleaned up if a tests
is canceled or crashes.
2016-02-09 00:24:38 -08:00
Trevor Pounds
5624a33239
Change AWS ELB health_check to list type.
...
There can only be a single health_check configuration per load balancer
so choosing to use a list over a set is only relevant when comparing
changes during a plan. A list makes it much easier to compare updates
since the index is stable (0 vs. computed hash).
2016-02-08 23:08:35 -08:00
Trevor Pounds
5801b991c9
Cleanup unrelated config to speed up autogenerate name acc test.
...
Removes overspecified config that is unrelated to testing the auto scaling
group's autogenerated name. The test is only concerned with checking that
the auto scaling group was created successfully with an autogenerated name
matching a specific pattern.
2016-02-08 21:28:35 -08:00
Trevor Pounds
eba605fa6a
Cleanup unrelated config to speed up AZ/VPC acc tests.
...
Removes overspecified config that is unrelated to the auto scaling
group's availability zone and VPC identifier acceptance tests. The
created auto scaling groups do not need to spin up any hosts since
the acceptance tests are only concerned with checking the existence
of the associated availability zones and VPC identifiers.
2016-02-08 19:55:11 -08:00
Paul Stack
4baa8fa691
Merge pull request #5044 from tpounds/fix-read-aws-asg-az
...
provider/aws: Fix reading auto scaling group availability zones
2016-02-08 21:37:23 +00:00
Radek Simko
05b6af5d83
Merge pull request #5051 from TimeIncOSS/f-aws-cloudtrail-fields
...
provider/aws: Add support for CloudTrail log validation + KMS encryption
2016-02-08 21:05:35 +00:00
Radek Simko
531e60047b
provider/aws: Add support for CloudTrail log validation + KMS encryption
2016-02-08 11:51:25 +00:00
Trevor Pounds
0cd0ff0f8e
Use built-in schema.HashString.
2016-02-07 16:29:34 -08:00
Trevor Pounds
8ceeaaf7ff
Fix load balancers read logic.
2016-02-07 15:00:21 -08:00
Trevor Pounds
dac7226a8e
Check calculated availability zones.
2016-02-07 14:24:31 -08:00
Trevor Pounds
37eb1cba88
Make availability zones a computed attribute.
...
Fixes a diff calculation error when only a VPC zone
identifiers is provided. In this case the associated
availability zones are computed from the subnets per
the AWS documentation.
2016-02-07 14:14:00 -08:00
Trevor Pounds
e0f4be47a8
Remove redundant metadata get.
2016-02-07 14:14:00 -08:00
Trevor Pounds
cd42705bf1
Fix availability zones read logic.
2016-02-07 14:14:00 -08:00
Paul Stack
00ea9c969d
Merge pull request #4943 from stack72/f-aws-dynamodbtable-refresh
...
provider/aws: DynamoDB Table Refresh State on Error
2016-02-06 23:47:41 +00:00
Cameron Stokes
24f034a2c6
Acc tests for aws_vpn_connection tunnel attributes.
2016-02-06 14:00:26 -08:00
Cameron Stokes
6a5cb5b109
Provide tunnel info from XML config.
2016-02-06 12:39:49 -08:00
Maxime Bury
eaacf5c618
Add multi-region option to cloudtrail
2016-02-05 13:15:05 -05:00
clint shryock
52f3e9b8db
update provider test and extend the delete timelimit
2016-02-04 15:48:54 -06:00
Paul Tyng
0961033400
Add tag support for elasticsearch
2016-02-04 12:53:11 -05:00
Paul Tyng
20efc7688f
Update validation on domain name
2016-02-04 12:53:10 -05:00
clint shryock
840d2e7ccc
Switch to acctest.RandInt for acceptance tests
2016-02-04 11:20:22 -06:00
clint shryock
53a42eaa0f
provider/aws: Add a regression test for Route53 records
...
This is a follow up on #4892 with tests that demonstrate creating a record and a zone, then destroying said record, and confirming that a new plan is generated, using the ExpectNonEmptyPlan flag
This simulates the bug reported in #4641 by mimicking the state file that one would have if they created a record with Terraform v0.6.6, which is to say a weight = 0 for a default value.
When upgrading, there would be an expected plan change to get that to -1. To mimic the statefile we apply the record and then in a follow up step change the attributes directly. We then try to delete the record.
I tested this by grabbing the source of aws_resource_route53.go from Terraform v0.6.9 and running the included test, which fails. The test will pass with #4892 , because we no longer reconstruct what the record should be based on the state (instead finding via the API and elimination/matching)
2016-02-03 09:16:50 -06:00
Diego Rodriguez
cfafa3f574
fix ec2 classic security group changing
2016-02-03 00:33:42 -08:00
stack72
e87d3bb711
Enabled Enhanced Monitoring for RDS
2016-02-03 00:14:24 +00:00
stack72
9c17e5d3e8
DynamoDB Table now refreshes the state when NotFoundException occurs
2016-02-01 21:55:10 +00:00
clint shryock
772ac8522a
provider/aws: Change VPC ClassicLink to be computed
2016-02-01 09:30:09 -06:00
Clint
41de3ee6bd
Merge pull request #4892 from hashicorp/b-aws-r53-weight-update
...
provider/aws: Refactor Route53 record to fix regression in deleting
2016-01-29 13:36:32 -06:00
clint shryock
39f5a7e751
use the same error checking in DELETE
2016-01-29 12:38:22 -06:00
clint shryock
3bbb21d115
refactor error handling in findRecord
2016-01-29 11:56:19 -06:00
Clint
b7582fa6d9
Merge pull request #4869 from hashicorp/b-aws-provider-auth-docs
...
provider/aws: Provide a better message if no AWS creds are found
2016-01-29 09:25:26 -06:00
Clint
800420cf9b
Merge pull request #4856 from hashicorp/b-aws-test-randoms
...
provider/aws: Randomize all S3 bucket names per test, not per run
2016-01-29 06:52:29 -06:00
Clint
23cf9fdbd9
Merge pull request #4860 from hashicorp/b-aws-test-randoms-ops
...
provider/aws: Restructure OpsWorks test files
2016-01-29 06:52:16 -06:00
Paul Stack
2bc5d25bc0
Merge pull request #4891 from stack72/f-aws-sns-ui-deleted
...
provider/aws: SNS Topic State Refreshing correctly
2016-01-29 11:03:19 +00:00
Radek Simko
51f6a15803
Merge pull request #4894 from paultyng/pt/error-message
...
Add "lowercase" to error message
2016-01-29 10:39:43 +00:00
stack72
91cb65dd05
Provider/aws - SNS Topics deleted from the UI were causing Terraform to
...
throw an error:
* aws_sns_topic_subscription.checker: NotFound: Subscription does not
* exist
status code: 404, request id: b8ca0c27-1a62-57b3-8b96-43038a0ead86
Terraform wasn't refreshing the state when the topic gave a 404
2016-01-28 23:26:05 +00:00
Paul Tyng
15f3091f9d
Add "lowercase" to error message
2016-01-28 18:20:50 -05:00
clint shryock
125987994c
provider/aws: Refactor Route53 record to fix regression in deleting
...
refactored to add a `findRecord` method to find the matching record set,
and use that for the `DELETE` method call.
2016-01-28 17:01:53 -06:00
stack72
bd4f8ed800
Refactoring the getAwsAutoscalingGroup func to accept only the arguments it needs rather than ResourceData and meta. This makes it more portable and reusable
2016-01-28 17:52:35 +00:00
Clint
dd0475ca4e
Merge pull request #4879 from hashicorp/b-aws-vpc-classiclink-fix
...
providers/aws: Fix issue with VPC Classic Link and regions that don't support it
2016-01-28 10:54:40 -06:00
clint shryock
2ac040bef2
providers/aws: Fix issue with VPC Classic Link and regions that don't support it
...
- use eu-central-1 to a config to check for #4874
- update documentation
2016-01-28 10:12:06 -06:00
Paul Stack
05d19b0fc3
Merge pull request #4693 from stack72/f-aws-asg-schedule-0values
...
provider/aws: aws autoscale schedule 0 values
2016-01-28 15:38:41 +00:00
clint shryock
45c9a10d0f
provider/aws: Provide a better message if no AWS creds are found
2016-01-27 16:30:03 -06:00
clint shryock
e64c23c69a
patch up acc tests
2016-01-27 14:42:21 -06:00
Paul Hinze
c70eab6500
aws: undeprecate min_elb_capacity; restore min capacity waiting
...
It was a mistake to switched fully to `==` when activating waiting for
capacity on updates in #3947 . Users that didn't set `min_elb_capacity ==
desired_capacity` and instead treated it as an actual "minimum" would
see timeouts for every create, since their target numbers would never be
reached exactly.
Here, we fix that regression by restoring the minimum waiting behavior
during creates.
In order to preserve all the stated behavior, I had to split out
different criteria for create and update, criteria which are now
exhaustively unit tested.
The set of fields that affect capacity waiting behavior has become a bit
of a mess. Next major release I'd like to rework all of these into a
more consistently named block of config. For now, just getting the
behavior correct and documented.
(Also removes all the fixed names from the ASG tests as I was hitting
collision issues running them over here.)
Fixes #4792
2016-01-27 13:30:44 -06:00
clint shryock
99e9dca413
fix some typos
2016-01-27 11:46:46 -06:00
Lars Bahner
8f2d39be45
On Oracle RDS DB instances you can't change the encoding
...
of the database after creation. So we need to be able to
set the CharacterSetName on creation.
This is an option and will automagically default to
AL32UTF8.
The AWS SDK will give you an error message if you try to
apply this setting to other engines. The patch will only
report the character_set_name attribute, if CharacterSetName
is set on the instance.
Signed-off-by: Lars Bahner <lars.bahner@gmail.com>
2016-01-27 18:39:00 +01:00
clint shryock
303554c8df
restructure OpsWorks test files to use random stack name, and duplication
2016-01-27 11:32:40 -06:00
clint shryock
dd0ca302de
guard against a nil dereference
2016-01-27 10:56:33 -06:00
clint shryock
244e727c6f
provider/aws: Randomize all S3 bucket names per test, not per run
...
The existing `randInt` is being use per run (so all tests use the same bucket
name), not per run (where each test would get a random int)
Fixes that
2016-01-27 10:45:52 -06:00
Clint
24f10b024f
Merge pull request #4838 from hashicorp/b-aws-rds-db-name-fix
...
provider/aws: Workaround API issue with RDS Cluster DatabaseName
2016-01-26 14:08:42 -06:00
clint shryock
d78e897b46
provider/aws: Fix SG leak in opsworks custom layer test
2016-01-26 11:43:35 -06:00
clint shryock
8d3f309f62
provider/aws: Workaround API issue with RDS Cluster DatabaseName
2016-01-26 10:35:21 -06:00
Clint
0f2f9da2fd
Merge pull request #4779 from hashicorp/aws-sg-drift-fix
...
provider/aws: Fix issue with detecting drift in AWS Security Groups rules
2016-01-25 16:35:43 -06:00
Clint
2faf1c1422
Merge pull request #4829 from hashicorp/b-aws-efs-test-updates
...
provider/aws: Update EFS test destroy methods
2016-01-25 16:34:59 -06:00
Clint
577618b368
Merge pull request #4825 from hashicorp/b-aws-elb-listener-retry
...
provider/aws: Retry Listener Creation for ELBs
2016-01-25 16:32:40 -06:00
Clint
6ce5ade259
Merge pull request #4828 from hashicorp/b-aws-state-funcs
...
provider/aws: Update refresh state func target for DHCP options
2016-01-25 16:30:55 -06:00
clint shryock
a3bfec2684
provider/aws: Update EFS test destroy methods
2016-01-25 16:27:58 -06:00
clint shryock
1e03c90238
provider/aws: use a known good ami for spot instance test
2016-01-25 16:16:55 -06:00
clint shryock
48ecc9b3a0
provider/aws: Update refresh state func target for DHCP options
2016-01-25 14:47:25 -06:00
clint shryock
86ad4c4340
provider/aws: Retry Listener Creation for ELBs
2016-01-25 11:38:04 -06:00
clint shryock
e865c342cc
provider/aws: fix ELB SG test
2016-01-25 11:05:22 -06:00
Clint
4708e66328
Merge pull request #4098 from csabapalfi/f-aws-s3-redirect-protocol
...
Enable specifying aws s3 redirect protocol
2016-01-22 15:51:40 -06:00
Clint
6befb714cc
Merge pull request #4734 from hashicorp/b-network-acl-visibility
...
provider/aws: Wait for NACL rule to be visible
2016-01-22 14:26:21 -06:00
Csaba Palfi
8f6404a0e1
provider/aws enable specifying aws s3 redirect protocol
...
Signed-off-by: Csaba Palfi <csaba@palfi.me>
2016-01-21 23:26:13 +00:00
clint shryock
9ee6f822f6
provider/aws: Default Autoscaling Schedule min/max/desired to zero
2016-01-21 16:02:46 -06:00
clint shryock
7462eb1742
provider/aws: Fix issue with detecting drift in AWS Security Groups in-line rules
2016-01-21 11:21:25 -06:00
Ian Duffy
47ac10d66b
Change resource.StateChangeConf to use an array for target states
...
Signed-off-by: Ian Duffy <ian@ianduffy.ie>
2016-01-21 01:20:41 +00:00
Paul Hinze
7d10d454e2
Merge pull request #4749 from hashicorp/b-1752
...
core: fix diff mismatch when RequiresNew field and list both change
2016-01-19 18:29:10 -06:00
Paul Hinze
4af2c5f5dd
core: fix diff mismatch when RequiresNew field and list both change
...
fixes #1752
Includes AccTest reproducing example from the issue as well as a bunch
of explanatory comments in the tests and impls.
2016-01-19 15:38:04 -06:00
Clint
569e74c2e7
Merge pull request #4481 from ElliotG/feature/encryptedBlockDevice
...
provider/aws: Added support for the encryption flag on ebs_block_devices in launch configurations
2016-01-19 10:26:11 -06:00
James Nugent
7620381a4f
provider/aws: Wait for NACL rule to be visible
...
Fixes #4721 . It seems there may be some eventual consistency in the API
for network ACLs. This fix doesn't use resource.WaitForState() as there
the NACL is not something that can be looked up by ID and has a
property which determines if it is present.
Instead we reuse the findNetworkAclRule function which the Read function
exhibiting the problem uses, and retry over a 3 minute period, returning
an error message informing the user that running `terraform apply` again
will likely allow them to continue.
2016-01-19 08:12:20 -05:00
Srikalyan Swayampakula
3d256dd021
Found an issue with more testing aws api is responding with various of
...
"pending confirmation" such as "PendingConfirmation", "Pending Confirmation" etc.
2016-01-18 15:38:34 -08:00
Srikalyan Swayampakula
63d6d8dbe2
Forgot to add one last condition to ensure that non pending confirmation subscription is returned.
2016-01-18 14:00:11 -08:00
Srikalyan Swayampakula
9d125944c0
Added support for http/https endpoints that auto confirms SNS topic subscription.
...
http and https SNS topic subscription endpoints require confirmation to set a valid arn otherwise
arn would be set to "pending confirmation". If the endpoints auto confirm then arn is set
asynchronously but if we try to create another subscription with same parameters then api returns
"pending subscription" as arn but does not create another a duplicate subscription. In order to
solve this we should be fetching the subscription list for the topic and identify the subscription
with same parameters i.e., protocol, topic_arn, endpoint and extract the subscription arn.
Following changes were made to support the http/https endpoints that auto confirms
1. Added 3 extra parameters i.e.,
1. endpoint_auto_confirms -> boolean indicates if end points auto confirms
2. max_fetch_retries -> number of times to fetch subscription list for the topic to get the subscription arn
3. fetch_retry_delay -> delay b/w fetch subscription list call as the confirmation is done asynchronously.
With these parameters help added support http and https protocol based endpoints that auto confirm.
2. Update website doc appropriately
2016-01-17 12:24:32 -08:00
stack72
acabd4d407
Change ASG Lifecycle Default Result to be computed and added a test to record what the default value is
2016-01-15 22:34:16 +00:00
stack72
318db85623
Added a test to prove that 0 values cannot be specified for the Autoscale Group Schedule resource
2016-01-15 17:45:09 +00:00
Clint
79c32ddbe9
Merge pull request #4627 from ColinHebert/patch-1
...
provider/aws: EBS optimised to force new resource
2016-01-14 14:57:13 -06:00
Clint
8e6fba43ef
Merge pull request #4564 from hashicorp/pr-3741
...
provider/aws: Supporting New AWS Route53 HealthCheck additions (supersedes #3741 )
2016-01-14 14:41:19 -06:00
James Nugent
6acc7a14e4
Merge pull request #4632 from hashicorp/f-aws-profile
...
provider/aws: Add profile to provider config
2016-01-14 17:08:04 +00:00
James Nugent
ace215481a
provider/aws: Add profile to provider config
...
This allows specification of the profile for the shared credentials
provider for AWS to be specified in Terraform configuration. This is
useful if defining providers with aliases, or if you don't want to set
environment variables. Example:
$ aws configure --profile this_is_dog
... enter keys
$ cat main.tf
provider "aws" {
profile = "this_is_dog"
# Optionally also specify the path to the credentials file
shared_credentials_file = "/tmp/credentials"
}
This is equivalent to specifying AWS_PROFILE or
AWS_SHARED_CREDENTIALS_FILE in the environment.
2016-01-14 15:39:35 +00:00
James Nugent
ea4595840c
Merge pull request #4674 from stack72/carl-youngblood/master
...
Fix recurrence on `aws_autoscaling_schedule` resource
2016-01-14 12:22:43 +00:00
Carl Youngblood
5c68858c5b
Bug fixes for aws_autoscaling_schedule resource
...
- Fix typo s/recurrance/recurrence
- Fix missing nil check on EndTime that was crashing
2016-01-14 10:08:37 +00:00
clint shryock
8181a4ea24
minor clean ups after #3862
2016-01-13 16:58:07 -06:00
Clint
7f6624e926
Merge pull request #3862 from stack72/aws-redshift
...
provider/aws: AWS Redshift
2016-01-13 16:52:47 -06:00
Clint
64f44c53c6
Merge pull request #4597 from tpounds/support-aws-elb-az-and-subnet-updates
...
provider/aws: Support updating ELB availability zones and subnets
2016-01-13 15:30:44 -06:00
Clint
eed2a2a0f6
Merge pull request #3139 from koendc/b-rds-snapshots-required-fields
...
provider/aws: aws_db_instance: make some fields optional
2016-01-13 15:15:09 -06:00
Clint
921f6eb806
Merge pull request #4388 from jszwedko/add-support-for-aws-directory-service-microsoft-active-directory
...
Add support for creating Managed Microsoft Active Directory and Directory Connectors in AWS
2016-01-13 13:39:29 -06:00
Paul Hinze
395b61825d
Merge pull request #4654 from hashicorp/gofmts
...
Go fmt updates
2016-01-13 12:55:36 -06:00
Clint
c9231a73ec
Merge pull request #4240 from hashicorp/b-aws-catch-sg-name-id-error
...
provider/aws: Trap Instance error from mismatched SG IDs and Names
2016-01-13 11:57:58 -06:00
clint shryock
f084871fad
move the 'color' assignment
2016-01-13 11:16:36 -06:00
clint shryock
aa7ba9ab9b
provider/aws: OpsWorks updates
...
- add UseOpsworksSecurityGroups to the Create ops
- toggle waiting on said membership of groups
2016-01-13 11:13:09 -06:00
aibou
5e9c17d008
Implement some lacking parameters and stop waiting when in vpc and un-use opsworks default SG
2016-01-13 10:45:32 -06:00
clint shryock
73064bcb87
formatting
2016-01-13 10:10:15 -06:00
Johannes Boyne
df7ac2d51b
Add AWS lambda alias support and documentation
2016-01-13 10:05:32 -06:00
Koen De Causmaecker
45ef11e59f
provider/aws: aws_db_instance: unrequire fields
...
When spinning up from a snapshot or a read replica, these fields are
now optional:
* allocated_storage
* engine
* password
* username
Some validation logic is added to make these fields required when
starting a database from scratch.
The documentation is updated accordingly.
2016-01-13 15:40:15 +01:00
Clint
5c3b88a0a7
Merge pull request #4140 from hashicorp/b-empty-element-sg
...
provider/aws: error with empty list item on security group
2016-01-12 17:03:02 -06:00
clint shryock
57b9097015
provider/aws: Default false for VPC Classic Link
2016-01-12 16:49:51 -06:00
Clint
90e5f5f655
Merge pull request #3994 from Pryz/master
...
Add AWS Classiclink for AWS VPC resource
2016-01-12 16:48:23 -06:00
clint shryock
317ab83743
Go fmt updates
2016-01-12 16:07:26 -06:00
Clint
a5f8c39ddd
Merge pull request #3332 from ross/aws-instance-migrate-nil-attr
...
Avoid nil map assign in aws instance migrateStateV0toV1
2016-01-12 15:55:16 -06:00
Clint
4f8e9713cf
Merge pull request #3261 from fatih/show-instance-state
...
aws: store and read instance state
2016-01-12 11:06:30 -06:00
clint shryock
ac60d6b959
provider/aws: Limit SNS Topic Subscription protocols
...
- update the ARN with the new ID
2016-01-12 09:57:09 -06:00
Clint
a69df4b77c
Merge pull request #4637 from discogestalt/aws-ap-northeast-2
...
provider/aws: Allow ap-northeast-2 (Seoul) as valid region
2016-01-11 16:50:55 -06:00
Mark Troyer
b396bbb3e4
provider/aws: Allow ap-northeast-2 (Seoul) as valid region
2016-01-11 13:46:53 -08:00
Clint
f0ef2c1a72
Merge pull request #4631 from wata727/add_new_parameter_elasticache
...
provider/aws: Add new parameter az_mode and availabiliy_zone(s) in ElastiCache
2016-01-11 15:46:04 -06:00
Paul Hinze
771fba4913
provider/aws: use random cert name in ELB test
2016-01-11 14:23:33 -06:00
wata_mac
bfcff6b068
Add az_mode and availability_zones parameters
...
Signed-off-by: wata727 <watassbass@gmail.com>
2016-01-11 23:45:07 +09:00
wata_mac
df56ef44f7
Add availability_zone parameter.
...
Signed-off-by: wata727 <watassbass@gmail.com>
2016-01-11 23:33:21 +09:00
Colin Hebert
2948d3678d
provider/aws: EBS optimised to force new resource
...
EBS optimised can't be changed without re-creating the instance. Apply forcenew.
2016-01-11 08:16:49 +01:00
Trevor Pounds
76e23a3b2e
Fix ELB security groups read logic.
2016-01-09 16:09:14 -08:00
Trevor Pounds
6dd4578e7c
Add ELB availability zones acceptance test.
2016-01-09 15:40:21 -08:00
Trevor Pounds
c34c2249e7
Support updating ELB availability zones.
2016-01-09 15:40:21 -08:00
Trevor Pounds
f75c3168d7
Support updating ELB subnets.
2016-01-09 15:40:21 -08:00
Trevor Pounds
9541c37ef4
Fix ELB availability zones and subnets read logic.
2016-01-09 15:40:21 -08:00
Kazunori Kojima
f2ce28ed46
Add support for S3 logging.
2016-01-09 10:09:23 -08:00
Clint
3c494a4d6a
Merge pull request #4550 from hashicorp/b-aws-acc-fixes
...
provider/aws: Update acceptance tests
2016-01-08 09:27:32 -06:00
stack72
e635878b11
Forcing all Route 53 Healthcheck Types to be Uppercase or it would show diffs unnecessarily
2016-01-07 17:14:11 -06:00
stack72
3ebbb62bb0
Adding child_healthchecks to the Route 53 HealthCheck resource
2016-01-07 17:13:24 -06:00
stack72
172faca052
Adding support to Route53 HealthCheck for measure_latency and inverting healthcheck
2016-01-07 17:12:45 -06:00
Clint
829fffce7e
Merge pull request #3688 from ajvb/master
...
Added measure_latency option to Route 53 Health Check resource.
2016-01-07 17:07:06 -06:00
Clint
e25aaa5fb3
Merge pull request #4368 from spenczar/kinesis_pagination
...
provider/aws: Kinesis DescribeStream pagination
2016-01-07 16:51:36 -06:00
Radek Simko
ddcee32411
Merge pull request #4366 from TimeIncOSS/b-ecs-svc-fixes
...
provider/aws: Fix bug w/ changing ECS svc/ELB association
2016-01-07 21:11:35 +00:00
clint shryock
9a4f0a06b3
clean up debugging
2016-01-07 15:00:55 -06:00
clint shryock
dcce2aa479
providers/aws: Update OpsWorks tests to inject the expected availability zone, based on if we are testing vpc or not
2016-01-07 14:16:41 -06:00
clint shryock
e2a7d4d98b
provider/aws: Update testAccCheckAWSVpcPeeringConnectionDestroy to correctly check the destroyed state
2016-01-07 11:48:53 -06:00
Radek Simko
72d3d7ed9b
provider/aws: Fix template_url/template_body conflict
2016-01-07 12:07:43 +00:00
Paul Hinze
319f7d77a0
Merge pull request #3947 from hashicorp/phinze/asg-wait-on-update
...
provider/aws: wait for ASG capacity on update
2016-01-06 15:55:43 -06:00
Clint
98703490bc
Merge pull request #4531 from hashicorp/b-aws-resources-tests
...
provider/aws: Clean up OpsWorks tests
2016-01-06 15:40:59 -06:00
clint shryock
adcbe85e3b
provider/aws: Clean up OpsWorks tests to use us-east, validate destroy of custom layer
2016-01-06 14:44:55 -06:00
Clint
bbfb9f0463
Merge pull request #4527 from hashicorp/b-aws-resources-tests
...
provider/aws: Update opsworks, vpn connection route tests
2016-01-06 13:30:06 -06:00
clint shryock
266f216a13
provider/aws: Update Ops works tests, error catching
2016-01-06 11:19:42 -06:00
Radek Simko
2edc25e868
Merge pull request #4431 from TimeIncOSS/f-aws-validators
...
provider/aws: Add validation for ECR repository name
2016-01-06 16:43:50 +00:00
clint shryock
2be03ddf06
provider/aws: Update testAccAwsVpnConnectionRouteDestroy method
2016-01-06 10:22:54 -06:00
Elliot Graebert
65567cfbdc
Added an acceptance test
2016-01-05 23:36:39 -08:00
Paul Hinze
a8d2ad3ebe
refactor s3 bucket test to expect non-empty plan
...
pushing to master but paging @catsby for post-hoc review
2016-01-05 17:38:38 -06:00
Clint
5b3ef43b1c
Merge pull request #4518 from hashicorp/b-aws-resources-tests
...
providers/aws: Update VPN Gateway test
2016-01-05 16:43:14 -06:00
clint shryock
055482a9f5
providers/aws: Update VPN Gateway test
2016-01-05 16:16:32 -06:00
Clint
efeb9b02e6
Merge pull request #4511 from hashicorp/b-aws-resources-tests
...
provider/aws: More Acc test updates
2016-01-05 14:14:09 -06:00
clint shryock
449ffe027f
fix error with undefined err
2016-01-05 11:35:21 -06:00
clint shryock
312f2dd6e3
document why we retry in lambda source mapping
2016-01-05 11:27:49 -06:00
clint shryock
6b733a09eb
provider/aws: more retrying with Lambda
2016-01-05 11:22:57 -06:00
Clint
dedc17072e
Merge pull request #4510 from hashicorp/b-aws-resources-tests
...
provider/aws:Updating AWS Acceptance tests
2016-01-05 10:24:39 -06:00
clint shryock
89ca1bc86f
Merge branch 'pr-4316' into b-aws-resources-tests
...
* pr-4316:
Retry InvalidParameterValueException errors due to newly created resources
2016-01-05 10:17:40 -06:00
clint shryock
f0d1193f8f
provider/aws: Update Lambda create error handling to be more flexible
2016-01-05 10:17:20 -06:00
clint shryock
1510277f45
update AWS Service Directory delete method and test
2016-01-05 09:33:34 -06:00
clint shryock
dd3a2aa4e9
provider/aws: Dynamo DB test/destroy updates
2016-01-04 16:57:31 -06:00
James Nugent
c519ea74c5
provider/aws: Don't set NatGatewayId with no value
...
This fixes create aws_route_table resources in regions which do not
support the NAT Gateway yet (e.g. eu-central) - unless a value is
explicitly set in which case the API call will fail until such time as
NAT Gateway is supported.
Fixes #4499 .
2016-01-04 16:14:30 -05:00
Clint
89f71d4ec4
Merge pull request #4497 from hashicorp/b-aws-iam-role-test-fix
...
provider/aws: Update some IAM tests
2016-01-04 14:55:29 -06:00
clint shryock
c94815d56d
provider/aws: Update some IAM tests
2016-01-04 14:19:12 -06:00
James Nugent
7b9f6e5128
Merge pull request #4490 from hashicorp/b-rds-unexpected-state
...
provider/aws: Fix RDS unexpected state config
2016-01-04 14:20:13 -05:00
James Nugent
3c330f6e19
provider/aws: Fix RDS unexpected state config
...
This commit adds the various states (taken from the RDS documentation
here: http://amzn.to/1OHqi6g ) to the list of allowable pending states
when creating an RDS instance.
In particular, `resetting-master-credentials` is returned when creating
an `aws_db_instance` from a snapshot. Fixes #4477 .
2016-01-04 13:24:29 -05:00
Elliot Graebert
2112f763ee
Added support for the encryption flag on ebs_block_devices in launch configurations
2016-01-01 15:47:36 -08:00
Radek Simko
d853d2cc93
aws: Add validation for ECR repository name
2015-12-23 16:07:53 +01:00
Radek Simko
a367886eaf
provider/aws: Separate existing validate functions
2015-12-23 15:11:45 +01:00
Radek Simko
b7ed0e1c80
Revert "provider/aws: fix ECS service CheckDestroy in tests"
...
This reverts commit 47f8b0cd79
.
cc @phinze
2015-12-23 11:35:30 +01:00
Radek Simko
9a625427ca
aws: Add regression acc test for ecs svc lb changes
2015-12-23 10:43:37 +01:00
Radek Simko
95367bc0fc
aws: Fix CheckDestroy for ecs service
2015-12-23 10:17:52 +01:00
clint shryock
f68a351fba
provider/aws: Fix issue with Route53 and zero weighted records
2015-12-22 16:23:08 -06:00
Paul Hinze
0d895ffa96
provider/aws: mention us-east-1 in ECR docs and tests
...
ECR is only available in us-east-1 for now.
Also added missing sidebar links for ECR resources.
/cc @nextrevision
2015-12-22 16:00:21 -06:00
Clint
c49802de87
Merge pull request #4422 from hashicorp/b-vpc-endpoint-updates
...
VPC Endpoint test updates
2015-12-22 15:46:59 -06:00
Paul Hinze
0616c51aa2
Merge pull request #4415 from nextrevision/provider/aws-ecr
...
provider/aws: ecr resources
2015-12-22 15:34:27 -06:00
clint shryock
363defb548
provider/aws: Update Route53 Zone tests
2015-12-22 14:58:43 -06:00
Radek Simko
f8bb48b287
aws: Wait for ECS service to be drained before deletion
2015-12-22 21:11:16 +01:00
Radek Simko
583c0a54c4
aws: Fix bug w/ changing ECS service LB association
...
- fixes #3444
- fixes #4227
2015-12-22 21:10:23 +01:00
clint shryock
558e839bf2
vpc vpn connection test fixes
2015-12-22 12:53:42 -06:00
clint shryock
70bb536be1
skip TestAccAWSVPCPeeringConnection_tags for now
2015-12-22 12:18:22 -06:00
clint shryock
c3d987ab18
VPC Endpoint test updates
2015-12-22 12:12:25 -06:00
Clint
791b2f0ccd
Merge pull request #4392 from hashicorp/b-vpc-endpoint-updates
...
provider/aws: Update VPC Endpoint to correctly set route table ids, a…
2015-12-22 11:44:49 -06:00
Clint
86776e8b42
Merge pull request #4417 from hashicorp/b-aws-elasticache-testupdates
...
provider/aws: Updates for ElastiCache, ElastiSearch tests
2015-12-22 11:25:20 -06:00
Clint
3fc370285b
Merge pull request #4420 from hashicorp/b-aws-s-test-updates
...
provider/aws: Update tests destroy checks
2015-12-22 11:25:06 -06:00
Paul Hinze
b9ea8d8698
provider/aws: fix CheckDestroy for ProtocolPolicy tests
...
Can only assert that the load balancer is gone, since the test suite
deletes everything, and the load balancer is the way you get to the
proxy protocol policy.
2015-12-22 11:18:11 -06:00
clint shryock
1c2c1a5edb
provider/aws: Update tests destroy checks
2015-12-22 11:08:09 -06:00
clint shryock
84fe0b15fd
provider/aws: Update ElastiCache tests to verify delete
...
provider/aws: update elasticache search domain to only save access policies if not empty
2015-12-22 10:21:40 -06:00
Paul Hinze
88b2b86978
Merge pull request #4416 from hashicorp/phinze/aws-network-acl-fixes
...
provider/aws: fixes for Network ACL Rules
2015-12-22 10:21:05 -06:00
Paul Hinze
df0f65502f
provider/aws: fix CheckDestroy on placement_group tests
2015-12-22 10:20:28 -06:00
nextrevision
27b8dd08e7
Check for ecr repository and policy removal
2015-12-22 11:18:14 -05:00
Paul Hinze
7f62a49ebd
provider/aws: fixes for Network ACL Rules
...
* Fixup Exists and CheckDestroy assertions
* Make ingress/egress computed on network_acl, otherwise you could
never use network_acl_rule with a managed network_acl without a
perpetual diff.
2015-12-22 09:58:22 -06:00
nextrevision
6a3ed429ad
Adding AWS ECR provider resources
...
Adds ECR aws_ecr_repository and aws_ecr_repository_policy resources to
the AWS provider.
2015-12-22 10:31:30 -05:00
Paul Hinze
b7e87bbf16
provider/aws: fix CheckDestroy for main_route_table_association tests
2015-12-22 09:02:01 -06:00
Paul Hinze
c8319d3b72
provider/aws: fix CheckDestroy on aws_instance tests
2015-12-22 08:49:50 -06:00
Paul Hinze
fd528df002
provider/aws: fix CheckDestroy for iam_group_policy tests
2015-12-22 08:05:37 -06:00
Paul Hinze
c8e88ed1b4
provider/aws: fix CheckDestroy for group_membership test
2015-12-22 08:00:55 -06:00
Paul Hinze
da2c545c8c
Merge pull request #4370 from TimeIncOSS/b-cloudformation-params-fix
...
provider/aws: CloudFormation - Use body or URL for all updates
2015-12-22 07:56:23 -06:00
Paul Hinze
bf40c48075
provider/aws: fix ELB acc tests
...
* LB Name test could end up too long and fail
* CheckDestroy was looking for the wrong error code
2015-12-22 07:41:24 -06:00
Paul Hinze
10cc513ae0
provider/aws: fix CheckDestroy for aws_eip tests
2015-12-22 07:34:06 -06:00
Paul Hinze
51732ac9eb
provider/aws: fix CheckDestroy for codedeploy_app tests
2015-12-22 07:22:06 -06:00
Paul Hinze
02f14ae34a
provider/aws: fix CheckDestroy on glacier vault
2015-12-22 07:17:35 -06:00
Paul Hinze
7d6b98060a
provider/aws: fix CheckDestroy on a bunch of resources
2015-12-21 21:43:42 -06:00
Paul Hinze
1d5c65fa86
provider/aws: fix cookie stickiness policy test destroys
2015-12-21 21:23:57 -06:00
Paul Hinze
67832f6bd0
provider/aws: fix cache SG tests
...
* CheckDestroy should handle not found error
* Pin provider in config to region most likely to have EC2 Classic
2015-12-21 21:12:47 -06:00
Paul Hinze
47f8b0cd79
provider/aws: fix ECS service CheckDestroy in tests
2015-12-21 21:10:13 -06:00
Paul Hinze
f473c2a6d4
provider/aws: don't set static ELB names in tests
...
Prevents ELB name collisions during test runs
2015-12-21 17:41:55 -06:00
Paul Hinze
3dd8bea986
provider/aws: route table test; use standard account id env var
...
also moves the env var check inside the PreCheck, which makes it a
little simpler
2015-12-21 15:09:12 -06:00
Paul Hinze
092c268681
provider/aws: kinesis firehose stream: retry through IAM propagation
...
As I was fixing up the AccTests to not depend on a single existing IAM
role (which this commit does), I noticed that without some sleeping that
the kinesis_firehose_delivery_stream would often come back with:
```
msg: Firehose is unable to assume role {{arn}}. Please check the role provided.
code: InvalidArgumentException
```
Similar to the strategy taken in aws_instance with IAM Instance Profile errors,
I dropped in a simple retry loop which seemed to take care of the issue. Seems
that the same permission propagation delays apply here too.
2015-12-21 14:46:25 -06:00
stack72
bf03752552
Adding the documentation for the AWS Redshift Subnet Group resource
...
also removed the notion of tags from the redshift security group and
parameter group documentation until that has been implemented
Redshift Cluster CRUD and acceptance tests
Removing the Acceptance test for the Cluster Updates. You cannot delete
a cluster immediately after performing an operation on it. We would need
to add a lot of retry logic to the system to get this test to work
Adding some schema validation for RedShift cluster
Adding the last of the pieces of a first draft of the Redshift work - this is the documentation
2015-12-20 20:20:05 +00:00
stack72
48091e37c7
Adding the documentation for the Redshift Parameter Groups
...
Changed the aws_redshift_security_group and aws_redshift_parameter_group
to remove the tags from the schema. Tags are a little bit more
complicated than originally though - I will revisit this later
Then added the schema, CRUD functionality and basic acceptance tests for
aws_redshift_subnet_group
Adding an acceptance test for the Update of subnet_ids in AWS Redshift Subnet Group
2015-12-20 20:20:03 +00:00
stack72
249e7df76c
Adding the documentation for the Redshift security groups
...
Creation of the schema, CRUD and acceptance tests for Redshift Parameter Group
2015-12-20 20:20:01 +00:00
stack72
85afc7d614
Initial creation of the work for AWS RedShift Support
...
Finalising the schema and acceptance tests for the Redshift Security Group's
2015-12-20 20:19:55 +00:00
James Nugent
27008ae898
Merge pull request #4395 from stack72/gofmt_errors_2
...
Fix some gofmt errors in imports
2015-12-19 11:47:01 -05:00
stack72
244a75504e
More gofmt errors I'm afraid
2015-12-19 16:42:10 +00:00
James Nugent
c442ca3899
Merge pull request #4344 from hashicorp/b-aws-s3-test-fixes
...
provider/aws: Fix check destroy method for s3 tests
2015-12-19 11:41:00 -05:00
stack72
d932d99679
Adds documentation for the AWS Network ACL Rule resource
2015-12-18 23:17:08 +00:00
stack72
96ad95abe9
Adds an acceptance test for the AWS Network ACL Rules
2015-12-18 23:14:54 +00:00
stack72
2df8d7d9b0
Initial Scaffolding of the AWS Network ACL Entry resource
2015-12-18 23:14:54 +00:00
James Nugent
30f9d61a95
Merge pull request #4387 from justnom/master
...
provider/aws: EIP not noticing it has been unassigned from an ENI
2015-12-18 17:32:55 -05:00
Jesse Szwedko
48bfd67296
Add support for creating connectors to aws_directory_service_directory
...
This adds support for creating AD Connectors. It is pretty close to the
same as creating AD and simple directories so we reuse the resource.
2015-12-18 21:42:54 +00:00
James Nugent
ceee811625
Merge pull request #4381 from hashicorp/f-nat-gateway
...
provider/aws: Support for aws_nat_gateway
2015-12-18 16:00:42 -05:00
clint shryock
3b21fbc1bc
provider/aws: Update VPC Endpoint to correctly set route table ids, and read after update
2015-12-18 14:18:30 -06:00
Clint
058b55635e
Merge pull request #4264 from h-imaoka/b-aws-vpce-fix
...
providers_aws_vpce issue #4137
2015-12-18 14:10:01 -06:00
Jesse Szwedko
2d06381824
Increase aws_directory_service_directory timeouts
...
According to the AWS docs, creating a MS directory could take up to 25
minutes.
2015-12-18 20:07:34 +00:00
Jesse Szwedko
6bf1011df4
Validate type earlier for aws_directory_service_directory
...
Also DRY it up a little
2015-12-18 19:56:58 +00:00
Radek Simko
b120f8c123
Merge pull request #4372 from TimeIncOSS/b-cf-deleted-fix
...
provider/aws: Treat CF stacks in DELETE_COMPLETE state as deleted
2015-12-18 20:44:11 +01:00
James Nugent
0bdf249f2c
provider/aws: Add aws_nat_gateway Resource
2015-12-18 14:12:27 -05:00
Jesse Szwedko
82fe67f7fc
Add support for creating Managed Microsoft Active Directory in AWS
...
This action is almost exactly the same as creating a SimpleAD so we
reuse this resource and allow the user to specify the type when creating
the directory (ignoring the size if the type is MicrosoftAD).
2015-12-18 18:24:51 +00:00
Clint
e273fe6cfc
Merge pull request #3663 from semarj/master
...
get profile name even if profile path exists
2015-12-18 10:55:23 -06:00
James Nugent
8e538b68ec
Fix errors with gofmt compliance
2015-12-17 12:35:19 -05:00
Radek Simko
4e408d1593
provider/aws: CloudFormation - Add regression test for #4332
2015-12-17 18:00:09 +01:00
Radek Simko
f017d2d2d6
aws: Treat CF stacks in DELETE_COMPLETE state as deleted
2015-12-17 17:59:38 +01:00
Radek Simko
8b30fd484d
Merge pull request #4365 from TimeIncOSS/b-ecs-td-fix
...
provider/aws: Treat INACTIVE ECS TDs as deleted in acc tests
2015-12-17 17:38:46 +01:00
Radek Simko
202b0aef1b
provider/aws: Always use either body or URL for all updates
...
- fixes #4332
2015-12-17 17:01:34 +01:00
Radek Simko
a080447471
aws: Treat INACTIVE ECS TDs as deleted in acc tests
...
- related to https://github.com/hashicorp/terraform/pull/3924
2015-12-17 15:40:27 +01:00
Radek Simko
7f5e2b66ff
aws: Treat INACTIVE ECS cluster as deleted
2015-12-17 15:34:49 +01:00
Harry Macey
4f5df717b4
Fixes #4351
...
Adding empty string defaults for network interface and instance when reading `aws_eip` resource.
2015-12-16 17:38:05 -05:00
clint shryock
d4e4fb6ea0
Reuse structure method for network interface ips
2015-12-16 13:56:23 -06:00
Clint
fb2735e470
Merge pull request #4307 from justnom/b-private-ips-eni
...
provider/aws: Allow changing private IPs for ENIs
2015-12-16 11:43:07 -06:00
Clint
60817ae91a
Merge pull request #4315 from paybyphone/paybyphone_s3bucketpolicywaiter
...
aws_s3_bucket: Retry MalformedPolicy errors due to newly created principals
2015-12-16 11:21:52 -06:00
clint shryock
b172d94381
provider/aws: Fix check destroy method for s3 tests
2015-12-16 11:07:15 -06:00
James Nugent
19e68da388
Merge pull request #4340 from stack72/f-aws-db_subnet_group_name-downcase
...
provider/aws: StateFunc on db_subnet_group name to be lowercase
2015-12-16 11:36:37 -05:00
stack72
57bcb49ede
Change the DB Subnet Group Name to not allow UPPERCASE characters. If
...
this happens, throw a validation error
Add some ValidationTests for the DBSubnetGroupName ValidateFunc
2015-12-16 17:32:47 +01:00
Clint
54e44328e6
Merge pull request #4254 from hashicorp/b-aws-auth-refactor
...
provider/aws: WIP Refactor AWS Authentication chain
2015-12-16 10:12:06 -06:00
Clint
64482422b5
Merge pull request #4146 from hashicorp/b-aws-ebs-validate
...
providers/aws: Validate IOPs for EBS Volumes
2015-12-15 11:33:49 -06:00
clint shryock
adf417809a
add some comments on auth refactoring
2015-12-15 10:49:23 -06:00
clint shryock
5f5459a1fb
provider/aws: Refactor AWS Authentication chain
...
- update auth checking to check metadata header
- refactor tests to not export os env vars
2015-12-15 10:46:10 -06:00
clint shryock
d7a73937eb
provider/aws: Guard against nil DB Parameter vaules
2015-12-14 14:45:27 -06:00
Chris Marchesi
bfa4a88170
Retry InvalidParameterValueException errors due to newly created resources
2015-12-14 11:12:06 -08:00
Chris Marchesi
559aa50a31
Retry MalformedPolicy errors due to newly created principals
2015-12-14 10:42:08 -08:00
Spencer Nelson
063d770e51
provider/aws: Kinesis DescribeStream pagination
...
Each call to the Kinesis DescribeStream API returns a limited number of
shards. When interrogating AWS for the state of a Kinesis stream, the
client needs to page through the API's responses to get the true number
of shards.
2015-12-14 11:27:00 -05:00
justnom
38509d583d
Fixes #4253
2015-12-14 10:33:08 -05:00
James Nugent
19ea14bf8d
Merge pull request #4256 from stack72/aws-asg-scheduled-actions
...
provider/aws: Autoscaling Group Scheduled Actions
2015-12-11 16:54:13 -05:00
stack72
c965d2278e
Adding a resource for aws_autoscaling_schedule
2015-12-11 18:43:38 +00:00
toshihisa
bedd020dee
issue #4137
...
vpc_endpoint bug fix.
2015-12-12 01:15:54 +09:00
Clint
8b21f284b4
Merge pull request #4259 from stack72/aws-db_parameter_group-tags
...
provider/aws: Adding Tag support for DB Param Groups
2015-12-11 08:58:26 -06:00
Clint
5b2230588a
Merge pull request #4260 from stack72/aws-db_security_group-tags
...
provider/aws: Adding support for Tags to DB SecurityGroup
2015-12-11 08:48:59 -06:00
stack72
dec5a27f19
Adding the ARN as an output of the DB Subnet Group
2015-12-11 12:39:15 +00:00
stack72
474d6080f0
Adding support for Tags to the DB Security Group
2015-12-11 12:28:24 +00:00
stack72
67c1971e63
Adding support to DB Parameter Group for Tags
2015-12-11 12:07:50 +00:00
stack72
d84d6796c4
Initial CRUD work for the Autoscaling Group Scheduled Actions
2015-12-11 10:53:46 +00:00
James Nugent
fb4878cf37
Merge pull request #3853 from stack72/f-aws-db-instance-omit-snapshot
...
provider/aws: add DB Instance skip_final_snapshot
2015-12-10 18:38:11 -05:00
stack72
2b0c7aa4e9
Making the changes to db_instance skip_final_snapshot on the feedback from @catsby
2015-12-10 23:21:36 +00:00
James Nugent
2fecc72fb0
Merge pull request #3809 from stack72/f-aws-elasticache-cache-nodes-reduction
...
provider/aws: Ability to reduce nodes in an ElastiCache cluster
2015-12-10 15:30:09 -05:00
stack72
6082e3e732
Changing the db_instance to throw an error is a final snapshot is required but yet no identified is given
2015-12-10 19:11:47 +00:00
stack72
5796b13373
Adding skip_final_snapshop bool to th db_instance. This will allow us to specify whether a snapshot is needed directly rather than checking for an empty string
2015-12-10 19:11:47 +00:00
James Nugent
a213fe121d
Merge pull request #4245 from grisha/esd_fix
...
Fix a bug whereby AWS elasticsearch domain access_policies will always appear changed
2015-12-10 14:08:38 -05:00
Clint
eb3840c574
Merge pull request #4242 from hashicorp/b-aws-lc-guard
...
provider/aws: Fix missing AMI issue with Launch Configurations
2015-12-10 08:55:49 -06:00
Grisha Trubetskoy
6fbfd99ace
Fix a bug whereby AWS elasticsearch domain access_policy will
...
always appear changed because of a missing normalizeJson().
2015-12-09 23:29:38 -05:00