Paul Stack
bf755bb5c9
Merge pull request #8585 from hashicorp/f-diff-suppression
...
helper/schema: Add diff suppression callback
2016-09-01 14:46:03 +01:00
Paul Stack
8a811c2775
Merge pull request #8602 from jcalonso/fix/docs
...
Minor typos
2016-09-01 13:28:00 +01:00
Juan Carlos Alonso
cab71c98cd
Minor typos
2016-09-01 11:30:55 +01:00
Sander van Harmelen
5669185e54
Update CHANGELOG.md
2016-09-01 11:23:42 +02:00
Sander van Harmelen
1a85d06843
Fix the acceptance tests and some cosmetic tweaks ( #8598 )
2016-09-01 11:19:37 +02:00
Bart van der Schans
0835b64456
Add ability to manage cloudstack affinity groups ( #8360 )
...
Add documentation for cloudstack affinity group resource
Implement improvements from review by svanharmelen
Update to latest go-cloudstack v2.1.3
2016-09-01 10:48:49 +02:00
Mitchell Hashimoto
92a9a7c8b8
Update CHANGELOG.md
2016-08-31 20:00:41 -07:00
Mitchell Hashimoto
1b5d7cd2c6
Merge pull request #8590 from hashicorp/b-template-floats
...
providers/template: template_file supports floating point math
2016-08-31 20:00:00 -07:00
Mitchell Hashimoto
c6ad7f80e8
providers/template: template_file supports floating point math
2016-08-31 17:25:11 -07:00
James Nugent
85ec09111b
helper/schema: Add diff suppression callback
...
This commit adds a new callback, DiffSuppressFunc, to the schema.Schema
structure. If set for a given schema, a callback to the user-supplied
function will be made for each attribute for which the default
type-based diff mechanism produces an attribute diff. Returning `true`
from the callback will suppress the diff (i.e. pretend there was no
diff), and returning false will retain it as part of the plan.
There are a number of motivating examples for this - one of which is
included as an example:
1. On SSH public keys, trailing whitespace does not matter in many
cases - and in some cases it is added by provider APIs. For
digitalocean_ssh_key resources we previously had a StateFunc that
trimmed the whitespace - we now have a DiffSuppressFunc which
verifies whether the trimmed strings are equivalent.
2. IAM policy equivalence for AWS. A good proportion of AWS issues
relate to IAM policies which have been "normalized" (used loosely)
by the IAM API endpoints. This can make the JSON strings differ
from those generated by iam_policy_document resources or template
files, even though the semantics are the same (for example,
reordering of `bucket-prefix/` and `bucket-prefix/*` in an S3
bucket policy. DiffSupressFunc can be used to test for semantic
equivalence rather than pure text equivalence, but without having to
deal with the complexity associated with a full "provider-land" diff
implementation without helper/schema.
2016-08-31 19:13:53 -05:00
Paul Stack
6d4bc5547e
Update CHANGELOG.md
2016-08-31 21:49:03 +01:00
stack72
019a13eb7f
Merge branch 'elblivion-librato-alerts'
2016-08-31 21:46:15 +01:00
stack72
32ad2218cb
provider/librato: Fixing some go vet issues for the
...
`resourceLibratoAlertConditionsHash`
2016-08-31 21:45:03 +01:00
Paul Stack
5de8137eb3
Merge pull request #8582 from hashicorp/fix-aws-alb-docs
...
docs/aws: `aws_alb` name parameter is now documented as a Required field
2016-08-31 20:17:59 +01:00
stack72
a6c55ddea9
Merge branch 'librato-alerts' of https://github.com/elblivion/terraform into elblivion-librato-alerts
2016-08-31 20:14:52 +01:00
stack72
cea2ff6be0
docs/aws: `aws_alb` name parameter is now documented as a Required
...
field
The validation rules are also included in the documentation
Fixes #8561
2016-08-31 20:06:04 +01:00
Mitchell Hashimoto
b891f6f238
Update CHANGELOG.md
2016-08-31 11:59:16 -07:00
Mitchell Hashimoto
d081ad1bc0
Merge pull request #8581 from hashicorp/f-self-count
...
terraform: self.count works in interpolations [GH-5283]
2016-08-31 11:58:36 -07:00
Mitchell Hashimoto
60f212b73e
terraform: test for referencing counts that are from vars
2016-08-31 11:54:14 -07:00
Mitchell Hashimoto
d2e15ab69a
terraform: add test explicitly for referencing count
2016-08-31 11:49:25 -07:00
Mitchell Hashimoto
08a9c8e2c2
terraform: self.count works in interpolations [GH-5283]
2016-08-31 11:36:51 -07:00
James Bardin
5f441665af
Merge pull request #8557 from hashicorp/jbardin/races
...
Fix inconsistent results with self interpolation
2016-08-31 14:07:36 -04:00
James Bardin
e0014198e1
Merge pull request #8560 from hashicorp/jbardin/race2
...
Fix races in WaitForState
2016-08-31 14:02:43 -04:00
James Bardin
14138fc449
Add test for RawMap
...
Ensure that RawMap() returns an identical copy, and not a reference to
the original map.
2016-08-31 14:00:59 -04:00
Mitchell Hashimoto
aaaed823af
Merge pull request #8508 from TimeIncOSS/f-schema-all-validation-errors
...
schema: Return all validation errors together from InternalValidate
2016-08-31 10:44:13 -07:00
Mitchell Hashimoto
fe8922dc13
Merge pull request #8567 from premist/resource-fastly-error-msg
...
provider/fastly: Change error text on findService
2016-08-31 10:40:46 -07:00
Anthony Stanton
e4af2d56f2
fixup! Support for Librato Alerts and Services
2016-08-31 17:44:09 +02:00
Anthony Stanton
2b2920ba80
fixup! Support for Librato Alerts and Services
2016-08-31 17:26:39 +02:00
Anthony Stanton
83d4a71423
fixup! Support for Librato Alerts and Services
2016-08-31 17:20:20 +02:00
Anthony Stanton
4b2e11ac63
fixup! Support for Librato Alerts and Services
2016-08-31 17:20:08 +02:00
Anthony Stanton
783b2e5780
fixup! Support for Librato Alerts and Services
2016-08-31 17:19:53 +02:00
clint shryock
3580ae03be
provider/aws: Randomize some IAM user names to avoid conflicts in tests
2016-08-31 09:33:56 -05:00
Anthony Stanton
2ba1c4e39a
fixup! Support for Librato Alerts and Services
2016-08-31 14:10:37 +02:00
Paul Stack
dae81df157
Update CHANGELOG.md
2016-08-31 12:58:47 +01:00
Paul Stack
4d080020ed
Merge pull request #8571 from wowgroup/GH-8570
...
Fix breakage caused by MySQL version string parsing introduced in GH-8251
2016-08-31 12:57:39 +01:00
Paul Stack
85e6323e7b
Merge pull request #8574 from hashicorp/fix-spotfleet-tests
...
provider/aws: `aws_spot_fleet_request` was leaving orphaned instances running
2016-08-31 12:30:46 +01:00
stack72
4d2b9cb167
provider/aws: `aws_spot_fleet_request` was leaving orphaned instances
...
running
Each nightly build was leaving multiple instances running. The issue is
that the IAM role we were using didn't have access to Terminate the EC2
instances
The role was missing the ec2 principle
2016-08-31 11:25:08 +01:00
Paul Stack
aa1ec26bc5
Update CHANGELOG.md
2016-08-31 10:00:43 +01:00
Paul Stack
a424da0056
Merge pull request #8563 from hashicorp/triton-ssh-key
...
provider/triton: Id trying to be used before being set
2016-08-31 09:59:54 +01:00
Paul Stack
31e30d0cde
Update interpolation.html.md ( #8568 )
2016-08-31 09:59:08 +01:00
protomouse
b578b60b88
use hashicorp/go-version to parse mysql server version
2016-08-31 10:50:08 +02:00
zhuk-intetics
3308b974e2
Update interpolation.html.md
2016-08-31 10:19:17 +03:00
Minku Lee
59ff858c16
provider/fastly: Change error text on findService
2016-08-31 12:53:56 +09:00
Mitchell Hashimoto
70d9fe8db3
Update CHANGELOG.md
2016-08-30 16:06:17 -07:00
Mitchell Hashimoto
bc0c26585f
Merge pull request #8564 from hashicorp/b-getter-update
...
vendor: update go-getter
2016-08-30 16:05:50 -07:00
Mitchell Hashimoto
12da7e34fd
vendor: add netrc lib
2016-08-30 16:01:34 -07:00
Mitchell Hashimoto
a1c4e1a97b
vendor: update go-getter
2016-08-30 15:54:31 -07:00
stack72
750ce1dce6
provider/triton: Id trying to be used before being set
...
```
Before
=== RUN TestAccTritonKey_basic
--- FAIL: TestAccTritonKey_basic (1.60s)
testing.go:265: Step 0 error: Error applying: 1 error(s) occurred:
* triton_key.test: failed to get key with name:
caused by: failed unmarshaling/decoding the response body: [{"name":"phinze","fingerprint":"ee:5e:f8:bb:67:a6:60:21:36:5c:73:ce:c6:8b:4d:69","key":"ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC/zeXD4lIgk7Pm5r8qIM+U9qBHQE8a9aUXCsQd++SlA/hnBXeOLUpSm9vtuGFkknA1A4oQBvp07ngTFUw4y2ZD8GAIimmKywEetc/f2nnAkzxhbQ9C1OX5U1FbGUv+p8u60nB8ZZ/a4SgKA3IloVQ7HXjQmZKOsutE+IrT5FTviHrp6f7bwIhMkZXAuHWmkHlaIYub0TIgvbXujk6bqTGQq+G1yAeOLm2KSv6oU0v1A0aFYKBmcMVdj587fR0D91+DwsUBpmGeGyMBlA7x7eKFCS7Xme9sb9TC4VvkDg1xNIwZHo1ybkFih+l9DBMR7sbgfzeE6AwDxwY3/do7Uqwv phinze"},{"name":"jen20","fingerprint":"1b:bc:29:48:89:af:72:63:f0:83:b8:11:b6:4d:ff:3f","key":"ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC6f/7h11O0R4nHY4T9Xd4z2GCN9dPVQYZFvHLbQjwoxIiXYkqy0RVAJlmB9vFuCyxMfS2Hvn9NVhDOQhlXnc1poRaSp98t0uAfFtKfqfGHt5vGrLrA9ACAkPTx5STEryp5/wV9aElcGje4sU2XeFIr0Rf6FPptxGLqXw44yq0X5DVcFg+axov123ErOIMSLNJ7TMdZCh3bqbpE7MnwyBEh69WUwjMr1OfW1AlX0O3RnIHa6HkLCoYnjj4pa3eDKeG0NjAOjbDSqxg8hLVb/+2YA7oaOhZzqhSLmKOZrnFgMSGv90rBbhHzCYTTHNP4NvSGTjPbYzUB/6I6M9l7QD5T James@jn-mpb13"},{"name":"stack72","fingerprint":"40:b3:59:04:7e:e0:08💿 08:70:7e:a5:9c:07:22:4d","key":"ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDGgEagvBiKCc68r2kw7EKyosZs+ibMAQU4as+zOgTFbpHR6iSshAbRUjXXGuSVMmy5GhepnBHdT68hBXD5ny2NcyQPMV2RjSTtzFFWUoazwpUdZiFf4G+fEfK6mLjla1TtHcetCqyjuc1N5+CMWiGypQLDXPtfJKAgNU0RiwXP1SK4zDA8JIl5CcTGtE4ok+mtFFXRIQAoVyAo0u6XM8uToTq/7zH1NKe12pPgcaTthNeZBUiNTaq+BJuS2Y/ws72a7fUsXD5Cc9kvAZQe/QKmMWHOkw8qW8cSDQoWfH2awneZnxNrt3HKPye5IJqbPWhQlpAH32kwvT6DJ0ZAEkZr triton"},{"name":"Acceptance Tests","fingerprint":"b5:28:91:3a:3b:0b:34:72:d4:a6:95:62:40:20:f4:1c","key":"ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDSbVS0L6gCEfrpguFuNrsRls6cX12khHRVqoipL//UbvdVk1YaJuxHqfHoa+wf+ICTqOqrdxmLXk4VnFuEdECKkNzbNwa0P0QAVC1RLVEv1WHlOf5cFn+imJHt2bis3nHGz4kat1ZAMiKcDYTWGOH4Hn0HS32kW4oVqhINeeifb0uPkBej7YfD0Cs2Ihk5siZ4A2eejlZpw+X7tV9UnDBf4i/3bEnp4owPdSZjfyEJ1KJD1GiFYp3xf+pDEn9hLYOLmUFH2U3+bY+LglILzCRdXKQH5R2qAP5EGVprl5W3QmFlUpoYxGERB1feJZKGqCFQzNZzfvuSHkhxxXdVlOSX James@jn-mpb13"},{"name":"acctest-1882518303167625406","fingerprint":"af:ee:3c:aa:94:e1:08:93:f8:c0:9f:67:62:e5:e7:e9","key":"ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDL18KJIe8N7FxcgOMtabo10qZEDyYUSlOpsh/EYrugQCQHMKuNytog1lhFNZNk4LGNAz5L8/btG9+/axY/PfundbjR3SXt0hupAGQIVHuygWTr7foj5iGhckrEM+r3eMCXqoCnIFLhDZLDcq/zN2MxNbqDKcWSYmc8ul9dZWuiQpKOL+0nNXjhYA8Ewu+07kVAtsZD0WfvnAUjxmYb3rB15eBWk7gLxHrOPfZpeDSvOOX2bmzikpLn+L5NKrJsLrzO6hU/rpxD4OTHLULcsnIts3lYH8hShU8uY5ry94PBzdix++se3pUGvNSe967fKlHw3Ymh9nE/LJDQnzTNyFMj James@jn-mpb13"}]
caused by: unexpected type *cloudapi.Key
```
```
After
=== RUN TestAccTritonKey_basic
--- PASS: TestAccTritonKey_basic (17.14s)
```
2016-08-30 23:19:04 +01:00
James Bardin
481f12cf2c
Remove `first` variable an extra if block
...
clean up the code slighly by moving the Sleep in WaitForState to the end
of the loop.
2016-08-30 17:56:26 -04:00
James Bardin
82be35a797
Fix races in WaitForState
...
The WaitForState method can't read the result values in a timeout
because they are still owned by the running goroutine. Keep all values
scoped inside the goroutine, and save them into an atomic.Value to be
returned.
Fixes race introduced in #8510
2016-08-30 16:22:21 -04:00