Paul Hinze
b9ea8d8698
provider/aws: fix CheckDestroy for ProtocolPolicy tests
...
Can only assert that the load balancer is gone, since the test suite
deletes everything, and the load balancer is the way you get to the
proxy protocol policy.
2015-12-22 11:18:11 -06:00
clint shryock
1c2c1a5edb
provider/aws: Update tests destroy checks
2015-12-22 11:08:09 -06:00
clint shryock
84fe0b15fd
provider/aws: Update ElastiCache tests to verify delete
...
provider/aws: update elasticache search domain to only save access policies if not empty
2015-12-22 10:21:40 -06:00
Paul Hinze
88b2b86978
Merge pull request #4416 from hashicorp/phinze/aws-network-acl-fixes
...
provider/aws: fixes for Network ACL Rules
2015-12-22 10:21:05 -06:00
Paul Hinze
df0f65502f
provider/aws: fix CheckDestroy on placement_group tests
2015-12-22 10:20:28 -06:00
nextrevision
27b8dd08e7
Check for ecr repository and policy removal
2015-12-22 11:18:14 -05:00
Paul Hinze
7f62a49ebd
provider/aws: fixes for Network ACL Rules
...
* Fixup Exists and CheckDestroy assertions
* Make ingress/egress computed on network_acl, otherwise you could
never use network_acl_rule with a managed network_acl without a
perpetual diff.
2015-12-22 09:58:22 -06:00
nextrevision
6a3ed429ad
Adding AWS ECR provider resources
...
Adds ECR aws_ecr_repository and aws_ecr_repository_policy resources to
the AWS provider.
2015-12-22 10:31:30 -05:00
Paul Hinze
b7e87bbf16
provider/aws: fix CheckDestroy for main_route_table_association tests
2015-12-22 09:02:01 -06:00
Paul Hinze
c8319d3b72
provider/aws: fix CheckDestroy on aws_instance tests
2015-12-22 08:49:50 -06:00
Paul Hinze
fd528df002
provider/aws: fix CheckDestroy for iam_group_policy tests
2015-12-22 08:05:37 -06:00
Paul Hinze
c8e88ed1b4
provider/aws: fix CheckDestroy for group_membership test
2015-12-22 08:00:55 -06:00
Paul Hinze
da2c545c8c
Merge pull request #4370 from TimeIncOSS/b-cloudformation-params-fix
...
provider/aws: CloudFormation - Use body or URL for all updates
2015-12-22 07:56:23 -06:00
Paul Hinze
bf40c48075
provider/aws: fix ELB acc tests
...
* LB Name test could end up too long and fail
* CheckDestroy was looking for the wrong error code
2015-12-22 07:41:24 -06:00
Paul Hinze
10cc513ae0
provider/aws: fix CheckDestroy for aws_eip tests
2015-12-22 07:34:06 -06:00
Paul Hinze
51732ac9eb
provider/aws: fix CheckDestroy for codedeploy_app tests
2015-12-22 07:22:06 -06:00
Paul Hinze
02f14ae34a
provider/aws: fix CheckDestroy on glacier vault
2015-12-22 07:17:35 -06:00
Paul Hinze
7d6b98060a
provider/aws: fix CheckDestroy on a bunch of resources
2015-12-21 21:43:42 -06:00
Paul Hinze
1d5c65fa86
provider/aws: fix cookie stickiness policy test destroys
2015-12-21 21:23:57 -06:00
Paul Hinze
67832f6bd0
provider/aws: fix cache SG tests
...
* CheckDestroy should handle not found error
* Pin provider in config to region most likely to have EC2 Classic
2015-12-21 21:12:47 -06:00
Paul Hinze
47f8b0cd79
provider/aws: fix ECS service CheckDestroy in tests
2015-12-21 21:10:13 -06:00
Paul Hinze
f473c2a6d4
provider/aws: don't set static ELB names in tests
...
Prevents ELB name collisions during test runs
2015-12-21 17:41:55 -06:00
Paul Hinze
3dd8bea986
provider/aws: route table test; use standard account id env var
...
also moves the env var check inside the PreCheck, which makes it a
little simpler
2015-12-21 15:09:12 -06:00
Paul Hinze
092c268681
provider/aws: kinesis firehose stream: retry through IAM propagation
...
As I was fixing up the AccTests to not depend on a single existing IAM
role (which this commit does), I noticed that without some sleeping that
the kinesis_firehose_delivery_stream would often come back with:
```
msg: Firehose is unable to assume role {{arn}}. Please check the role provided.
code: InvalidArgumentException
```
Similar to the strategy taken in aws_instance with IAM Instance Profile errors,
I dropped in a simple retry loop which seemed to take care of the issue. Seems
that the same permission propagation delays apply here too.
2015-12-21 14:46:25 -06:00
James Nugent
27008ae898
Merge pull request #4395 from stack72/gofmt_errors_2
...
Fix some gofmt errors in imports
2015-12-19 11:47:01 -05:00
stack72
244a75504e
More gofmt errors I'm afraid
2015-12-19 16:42:10 +00:00
James Nugent
c442ca3899
Merge pull request #4344 from hashicorp/b-aws-s3-test-fixes
...
provider/aws: Fix check destroy method for s3 tests
2015-12-19 11:41:00 -05:00
stack72
d932d99679
Adds documentation for the AWS Network ACL Rule resource
2015-12-18 23:17:08 +00:00
stack72
96ad95abe9
Adds an acceptance test for the AWS Network ACL Rules
2015-12-18 23:14:54 +00:00
stack72
2df8d7d9b0
Initial Scaffolding of the AWS Network ACL Entry resource
2015-12-18 23:14:54 +00:00
James Nugent
30f9d61a95
Merge pull request #4387 from justnom/master
...
provider/aws: EIP not noticing it has been unassigned from an ENI
2015-12-18 17:32:55 -05:00
James Nugent
ceee811625
Merge pull request #4381 from hashicorp/f-nat-gateway
...
provider/aws: Support for aws_nat_gateway
2015-12-18 16:00:42 -05:00
clint shryock
3b21fbc1bc
provider/aws: Update VPC Endpoint to correctly set route table ids, and read after update
2015-12-18 14:18:30 -06:00
Clint
058b55635e
Merge pull request #4264 from h-imaoka/b-aws-vpce-fix
...
providers_aws_vpce issue #4137
2015-12-18 14:10:01 -06:00
Radek Simko
b120f8c123
Merge pull request #4372 from TimeIncOSS/b-cf-deleted-fix
...
provider/aws: Treat CF stacks in DELETE_COMPLETE state as deleted
2015-12-18 20:44:11 +01:00
James Nugent
0bdf249f2c
provider/aws: Add aws_nat_gateway Resource
2015-12-18 14:12:27 -05:00
Clint
e273fe6cfc
Merge pull request #3663 from semarj/master
...
get profile name even if profile path exists
2015-12-18 10:55:23 -06:00
James Nugent
8e538b68ec
Fix errors with gofmt compliance
2015-12-17 12:35:19 -05:00
Radek Simko
4e408d1593
provider/aws: CloudFormation - Add regression test for #4332
2015-12-17 18:00:09 +01:00
Radek Simko
f017d2d2d6
aws: Treat CF stacks in DELETE_COMPLETE state as deleted
2015-12-17 17:59:38 +01:00
Radek Simko
8b30fd484d
Merge pull request #4365 from TimeIncOSS/b-ecs-td-fix
...
provider/aws: Treat INACTIVE ECS TDs as deleted in acc tests
2015-12-17 17:38:46 +01:00
Radek Simko
202b0aef1b
provider/aws: Always use either body or URL for all updates
...
- fixes #4332
2015-12-17 17:01:34 +01:00
Radek Simko
a080447471
aws: Treat INACTIVE ECS TDs as deleted in acc tests
...
- related to https://github.com/hashicorp/terraform/pull/3924
2015-12-17 15:40:27 +01:00
Radek Simko
7f5e2b66ff
aws: Treat INACTIVE ECS cluster as deleted
2015-12-17 15:34:49 +01:00
Harry Macey
4f5df717b4
Fixes #4351
...
Adding empty string defaults for network interface and instance when reading `aws_eip` resource.
2015-12-16 17:38:05 -05:00
clint shryock
d4e4fb6ea0
Reuse structure method for network interface ips
2015-12-16 13:56:23 -06:00
Clint
fb2735e470
Merge pull request #4307 from justnom/b-private-ips-eni
...
provider/aws: Allow changing private IPs for ENIs
2015-12-16 11:43:07 -06:00
Clint
60817ae91a
Merge pull request #4315 from paybyphone/paybyphone_s3bucketpolicywaiter
...
aws_s3_bucket: Retry MalformedPolicy errors due to newly created principals
2015-12-16 11:21:52 -06:00
clint shryock
b172d94381
provider/aws: Fix check destroy method for s3 tests
2015-12-16 11:07:15 -06:00
James Nugent
19e68da388
Merge pull request #4340 from stack72/f-aws-db_subnet_group_name-downcase
...
provider/aws: StateFunc on db_subnet_group name to be lowercase
2015-12-16 11:36:37 -05:00
stack72
57bcb49ede
Change the DB Subnet Group Name to not allow UPPERCASE characters. If
...
this happens, throw a validation error
Add some ValidationTests for the DBSubnetGroupName ValidateFunc
2015-12-16 17:32:47 +01:00
Clint
54e44328e6
Merge pull request #4254 from hashicorp/b-aws-auth-refactor
...
provider/aws: WIP Refactor AWS Authentication chain
2015-12-16 10:12:06 -06:00
Clint
64482422b5
Merge pull request #4146 from hashicorp/b-aws-ebs-validate
...
providers/aws: Validate IOPs for EBS Volumes
2015-12-15 11:33:49 -06:00
clint shryock
adf417809a
add some comments on auth refactoring
2015-12-15 10:49:23 -06:00
clint shryock
5f5459a1fb
provider/aws: Refactor AWS Authentication chain
...
- update auth checking to check metadata header
- refactor tests to not export os env vars
2015-12-15 10:46:10 -06:00
clint shryock
d7a73937eb
provider/aws: Guard against nil DB Parameter vaules
2015-12-14 14:45:27 -06:00
Chris Marchesi
bfa4a88170
Retry InvalidParameterValueException errors due to newly created resources
2015-12-14 11:12:06 -08:00
Chris Marchesi
559aa50a31
Retry MalformedPolicy errors due to newly created principals
2015-12-14 10:42:08 -08:00
Spencer Nelson
063d770e51
provider/aws: Kinesis DescribeStream pagination
...
Each call to the Kinesis DescribeStream API returns a limited number of
shards. When interrogating AWS for the state of a Kinesis stream, the
client needs to page through the API's responses to get the true number
of shards.
2015-12-14 11:27:00 -05:00
justnom
38509d583d
Fixes #4253
2015-12-14 10:33:08 -05:00
James Nugent
19ea14bf8d
Merge pull request #4256 from stack72/aws-asg-scheduled-actions
...
provider/aws: Autoscaling Group Scheduled Actions
2015-12-11 16:54:13 -05:00
stack72
c965d2278e
Adding a resource for aws_autoscaling_schedule
2015-12-11 18:43:38 +00:00
toshihisa
bedd020dee
issue #4137
...
vpc_endpoint bug fix.
2015-12-12 01:15:54 +09:00
Clint
8b21f284b4
Merge pull request #4259 from stack72/aws-db_parameter_group-tags
...
provider/aws: Adding Tag support for DB Param Groups
2015-12-11 08:58:26 -06:00
Clint
5b2230588a
Merge pull request #4260 from stack72/aws-db_security_group-tags
...
provider/aws: Adding support for Tags to DB SecurityGroup
2015-12-11 08:48:59 -06:00
stack72
dec5a27f19
Adding the ARN as an output of the DB Subnet Group
2015-12-11 12:39:15 +00:00
stack72
474d6080f0
Adding support for Tags to the DB Security Group
2015-12-11 12:28:24 +00:00
stack72
67c1971e63
Adding support to DB Parameter Group for Tags
2015-12-11 12:07:50 +00:00
stack72
d84d6796c4
Initial CRUD work for the Autoscaling Group Scheduled Actions
2015-12-11 10:53:46 +00:00
James Nugent
fb4878cf37
Merge pull request #3853 from stack72/f-aws-db-instance-omit-snapshot
...
provider/aws: add DB Instance skip_final_snapshot
2015-12-10 18:38:11 -05:00
stack72
2b0c7aa4e9
Making the changes to db_instance skip_final_snapshot on the feedback from @catsby
2015-12-10 23:21:36 +00:00
James Nugent
2fecc72fb0
Merge pull request #3809 from stack72/f-aws-elasticache-cache-nodes-reduction
...
provider/aws: Ability to reduce nodes in an ElastiCache cluster
2015-12-10 15:30:09 -05:00
stack72
6082e3e732
Changing the db_instance to throw an error is a final snapshot is required but yet no identified is given
2015-12-10 19:11:47 +00:00
stack72
5796b13373
Adding skip_final_snapshop bool to th db_instance. This will allow us to specify whether a snapshot is needed directly rather than checking for an empty string
2015-12-10 19:11:47 +00:00
James Nugent
a213fe121d
Merge pull request #4245 from grisha/esd_fix
...
Fix a bug whereby AWS elasticsearch domain access_policies will always appear changed
2015-12-10 14:08:38 -05:00
Clint
eb3840c574
Merge pull request #4242 from hashicorp/b-aws-lc-guard
...
provider/aws: Fix missing AMI issue with Launch Configurations
2015-12-10 08:55:49 -06:00
Grisha Trubetskoy
6fbfd99ace
Fix a bug whereby AWS elasticsearch domain access_policy will
...
always appear changed because of a missing normalizeJson().
2015-12-09 23:29:38 -05:00
Martin Atkins
b679bb2b31
Merge pull request #4241 from b-ryan/fix/opsworks-ssh-key-write-only
...
Make the OpsWorks cookbooks SSH key write only
2015-12-09 18:04:58 -08:00
clint shryock
e4dba86098
provider/aws: Fix missing AMI issue with Launch Configurations
2015-12-09 16:39:03 -06:00
Buck Ryan
921944c956
Make the OpsWorks cookbooks SSH key write only
...
Fixes #3635
This follows the suggestion of @apparentlymart in
https://github.com/hashicorp/terraform/issues/3635#issuecomment-151000068
to fix the issue of OpsWorks stacks always complaining about the custom
cookbooks SSH key needing to be changed.
Functional tests:
* Created a new stack and gave it an SSH key. The key was written to
OpsWorks properly.
* Ran "plan" again and terraform indicated it needed to change the SSH
key, which is expected since terraform cannot read what the existing
SSH is.
* Removed the key from my resource and this time, "plan" did not have
any changes. The `tfstate` file indicated the SSH key was "" (empty
string).
* Changed an unrelated property of the stack. Previously this was not
working for me due to terraform attempting to change the SSH key.
2015-12-09 16:58:05 -05:00
Clint
078280f1ea
Merge pull request #4155 from hashicorp/b-aws-db-replica-storage
...
providers/aws: Update DB Replica to honor storage type
2015-12-09 13:30:23 -06:00
Clint
501a016692
Merge pull request #4127 from hashicorp/aws-vet
...
Small updates to AWS provider to make go vet happy
2015-12-09 13:30:07 -06:00
clint shryock
6015874273
providers/aws: Update DB Replica to honor storage type
...
DB Replica can be of a different storage type, but we were skipping that part.
Note that they are created as the default (or as the primary?) initially,
and then modified to be of the correct type
2015-12-09 13:24:10 -06:00
Clint
9cc5e52cf0
Merge pull request #4167 from stack72/aws-security_group_name_prefix
...
provider/aws: securitygroup name_prefix
2015-12-09 11:42:34 -06:00
Clint
8e20552d44
Merge pull request #4236 from hashicorp/b-aws-s3-hosted-zone-update
...
providers/aws: Update Hosted Zones to fix issue with eu-central
2015-12-09 10:51:02 -06:00
clint shryock
bd22c77c1f
providers/aws: Update Hosted Zones to fix issue with eu-central
2015-12-09 10:44:22 -06:00
Clint
ced42342ff
Merge pull request #4215 from hashicorp/pr-4207
...
Fix issue creating AWS RDS replicas across regions
2015-12-09 09:54:53 -06:00
Clint
9044807152
Merge pull request #4221 from hashicorp/b-aws-runinstances-check
...
provider/aws: Handle empty Instances response from RunInstances
2015-12-09 09:54:02 -06:00
Paul Hinze
5884323c99
Merge pull request #4208 from stack72/aws-dynamodb_streams
...
provider/aws: DynamoDB Table StreamSpecifications
2015-12-08 18:42:48 -06:00
Paul Hinze
baeb790ed9
provider/aws: fix capitalization in acctest names
2015-12-08 17:49:17 -06:00
Clint
9f5f30650f
Merge pull request #4168 from combor/malformed_xml_fix
...
S3 bucket force_destroy error: MalformedXML
2015-12-08 15:24:50 -06:00
stack72
8b79881dea
Adding a validation function for the DynamoDb Table StreamViewType
2015-12-08 20:58:06 +00:00
Paul Hinze
a6ca034968
provider/aws: run codeclimate tests in us-east-1
...
It's only available there.
2015-12-08 14:46:08 -06:00
Paul Hinze
6e32320e41
provider/aws: switch test to use more accessible ami
...
Switch out an AMI that doesn't require marketplace terms acceptance.
2015-12-08 14:40:24 -06:00
clint shryock
9fc6c27de1
provider/aws: Check for empty instances in AWS Instance RunInstance response
...
Fixes #4206
2015-12-08 14:37:54 -06:00
clint shryock
e52af33db7
remove extra DBSubnetGroupName
2015-12-08 10:55:57 -06:00
clint shryock
0619898f6a
provider/aws: Add arn to DB Instance output
2015-12-08 10:52:17 -06:00
stack72
d46348c233
Adding support for AWS DynamoDB Table for StreamSpecifications
2015-12-08 14:07:11 +00:00
Philipp Preß
1cd2fea1f9
Fix AWS RDS cross-region read replica always being placed in default VPC
...
Fixes #4192 by honouring the `db_subnet_group_name` parameter when creating a cross-region read replica.
2015-12-08 15:06:57 +01:00
clint shryock
cf87642bc8
provider/aws: Fix issue destroy Route 53 zone/record if it no longer exists
2015-12-07 16:33:37 -06:00