Pam Selle
a7e43dfd46
Merge pull request #26431 from hashicorp/pselle/sensitive-vals-docs
...
docs: Docs for sensitive variables
2020-10-01 13:50:11 -04:00
Pam Selle
3ddbb4b009
Update provider caveat grammar
2020-10-01 13:19:14 -04:00
Pam Selle
93d38ff2d2
Update intro to code blocks
2020-10-01 13:16:15 -04:00
Pam Selle
be50089c7f
Rephrase sensitive index description
2020-10-01 13:12:25 -04:00
Pam Selle
09551de078
Rewrite intro to section, rename section, move state info
...
Move the information about state from the "caveats" to the main
info section, using similar information to sensitive outputs.
Updates the header of the section from similar inspiration.
2020-10-01 13:09:52 -04:00
Pam Selle
5cf61448e7
Update website/docs/configuration/variables.html.md
...
Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>
2020-10-01 12:58:43 -04:00
Pam Selle
9c2556b5ad
Add sensitive variables to changelog
2020-10-01 11:14:41 -04:00
Pam Selle
e0e6f4fd13
Merge pull request #26443 from hashicorp/pselle/sensitive-var-module-merge
...
Implement module merge for sensitive variable config
2020-10-01 10:40:47 -04:00
Pam Selle
d57cb50fa9
Merge pull request #26437 from hashicorp/pselle/sensitive-var-type-check
...
Add test file for bad sensitive value
2020-10-01 10:34:06 -04:00
James Bardin
2376b3c5ee
Merge pull request #26444 from hashicorp/jbardin/value-checks
...
Add some log warnings and remove dead code
2020-10-01 09:37:56 -04:00
Kristin Laemmert
90588c036b
terraform: minor cleanup from EvalTree() refactor ( #26429 )
...
* Split node_resource_abstract.go into two files, putting
NodeAbstractResourceInstance methods in their own file - it was getting
large enough to be tricky for (my) human eyeballs.
* un-exported the functions that were created as part of the EvalTree()
refactor; they did not need to be public.
2020-10-01 08:12:10 -04:00
Kristin Laemmert
d76cfc8c0c
Merge pull request #26440 from hashicorp/mildwonkey/remove-older-state-vs
...
refactor tests to use modern states.State in favor of terraform.State where possible
2020-10-01 08:11:27 -04:00
James Bardin
98b568ad01
remove unused refresh node
...
There is no longer a refresh walk, so we no longer use this type.
2020-09-30 18:04:40 -04:00
Pam Selle
2a35240a17
Merge pull request #26314 from hashicorp/remove-template-provider-link
...
docs: remove link to deprecated provider
2020-09-30 17:57:02 -04:00
Pam Selle
ef95cf482b
Update CHANGELOG.md
...
Add pg backend PR
2020-09-30 17:56:05 -04:00
Pam Selle
3a99405b8b
Merge pull request #26420 from remilapeyre/postgres-default-backend
...
Always have the default workspace in the pg backend
2020-09-30 17:54:24 -04:00
James Bardin
c52672cbbe
log inconsistencies during refresh
...
We can't make these errors because there's no way to exempt legacy
providers from the check, but we can at least log them for
troubleshooting.
2020-09-30 17:40:39 -04:00
Pam Selle
f2fe0ceb0a
Implement module merge for sensitive config
...
Implements merging behavior for when sensitive
is set on a variable and adds testing accordingly
2020-09-30 17:25:54 -04:00
Kristin Laemmert
479655ad47
refactor tests to use modern states.State in favor of terraform.State where possible
2020-09-30 16:07:54 -04:00
James Bardin
c51104fb7c
Merge pull request #26435 from hashicorp/jbardin/races
...
Fix race conditions
2020-09-30 15:19:58 -04:00
James Bardin
59110a2ca5
e2etest server was unsynchronized
2020-09-30 14:28:02 -04:00
Pam Selle
ada6f45871
Add test file for bad sensitive value
...
Adds a test file for an incorrectly typed
(non-boolean) sensitive value to ensure it errors
2020-09-30 13:58:01 -04:00
James Bardin
a3c9b33b7b
output buffer must be synchronized
2020-09-30 13:44:07 -04:00
James Bardin
ab6d6f99ae
fix races in remote backend mock
2020-09-30 13:36:04 -04:00
James Bardin
b464bcbc5d
copy the refreshed state at the end of plan
...
Otherwise we may end up with the same state value for the state and
refreshState when re-using the context.
2020-09-30 12:14:37 -04:00
James Bardin
8dc6f518c2
don't use same state in Validate for refreshState
2020-09-30 12:14:37 -04:00
James Bardin
8c699fbe32
Unsynchronized maps in test
2020-09-30 12:14:31 -04:00
Martin Atkins
b0f58479c5
Update CHANGELOG.md
2020-09-30 09:04:00 -07:00
Pam Selle
e369fe0559
Docs for sensitive variables
2020-09-30 11:57:03 -04:00
Pam Selle
b57248533d
Re-organize variable page for sensitive argument addition
2020-09-30 11:57:03 -04:00
Martin Atkins
59b116f7bf
command/init: Remove support for legacy provider addresses
...
We no longer need to support 0.12-and-earlier-style provider addresses
because users should've upgraded their existing configurations and states
on Terraform 0.13 already.
For now this is only checked in the "init" command, because various test
shims are still relying on the idea of legacy providers the core layer.
However, rejecting these during init is sufficient grounds to avoid
supporting legacy provider addresses in the new dependency lock file
format, and thus sets the stage for a more severe removal of legacy
provider support in a later commit.
2020-09-30 08:54:57 -07:00
James Bardin
bdef106a8b
WithPath should only modify the copy
2020-09-30 11:50:50 -04:00
Kristin Laemmert
c258e8efbb
Merge pull request #26413 from hashicorp/mildwonkey/the-rest-of-the-owl-tree
...
The Last Chapter in our Epic Saga: `EvalTree()` Refactor
2020-09-30 10:48:03 -04:00
Rémi Lapeyre
9acfe30ca6
Always have the default workspace in the pg backend
...
Closes https://github.com/hashicorp/terraform/issues/23121
2020-09-29 23:18:34 +02:00
James Bardin
a78d75ccfb
Merge pull request #26387 from hashicorp/jbardin/ignore-changes-2
...
Fix handling of ignore_changes
2020-09-29 15:35:29 -04:00
Kristin Laemmert
0ac53ae3ed
terraform: remove deprecated or unused Eval() bits
2020-09-29 15:01:24 -04:00
Pam Selle
a82b495683
Merge pull request #26417 from hashicorp/pk-provisioner-deprecation
...
Updating CODEOWNERS with our deprecated status for tool-specific provisioners
2020-09-29 14:59:25 -04:00
Kristin Laemmert
184893d1e4
evaltree refactor
2020-09-29 14:31:20 -04:00
Petros Kolyvas
3ea5175feb
Updating codeowners with our deprecated status for tool-specific provisioners
2020-09-29 14:19:56 -04:00
Martin Atkins
f53264d378
command/init: Better error message for provider unsupported platform
...
As we add and remove support for different target platforms over time,
there will be transition periods where the available platforms for
each provider will be different than the available platforms for Terraform
CLI itself.
In recognition of that possibility, here we add a more specialized error
message for that situation which tries to explain the problem a little
more clearly than the generic error message that came before it.
In an ideal world we'd be able to detect situations where a newer or older
version has support in a similar vein to what we do with provider protocol
incompatibilities, but we don't currently have logic to fetch the data
necessary to implement that, so this is instead a presentation-only change
aimed at allowing some possible near-future changes to the supported
target platforms.
2020-09-29 10:28:26 -07:00
Kristin Laemmert
c66494b874
terraform: refactor NodeDestroyDeposedResourceInstanceObject and NodePlanDeposedResourceInstanceObject
...
The various Eval()s will be refactored in a later PR.
2020-09-29 13:26:50 -04:00
Kristin Laemmert
3bb64e80d5
apply refactor
2020-09-29 13:26:50 -04:00
Kristin Laemmert
26260c47f0
terraform: add ReadDiff method on NodeAbstractResourceInstance to replace EvalReadDiff
2020-09-29 13:26:50 -04:00
Kristin Laemmert
ff5d78ff5a
EvalReduceDiff: removing unused struct field
2020-09-29 13:25:17 -04:00
Kristin Laemmert
f835841c28
terrafrom: create CheckPreventDestroy method on NodeAbstractResource
...
This will eventually replace all uses of EvalCheckPreventDestroy.
2020-09-29 13:24:21 -04:00
Kristin Laemmert
ab5bf50fc3
terrafrom: create NodeAbstractResource ReadResourceInstanceState
...
function
The original EvalReadState node is used only by `NodeAbstractResource`s,
so I've created a new method on NodeAbstractResource which does the same
thing as EvalReadState. When the EvalNode refactor project is complete,
EvalReadState will be removed entirely.
2020-09-29 13:24:21 -04:00
Kristin Laemmert
d1cf0279fa
terraform: NodePlannableResourceInstanceOrphan refactor
2020-09-29 13:24:21 -04:00
Kristin Laemmert
9c721a4131
terraform: improved refactor of EvalWriteResourceState
...
EvalWriteResourceState finds new life as a method called WriteResourceState on NodeAbstractResource.
2020-09-29 13:24:21 -04:00
James Bardin
a8981a954f
don't use ignore_changes during replacement
...
When replacing an instance, we have to be sure to use the original
configuration which hasn't been processed with ignore_changes.
2020-09-29 13:15:33 -04:00
James Bardin
7fa4c00d1a
add validation for ignore_changes references
...
Ensure that ignore_changes only refers to arguments set in the
configuration.
2020-09-29 13:15:33 -04:00