9d1d8c0212
Merge branch 'contribution-codeowners' of github:pkolyvas/terraform into contribution-codeowners
2020-04-06 16:44:43 -04:00
02d67b8049
Merge branch 'contribution-codeowners' of github:pkolyvas/terraform into contribution-codeowners
2020-04-06 16:44:33 -04:00
e760927408
Update .github/CONTRIBUTING.md
...
Co-Authored-By: Pam Selle <pamela.selle@gmail.com>
2020-04-06 16:43:46 -04:00
e92b8a82f4
Pam & Kristin's feedback & some more suggested changed.
2020-04-06 16:43:11 -04:00
783c06b6da
Kristin's corrections
...
Co-Authored-By: Kristin Laemmert <mildwonkey@users.noreply.github.com>
2020-04-06 13:25:17 -04:00
6529a7c6e9
Kristin's comments & suggested changes
2020-04-06 12:59:38 -04:00
f6ac9e361b
Merge branch 'contribution-codeowners' of github:pkolyvas/terraform into contribution-codeowners
2020-04-06 12:13:49 -04:00
77ebf266f3
Restored the note about our community guidelines
2020-04-06 12:13:46 -04:00
6ff988a423
Apply suggestions from code review
...
Alisdair's fixes.
Co-Authored-By: Alisdair McDiarmid <alisdair@users.noreply.github.com>
2020-04-06 12:10:27 -04:00
10437b4b15
Update .github/CONTRIBUTING.md
...
Co-Authored-By: Alisdair McDiarmid <alisdair@users.noreply.github.com>
2020-04-06 12:09:22 -04:00
ad15e4a116
A few more spacing issues in MD format for GH
2020-04-03 16:15:09 -04:00
c7cae98076
GitHub hates me
2020-04-03 16:14:08 -04:00
cd54300621
Why won't you h4 maintainers.
2020-04-03 16:13:36 -04:00
db5878ff04
More updates and fixes, some grammatical, some clarity issues, one markdown bugaboo
2020-04-03 16:11:42 -04:00
68155c23ac
Merge branch 'contribution-codeowners' of github:pkolyvas/terraform into contribution-codeowners
2020-04-03 16:06:11 -04:00
ca90de14ec
Updated Contribution Guide TOC
2020-04-03 16:04:55 -04:00
942b4df545
Added a provisioners section and a maintainers section
2020-04-03 16:00:19 -04:00
a3dcda6ae5
tabs are hard
2020-04-01 15:32:47 -04:00
464a40b185
OCD spacing, formatting of Codeowners
2020-04-01 15:31:12 -04:00
ed9a2ea118
OCD spacing, formatting of Codeowners
2020-04-01 15:30:17 -04:00
9d097195a3
Fixing some minor formatting issues
...
They don't seem to be present on `localhost`
2020-04-01 15:28:50 -04:00
3725b4b3a0
Updated provisioners & added team-tf-core to http backend ownship, possibly in error.
2020-04-01 15:09:15 -04:00
700182dc7a
Fixed etcdv3 maintainer and added provisioners
2020-03-31 16:13:50 -04:00
61fe0a3402
Fixed an ordering/clarity issue with the TOC
2020-03-27 17:20:53 -04:00
96e1a1f800
more prescriptive Contributor's guide
2020-03-27 17:12:35 -04:00
236b108cd8
Added etcdv3 maintainer
2020-03-27 16:43:49 -04:00
a40207c9eb
Updated contributing to Terraform
2020-03-27 11:13:28 -04:00
c434db158e
Codeowners initial update
2020-03-27 10:08:59 -04:00
d99a663ea5
Update CHANGELOG.md
2020-03-27 09:20:44 -04:00
7b94ddd2f6
Merge pull request #24471 from hashicorp/alisdair/fmt-source
...
command/fmt: Include source snippets in errors
2020-03-27 09:19:12 -04:00
7302bfb484
Merge pull request #24473 from hashicorp/alisdair/fix-multiline-diagnostic-output
...
command/format: Fix multi-line diagnostic output
2020-03-27 09:18:51 -04:00
a23c3e3c81
command/format: Fix multi-line diagnostic output
...
Previously, if a diagnostic context spanned multiple lines, any lines
which did not overlap with the highlight range would be displayed as
blank. This commit fixes the bug.
The problem was caused by the unconditional use of `PartitionAround` to
split the line into before/highlighted/after ranges. When two ranges
don't overlap, this method returns empty ranges, which results in a
blank line. Instead, we first check if the ranges do overlap, and if not
we print the entire line from the context.
2020-03-26 15:53:52 -04:00
206e2e6d6a
command/fmt: Include source snippets in errors
...
Previously, diagnostic errors would display the filename and line
number, along with "(source code not available)". This is because the
fmt command directly loads and parses the configuration, instead of
using the config loader.
This commit registers the manually parsed source as a synthetic
configuration file, so that the diagnostic formatter can look up the
source for the range with the error and display it.
2020-03-26 14:00:26 -04:00
369b0560b9
Merge pull request #24446 from hashicorp/pselle/moduleinstance-outputs
...
Update ModuleCallOutput and add AbsModuleCallOutput
2020-03-26 13:42:13 -04:00
f738f85241
Create non-specific ModuleCallOutput
2020-03-26 13:29:38 -04:00
34cab3bc99
Merge pull request #24461 from hashicorp/jbardin/eval-context-path
...
Module Expansion Activate!
2020-03-26 12:45:23 -04:00
cec989d660
comment update and remove extra Name method
...
This name method won't be called in the full graph, and remove it to
prevent confusion with the parent node in logs.
2020-03-26 11:52:41 -04:00
4f1692cfaf
comment updates
2020-03-25 17:03:06 -04:00
5810261add
don't log path in EvalRaw
...
eval nodes no longer always have a context path
2020-03-25 17:03:06 -04:00
04a117b2a1
module expansion test
...
simplify the test a bit and add a few more combinations to the config
2020-03-25 17:03:06 -04:00
cd045f6f4e
enable count and for_each in configuration
2020-03-25 17:03:06 -04:00
8eb3f2cf52
orphan resources needs to use AbsResource
...
The expand logic was separated into
nodeExpandRefreshableManagedResource, but the orphan logic wasn't
updated.
2020-03-25 17:03:06 -04:00
7f0199bab0
cleanup some expanders
2020-03-25 17:03:06 -04:00
2474b87ff4
remove UnkeyedInstanceShim from some provider nodes
...
Remove the shims where they aren't necessary from the Init and Close
provider nodes. This also removed some provider path checks from the
builtin eval context, which cannot be resolved since the context may not
be created with a ModuleInstance path.
2020-03-25 17:03:06 -04:00
b3fc0dab94
use addrs.ConfigResource for dependency tracking
...
We can't get module instances during transformation, so we need to
reduce the Dependencies to using `addrs.ConfigResource` for now.
2020-03-25 17:03:06 -04:00
0afa3710fd
create refresh node expanders
2020-03-25 17:03:06 -04:00
74d85aa956
Add Path to more nodes that require it.
2020-03-25 17:03:06 -04:00
0b85eeab38
NewNodeAbstractResource accepts a ResourceConfig
...
Use the new addrs type here.
Also remove the uniqueMap from the config transformer. We enforce
uniqueness during config loading, and this is more likely to have false
positives due to stringification than anything.
2020-03-25 17:03:06 -04:00
23cebc5205
create nodeExpandApplyableResource
...
Resources also need to be expanded during apply, which cannot be done
via EvalTree due to the lack of EvalContext.
2020-03-25 17:03:06 -04:00
40f09027f0
expand planned resources
...
While the Expander itself now handles the recursive expansion of
modules, Resources themselves still need to be expanded twice, because
the evaluation of the Resource, which entails evaluating the for_each or
count expressions, is separate from the ResourceInstance expansion.
Add a nodeExpandPlannableResource to do handle this expansion to allow
all NodePlannableResources to call EvalWriteResourceState with an
absolute address.
2020-03-25 17:03:06 -04:00
Petros Kolyvas