ResiLien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
12,421 Commits 1 Branch 0 Tags 187 MiB
Commit Graph

12421 Commits

Author SHA1 Message Date
Paul Stack 94f9e1d4ab Merge pull request #8607 from hashicorp/arm-reorder-get-request-checks 
provider/azurerm: Reordering the checks after an Azure API Get
 2016-09-01 18:04:24 +01:00
stack72 392f634ff4
provider/azurerm: Reordering the checks after an Azure API Get 
We are receiving suggestions of a panic as follows:

```
2016/09/01 07:21:55 [DEBUG] plugin: terraform: panic: runtime error: invalid memory address or nil pointer dereference
2016/09/01 07:21:55 [DEBUG] plugin: terraform: [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xa3170f]
2016/09/01 07:21:55 [DEBUG] plugin: terraform:
2016/09/01 07:21:55 [DEBUG] plugin: terraform: goroutine 114 [running]:
2016/09/01 07:21:55 [DEBUG] plugin: terraform: panic(0x27f4e60, 0xc4200100e0)
2016/09/01 07:21:55 [DEBUG] plugin: terraform: 	/opt/go/src/runtime/panic.go:500 +0x1a1
2016/09/01 07:21:55 [DEBUG] plugin: terraform: github.com/hashicorp/terraform/builtin/providers/azurerm.resourceArmVirtualMachineRead(0xc4206d8060, 0x2995620, 0xc4204d0000, 0x0, 0x17)
2016/09/01 07:21:55 [DEBUG] plugin: terraform: 	/opt/gopath/src/github.com/hashicorp/terraform/builtin/providers/azurerm/resource_arm_virtual_machine.go:488 +0x1ff
2016/09/01 07:21:55 [DEBUG] plugin: terraform: github.com/hashicorp/terraform/helper/schema.(*Resource).Refresh(0xc420017a40, 0xc42040c780, 0x2995620, 0xc4204d0000, 0xc42019c990, 0x1, 0x0)
```

This is because the code is as follows:

```
resp, err := client.Get(resGroup, vnetName, name)
if resp.StatusCode == http.StatusNotFound {
	d.SetId("")
	return nil
}
if err != nil {
	return fmt.Errorf("Error making Read request on Azure virtual network peering %s: %s", name, err)
}
```

When a request throws an error, the response object isn't valid. Therefore, we need to flip that code to check the error first

```
resp, err := client.Get(resGroup, vnetName, name)
if err != nil {
	return fmt.Errorf("Error making Read request on Azure virtual network peering %s: %s", name, err)
}
if resp.StatusCode == http.StatusNotFound {
	d.SetId("")
	return nil
}
```
 2016-09-01 15:31:42 +01:00
Paul Stack 5cf92d086a Update CHANGELOG.md 2016-09-01 14:46:26 +01:00
Paul Stack bf755bb5c9 Merge pull request #8585 from hashicorp/f-diff-suppression 
helper/schema: Add diff suppression callback
 2016-09-01 14:46:03 +01:00
Paul Stack 8a811c2775 Merge pull request #8602 from jcalonso/fix/docs 
Minor typos
 2016-09-01 13:28:00 +01:00
Juan Carlos Alonso cab71c98cd Minor typos 2016-09-01 11:30:55 +01:00
Sander van Harmelen 5669185e54 Update CHANGELOG.md 2016-09-01 11:23:42 +02:00
Sander van Harmelen 1a85d06843 Fix the acceptance tests and some cosmetic tweaks (#8598) 2016-09-01 11:19:37 +02:00
Bart van der Schans 0835b64456 Add ability to manage cloudstack affinity groups (#8360) 
Add documentation for cloudstack affinity group resource

Implement improvements from review by svanharmelen

Update to latest go-cloudstack v2.1.3
 2016-09-01 10:48:49 +02:00
Mitchell Hashimoto 92a9a7c8b8 Update CHANGELOG.md 2016-08-31 20:00:41 -07:00
Mitchell Hashimoto 1b5d7cd2c6 Merge pull request #8590 from hashicorp/b-template-floats 
providers/template: template_file supports floating point math
 2016-08-31 20:00:00 -07:00
Mitchell Hashimoto c6ad7f80e8
providers/template: template_file supports floating point math 2016-08-31 17:25:11 -07:00
James Nugent 85ec09111b helper/schema: Add diff suppression callback 
This commit adds a new callback, DiffSuppressFunc, to  the schema.Schema
structure. If set for a given schema, a callback to the user-supplied
function will be made for each attribute for which the default
type-based diff mechanism produces an attribute diff. Returning `true`
from the callback will suppress the diff (i.e. pretend there was no
diff), and returning false will retain it as part of the plan.

There are a number of motivating examples for this - one of which is
included as an example:

1. On SSH public keys, trailing whitespace does not matter in many
   cases - and in some cases it is added by provider APIs. For
   digitalocean_ssh_key resources we previously had a StateFunc that
   trimmed the whitespace - we now have a DiffSuppressFunc which
   verifies whether the trimmed strings are equivalent.

2. IAM policy equivalence for AWS. A good proportion of AWS issues
   relate to IAM policies which have been "normalized" (used loosely)
   by the IAM API endpoints. This can make the JSON strings differ
   from those generated by iam_policy_document resources or template
   files, even though the semantics are the same (for example,
   reordering of `bucket-prefix/` and `bucket-prefix/*` in an S3
   bucket policy. DiffSupressFunc can be used to test for semantic
   equivalence rather than pure text equivalence, but without having to
   deal with the complexity associated with a full "provider-land" diff
   implementation without helper/schema.
 2016-08-31 19:13:53 -05:00
Paul Stack 6d4bc5547e Update CHANGELOG.md 2016-08-31 21:49:03 +01:00
stack72 019a13eb7f
Merge branch 'elblivion-librato-alerts' 2016-08-31 21:46:15 +01:00
stack72 32ad2218cb
provider/librato: Fixing some go vet issues for the 
`resourceLibratoAlertConditionsHash`
 2016-08-31 21:45:03 +01:00
Paul Stack 5de8137eb3 Merge pull request #8582 from hashicorp/fix-aws-alb-docs 
docs/aws: `aws_alb` name parameter is now documented as a Required field
 2016-08-31 20:17:59 +01:00
stack72 a6c55ddea9
Merge branch 'librato-alerts' of https://github.com/elblivion/terraform into elblivion-librato-alerts 2016-08-31 20:14:52 +01:00
stack72 cea2ff6be0
docs/aws: `aws_alb` name parameter is now documented as a Required 
field

The validation rules are also included in the documentation

Fixes #8561
 2016-08-31 20:06:04 +01:00
Mitchell Hashimoto b891f6f238 Update CHANGELOG.md 2016-08-31 11:59:16 -07:00
Mitchell Hashimoto d081ad1bc0 Merge pull request #8581 from hashicorp/f-self-count 
terraform: self.count works in interpolations [GH-5283]
 2016-08-31 11:58:36 -07:00
Mitchell Hashimoto 60f212b73e
terraform: test for referencing counts that are from vars 2016-08-31 11:54:14 -07:00
Mitchell Hashimoto d2e15ab69a
terraform: add test explicitly for referencing count 2016-08-31 11:49:25 -07:00
Mitchell Hashimoto 08a9c8e2c2
terraform: self.count works in interpolations [GH-5283] 2016-08-31 11:36:51 -07:00
James Bardin 5f441665af Merge pull request #8557 from hashicorp/jbardin/races 
Fix inconsistent results with self interpolation
 2016-08-31 14:07:36 -04:00
James Bardin e0014198e1 Merge pull request #8560 from hashicorp/jbardin/race2 
Fix races in WaitForState
 2016-08-31 14:02:43 -04:00
James Bardin 14138fc449 Add test for RawMap 
Ensure that RawMap() returns an identical copy, and not a reference to
the original map.
 2016-08-31 14:00:59 -04:00
Mitchell Hashimoto aaaed823af Merge pull request #8508 from TimeIncOSS/f-schema-all-validation-errors 
schema: Return all validation errors together from InternalValidate
 2016-08-31 10:44:13 -07:00
Mitchell Hashimoto fe8922dc13 Merge pull request #8567 from premist/resource-fastly-error-msg 
provider/fastly: Change error text on findService
 2016-08-31 10:40:46 -07:00
Anthony Stanton e4af2d56f2
fixup! Support for Librato Alerts and Services 2016-08-31 17:44:09 +02:00
Anthony Stanton 2b2920ba80
fixup! Support for Librato Alerts and Services 2016-08-31 17:26:39 +02:00
Anthony Stanton 83d4a71423
fixup! Support for Librato Alerts and Services 2016-08-31 17:20:20 +02:00
Anthony Stanton 4b2e11ac63
fixup! Support for Librato Alerts and Services 2016-08-31 17:20:08 +02:00
Anthony Stanton 783b2e5780
fixup! Support for Librato Alerts and Services 2016-08-31 17:19:53 +02:00
clint shryock 3580ae03be provider/aws: Randomize some IAM user names to avoid conflicts in tests 2016-08-31 09:33:56 -05:00
Anthony Stanton 2ba1c4e39a
fixup! Support for Librato Alerts and Services 2016-08-31 14:10:37 +02:00
Paul Stack dae81df157 Update CHANGELOG.md 2016-08-31 12:58:47 +01:00
Paul Stack 4d080020ed Merge pull request #8571 from wowgroup/GH-8570 
Fix breakage caused by MySQL version string parsing introduced in GH-8251
 2016-08-31 12:57:39 +01:00
Paul Stack 85e6323e7b Merge pull request #8574 from hashicorp/fix-spotfleet-tests 
provider/aws: `aws_spot_fleet_request` was leaving orphaned instances running
 2016-08-31 12:30:46 +01:00
stack72 4d2b9cb167
provider/aws: `aws_spot_fleet_request` was leaving orphaned instances 
running

Each nightly build was leaving multiple instances running. The issue is
that the IAM role we were using didn't have access to Terminate the EC2
instances

The role was missing the ec2 principle
 2016-08-31 11:25:08 +01:00
Paul Stack aa1ec26bc5 Update CHANGELOG.md 2016-08-31 10:00:43 +01:00
Paul Stack a424da0056 Merge pull request #8563 from hashicorp/triton-ssh-key 
provider/triton: Id trying to be used before being set
 2016-08-31 09:59:54 +01:00
Paul Stack 31e30d0cde Update interpolation.html.md (#8568) 2016-08-31 09:59:08 +01:00
protomouse b578b60b88 use hashicorp/go-version to parse mysql server version 2016-08-31 10:50:08 +02:00
zhuk-intetics 3308b974e2 Update interpolation.html.md 2016-08-31 10:19:17 +03:00
Minku Lee 59ff858c16 provider/fastly: Change error text on findService 2016-08-31 12:53:56 +09:00
Mitchell Hashimoto 70d9fe8db3 Update CHANGELOG.md 2016-08-30 16:06:17 -07:00
Mitchell Hashimoto bc0c26585f Merge pull request #8564 from hashicorp/b-getter-update 
vendor: update go-getter
 2016-08-30 16:05:50 -07:00
Mitchell Hashimoto 12da7e34fd
vendor: add netrc lib 2016-08-30 16:01:34 -07:00
Mitchell Hashimoto a1c4e1a97b
vendor: update go-getter 2016-08-30 15:54:31 -07:00