c279adfc55
provider/azurerm: Initial commit.
...
This commit brings some of the work over from #3808 , but rearchitects to
use a separate provider for Azure Resource Manager. This is in line with
the decisions made by the Azure Powershell Cmdlets, and is important for
usability since the sets of required fields change between the ASM and
ARM APIs.
Currently `azurerm_resource_group` and `azurerm_virtual_network` are
implemented, more resources will follow.
2015-12-15 17:26:33 -05:00
889b9fc95d
Merge pull request #3763 from sl1pm4t/b-gce-instance-no-exist
...
Issue #3742 - terraform destroy fails if Google Compute Instance no...
2015-12-15 15:02:36 -05:00
64482422b5
Merge pull request #4146 from hashicorp/b-aws-ebs-validate
...
providers/aws: Validate IOPs for EBS Volumes
2015-12-15 11:33:49 -06:00
adf417809a
add some comments on auth refactoring
2015-12-15 10:49:23 -06:00
5f5459a1fb
provider/aws: Refactor AWS Authentication chain
...
- update auth checking to check metadata header
- refactor tests to not export os env vars
2015-12-15 10:46:10 -06:00
41cd85c7d8
Merge pull request #3892 from lwander/b-gcp-instance-group-restart
...
provider/google: Fix instance group manager instance restart policy
2015-12-15 11:38:12 -05:00
d7a73937eb
provider/aws: Guard against nil DB Parameter vaules
2015-12-14 14:45:27 -06:00
559aa50a31
Retry MalformedPolicy errors due to newly created principals
2015-12-14 10:42:08 -08:00
38509d583d
Fixes #4253
2015-12-14 10:33:08 -05:00
98fc16ec06
Only refresh project name if Rundeck server provides it.
...
It seems that not all Rundeck servers consistently return the project name
when retrieving a job. Not yet sure in what situations it is or isn't
returned, but since jobs are not allowed to move between projects anyway
it doesn't hurt to just skip refreshing it if the server provides no
value.
2015-12-13 17:38:08 -08:00
6aeffdfb2c
chef_node resource.
2015-12-13 15:09:17 -08:00
2aab842be1
chef_role resource.
2015-12-13 15:09:17 -08:00
25b05c0808
chef_environment resource.
2015-12-13 15:09:17 -08:00
406aba4a62
chef_data_bag_item resource.
2015-12-13 15:09:17 -08:00
d583b936b2
chef_data_bag resource.
2015-12-13 15:09:16 -08:00
53aa3fb049
Entry point for chef provider.
2015-12-13 15:09:16 -08:00
e25a0cafa2
Update for breaking change to Azure library.
...
vmImageClient.ListVirtualMachineImages takes a parameter as of
68d50cb53a73edfeb7f17f5e86cdc8eb359a9528 in Azure/azure-sdk-for-go .
Passing in a parameters object whose members are all empty strings seems
to restore the previous behavior.
2015-12-13 14:59:24 -08:00
1ff403347b
provider/openstack: Fix set hash for security group test
2015-12-13 03:15:52 +00:00
7cbd18a88d
provider/openstack: DevStack Deploy Script
...
This commit includes a script to deploy a standardized devstack environment
for use with development and testing.
2015-12-13 02:58:29 +00:00
4716451617
provider/openstack: Convert block_device from TypeSet to TypeList
...
This change better reflects how block devices are passed to the Nova API
and allows for future enablement of block_device features. It also resolves
an interpolation bug.
2015-12-12 22:18:23 +00:00
ed8c5cdeea
Fixing some gofmt errors that keep appearing on my master branch
2015-12-12 11:00:54 +00:00
19ea14bf8d
Merge pull request #4256 from stack72/aws-asg-scheduled-actions
...
provider/aws: Autoscaling Group Scheduled Actions
2015-12-11 16:54:13 -05:00
c965d2278e
Adding a resource for aws_autoscaling_schedule
2015-12-11 18:43:38 +00:00
a1676f9eb1
provider/google: gofmt
2015-12-11 12:59:13 -05:00
bedd020dee
issue #4137
...
vpc_endpoint bug fix.
2015-12-12 01:15:54 +09:00
8b21f284b4
Merge pull request #4259 from stack72/aws-db_parameter_group-tags
...
provider/aws: Adding Tag support for DB Param Groups
2015-12-11 08:58:26 -06:00
5b2230588a
Merge pull request #4260 from stack72/aws-db_security_group-tags
...
provider/aws: Adding support for Tags to DB SecurityGroup
2015-12-11 08:48:59 -06:00
dec5a27f19
Adding the ARN as an output of the DB Subnet Group
2015-12-11 12:39:15 +00:00
474d6080f0
Adding support for Tags to the DB Security Group
2015-12-11 12:28:24 +00:00
67c1971e63
Adding support to DB Parameter Group for Tags
2015-12-11 12:07:50 +00:00
d84d6796c4
Initial CRUD work for the Autoscaling Group Scheduled Actions
2015-12-11 10:53:46 +00:00
fb4878cf37
Merge pull request #3853 from stack72/f-aws-db-instance-omit-snapshot
...
provider/aws: add DB Instance skip_final_snapshot
2015-12-10 18:38:11 -05:00
2b0c7aa4e9
Making the changes to db_instance skip_final_snapshot on the feedback from @catsby
2015-12-10 23:21:36 +00:00
2fecc72fb0
Merge pull request #3809 from stack72/f-aws-elasticache-cache-nodes-reduction
...
provider/aws: Ability to reduce nodes in an ElastiCache cluster
2015-12-10 15:30:09 -05:00
6082e3e732
Changing the db_instance to throw an error is a final snapshot is required but yet no identified is given
2015-12-10 19:11:47 +00:00
5796b13373
Adding skip_final_snapshop bool to th db_instance. This will allow us to specify whether a snapshot is needed directly rather than checking for an empty string
2015-12-10 19:11:47 +00:00
a213fe121d
Merge pull request #4245 from grisha/esd_fix
...
Fix a bug whereby AWS elasticsearch domain access_policies will always appear changed
2015-12-10 14:08:38 -05:00
cfea7c8e2d
provider/vsphere: restore vcenter_server as deprecated field
...
As promised in my comment in #3718 , this preserves backwards
compatibility while warning users of the new proper name for the field.
2015-12-10 12:11:51 -06:00
231f0cb474
Merge pull request #4035 from rakutentech/fix-ipv6-bug
...
provider/vsphere: Change ip_address parameter for ipv6 support
2015-12-10 12:02:11 -06:00
eb3840c574
Merge pull request #4242 from hashicorp/b-aws-lc-guard
...
provider/aws: Fix missing AMI issue with Launch Configurations
2015-12-10 08:55:49 -06:00
68ac4bceaf
provider/vsphere: Change ip_address parameter to ipv4_address and ipv6_address for ipv6 support
2015-12-10 18:28:24 +09:00
6fbfd99ace
Fix a bug whereby AWS elasticsearch domain access_policy will
...
always appear changed because of a missing normalizeJson().
2015-12-09 23:29:38 -05:00
b679bb2b31
Merge pull request #4241 from b-ryan/fix/opsworks-ssh-key-write-only
...
Make the OpsWorks cookbooks SSH key write only
2015-12-09 18:04:58 -08:00
e4dba86098
provider/aws: Fix missing AMI issue with Launch Configurations
2015-12-09 16:39:03 -06:00
921944c956
Make the OpsWorks cookbooks SSH key write only
...
Fixes #3635
This follows the suggestion of @apparentlymart in
https://github.com/hashicorp/terraform/issues/3635#issuecomment-151000068
to fix the issue of OpsWorks stacks always complaining about the custom
cookbooks SSH key needing to be changed.
Functional tests:
* Created a new stack and gave it an SSH key. The key was written to
OpsWorks properly.
* Ran "plan" again and terraform indicated it needed to change the SSH
key, which is expected since terraform cannot read what the existing
SSH is.
* Removed the key from my resource and this time, "plan" did not have
any changes. The `tfstate` file indicated the SSH key was "" (empty
string).
* Changed an unrelated property of the stack. Previously this was not
working for me due to terraform attempting to change the SSH key.
2015-12-09 16:58:05 -05:00
078280f1ea
Merge pull request #4155 from hashicorp/b-aws-db-replica-storage
...
providers/aws: Update DB Replica to honor storage type
2015-12-09 13:30:23 -06:00
501a016692
Merge pull request #4127 from hashicorp/aws-vet
...
Small updates to AWS provider to make go vet happy
2015-12-09 13:30:07 -06:00
6015874273
providers/aws: Update DB Replica to honor storage type
...
DB Replica can be of a different storage type, but we were skipping that part.
Note that they are created as the default (or as the primary?) initially,
and then modified to be of the correct type
2015-12-09 13:24:10 -06:00
9cc5e52cf0
Merge pull request #4167 from stack72/aws-security_group_name_prefix
...
provider/aws: securitygroup name_prefix
2015-12-09 11:42:34 -06:00
8e20552d44
Merge pull request #4236 from hashicorp/b-aws-s3-hosted-zone-update
...
providers/aws: Update Hosted Zones to fix issue with eu-central
2015-12-09 10:51:02 -06:00
bd22c77c1f
providers/aws: Update Hosted Zones to fix issue with eu-central
2015-12-09 10:44:22 -06:00
5630f9581f
Merge pull request #4196 from kristinn/create-disk-before-startup
...
provider/vsphere: Create and attach additional disks before bootup.
2015-12-09 10:06:34 -06:00
e065bec624
Merge pull request #3939 from matt-deboer/master
...
vsphere-provider: Added folder handling for folder-qualified vm names
2015-12-09 09:55:06 -06:00
ced42342ff
Merge pull request #4215 from hashicorp/pr-4207
...
Fix issue creating AWS RDS replicas across regions
2015-12-09 09:54:53 -06:00
9044807152
Merge pull request #4221 from hashicorp/b-aws-runinstances-check
...
provider/aws: Handle empty Instances response from RunInstances
2015-12-09 09:54:02 -06:00
3dc45039d1
Merge pull request #4204 from jtopjian/jtopjian-openstack-deleting-volume
...
provider/openstack: Handle volumes in "deleting" state
2015-12-08 22:58:32 -07:00
8ebb74cbff
Merge pull request #4223 from nicgrayson/increase-OS-timeout
...
provider/openstack: increase instance timeout from 10 to 30 minutes
2015-12-08 22:19:05 -07:00
67bfc2faef
Added folder handling for folder-qualified vm names
...
Added acceptance test for creation in folders
Added 'baseName' as computed schema attribute for convenience
Added 'base_name' computed attribute for convenience
Added new vsphere folder resource
Fixed folder behavior
Assure test folders are properly removed
Avoid creating recreating search index in loop
Fix typeo in vsphere.createFolder
Updated website documentation
Renamed test folders to be unique across tests
Fixes based on acc test findings; code cleanup
Added combined folder and vm acc test
Restored newline; fixed skipped acc tests
Marked 'existing_path' as computed only
Removed debug logging from tests
Changed folder read to return error
2015-12-08 20:35:27 -08:00
5884323c99
Merge pull request #4208 from stack72/aws-dynamodb_streams
...
provider/aws: DynamoDB Table StreamSpecifications
2015-12-08 18:42:48 -06:00
baeb790ed9
provider/aws: fix capitalization in acctest names
2015-12-08 17:49:17 -06:00
6e45319102
Merge pull request #4216 from stack72/f-do-floatingip_read
...
provider/digitalocean: FloatingIP Read Func for Region
2015-12-08 17:18:54 -05:00
ef9838c796
increased openstack 10 minute timeouts to 30 minutes
2015-12-08 16:03:33 -06:00
9f5f30650f
Merge pull request #4168 from combor/malformed_xml_fix
...
S3 bucket force_destroy error: MalformedXML
2015-12-08 15:24:50 -06:00
8b79881dea
Adding a validation function for the DynamoDb Table StreamViewType
2015-12-08 20:58:06 +00:00
a6ca034968
provider/aws: run codeclimate tests in us-east-1
...
It's only available there.
2015-12-08 14:46:08 -06:00
6e32320e41
provider/aws: switch test to use more accessible ami
...
Switch out an AMI that doesn't require marketplace terms acceptance.
2015-12-08 14:40:24 -06:00
9fc6c27de1
provider/aws: Check for empty instances in AWS Instance RunInstance response
...
Fixes #4206
2015-12-08 14:37:54 -06:00
22388139a3
Changing the DigitalOcean FloatingIP Read func to check for Droplet Region and then fallback to FloatingIP Region
2015-12-08 17:08:02 +00:00
e52af33db7
remove extra DBSubnetGroupName
2015-12-08 10:55:57 -06:00
0619898f6a
provider/aws: Add arn to DB Instance output
2015-12-08 10:52:17 -06:00
53609c89c5
Merge pull request #4214 from stack72/f-do-floatingip_panic
...
provider/digitalocean: Fixing panic condition on FloatingIP droplet
2015-12-08 11:37:59 -05:00
4b5cb07475
Fixing the digitalocean floatingip resource for a panic when droplet wasn't available
2015-12-08 16:29:13 +00:00
d46348c233
Adding support for AWS DynamoDB Table for StreamSpecifications
2015-12-08 14:07:11 +00:00
1cd2fea1f9
Fix AWS RDS cross-region read replica always being placed in default VPC
...
Fixes #4192 by honouring the `db_subnet_group_name` parameter when creating a cross-region read replica.
2015-12-08 15:06:57 +01:00
c3f6bbcece
provider/openstack: Handle volumes in "deleting" state
...
This commit prevents Terraform from erroring when an attempt is made
to delete a volume already in a "deleting" state. This can happen when
the volume is the root disk of an instance and the instance was
terminated.
2015-12-08 06:33:06 +00:00
cf87642bc8
provider/aws: Fix issue destroy Route 53 zone/record if it no longer exists
2015-12-07 16:33:37 -06:00
d69abbaeda
Run go fmt on VMWare vCloud Director provider
2015-12-07 15:24:34 -06:00
aa97300a3b
Create and attach additional disks before bootup.
...
Additional disks weren't created and attached to cloned vms until after bootup.
I also fixed some typos.
2015-12-07 22:16:52 +01:00
7bf404619c
adjust the ebs validation to not error, only log, and only set iops for io1
2015-12-07 14:49:44 -06:00
5e54bcc6ff
Add test for iops with gp2, remove strict validation
2015-12-07 11:16:29 -06:00
53f02fc4a2
Analogous to #3768 -- just for DNS and keys.
...
The error string for 404s on DNS domains has (apparently)
changed, causing things to be a little sad when you modify
DNS domains from the DO console instead of terraform. This
is just the same fix as was applied to droplets around this
time last month.
While I was at it I just fixed this everywhere I saw it in the
DO provider source tree.
2015-12-06 07:13:14 -05:00
283a838b58
Merge #3930 : tls_locally_signed_cert resource
2015-12-04 13:30:37 -08:00
3d28b8dec2
S3 bucket force_destroy error: MalformedXML
...
AWS provider was not checking whether DeleteMarkers are left in S3
bucket causing s3.DeleteObjectsInput to send empty XML which resulted in
400 error and MalformedXML message.
2015-12-04 15:24:23 +00:00
30a87be969
Merge pull request #4150 from svanharmelen/f-cloudstack-performance
...
provider/cloudstack: performance improvements
2015-12-04 09:07:10 -06:00
3a08cc9334
provider/vsphere: Add allow_unverified_ssl flag for unverified SSL requests
2015-12-04 08:49:22 -06:00
6817e0d144
Adding the ability to generate a securitygroup name-prefix
2015-12-04 09:21:08 -05:00
e1eef15646
postgresql provider with "database" and "role" resources
2015-12-03 23:44:20 -08:00
8e40b6b855
provider/aws: fixes to ASG placement_group tests
...
Based on @stack72's recommendations in #3704 , thanks @stack72!
2015-12-03 18:17:54 -06:00
709d1f3599
Merge pull request #3704 from dayer4b/add-placement-group
...
added placement group as an option for autoscaling groups
2015-12-03 18:05:01 -06:00
9e68c34abe
Merge pull request #3785 from hmrc/master
...
VMWare vCloud Director Support
2015-12-03 15:51:47 -06:00
79c9953b83
Merge pull request #4075 from elblivion/fix-elb-ec2-classic
...
provider/aws: Skip SG ID determination logic for Classic ELBs
2015-12-03 14:23:14 -06:00
b8f3417e79
Change all firewall related resources to take a cidr_list
...
Also some additional tweaks to improve performance and add in a little
concurrency to speed things up a little.
2015-12-03 15:34:53 +01:00
387a8ea127
Merge pull request #3926 from jtopjian/jtopjian-openstack-lbaas-statechange
...
provider/openstack: Add State Change support to LBaaS Resources
2015-12-02 20:25:04 -07:00
597fafbb68
provider/docker: locate container via ID not name
...
This reapplies the patch mentioned in #3364 - for an unknown reason the
diff there was incorrect.
2015-12-02 17:27:24 -05:00
d1bba3095b
providers/aws: Validate IOPs for EBS Volumes
2015-12-02 15:20:11 -06:00
2882d01904
Work to allow reducing the Number of Cache Nodes in an ElastiCache Cluster
2015-12-02 21:07:50 +00:00
d6ae527159
Merge pull request #3671 from 22Acacia/google-pubsub-clean
...
Google Cloud: PubSub Topic and Subscription resources
2015-12-02 15:37:23 -05:00
4343e60481
Merge pull request #4144 from hashicorp/b-brittle-docker-image-tests
...
provider/docker: Refer to a tag instead of latest
2015-12-02 15:16:48 -05:00
4ce6455e8a
provider/docker: Refer to a tag instead of latest
...
This should make tests more stable going forward. Also switch out the
image used from Ubuntu to Alpine Linux to reduce required download size
during test runs.
2015-12-02 15:08:16 -05:00
4216a8d1e1
Merge pull request #3718 from rakutentech/rename-config-parameters
...
provider/vsphere: rename vcenter_server config parameter to something clearer
2015-12-02 14:04:52 -06:00
6c76984419
Merge pull request #3867 from chrislovecnm/vsphere-custom-vm-params
...
vSphere custom vm params
2015-12-02 14:00:30 -06:00
6f7ef2fadd
golang pubsub SDK has been released. moved topics/subscriptions to use that
...
Conflicts:
builtin/providers/google/provider.go
builtin/providers/google/resource_subscription.go
builtin/providers/google/resource_subscription_test.go
golang pubsub SDK has been released. moved topics/subscriptions to use that
Conflicts:
builtin/providers/google/provider.go
builtin/providers/google/resource_subscription.go
builtin/providers/google/resource_subscription_test.go
file renames and add documentation files
remove typo'd merge and type file move
add to index page as well
only need to define that once
remove topic_computed schema value
I think this was used at one point but is no longer. away.
cleanup typo
adds a couple more config values
- ackDeadlineSeconds: number of seconds to wait for an ack
- pushAttributes: attributes of a push subscription
- pushEndpoint: target for a push subscription
rearrange to better match current conventions
respond to all of the comments
2015-12-02 10:36:00 -08:00
50d7abcd8a
Merge pull request #3761 from ryane/f-provider-docker-improvements
...
provider/docker: support additional arguments for `docker_container` resource
2015-12-02 11:46:29 -05:00
be07e4c0c9
cleanup spot instance attribute setting
2015-12-01 15:25:53 -06:00
c5f0c8ced6
provider/aws: Check for nil on some spot instance attributes
2015-12-01 14:58:59 -06:00
4a5847f9ea
providers/aws: Vet aws
2015-12-01 10:00:35 -06:00
9987f36d86
Merge pull request #4093 from paybyphone/master
...
provider/aws: New resource `aws_lambda_event_source_mapping`
2015-12-01 08:36:45 -05:00
84645bd8b5
More tweaks to improve performance
2015-12-01 00:36:33 +01:00
85627630bd
New resource (AWS provider) - aws_lambda_event_source_mapping
2015-11-30 07:45:38 -08:00
85c8595c89
Merge pull request #4108 from stack72/f-aws-route53-spf-record
...
provider/aws: Normalization of SPF records to prevent reporting changes
2015-11-30 13:15:32 +00:00
fece57f83b
Changing the IAM Role resource to allow update of Assume Policy Document
2015-11-30 12:52:07 +00:00
a556c98cde
Adding support for the escapaing of Route53 SPF records
2015-11-30 12:14:39 +00:00
ee4d29ce97
Added some acceptance tests for the statuscake provider
2015-11-27 15:03:13 +00:00
038604d97d
Migrating the statuscake_test resource to use the new version of the statuscake client
2015-11-27 15:03:13 +00:00
34b77aa78b
Adding the update and read functionality for the statuscake client
2015-11-27 15:03:13 +00:00
97c0aa5e73
Using the latest version of the statuscake client
2015-11-27 15:03:13 +00:00
d26f5f93e4
Created the initial scaffolding for the statuscake provider
2015-11-27 15:03:13 +00:00
d4ce2b87fb
Modified executable bit
2015-11-27 14:49:28 +01:00
0cca74fe76
Changing the S3 Bucket resource to allow the update of ACL by using PutBucketAcl
2015-11-26 21:45:48 +00:00
5753efa8af
Skip SG ID determination logic for Classic ELBs
2015-11-26 15:34:28 +01:00
632a9147cc
Adding support for Block_Durations to AWS Spot instance
2015-11-26 11:56:04 +00:00
b7a12e3a58
Merge pull request #4009 from apparentlymart/aws-opsworks-acctest-iam
...
provider/aws: AWS Opsworks tests bring their own IAM objects
2015-11-25 21:26:40 +02:00
c262bc72ea
Merge pull request #3895 from br0ch0n/rds_pub_access_param
...
Issue #3894 RDS publicly_accessible param shouldn't force new resource
2015-11-25 21:09:23 +02:00
aec94b1682
Don't error if unable to undeploy
2015-11-25 16:53:00 +00:00
ca2a7ee120
Merge pull request #4051 from svanharmelen/f-reduce-api-calls
...
provider/cloudstack: improve performance for all firewall related resources
2015-11-25 14:06:42 +02:00
a02667389e
Only undeploy a machine if it is switched on
2015-11-25 12:05:59 +00:00
811a82d9b3
updating printf formating to correct syntax with int
2015-11-25 07:59:46 +00:00
de2c76a61c
polish
2015-11-25 00:48:44 -07:00
d70cdde233
merging in upstream, because rebase was insane
2015-11-25 00:44:27 -07:00
1d1de992af
adding better acceptance test to check custom config
2015-11-25 05:41:01 +00:00
a35b65e5d2
working on better test
2015-11-24 21:35:40 -07:00
e9cb722471
providers/aws: Fix issue recreating security group rule if it has been destroyed
2015-11-24 13:50:30 -06:00
a3eae45b32
Improve performance all firewall related resources
2015-11-24 18:27:52 +01:00
5e0b603212
Merge pull request #4041 from svanharmelen/b-chef-provisioner
...
Revert changing `path.Join()` to `filepath.Join()` (PR #3896 )
2015-11-24 08:44:46 -06:00
b007d4f77a
Revert changing `path.Join()` to `filepath.Join()` (PR #3896 )
...
PR #3896 added support for passing keys by content, but in this same PR
all references to `path.Join()` where changed to `filepath.join()`.
There is however a significant difference between these two calls and
using the latter one now causes issues when running the Chef
provisioner on Windows (see issue #4039 ).
2015-11-24 14:40:46 +01:00
1cde2e64a0
Merge pull request #3748 from stack72/do-floatingips
...
provider/digitalocean : New Resource for Floating IPs
2015-11-24 13:16:24 +02:00
3fc9107333
Using the laterst version of the DO API to get the Assign of an IP working without a time.Sleep
2015-11-24 11:08:43 +00:00
288e568272
Merge pull request #4024 from rjeczalik/nil-deref-fix
...
provider/aws: fix for https://github.com/aws/aws-sdk-go/issues/452
2015-11-24 11:52:33 +02:00
9e66e18334
provider/aws: fix for https://github.com/aws/aws-sdk-go/issues/452
2015-11-24 09:30:21 +01:00
99e3d62cd8
provider/aws: Make VPC ID required on subnets
2015-11-23 16:53:49 +02:00
82050ff832
Merge pull request #4005 from hashicorp/b-aws-iam-user-delete
...
provider/aws: Fix issue deleting users who are attached to a group
2015-11-23 08:22:48 -06:00
7772a66b2f
Merge pull request #3940 from hashicorp/b-aws-spot-instance-updates
...
providers/aws: Update Spot Instance request to provide connection information
2015-11-23 08:22:07 -06:00
150e997a96
Changing the AWS ElastiCache cluster maintenance_window to enforce lowercase
2015-11-23 12:54:56 +00:00
3809315af9
Upped default maxRetryTimeout from 30s -> 60s
2015-11-23 11:45:16 +00:00
749fcd4931
Merge pull request #4010 from pforman/cloudtrail-enable
...
provider/aws: Add "enable_logging" to CloudTrail resource
2015-11-23 07:59:29 +00:00
52aad04930
Mistake in type refactor in cloudTrailGetLoggingStatus
...
When adjusting the types to prevent casting, I didn't change the error
message to handle the pointer change. "go tool vet" caught this.
2015-11-22 13:23:08 -07:00
9cec40ea3c
Add missing error-checks from code review
...
Some error-checking was omitted.
Specifically, the cloudTrailSetLogging call in the Create function was
ignoring the return and cloudTrailGetLoggingStatus could crash on a
nil-dereference during the return. Fixed both.
Fixed some needless casting in cloudTrailGetLoggingStatus.
Clarified error message in acceptance tests.
Removed needless option from example in docs.
2015-11-22 12:54:11 -07:00
484887c0c5
Change default for logging in CloudTrail to true
...
The default for `enable_logging`, which defines whether CloudTrail
actually logs events was originally written as defaulting to `false`,
since that's how AWS creates trails.
`true` is likely a better default for Terraform users.
Changed the default and updated the docs.
Changed the acceptance tests to verify new default behavior.
2015-11-22 10:47:23 -07:00
774ed1ded8
Merge pull request #4012 from rakutentech/rename-function
...
provider/vsphere: Rename create* functions
2015-11-22 11:34:42 +02:00
c9eeb161e0
Add a comment in tests
...
The purpose of the first test of enable_logging wasn't quite clear.
It's future-proofing against the assumptions made about AWS behavior.
2015-11-21 14:55:08 -07:00
Nashwan Azhari