Commit Graph

70 Commits

Author SHA1 Message Date
Radek Simko 2077869be4 provider/heroku: Fix failing acceptance test () 2017-01-24 14:10:11 +02:00
Paul Hinze 108ccf0007 builtin: Refactor resource.Retry to clarify return
Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.

Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.

This makes it eminently clear whether or not a given error is
retryable from inside the client code.

Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
2016-03-09 17:37:56 -06:00
Trevor Pounds 79742fc367 Enable `go vet -composites` check and fix warnings. 2016-02-17 11:59:50 -08:00
Paul Hinze 97bae0ea30 provider/heroku: address cert test failure
* Randomize app name in test
 * Return error and don't panic when there is a problem

It's possible there may still be an underlying problem that caused the
error that made the cert leak in the first place - this should help us
diagnose it.
2016-02-04 09:58:27 -06:00
Paul Hinze b537e5e966 provider/heroku: retry drain create until log channel is assigned
Should fix the build error encountered here:

https://travis-ci.org/hashicorp/terraform/builds/104548513
2016-01-25 09:59:41 -06:00
Paul Hinze 19d90ae00f heroku: randomize the remaining appnames in tests
Should take care of the remaining flapping acceptance test failures like
this:

https://travis-ci.org/hashicorp/terraform/builds/104012729
2016-01-22 09:26:34 -06:00
Paul Hinze d1010f40c5 heroku: randomize names in acctests
Should fix build failures seen here:

https://travis-ci.org/hashicorp/terraform/builds/103764448
2016-01-21 09:31:48 -06:00
Paul Hinze 7cd955e3a1 provider/heroku: fix typo in organization struct
"personal", not "private"
2016-01-08 08:20:19 -06:00
Paul Hinze c52765417a provider/heroku: add acctest covering orgs; fixup issues
Switching up ResourceData interaction to not reach into the internal
dot-notation nesting.
2016-01-04 16:13:52 -06:00
Jakub Janczak 81779aa1d4 Fixing the situation when you've got an organization app, and want to have it in a private area instead 2016-01-04 16:13:52 -06:00
Paul Hinze 24d15820c1 provider/heroku: fix acc test
depends_on requires a list of strings. the old parser would silently
ignore this field, but the new one returned a syntax error.
2015-11-20 10:51:34 -06:00
Sander van Harmelen 2ba8dc38fa Switch to go-multierror
It seems there are 4 locations left that use the `helper/multierror`
package, where the rest is TF settled on the `hashicorp/go-multierror`
package.

Functionally this doesn’t change anything, so I suggest to delete the
builtin version as it can only cause confusion (both packages have the
same name, but are still different types according to Go’s type system.
2015-09-27 18:58:48 -07:00
Paul Hinze 28875f49cd provider/heroku: fix config_vars in addons
These were never read properly - on Addons they show up as just a list
of var names, not a Map.

Fixes one issue in Addon acceptance tests.
2015-05-07 09:11:31 -05:00
Mitchell Hashimoto e5a375ae58 providers/heroku: empty config vars block shouldn't panic [GH-1211] 2015-03-26 09:45:37 -07:00
Mitchell Hashimoto 0281d73686 Revert "Heroku returns config_vars for addon as string array." 2015-02-23 14:04:58 -08:00
Mitchell Hashimoto 9599861350 Merge pull request from smp-labs/proper_heroku_config_vars_type
providers/heroku: heroku returns config_vars for addon as string array.
2015-02-23 13:59:10 -08:00
Mitchell Hashimoto 523639b5cd fmt 2015-02-20 10:22:26 -08:00
Jakub Janczak b99179a5a0 The type returned from heroku API is a string array, while our schema says []map[string]interface{}. 2015-02-19 10:31:04 +01:00
Jeff Mitchell f2bd1f45ab Move duplicated envDefaultFunc out of each provider and into Schema. 2015-01-16 17:25:39 +00:00
Emil Hessman 7b704fb77d builtin/providers/heroku: vet fix
Fixes the following vet reports:

builtin/providers/heroku/resource_heroku_app.go:192: arg vs for printf verb %s of wrong type: bool
builtin/providers/heroku/resource_heroku_app.go:198: arg vs for printf verb %s of wrong type: bool
2014-12-17 12:58:12 +01:00
Armon Dadgar f923368fc5 Merge pull request from plan3-labs/heroku_cert_support
Heroku SSL certificate support
2014-12-15 12:12:57 -08:00
Sander van Harmelen 4ace4865d7 Making all function names consistent
Before all providers were using the helper.Schema approach the helper
function had these names. Now they all use names consistent with the Go
naming conventions except for these last few…
2014-12-15 15:26:17 +01:00
Jakub Janczak 765cd1f494 Heroku SSL support: fixes after code review of @svanharmelen 2014-12-15 15:10:59 +01:00
Jakub Janczak 3c0e9970e5 Heroku SSL certificate support added 2014-12-15 12:21:47 +01:00
Sander van Harmelen 1b6f37b6eb Fixed tests and updated the provider schema to use a DefaultFunc
The default stack changed from ‘cedar’ to ‘cedar-14’, so updated the
acceptance tests to reflect this.

Updating the schema makes testing easier and gives you a way to
configure the provider using env variables. It also makes the provider
more inline following the TF 0.2 approach.
2014-11-19 14:25:18 +01:00
Mitchell Hashimoto 1792334ec4 fmt 2014-10-21 11:00:12 -07:00
Clint Shryock 98667d1b12 update error message 2014-10-14 17:28:25 -05:00
Clint Shryock b850f8bc65 proposal for making orgs a structure with fields instead of just a name field 2014-10-14 17:28:24 -05:00
Mitchell Hashimoto 3e6263332d providers/heroku: set all the things 2014-10-14 12:18:18 -07:00
Clint Shryock 764b0259dd Document the organization name field 2014-10-12 12:21:32 -05:00
Clint Shryock 8ab3ebbfb2 clean up the conditional check for Heroku organization 2014-10-12 11:58:18 -05:00
Clint Shryock 5fe2593c16 Add to Organization schema ref. Also gofmt the file 2014-10-12 11:49:57 -05:00
Clint Shryock 95a815deda Starting point for adding Organization app support for Heroku Provider 2014-10-10 14:07:27 -05:00
Mitchell Hashimoto 2f681c4bcc providers: fix tests 2014-09-28 17:32:39 -07:00
Mitchell Hashimoto e2534e4210 builtin: fix all compilation 2014-09-28 11:51:39 -07:00
Mitchell Hashimoto 64bc356f97 providers/heroku: tests passing, compiling 2014-09-16 17:21:01 -07:00
Mitchell Hashimoto 08dbf4daf0 fmt 2014-08-30 17:02:11 -07:00
Mitchell Hashimoto bb2edb20fd providers/heroku: clean up heroku_app config vars 2014-08-27 21:07:56 -07:00
Mitchell Hashimoto 39c4fb2005 providers/heroku: plans work without specific plan name [GH-198] 2014-08-27 21:05:09 -07:00
Mitchell Hashimoto d8cc32b49f providers/heroku: all_config_vars for reading 2014-08-27 16:35:15 -07:00
Mitchell Hashimoto 0a03ff9d34 providers/heroku: config vars aren't computed, they're non-exclusive
/cc @pearkes - See doc change
2014-08-27 16:26:03 -07:00
Jack Pearkes 02d18d67b8 providers/heroku: name and region are now required
cc/ @catsby if you're curious. That fixed the acceptance tests,
thought there is still one (different issue) that is still failing.

Also, it nows construct a transport instead of using the default
and setting the auth globally. TF could potentially run things
concurrently and that might go wrong.
2014-08-27 16:06:43 -07:00
Clint Shryock f6d5ed6c31 Swap bgentry/heroku-go for cyberdelia/heroku-go 2014-08-27 09:50:37 -05:00
Mitchell Hashimoto 9a0c0ea985 providers/heroku: domain/drain have dep on app 2014-08-19 10:16:47 -07:00
Mitchell Hashimoto 2a6b83591a providers/heroku: nuking config vars works 2014-08-19 10:13:34 -07:00
Mitchell Hashimoto 43405c270b providers/heroku: heroku_drain 2014-08-19 09:18:45 -07:00
Mitchell Hashimoto 27ee254447 providers/heroku: heroku_domain resource 2014-08-19 09:14:14 -07:00
Mitchell Hashimoto 5fc308d934 providers/heroku: addon 2014-08-18 15:49:54 -07:00
Mitchell Hashimoto 4e1d8869fe providers/heroku: use new schema API 2014-08-18 15:18:51 -07:00
Mitchell Hashimoto 199b72d798 providers/heroku: clean up unused functions 2014-08-18 09:36:37 -07:00