Mitchell Hashimoto
1a418c1452
command/apply: -Xnew-destroy
2016-10-22 12:36:47 -07:00
Mitchell Hashimoto
5a8ec482a2
terraform: unify destroy/apply graph builders
...
They're so similar we unify them, they only change in a select few
places. This is very similar to the old graph but is still much simpler.
2016-10-22 12:12:30 -07:00
Mitchell Hashimoto
1523504645
terraform: enable shadow graph and destroy resource mode with addr
...
This enables the shadow graph since all tests pass!
We also change the destroy node to check the resource type using the
addr since that is always available and reliable. The configuration can
be nil for orphans.
2016-10-22 12:12:30 -07:00
Mitchell Hashimoto
a4aea3e085
terraform: destroy apply graph builder should disable providers
2016-10-22 12:12:30 -07:00
Mitchell Hashimoto
db6d87b16c
terraform: destroy node should understand data sources
...
This makes the new destroy nodes undestand data sourcs and call the
correct apply function.
2016-10-22 12:12:30 -07:00
Mitchell Hashimoto
ac9a049d19
terraform: Diff.Equal ignores ModuleDiff.Destroy
...
This is necessary to get the shadow working properly with the destroy
graph since the destroy graph doesn't set this field but the end state
is still the same.
2016-10-22 12:12:30 -07:00
Mitchell Hashimoto
ceb613d449
terraform: don't set destroy module on diff
...
This is something that should be determined and done during an apply. It
doesn't make a lot of sense that the plan is doing it (in its current
form at least).
2016-10-22 12:12:30 -07:00
Mitchell Hashimoto
ab4ebcc5c7
terraform: TargetsTransformer on destroy plan
...
This enables targeting to work properly on planning destroys
2016-10-22 12:12:30 -07:00
Mitchell Hashimoto
2d4f65cc94
terraform: disable shadowing destroy graph for now
...
It doesn't fully work so we want to wait until we think its ready before
we start the shadowing.
2016-10-22 12:12:29 -07:00
Mitchell Hashimoto
480a414c40
terraform: destroy module nodes show up in plan destroy
2016-10-22 12:12:29 -07:00
Mitchell Hashimoto
e68327e765
terraform: add config transformer to enable preventDestroy
2016-10-22 12:12:29 -07:00
Mitchell Hashimoto
0ed896a313
terraform: implement destroy planning basics from state
2016-10-22 12:12:29 -07:00
Mitchell Hashimoto
db807f4b0f
terraform: destroy graph builder, -Xnew-destroy flag
2016-10-22 12:12:29 -07:00
Mitchell Hashimoto
bff4e31070
Update go.sh to run destroy tests
2016-10-22 12:12:29 -07:00
Mitchell Hashimoto
7418f6c48f
Merge pull request #9526 from hashicorp/b-resource-config-equal
...
terraform: ResourceConfig.Equal should sort ComputedKeys
2016-10-22 12:06:20 -07:00
Mitchell Hashimoto
3dd64d9f2e
terraform: ResourceConfig.Equal should sort ComputedKeys
...
This was causing otherwise equal ResourceConfigs to report non-equal
which was incorrect, thus causing incorrect shadow graph errors.
2016-10-22 12:00:05 -07:00
Mitchell Hashimoto
ab36666653
Merge pull request #9525 from hashicorp/b-shadow-block
...
helper/shadow: keyedValue.WaitForChange must unlock
2016-10-22 11:56:14 -07:00
Radek Simko
f5c4d79a0e
Update CHANGELOG.md
2016-10-22 14:17:44 +01:00
Radek Simko
eda1298e21
provider/aws: Increase ECS service drain timeout ( #9521 )
2016-10-22 14:16:59 +01:00
Paul Stack
faa9c4ba59
docs/aws: Document the default of aws_alb enable_deletion_protection ( #9503 )
...
Fixes #9486
2016-10-22 13:36:37 +01:00
Mitchell Hashimoto
de827887bf
helper/shadow: keyedValue.WaitForChange must unlock
2016-10-21 17:57:00 -07:00
Mitchell Hashimoto
f8e35ecb2f
terraform: log starting graph walk outside of the goroutine
...
This is so ordering makes a bit more sense reliably.
2016-10-21 16:20:38 -07:00
Mitchell Hashimoto
a0382ccbdd
Merge pull request #9517 from hashicorp/f-disable-shadow
...
command/meta: add -shadow flag to disable shadow graph
2016-10-21 14:31:23 -07:00
Mitchell Hashimoto
ae4f79e3b6
command/meta: add -shadow flag to disable shadow graph
...
Since it is still very much possible for this to cause problems, this
can be used to disable the shadow graph. We'll purposely not document
this since the goal is to remove this flag as we become more confident
with it.
2016-10-21 14:25:05 -07:00
Cameron Stokes
f6b149932c
~website: Remove duplicate Bitbucket link in sidebar.
2016-10-21 14:24:46 -07:00
Clint
afa2bbc0b3
Update CHANGELOG.md
2016-10-21 16:18:35 -05:00
Clint
dcbcde4b82
Merge pull request #8893 from dennis-bsi/fix-asg-policy-to-0
...
provider/aws: aws_autoscaling_policy fails when setting scaling_adjustment to 0 for SimpleScaling
2016-10-21 16:17:16 -05:00
Clint
6f7e9ac4dd
Merge pull request #9511 from dennis-bsi/aws-redshift-sng-name-validation
...
provider/aws: limiting aws_redshift_subnet_group name to alphanumeric and hyphens
2016-10-21 14:35:53 -05:00
Clint
2838a035bd
Update CHANGELOG.md
2016-10-21 14:33:32 -05:00
Clint
88925eb939
Merge pull request #9515 from dennis-bsi/aws-redshift-sng-description-update
...
provider/aws: aws_redshift_subnet_group allows description to be modified
2016-10-21 14:32:34 -05:00
Dennis Webb
dac69b7919
fixing issue where changing only the description only didn't actually update on AWS
2016-10-21 12:14:41 -05:00
Clint
3015855a40
Update CHANGELOG.md
2016-10-21 11:44:49 -05:00
Clint
34b21083ee
Merge pull request #8983 from 987poiuytrewq/b-aws-beanstalk-option-updates
...
provider/aws: fix option updates to beanstalk
2016-10-21 11:43:43 -05:00
clint shryock
3fbf01ea1b
provider/aws: Bump AWS Route retry to 2 minutes, up from 15 seconds
2016-10-21 11:36:51 -05:00
Dennis Webb
05783ca044
limiting subnetgroup name to alphanumeric and hyphens
2016-10-21 11:28:48 -05:00
Clint
7d8a5e4423
Merge pull request #9172 from dnABic/docs-p2
...
Documentation Update: Changing virtualization type in documentation for aws_instance
2016-10-21 10:10:27 -05:00
Paul Stack
c31f85a953
Merge pull request #9494 from cblecker/google-import-docs
...
provider/google: Add google resources to importability docs
2016-10-21 17:30:17 +04:00
Paul Stack
ccf3f6e5ae
Merge pull request #9500 from niclasnilsson/patch-1
...
Bugfix in example
2016-10-21 17:29:37 +04:00
Paul Stack
7d7da4b6b6
Merge pull request #9456 from kwilczynski/feature/rename-file-aws_availability_zones
...
provider/aws: Rename the file to match the naming scheme.
2016-10-21 14:38:03 +04:00
Paul Stack
543a06db85
Merge pull request #9475 from IceBear2k/patch-1
...
Fix Scaleway documentation typo/error
2016-10-21 14:36:38 +04:00
Paul Stack
15905d9ae3
Merge pull request #9497 from jamtur01/fanchor
...
I'd like to be able to anchor to functions
2016-10-21 14:35:23 +04:00
Niclas Nilsson
2a5b3e406d
Bugfix in example
...
Shouldn't the aws_route53_record in the example should use the "dev" zone_id?
2016-10-21 11:11:39 +02:00
James Turnbull
e0fab2267b
I'd like to be able to anchor to functions
2016-10-21 17:28:01 +11:00
Mitchell Hashimoto
0fdedbd003
Merge pull request #9496 from hashicorp/b-apply-data
...
terraform: new apply resource node supports data sources
2016-10-20 22:43:21 -07:00
Mitchell Hashimoto
4a6cc3b100
terraform: new apply resource node supports data sources
...
This enables the new apply graph's resource node to apply data sources.
Data sources appear to only be tested for "refresh" which is likely
where they're set but they've also been implemented (not my code, not
trying to edit code) within the "apply" operation as well.
This adds an apply test to ensure data sources work, and then modifies
the new apply node to support data sources.
2016-10-20 22:03:48 -07:00
Mitchell Hashimoto
1d27e554a5
terraform: test to ensure data sources work on Apply operation
...
It appears data sources have always been coded to work during apply, as
can be verified with this test (no impl. changes were necessary to make
it pass).
This test should be added to ensure our apply graph always works with
data sources as well.
2016-10-20 21:53:54 -07:00
Mitchell Hashimoto
293e214e3e
update CHANGELOG
2016-10-20 15:21:46 -07:00
Mitchell Hashimoto
2c1a21a8ef
terraform: disable shadowing the experimental graph
2016-10-20 15:17:28 -07:00
Mitchell Hashimoto
14cff93b67
Merge pull request #9388 from hashicorp/f-apply-builder
...
terraform: new apply graph builder based on the "diff"
2016-10-20 15:13:29 -07:00
Christoph Blecker
b42a723355
Add google resources to importability docs
2016-10-20 14:44:07 -07:00