Commit Graph

4663 Commits

Author SHA1 Message Date
Paul Hinze 0fff7d1673 core: validate graph w/ diff during plan phase
This reimplements my prior attempt at nipping issues where a plan did
not yield the same cycle an apply did. My prior attempt was to have
ctx.Validate generate a "Verbose" worst-case graph. It turns out that
skipping PruneDestroyTransformer to generate this graph misses important
heuristics that prevent cycles by dropping destroy nodes that are
determined to be unused.

This resulted in Validate improperly failing in scenarios where these
heuristics would have broken the cycle.

We detected the problem during the work on #1781 and worked around the
issue by reverting to the non-Verbose graph in Validate.

This commit accomplishes the original goal in a better way - by
generating the full graph and checking it once Plan has calculated the
diff. This guarantees that any graph issue that would be caught by Apply
will be caught by Plan.
2015-05-05 17:24:44 -05:00
Mitchell Hashimoto c8635654cb Merge pull request #1781 from hashicorp/b-module-deps
Flatten modules into main graph
2015-05-05 13:19:41 -07:00
Clint ad539d3c96 Update CHANGELOG.md 2015-05-05 15:10:34 -05:00
Mitchell Hashimoto a07f07bbf2 Merge pull request #1813 from svanharmelen/b-aws-creds-fix
Fixing PR #1804
2015-05-05 13:05:35 -07:00
Mitchell Hashimoto 0f40cebc0f Merge pull request #1814 from svanharmelen/b-fix-small-vet-warning
Fixing a small vet warning introduced by PR #1796
2015-05-05 13:05:11 -07:00
Clint 18b43b78cb Merge pull request #939 from bitglue/iam
Implement a subset of IAM resources
2015-05-05 15:05:05 -05:00
Mitchell Hashimoto 8c34e9a36a terraform: provisionedby prefixed 2015-05-05 13:04:27 -07:00
Clint Shryock 7b082d007e Merge commit '33183c0'
* commit '33183c0':
  Implement a hash function for string sets
2015-05-05 15:01:02 -05:00
Sander van Harmelen 3881c81a66 Added the exit code as well... 2015-05-05 21:56:20 +02:00
Mitchell Hashimoto d503cc2d82 terraform: flattenable graphNodeMissingProvisioner 2015-05-05 12:45:28 -07:00
Sander van Harmelen 48f4d499f9 Fixing a small vet warning introduced by PR #1796
While fixing the vet warning also tried to improve any feedback by
showing the actual output/error instead of just the error code.

While testing this I noticed only adding stderr output is not enough as
not all error info is send to stderr, but sometimes also to stdout.
2015-05-05 21:26:28 +02:00
Mitchell Hashimoto 6d4969f64c terraform: run prune destroy on validate 2015-05-05 12:11:49 -07:00
Sander van Harmelen 897bf5e53d Added `SharedCredentialsProvider` and `EC2RoleProvider` as well... 2015-05-05 20:38:35 +02:00
Sander van Harmelen 5435815524 Fixing PR #1804 2015-05-05 20:30:35 +02:00
Mitchell Hashimoto 1045fb9eac Merge pull request #1811 from hashicorp/b-aws-auth
providers/aws: chain credentials
2015-05-05 10:55:40 -07:00
Mitchell Hashimoto 803348d05f Merge pull request #1797 from hashicorp/b-flatten-modules-cycle
core: failing test for a bad module cycle
2015-05-05 10:54:57 -07:00
Mitchell Hashimoto 7a5499d4f7 providers/aws: chain credentials 2015-05-05 10:44:19 -07:00
Mitchell Hashimoto 094c859f2c Update CHANGELOG.md 2015-05-05 10:32:32 -07:00
Mitchell Hashimoto 639f310ae6 Merge pull request #1805 from dupuy/openstack-resource-docs
Openstack resource docs
2015-05-05 10:25:30 -07:00
Christopher Tiwald d76719bbb8 Add docs for various iam_* resources. 2015-05-05 12:47:20 -04:00
John Engelman 6ee17a8e9e Add acceptance tests 2015-05-05 12:47:20 -04:00
Phil Frost b082117e92 Implement AWS IAM resources
- Users
- Groups
- Roles
- Inline policies for the above three
- Instance profiles
- Managed policies
- Access keys

This is most of the data types provided by IAM. There are a few things
missing, but the functionality here is probably sufficient for 95% of
the cases. Makes a dent in #28.
2015-05-05 12:47:20 -04:00
Phil Frost 33183c078b Implement a hash function for string sets
Sets of strings are pretty common. Let's not duplicate the function
necessary to create a set of strings in so many places.
2015-05-05 12:47:18 -04:00
Clint Shryock 272415303d provider/aws: Shorting retry timeout for Subnets to 2 minutes, from 5 2015-05-05 11:20:29 -05:00
Clint Shryock 3ce3b7c516 provider/aws: Shorting retry timeout for Security Groups to 2 minutes, from 5 2015-05-05 11:07:16 -05:00
Clint 7c62329506 Merge pull request #1809 from hashicorp/f-aws-auto-vpc-peer-julienba
provider/aws: Add auto accept option for VPC peering
2015-05-05 10:49:56 -05:00
Clint Shryock 4b160dd28e minor cleanups 2015-05-05 10:45:30 -05:00
jba c50bcf2930 renaming function according to the aws struct 2015-05-05 10:39:25 -05:00
jba e9215c0676 move accept block to the update func 2015-05-05 10:38:20 -05:00
jba 5658fd6122 clean code 2015-05-05 10:37:13 -05:00
jba 11ba9b1042 add the auto_accecpt option 2015-05-05 10:37:13 -05:00
Alexander Dupuy fdd1f566b9 missed docs changes from PR#1550 2015-05-05 14:53:19 +02:00
Alexander Dupuy b4df3c427a fix openstack fw/floating ip sidebar refs
expand firewall examples to be self-contained
2015-05-05 14:26:45 +02:00
Alexander Dupuy 2ccaaf204d fix copy/paste typo in OpenStack FW error messages 2015-05-05 14:01:49 +02:00
Alexander Dupuy 2633585531 add online docs for remaining OpenStack resources 2015-05-05 14:00:51 +02:00
Sander van Harmelen c2695ba528 Merge pull request #1796 from Banno/bugfix-ssh-remote-exec
remote-exec (ssh): chmod'ing right path
2015-05-05 12:39:13 +02:00
Sander van Harmelen 4d1b663cdb Merge pull request #1800 from svanharmelen/b-cloudstack-name-vs-uuid
provider/cloudstack name vs uuid
2015-05-05 12:37:15 +02:00
Sander van Harmelen 44541c5465 Fixing up some tests after a couple of thorough test rounds 2015-05-05 12:31:21 +02:00
Avi Nanhkoesingh 1411d4010f Fixes #1: sets the rights values based on isUUID 2015-05-05 12:31:21 +02:00
Sander van Harmelen 61509fd96a Merge pull request #1804 from svanharmelen/b-fix-after-aws-sdk-changes
Small fix needed to be inline with the updated AWS SDK again...
2015-05-05 12:29:52 +02:00
Sander van Harmelen 7274de3c1d Small fix needed to be inline with the updated AWS SDK again...
Executed a couple of AWS ACC test as well to make sure everything works
properly again after this fix…
2015-05-05 12:26:26 +02:00
Paul Hinze c3ce23c7b4 core: failing test for a bad module cycle
passing output of one module into input of the following module results
in a cycle
2015-05-04 18:58:29 -05:00
Clint 98d34a3266 Merge pull request #1795 from hashicorp/b-aws-route53-record-type-check
provider/aws: Add a regression check for Route 53 records
2015-05-04 17:19:53 -05:00
Clint Shryock 81422123e8 provider/aws: Add a regression check for Route 53 records 2015-05-04 17:05:49 -05:00
Mitchell Hashimoto a52c1fb0f3 update CHANGELOG 2015-05-04 14:05:17 -07:00
Mitchell Hashimoto 9ed909c8fe Merge pull request #1749 from nabeken/aws-proxy-protocol-policy
provider/aws: Add proxy protocol support in ELB
2015-05-04 14:04:53 -07:00
Mitchell Hashimoto bb3b6c82c2 update CHANGELOG 2015-05-04 14:03:59 -07:00
Mitchell Hashimoto 8633c88723 Merge pull request #1775 from TimeIncOSS/r53-alias-record
aws: Add support for Alias records into AWS Route 53
2015-05-04 14:03:29 -07:00
Paul Hinze ed6f776d0a Merge pull request #1794 from hashicorp/f-extra-getok-test
helper/schema: add clarifying GetOk test
2015-05-04 16:03:01 -05:00
Mitchell Hashimoto 52b4270952 update CHANGELOG 2015-05-04 14:01:13 -07:00