d30d88e327
Merge pull request #1655 from hashicorp/f-build-graph-during-plan
...
core: validate on verbose graph to detect some cycles earlier
2015-04-30 16:08:33 -05:00
5f1ea7fccc
command: add env var equivalent to -input arg
...
Setting TF_INPUT has the equivalent effect of setting the flag.
I got sick of specifying this when iterating on TF config locally.
2015-04-30 09:59:14 -05:00
b08ba78341
adding new AskSecret to ColorizeUi
2015-04-29 13:07:13 -05:00
ce49dd6080
core: graph command gets -verbose and -draw-cycles
...
When you specify `-verbose` you'll get the whole graph of operations,
which gives a better idea of the operations terraform performs and in
what order.
The DOT graph is now generated with a small internal library instead of
simple string building. This allows us to ensure the graph generation is
as consistent as possible, among other benefits.
We set `newrank = true` in the graph, which I've found does just as good
a job organizing things visually as manually attempting to rank the nodes
based on depth.
This also fixes `-module-depth`, which was broken post-AST refector.
Modules are now expanded into subgraphs with labels and borders. We
have yet to regain the plan graphing functionality, so I removed that
from the docs for now.
Finally, if `-draw-cycles` is added, extra colored edges will be drawn
to indicate the path of any cycles detected in the graph.
A notable implementation change included here is that
{Reverse,}DepthFirstWalk has been made deterministic. (Before it was
dependent on `map` ordering.) This turned out to be unnecessary to gain
determinism in the final DOT-level implementation, but it seemed
a desirable enough of a property that I left it in.
2015-04-27 09:23:47 -05:00
d4b9362518
core: validate on verbose graph to detect some cycles earlier
...
Most CBD-related cycles include destroy nodes, and destroy nodes were
all being pruned from the graph before staring the Validate walk.
In practice this meant that we had scenarios that would error out with
graph cycles on Apply that _seemed_ fine during Plan.
This introduces a Verbose option to the GraphBuilder that tells it to
generate a "worst-case" graph. Validate sets this to true so that cycle
errors will always trigger at this step if they're going to happen.
(This Verbose option will be exposed as a CLI flag to `terraform graph`
in a second incoming PR.)
refs #1651
2015-04-23 11:07:13 -05:00
e91b5136bf
Merge pull request #1356 from koendc/b-remote-plugin-case
...
command/state: fix for state files containing an upper case remote type
2015-04-14 08:34:28 -07:00
a2cb77058c
command: fix push tests when running outside repo
...
VCS detection was on by default, and blows up when the tests are run in
a copy of the Terraform source that is not a git repository, like - say
- during a Homebrew formula install, just to pick a random example. :)
2015-04-09 18:46:25 -05:00
650a9f372b
command: implement proper module.Storage interface
2015-04-07 16:46:56 -07:00
000d28c489
command/push: read terraform.tfvars
2015-04-07 15:34:06 -07:00
1fac7b6488
state: cache should use State.Equal to check equality
...
reflect.DeepEqual was returning false, sometimes.
2015-04-07 15:03:04 -07:00
428fd98ba0
Handles upper case characters in the cached state file's remote type
...
If the cached state file contains a remote type field with upper case
characters, eg 'Consul', it was no longer possible to find the 'consul'
remote plugin.
2015-04-01 21:42:39 +02:00
9a091ffa78
command: plan supports detailed exit code
2015-04-01 09:38:19 -07:00
97acccd3ed
core: targeted operations
...
Add `-target=resource` flag to core operations, allowing users to
target specific resources in their infrastructure. When `-target` is
used, the operation will only apply to that resource and its
dependencies.
The calculated dependencies are different depending on whether we're
running a normal operation or a `terraform destroy`.
Generally, "dependencies" refers to ancestors: resources falling
_before_ the target in the graph, because their changes are required to
accurately act on the target.
For destroys, "dependencies" are descendents: those resources which fall
_after_ the target. These resources depend on our target, which is going
to be destroyed, so they should also be destroyed.
2015-03-31 14:49:38 -05:00
da7f307e56
command/remote-config: failing tests
2015-03-26 18:14:24 -07:00
4a7b554cf7
command/remote-config: do a pull with `terraform remote config`
2015-03-26 17:57:45 -07:00
6379a888fb
command/remote-{pull,push}: colorize and show success output
2015-03-26 17:40:39 -07:00
38b1a727bf
command/remote-config: lowercase the type so that Atlas works, for
...
example
2015-03-26 17:37:05 -07:00
7bfa5afd00
command/remote-config: show flag parse errors
...
/cc @sethvargo
2015-03-26 17:33:58 -07:00
35da19cc1f
command/remote-config: remove weird error case that shows no error
...
message
/cc @sethvargo
2015-03-26 17:31:50 -07:00
1adb3fbfa0
command: when setting up state, only write back if local is newer
2015-03-26 17:16:54 -07:00
83cb277583
command/output: don't panic if no root module in state [GH-1263]
2015-03-25 16:35:27 -07:00
431f5e6706
command/remote-config: syntax
2015-03-25 15:26:38 -07:00
2796f83950
command/remote-config: make the error message nicer for remote init
...
/cc @sethvargo - based on UX issues you ran into yesterday
2015-03-25 15:23:04 -07:00
280635d2b0
command/push: add -atlas-address
2015-03-24 17:45:19 -07:00
51614b6365
command/push: upload-modules
2015-03-24 17:42:40 -07:00
8d47f26bb7
command/push: address PR comments
2015-03-24 17:41:26 -07:00
0229852e48
command/push: change wording on error message
2015-03-24 17:39:37 -07:00
395dd04861
command/push: accept -vcs
2015-03-24 17:03:59 -07:00
86f92119e2
command/push: no version on GET should be okay
2015-03-24 13:59:13 -07:00
19c1771438
command/push: integrate atlas push client
2015-03-24 13:42:48 -07:00
1c0ffbd7bf
command/push: output the name/version of the pushed configuration
2015-03-24 13:30:23 -07:00
ee1ad49829
command/push: rename -module-lock to -module-upload
2015-03-24 13:30:23 -07:00
da46e16f4f
command/push: can set the name on the CLI
2015-03-24 13:30:23 -07:00
5e27bfc040
command/push: read name from the config
2015-03-24 13:30:23 -07:00
9062bfda89
command/meta: fix test
2015-03-24 13:30:23 -07:00
eebd7b8aa3
command/push: ask for only variables that are unset
2015-03-24 13:30:23 -07:00
bf14143369
command/push: test that input is asked
2015-03-24 13:30:22 -07:00
d37d9ea6ef
command/push: send the context variables up
2015-03-24 13:30:22 -07:00
a1b424d53f
command/push: properly copy the data directory no matter what
2015-03-24 13:30:22 -07:00
22087181af
command/push: archive, upload
2015-03-24 13:30:22 -07:00
ca8e2085f3
command/push: archiving
2015-03-24 13:30:22 -07:00
c4dc9af120
command: add DataDir
2015-03-24 13:30:21 -07:00
cdde9149ff
command/push: start it
2015-03-24 13:30:21 -07:00
4fc5ebf47e
command: warnings should not exit
...
also properly colorize error/warnings
depends on https://github.com/mitchellh/cli/pull/15
2015-03-05 14:22:34 -06:00
89e7438f0f
command/remote
2015-03-04 16:25:11 -08:00
01cd761023
command: move remote configuration stuff
2015-03-04 16:17:30 -08:00
71315076c3
command: autoload terraform.tfvars.json as well [GH-1030]
2015-03-02 09:22:28 -08:00
8e76a02a56
command: disable backup with "-" [GH-1072]
...
/cc @phinze
2015-03-02 09:11:49 -08:00
6f9a358cc4
command/taint: fix comment
2015-02-26 14:30:02 -08:00
d411e2939f
command/taint: -allow-missing
2015-02-26 10:56:45 -08:00
01aa4236c0
command/taint: support tainting resources in modules
2015-02-26 10:44:25 -08:00
fa9b655fd1
website: docs for tainted command
2015-02-26 10:37:08 -08:00
4ec31ecb95
command/taint: new command
2015-02-26 10:29:23 -08:00
95cf69aa32
command: StateHook for continous state updates
2015-02-23 21:57:17 -08:00
a655c1619a
command: update help text
2015-02-23 15:13:56 -08:00
0299e60e83
command/init: -backend-config
2015-02-23 15:13:56 -08:00
84a0e512d3
command/remote: general `-config` flag
2015-02-23 15:13:56 -08:00
189e7e700a
command: remove remote package
2015-02-23 15:13:55 -08:00
2c2b560d7f
command/remote: no more remote package
2015-02-23 15:13:55 -08:00
0fcc417ddd
command/apply: remove remote package
2015-02-23 15:13:55 -08:00
0c6d133d61
command/refresh: get rid of remote package
2015-02-23 15:13:55 -08:00
0d39a5d9a7
command/push: no more remote package
2015-02-23 15:13:55 -08:00
f2c6c12535
command/pull: remove remote package
2015-02-23 15:13:55 -08:00
b8a66cb6ca
command: remove more remote package
2015-02-23 15:13:55 -08:00
622690583c
command/init: remove dependency on remote package
2015-02-23 15:13:55 -08:00
3550f7ac3a
command: FlagVar => FlagKV
2015-02-23 15:13:54 -08:00
4f91b98a3e
command: default path should be the local path
2015-02-23 15:13:54 -08:00
f81110c2fe
command: backup stuff works better
2015-02-23 15:13:54 -08:00
4ec63bc2ef
command: deal with plan states
2015-02-23 15:13:54 -08:00
579f102f37
command: start migrating to new state package
2015-02-23 15:13:54 -08:00
c2593f6ada
terraform: re-enable dot-graphs
2015-02-19 23:00:29 -08:00
b1e5b32322
terraform: Graph returns *Graph for now
2015-02-19 12:08:32 -08:00
6c8dd9e8fa
Unreachable code removed
2015-02-18 18:28:09 +00:00
92540d3d88
fixing version numbers RCs should be labeled x.x.x-rcx
...
see conversation with ryanuber: https://github.com/hashicorp/go-checkpoint/issues/2#issuecomment-73199209
2015-02-07 16:56:56 +01:00
b40c2fe997
command: fix test failure on Windows
...
URLs are `/`-based. Windows path Separator is `\`.
Convert `\` in test fixture path to `/` with filepath.ToSlash
such that proper URLs are constructed even on Windows.
Fixes a test failure on Windows.
2015-01-28 08:13:44 +01:00
92e68c1ee6
command: fix test failure on Windows
...
Adjust the laddr argument to net.Listen to the form host:port,
as documented for net.Dial.
Fixes a test failure on Windows.
2015-01-28 08:10:52 +01:00
b211d69dde
Fix typo in refresh command error
...
Noticed this while I was digging around to see how the commands work.
2015-01-17 15:43:04 -08:00
fb3f10efb0
command/apply: ask for user variables before validation [GH-736]
2015-01-16 10:46:38 -08:00
90138825a2
command/apply: don't init if no args given [GH-780]
...
I really don't know how to unit test this since I don't know what input
triggers this except that it has been reporting a few times in the wild.
2015-01-16 10:22:20 -08:00
b69239e7f8
command/meta: Adding additional nil guards
2015-01-07 13:28:15 -08:00
408ae62306
command/apply: Handle remote state in a plan file
2015-01-07 13:08:32 -08:00
07505ed159
Fix typo: expacts -> expects
2015-01-03 17:59:55 +01:00
fc36b1cd94
command: vet fix
...
Fixes the following vet report:
command/remote.go:165: wrong number of args for format in Sprintf call: 1 needed but 2 args
2014-12-17 13:02:19 +01:00
cce881aadd
command/show: enable printing of remote state
2014-12-10 13:27:11 -08:00
07e5f3ff41
command/remote: Improve UI output for remote
2014-12-10 13:27:11 -08:00
bcd348aebd
command: updating tests
2014-12-10 13:27:10 -08:00
6a84be0686
command: updating for pluggable backends
2014-12-10 13:27:10 -08:00
ba01e27026
command: Refresh remote state when loading
2014-12-10 13:27:09 -08:00
dab47b0d48
command/plan: remote enable
2014-12-10 13:27:09 -08:00
b6265cf1a2
command/refresh: Remote enable
2014-12-10 13:27:09 -08:00
0fb87e499d
command: Meta provides the state output path
2014-12-10 13:27:09 -08:00
0c9436f37b
command/output: Remote enable
2014-12-10 13:27:09 -08:00
53704db4ee
command: Enable reading remote-enabled state
2014-12-10 13:27:09 -08:00
bf10111745
command/apply: Move state persistence to Meta
2014-12-10 13:27:09 -08:00
c24123ff8a
command/remote: Adding tests
2014-12-10 13:27:08 -08:00
b4b44dd0a8
command/remote: Refresh state before the disable
2014-12-10 13:27:08 -08:00
6e7cffd60b
command/init: Only initialize a blank state with remote
2014-12-10 13:27:08 -08:00
9168a0f1ce
command: Simplify push/pull, depend on remote command for setup
2014-12-10 13:27:08 -08:00
1945e2099a
command/remote: Use PersistState
2014-12-10 13:27:08 -08:00
4e44443aa3
command/remote: Working on the details
2014-12-10 13:27:08 -08:00
Paul Hinze