Go to file
Paul Hinze e76fdb92e7 core: fix bug detecting deeply nested module orphans
Context:

As part of building up a Plan, Terraform needs to detect "orphaned"
resources--resources which are present in the state but not in the
config. This happens when config for those resources is removed by the
user, making it Terraform's responsibility to destroy them.

Both state and config are organized by Module into a logical tree, so
the process of finding orphans involves checking for orphaned Resources
in the current module and for orphaned Modules, which themselves will
have all their Resources marked as orphans.

Bug:

In #3114 a problem was exposed where, given a module tree that looked
like this:

```
root
 |
 +-- parent (empty, except for sub-modules)
       |
       +-- child1 (1 resource)
       |
       +-- child2 (1 resource)
```

If `parent` was removed, a bunch of error messages would occur during
the plan. The root cause of this was duplicate orphans appearing for the
resources in child1 and child2.

Fix:

This turned out to be a bug in orphaned module detection. When looking
for deeply nested orphaned modules, root.parent was getting added twice
as an orphaned module to the graph.

Here, we add an additional check to prevent a double add, which
addresses this scenario properly.

Fixes #3114 (the Provisioner side of it was fixed in #4877)
2016-02-09 10:35:46 -06:00
Godeps provider/azurerm: Add the DNS A Record Resource 2016-02-05 11:28:48 +00:00
builtin provider/azurerm: Add DNS CName Record Resource 2016-02-05 12:51:33 +00:00
command core: write planfile even on empty plans 2016-01-20 16:00:20 -06:00
communicator communicator/winrm: fix data race in io copy 2016-01-16 13:33:24 -05:00
config remove config/lang, use hashicorp/hil 2016-02-03 13:24:04 -05:00
contrib command: Change module-depth default to -1 2016-01-20 13:58:02 -06:00
dag dag: add HasVertex, HasEdge 2016-01-14 13:52:01 -08:00
deps v0.6.10 2016-01-27 22:18:55 +00:00
digraph
dot
examples Added a bit of formatting for readability 2016-01-21 17:26:08 +05:30
flatmap
helper helper/schema: replace config/lang 2016-02-03 13:24:04 -05:00
plugin Demote some log lines to DEBUG. 2015-10-11 10:45:33 -07:00
rpc
scripts build.sh: don't dive into vendored deps when building 2016-02-01 11:28:41 -06:00
state tests: allow opt-out of remote tests via env var 2016-01-21 15:44:18 -06:00
terraform core: fix bug detecting deeply nested module orphans 2016-02-09 10:35:46 -06:00
test-fixtures
vendor provider/azurerm: Add the DNS A Record Resource 2016-02-05 11:28:48 +00:00
website provider/azurerm: Add DNS CName Record Resource 2016-02-05 12:51:33 +00:00
.gitignore Vendor all dependencies w/ Godep 2016-01-29 15:08:48 -06:00
.travis.yml Vendor all dependencies w/ Godep 2016-01-29 15:08:48 -06:00
BUILDING.md Update BUILDING.md 2015-11-28 22:49:23 -05:00
CHANGELOG.md Update CHANGELOG.md 2016-02-05 12:44:22 -06:00
CONTRIBUTING.md Enhanced Contributing Guide 2016-01-19 17:11:17 -06:00
LICENSE
Makefile Vendor all dependencies w/ Godep 2016-01-29 15:08:48 -06:00
README.md Remove release target and document cross-compiling 2015-12-08 13:10:40 -05:00
Vagrantfile Update Vagrant file to use Go 1.5.1 2015-11-23 11:11:55 -06:00
checkpoint.go
commands.go
config.go use upstream osext, which fixes some bugs 2015-10-17 17:33:45 -07:00
config_test.go
config_unix.go core: use !windows instead of a list of unixes 2015-12-30 17:37:24 -05:00
config_windows.go
main.go core: use same logging setup for acctests 2015-12-08 17:50:36 -06:00
make.bat
panic.go
version.go

README.md

Terraform

Terraform

Terraform is a tool for building, changing, and versioning infrastructure safely and efficiently. Terraform can manage existing and popular service providers as well as custom in-house solutions.

The key features of Terraform are:

  • Infrastructure as Code: Infrastructure is described using a high-level configuration syntax. This allows a blueprint of your datacenter to be versioned and treated as you would any other code. Additionally, infrastructure can be shared and re-used.

  • Execution Plans: Terraform has a "planning" step where it generates an execution plan. The execution plan shows what Terraform will do when you call apply. This lets you avoid any surprises when Terraform manipulates infrastructure.

  • Resource Graph: Terraform builds a graph of all your resources, and parallelizes the creation and modification of any non-dependent resources. Because of this, Terraform builds infrastructure as efficiently as possible, and operators get insight into dependencies in their infrastructure.

  • Change Automation: Complex changesets can be applied to your infrastructure with minimal human interaction. With the previously mentioned execution plan and resource graph, you know exactly what Terraform will change and in what order, avoiding many possible human errors.

For more information, see the introduction section of the Terraform website.

Getting Started & Documentation

All documentation is available on the Terraform website.

Developing Terraform

If you wish to work on Terraform itself or any of its built-in providers, you'll first need Go installed on your machine (version 1.4+ is required). Alternatively, you can use the Vagrantfile in the root of this repo to stand up a virtual machine with the appropriate dev tooling already set up for you.

For local dev first make sure Go is properly installed, including setting up a GOPATH. You will also need to add $GOPATH/bin to your $PATH. Next, install the following software packages, which are needed for some dependencies:

Next, clone this repository into $GOPATH/src/github.com/hashicorp/terraform. Install the necessary dependencies by running make updatedeps and then just type make. This will compile some more dependencies and then run the tests. If this exits with exit status 0, then everything is working!

$ make updatedeps
...
$ make
...

To compile a development version of Terraform and the built-in plugins, run make dev. This will put Terraform binaries in the bin and $GOPATH/bin folders:

$ make dev
...
$ bin/terraform
...

If you're developing a specific package, you can run tests for just that package by specifying the TEST variable. For example below, onlyterraform package tests will be run.

$ make test TEST=./terraform
...

If you're working on a specific provider and only wish to rebuild that provider, you can use the plugin-dev target. For example, to build only the Azure provider:

$ make plugin-dev PLUGIN=provider-azure

If you're working on the core of Terraform, and only wish to rebuild that without rebuilding providers, you can use the core-dev target. It is important to note that some types of changes may require both core and providers to be rebuilt - for example work on the RPC interface. To build just the core of Terraform:

$ make core-dev

Acceptance Tests

Terraform also has a comprehensive acceptance test suite covering most of the major features of the built-in providers.

If you're working on a feature of a provider and want to verify it is functioning (and hasn't broken anything else), we recommend running the acceptance tests. Note that we do not require that you run or write acceptance tests to have a PR accepted. The acceptance tests are just here for your convenience.

Warning: The acceptance tests create/destroy/modify real resources, which may incur real costs. In the presence of a bug, it is technically possible that broken providers could corrupt existing infrastructure as well. Therefore, please run the acceptance providers at your own risk. At the very least, we recommend running them in their own private account for whatever provider you're testing.

To run the acceptance tests, invoke make testacc:

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=Vpc'
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=Vpc -timeout 90m
=== RUN TestAccVpc_basic
2015/02/10 14:11:17 [INFO] Test: Using us-west-2 as test region
[...]
[...]
...

The TEST variable is required, and you should specify the folder where the provider is. The TESTARGS variable is recommended to filter down to a specific resource to test, since testing all of them at once can take a very long time.

Acceptance tests typically require other environment variables to be set for things such as access keys. The provider itself should error early and tell you what to set, so it is not documented here.

Cross Compilation and Building for Distribution

If you wish to cross-compile Terraform for another architecture, you can set the XC_OS and XC_ARCH environment variables to values representing the target operating system and architecture before calling make. The output is placed in the pkg subdirectory tree both expanded in a directory representing the OS/architecture combination and as a ZIP archive.

For example, to compile 64-bit Linux binaries on Mac OS X Linux, you can run:

$ XC_OS=linux XC_ARCH=amd64 make bin 
...
$ file pkg/linux_amd64/terraform
terraform: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped

XC_OS and XC_ARCH can be space separated lists representing different combinations of operating system and architecture. For example, to compile for both Linux and Mac OS X, targeting both 32- and 64-bit architectures, you can run:

$ XC_OS="linux darwin" XC_ARCH="386 amd64" make bin
...
$ tree ./pkg/ -P "terraform|*.zip"
./pkg/
├── darwin_386
│   └── terraform
├── darwin_386.zip
├── darwin_amd64
│   └── terraform
├── darwin_amd64.zip
├── linux_386
│   └── terraform
├── linux_386.zip
├── linux_amd64
│   └── terraform
└── linux_amd64.zip

4 directories, 8 files

Note: Cross-compilation uses gox, which requires toolchains to be built with versions of Go prior to 1.5. In order to successfully cross-compile with older versions of Go, you will need to run gox -build-toolchain before running the commands detailed above.