e95f29bf9d
Previously we were just returning a string representation of the file mode, which spends more characters on the irrelevant permission bits that it does on the directory entry type, and is presented in a Unix-centric format that likely won't be familiar to the user of a Windows system. Instead, we'll recognize a few specific directory entry types that seem worth mentioning by name, and then use a generic message for the rest. The original motivation here was actually to deal with the fact that our tests for this function were previously not portable due to the error message leaking system-specific permission detail that are not relevant to the test. Rather than just directly addressing that portability problem, I took the opportunity to improve the error messages at the same time. However, because of that initial focus there are only actually tests here for the directory case. A test that tries to test any of these other file modes would not be portable and in some cases would require superuser access, so we'll just leave those cases untested for the moment since they weren't tested before anyway, and so we've not _lost_ any test coverage here. |
||
|---|---|---|
| .. | ||
| blocktoattr | ||
| funcs | ||
| marks | ||
| testdata/functions-test | ||
| data.go | ||
| data_test.go | ||
| doc.go | ||
| eval.go | ||
| eval_test.go | ||
| functions.go | ||
| functions_test.go | ||
| references.go | ||
| scope.go | ||