History

Paul Hinze 6fe2703665 Vendor all dependencies w/ Godep * Remove `make updatedeps` from Travis build. We'll follow up with more specific plans around dependency updating in subsequent PRs. * Update all `make` targets to set `GO15VENDOREXPERIMENT=1` and to filter out `/vendor/` from `./...` where appropriate. * Temporarily remove `vet` from the `make test` target until we can figure out how to get it to not vet `vendor/`. (Initial experimentation failed to yield the proper incantation.) Everything is pinned to current master, with the exception of: * Azure/azure-sdk-for-go which is pinned before the breaking change today * aws/aws-sdk-go which is pinned to the most recent tag The documentation still needs to be updated, which we can do in a follow up PR. The goal here is to unblock release.		2016-01-29 15:08:48 -06:00
..
LICENSE	Vendor all dependencies w/ Godep	2016-01-29 15:08:48 -06:00
README.md	Vendor all dependencies w/ Godep	2016-01-29 15:08:48 -06:00
cleanhttp.go	Vendor all dependencies w/ Godep	2016-01-29 15:08:48 -06:00

README.md

cleanhttp

Functions for accessing "clean" Go http.Client values

The Go standard library contains a default http.Client called http.DefaultClient. It is a common idiom in Go code to start with http.DefaultClient and tweak it as necessary, and in fact, this is encouraged; from the http package documentation:

The Client's Transport typically has internal state (cached TCP connections), so Clients should be reused instead of created as needed. Clients are safe for concurrent use by multiple goroutines.

Unfortunately, this is a shared value, and it is not uncommon for libraries to assume that they are free to modify it at will. With enough dependencies, it can be very easy to encounter strange problems and race conditions due to manipulation of this shared value across libraries and goroutines (clients are safe for concurrent use, but writing values to the client struct itself is not protected).

Making things worse is the fact that a bare http.Client will use a default http.Transport called http.DefaultTransport, which is another global value that behaves the same way. So it is not simply enough to replace http.DefaultClient with &http.Client{}.

This repository provides some simple functions to get a "clean" http.Client -- one that uses the same default values as the Go standard library, but returns a client that does not share any state with other clients.