332ea1f233
The original intent of this test was to verify that we properly release the state lock if terraform.NewContext fails. This was in response to a bug in an earlier version of Terraform where that wasn't true. In the recent refactoring that made terraform.NewContext no longer responsible for provider constraint/checksum verification, this test began testing a failed plan operation instead, which left the error return path from terraform.NewContext untested. An invalid parallelism value is the one remaining case where terraform.NewContext can return an error, so as a localized fix for this test I've switched it to just intentionally set an invalid parallelism value. This is still not ideal because it's still testing an implementation detail, but I've at least left a comment inline to try to be clearer about what the goal is here so that we can respond in a more appropriate way if future changes cause this test to fail again. In the long run I'd like to move this last remaining check out to be the responsibility of the CLI layer, with terraform.NewContext either just assuming the value correct or panicking when it isn't, but the handling of this CLI option is currently rather awkwardly spread across the command and backend packages so we'll save that refactoring for a later date. |
||
|---|---|---|
| .. | ||
| testdata | ||
| backend.go | ||
| backend_apply.go | ||
| backend_apply_test.go | ||
| backend_local.go | ||
| backend_local_test.go | ||
| backend_plan.go | ||
| backend_plan_test.go | ||
| backend_refresh.go | ||
| backend_refresh_test.go | ||
| backend_test.go | ||
| cli.go | ||
| hook_state.go | ||
| hook_state_test.go | ||
| local_test.go | ||
| testing.go | ||