95d37ea79c
Fixes #3309 There are two primary changes, one to how helper/schema creates diffs and one to how Terraform compares diffs. Both require careful understanding. == 1. helper/schema Changes helper/schema, given any primitive field (string, int, bool, etc.) _used to_ create a basic diff when given a computed new value (i.e. from an unkown interpolation). This would put in the plan that the old value is whatever the old value was, and the new value was the actual interpolation. For example, from #3309, the diff showed the following: ``` ~ module.test.aws_eip.test-instance.0 instance: "<INSTANCE ID>" => "${element(aws_instance.test-instance.*.id, count.index)}" ``` Then, when running `apply`, the diff would be realized and you would get a diff mismatch error because it would realize the final value is the same and remove it from the diff. **The change:** `helper/schema` now marks unknown primitive values with `NewComputed` set to true. Semantically this is correct for the diff to have this information. == 2. Terraform Diff.Same Changes Next, the way Terraform compares diffs needed to be updated Specifically, the case where the diff from the plan had a NewComputed primitive and the diff from the apply _no longer has that value_. This is possible if the computed value ended up being the same as the old value. This is allowed to pass through. Together, these fix #3309. |
||
|---|---|---|
| .. | ||
| README.md | ||
| data_source_resource_shim.go | ||
| equal.go | ||
| field_reader.go | ||
| field_reader_config.go | ||
| field_reader_config_test.go | ||
| field_reader_diff.go | ||
| field_reader_diff_test.go | ||
| field_reader_map.go | ||
| field_reader_map_test.go | ||
| field_reader_multi.go | ||
| field_reader_multi_test.go | ||
| field_reader_test.go | ||
| field_writer.go | ||
| field_writer_map.go | ||
| field_writer_map_test.go | ||
| getsource_string.go | ||
| provider.go | ||
| provider_test.go | ||
| resource.go | ||
| resource_data.go | ||
| resource_data_get_source.go | ||
| resource_data_test.go | ||
| resource_importer.go | ||
| resource_test.go | ||
| schema.go | ||
| schema_test.go | ||
| serialize.go | ||
| serialize_test.go | ||
| set.go | ||
| set_test.go | ||
| valuetype.go | ||
| valuetype_string.go | ||
README.md
Terraform Helper Lib: schema
The schema package provides a high-level interface for writing resource
providers for Terraform.
If you're writing a resource provider, we recommend you use this package.
The interface exposed by this package is much friendlier than trying to write to the Terraform API directly. The core Terraform API is low-level and built for maximum flexibility and control, whereas this library is built as a framework around that to more easily write common providers.