bee7403f3e
Previously we would reject attempts to delete a workspace if its state contained any resources at all, even if none of the resources had any resource instance objects associated with it. Nowadays there isn't any situation where the normal Terraform workflow will leave behind resource husks, and so this isn't as problematic as it might've been in the v0.12 era, but nonetheless what we actually care about for this check is whether there might be any remote objects that this state is tracking, and for that it's more precise to look for non-nil resource instance objects, rather than whole resources. This also includes some adjustments to our error messaging to give more information about the problem and to use terminology more consistent with how we currently talk about this situation in our documentation and elsewhere in the UI. We were also using the old State.HasResources method as part of some of our tests. I considered preserving it to avoid changing the behavior of those tests, but the new check seemed close enough to the intent of those tests that it wasn't worth maintaining this method that wouldn't be used in any main code anymore. I've therefore updated those tests to use the new HasResourceInstanceObjects method instead. |
||
|---|---|---|
| .. | ||
| remote | ||
| statefile | ||
| statemgr | ||
| doc.go | ||
| instance_generation.go | ||
| instance_object.go | ||
| instance_object_src.go | ||
| module.go | ||
| objectstatus_string.go | ||
| output_value.go | ||
| resource.go | ||
| resource_test.go | ||
| state.go | ||
| state_deepcopy.go | ||
| state_equal.go | ||
| state_string.go | ||
| state_test.go | ||
| sync.go | ||