657932261b
The Close methods on shadow.Values require pointer receivers because they contain a sync.Mutex, but that value was being copied through Value.Interface by the closeWalker. Because reflectwalk passes the struct fields to the StructField method as they are defined in the struct, and they may have been read as a value, we can't immediately call Interface() to check the method set without possibly copying the internal mutex values. Use the Implements method to first check if we need to call Interface, and if it's not, then we can check if the value is addressable. Because of this use of reflection, we can't vet for the copying of these locks. The minimal amount of code in the Close method left us only with a race detected within the mutex itself, which leads to a stacktrace pointing to the runtime rather than our code. |
||
|---|---|---|
| .. | ||
| closer.go | ||
| closer_test.go | ||
| compared_value.go | ||
| compared_value_test.go | ||
| keyed_value.go | ||
| keyed_value_test.go | ||
| ordered_value.go | ||
| ordered_value_test.go | ||
| value.go | ||
| value_test.go | ||