410b60cb7f
Prior to Terraform 0.7, lists in Terraform were just a shallow abstraction on top of strings with a magic delimiter between items. Wrapping a single string in brackets in the configuration was Terraform's prompt that it needed to split the string on that delimiter during interpolation. In 0.7, when first-class lists were added, this convention was preserved by flattening lists-of-lists by one level when they were encountered in configuration. However, there was an oversight in that change where it did not correctly handle the case where the inner list was unknown. In #14135 we removed some code that was flattening partially-unknown lists into fully-unknown (untyped) values. This inadvertently exposed the missed case from the previous paragraph, causing issues for list-wrapped splat expressions with unknown members. While this worked fine for resources, due to some fixup done inside helper/schema, this did not work for other interpolation contexts such as module blocks. Various attempts to fix this up and restore the flattening behavior selectively were unsuccessful, due to a proliferation of assumptions all over the core code that would be too risky to change just to fix this bug. This change, then, takes the different approach of removing the requirement that splats be presented inside list brackets. This requirement didn't make much sense anymore anyway, since no other list-returning expression had this constraint and so the rest of Terraform was already successfully dealing with both cases. This leaves us with two different scenarios: - For resource arguments, existing normalization code in helper/schema does its own flattening that preserves compatibility with the common practice of using bracketed splats. This change proves this with a test within the "test" provider that exercises the whole Terraform core and helper/schema stack that assigns bracketed splats to list and set attributes. - For arguments in other blocks, such as in module callsites, the interpolator's own flattening behavior applies to known lists, preserving compatibility with configurations from before partially-computed splats were possible, but those wishing to use partially-computed splats are required to drop the surrounding brackets. This is less concerning because this scenario was introduced only in 0.9.5, so the scope for breakage is limited to those who adopted this new feature quickly after upgrading. As of this commit, the recommendation is to stop using brackets around splats but the old form continues to be supported for backward compatibility. In a future _major_ version of Terraform we will probably phase out this legacy form to improve consistency, but for now both forms are acceptable at the expense of some (pre-existing) weird behavior when _actual_ lists-of-lists are used. This addresses #14521 by officially adopting the suggested workaround of dropping the brackets around the splat. However, it doesn't yet allow passing of a partially-unknown list between modules: that still violates assumptions in Terraform's core, so for the moment partially-unknown lists work only within a _single_ interpolation expression, and cannot be passed around between expressions. Until more holistic work is done to improve Terraform's type handling, passing a partially-unknown splat through to a module will result in a fully-unknown list emerging on the other side, just as was the case before #14135; this change just addresses the fact that this was failing with an error in 0.9.5. |
||
---|---|---|
.github | ||
backend | ||
builtin | ||
command | ||
communicator | ||
config | ||
contrib | ||
dag | ||
digraph | ||
docs | ||
examples | ||
flatmap | ||
helper | ||
plugin | ||
repl | ||
scripts | ||
state | ||
terraform | ||
test-fixtures | ||
vendor | ||
website | ||
.gitignore | ||
.travis.yml | ||
BUILDING.md | ||
CHANGELOG.md | ||
LICENSE | ||
Makefile | ||
README.md | ||
Vagrantfile | ||
checkpoint.go | ||
commands.go | ||
config.go | ||
config_test.go | ||
config_unix.go | ||
config_windows.go | ||
help.go | ||
main.go | ||
main_test.go | ||
panic.go | ||
signal_unix.go | ||
signal_windows.go | ||
synchronized_writers.go | ||
version.go |
README.md
Terraform
- Website: https://www.terraform.io
- Mailing list: Google Groups
Terraform is a tool for building, changing, and versioning infrastructure safely and efficiently. Terraform can manage existing and popular service providers as well as custom in-house solutions.
The key features of Terraform are:
-
Infrastructure as Code: Infrastructure is described using a high-level configuration syntax. This allows a blueprint of your datacenter to be versioned and treated as you would any other code. Additionally, infrastructure can be shared and re-used.
-
Execution Plans: Terraform has a "planning" step where it generates an execution plan. The execution plan shows what Terraform will do when you call apply. This lets you avoid any surprises when Terraform manipulates infrastructure.
-
Resource Graph: Terraform builds a graph of all your resources, and parallelizes the creation and modification of any non-dependent resources. Because of this, Terraform builds infrastructure as efficiently as possible, and operators get insight into dependencies in their infrastructure.
-
Change Automation: Complex changesets can be applied to your infrastructure with minimal human interaction. With the previously mentioned execution plan and resource graph, you know exactly what Terraform will change and in what order, avoiding many possible human errors.
For more information, see the introduction section of the Terraform website.
Getting Started & Documentation
All documentation is available on the Terraform website.
Developing Terraform
If you wish to work on Terraform itself or any of its built-in providers, you'll first need Go installed on your machine (version 1.8+ is required). Alternatively, you can use the Vagrantfile in the root of this repo to stand up a virtual machine with the appropriate dev tooling already set up for you.
For local dev first make sure Go is properly installed, including setting up a GOPATH. You will also need to add $GOPATH/bin
to your $PATH
.
Next, using Git, clone this repository into $GOPATH/src/github.com/hashicorp/terraform
. All the necessary dependencies are either vendored or automatically installed, so you just need to type make
. This will compile the code and then run the tests. If this exits with exit status 0, then everything is working!
$ cd "$GOPATH/src/github.com/hashicorp/terraform"
$ make
To compile a development version of Terraform and the built-in plugins, run make dev
. This will build everything using gox and put Terraform binaries in the bin
and $GOPATH/bin
folders:
$ make dev
...
$ bin/terraform
...
If you're developing a specific package, you can run tests for just that package by specifying the TEST
variable. For example below, onlyterraform
package tests will be run.
$ make test TEST=./terraform
...
If you're working on a specific provider and only wish to rebuild that provider, you can use the plugin-dev
target. For example, to build only the Azure provider:
$ make plugin-dev PLUGIN=provider-azure
If you're working on the core of Terraform, and only wish to rebuild that without rebuilding providers, you can use the core-dev
target. It is important to note that some types of changes may require both core and providers to be rebuilt - for example work on the RPC interface. To build just the core of Terraform:
$ make core-dev
Dependencies
Terraform stores its dependencies under vendor/
, which Go 1.6+ will automatically recognize and load. We use govendor
to manage the vendored dependencies.
If you're developing Terraform, there are a few tasks you might need to perform.
Adding a dependency
If you're adding a dependency, you'll need to vendor it in the same Pull Request as the code that depends on it. You should do this in a separate commit from your code, as makes PR review easier and Git history simpler to read in the future.
To add a dependency:
Assuming your work is on a branch called my-feature-branch
, the steps look like this:
-
Add the new package to your GOPATH:
go get github.com/hashicorp/my-project
-
Add the new package to your
vendor/
directory:govendor add github.com/hashicorp/my-project/package
-
Review the changes in git and commit them.
Updating a dependency
To update a dependency:
-
Fetch the dependency:
govendor fetch github.com/hashicorp/my-project
-
Review the changes in git and commit them.
Acceptance Tests
Terraform has a comprehensive acceptance test suite covering the built-in providers. Our Contributing Guide includes details about how and when to write and run acceptance tests in order to help contributions get accepted quickly.
Cross Compilation and Building for Distribution
If you wish to cross-compile Terraform for another architecture, you can set the XC_OS
and XC_ARCH
environment variables to values representing the target operating system and architecture before calling make
. The output is placed in the pkg
subdirectory tree both expanded in a directory representing the OS/architecture combination and as a ZIP archive.
For example, to compile 64-bit Linux binaries on Mac OS X, you can run:
$ XC_OS=linux XC_ARCH=amd64 make bin
...
$ file pkg/linux_amd64/terraform
terraform: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped
XC_OS
and XC_ARCH
can be space separated lists representing different combinations of operating system and architecture. For example, to compile for both Linux and Mac OS X, targeting both 32- and 64-bit architectures, you can run:
$ XC_OS="linux darwin" XC_ARCH="386 amd64" make bin
...
$ tree ./pkg/ -P "terraform|*.zip"
./pkg/
├── darwin_386
│ └── terraform
├── darwin_386.zip
├── darwin_amd64
│ └── terraform
├── darwin_amd64.zip
├── linux_386
│ └── terraform
├── linux_386.zip
├── linux_amd64
│ └── terraform
└── linux_amd64.zip
4 directories, 8 files
Note: Cross-compilation uses gox, which requires toolchains to be built with versions of Go prior to 1.5. In order to successfully cross-compile with older versions of Go, you will need to run gox -build-toolchain
before running the commands detailed above.
Docker
When using docker you don't need to have any of the Go development tools installed and you can clone terraform to any location on disk (doesn't have to be in your $GOPATH). This is useful for users who want to build master
or a specific branch for testing without setting up a proper Go environment.
For example, run the following command to build terraform in a linux-based container for macOS.
docker run --rm -v $(pwd):/go/src/github.com/hashicorp/terraform -w /go/src/github.com/hashicorp/terraform -e XC_OS=darwin -e XC_ARCH=amd64 golang:latest bash -c "apt-get update && apt-get install -y zip && make bin"