b9138f4465
* checkpoint save: update InternalValidate tests to compare exact error * configschema: extract and extend attribute validation This commit adds an attribute-specific InternalValidate which was extracted directly from the block.InternalValidate logic and extended to verify any NestedTypes inside an Attribute. Only one error message changed, since it is now valid to have a cty.NilType for Attribute.Type as long as NestedType is set. * terraform: validate provider schema's during NewContext We haven't been able to guarantee that providers are validating their own schemas using (some version of) InternalValidate since providers were split out of the main codebase. This PR adds a call to InternalValidate when provider schemas are initially loaded by NewContext, which required a few other changes: InternalValidate's handling of errors vs multierrors was a little weird - before this PR, it was occasionally returning a non-nil error which only stated "0 errors occurred" - so I addressed that in InternalValidate. I then tested this with a configuration that was using all of our most popular providers, and found that at least on provider had some invalid attribute names, so I commented that particular validation out. Adding that in would be a breaking change which we would have to coordinate with enablement and providers and (especially in this case) make sure it's well communicated to external provider developers. I ran a few very unscientific tests comparing the timing with and without this validation, and it appeared to only cause a sub-second increase. * refactor validate error message to closer match the sdk's message * better error message * tweak error message: move the instruction to run init to the end of the message, after the specific error. |
||
|---|---|---|
| .. | ||
| coerce_value.go | ||
| coerce_value_test.go | ||
| decoder_spec.go | ||
| decoder_spec_test.go | ||
| doc.go | ||
| empty_value.go | ||
| empty_value_test.go | ||
| implied_type.go | ||
| implied_type_test.go | ||
| internal_validate.go | ||
| internal_validate_test.go | ||
| nestingmode_string.go | ||
| none_required.go | ||
| path.go | ||
| path_test.go | ||
| schema.go | ||
| validate_traversal.go | ||
| validate_traversal_test.go | ||