f80b872bc3
backend/remote-state/gcloud: Unify on the "context" package.
...
We don't need to use the legacy package here.
2017-10-27 16:51:21 -04:00
5d4e25ada4
backend/remote-state/gcloud: Make gcsBackend private.
...
This class is only used via the "backend".Backend interface, so there is
no need to export this type beyond the gcloud package.
2017-10-27 16:51:21 -04:00
9ec39573ee
backend/remote-state/gcloud: Make remoteClient private.
...
This class is only used via the "state/remote".State interface, so there
is no need to export this type beyond the gcloud package.
2017-10-27 16:51:21 -04:00
42e8441a2b
backend/remote-state/gcloud: Refactor Backend.State().
...
Fixes:
* https://github.com/golang/go/wiki/CodeReviewComments#doc-comments
* https://github.com/golang/go/wiki/CodeReviewComments#error-strings
* https://github.com/golang/go/wiki/CodeReviewComments#initialisms
2017-10-27 16:51:21 -04:00
5cb574035a
backend/remote-state/gcloud: Refactor Backend.remoteClient().
...
This replaces stateFileName() and lockFileName() with path.Join().
Fixes:
* https://github.com/golang/go/wiki/CodeReviewComments#doc-comments
* https://github.com/golang/go/wiki/CodeReviewComments#doc-comments
2017-10-27 16:51:21 -04:00
9ae45e320f
backend/remote-state/gcloud: Refactor Backend.DeleteState().
...
Fixes:
* https://github.com/golang/go/wiki/CodeReviewComments#doc-comments
* https://github.com/golang/go/wiki/CodeReviewComments#error-strings
2017-10-27 16:51:21 -04:00
fabba5c0c8
backend/remote-state/gcloud: Refactor Backend.States().
...
The previous code listed all objects in the bucket and used local filtering
(using regular expressions) to find .tfstate objects. This new code sets
the delimiter to "/", which causes GCS to only return objects directly in
the given prefix, but not any sub"directories".
Fixes:
* https://github.com/golang/go/wiki/CodeReviewComments#doc-comments
* https://github.com/golang/go/wiki/CodeReviewComments#error-strings
2017-10-27 16:51:21 -04:00
97e1aa7ce9
backend/remote-state/gcloud: Use the lock file's generation as lock ID.
...
This allows Unlock() to call Delete() without reading the lock file's
content first.
2017-10-27 16:51:21 -04:00
edf2096e28
backend/remote-state/gcloud: Use the context provided to configure().
...
Calling context.Background() from outside the main() function is
discouraged. The configure functions are only called from
"…/helper/schema".Backend.Configure which provides the Background context,
i.e. a long-living context we can use for backend communication.
2017-10-27 16:51:21 -04:00
2e5fca78c2
backend/remote-state/gcloud: Coding style changes.
...
Refactorings to make the code more idiomatic.
2017-10-27 16:51:21 -04:00
f33005faba
backend/remote-state/gcloud: Handle errors returned by Write(), too.
...
Many GCS errors are returned by Close(), but not all.
2017-10-27 16:51:21 -04:00
1ee194986d
backend/remote-state/gcloud: Add the RemoteClient.{state,lock}File() methods.
2017-10-27 16:51:20 -04:00
e54d36b489
backend/remote-state/gcloud: Sort standard library imports before other imports.
2017-10-27 16:51:20 -04:00
52ac764036
backend/remote-state/gcloud: Rename Url -> URL
2017-10-27 16:51:20 -04:00
5313e15e07
backend/remote-state/gcloud: Move the definition of the Backend struct.
2017-10-27 16:51:20 -04:00
def3279ec7
backend/remote-state/gcloud: Use package provided OAuth scope.
2017-10-27 16:51:20 -04:00
5854373018
Implemented GCloud backend supporting remote locking and multiple workspaces.
2017-10-27 16:51:20 -04:00
31912956ce
Merge pull request #16290 from hashicorp/jbardin/s3-errors
...
retry on s3 state upload errors
2017-10-17 16:04:14 -04:00
611b1ced59
retry on s3 state upload errors
...
While #16243 added the ability to retry getting a state from S3, Put can
return the same InternalError status. Use the same retry logic when
uploading state to S3.
2017-10-08 16:46:33 -04:00
f5e9a20c66
reset testLockHook
2017-10-08 16:24:45 -04:00
25a8227291
add broken test for lock lost on connection error
...
Add a way to inject network errors by setting an immediate deadline on
open consul connections. The consul client currently doesn't retry on
some errors, and will force us to lose our lock.
Once the consul api client is fixed, this test will fail.
2017-10-08 16:16:57 -04:00
fd9adcdb36
only init one consul client, and lower keepalive
...
The consul Client is analogous to an http.Client, and we really don't
need more than 1. Configure a single client and store it in the backend.
Replace the default Transport's Dialer to reduce the KeepAlive setting
from 30s to 17s. This avoids racing with the common network timeout
value of 30s, and is also coprime to other common intervals.
2017-10-08 11:51:35 -04:00
d0ecb232ae
record consul session ID in lock info
...
This can help correlate TF and consul logs
2017-10-08 11:24:43 -04:00
b20ab9f0bb
Merge pull request #16243 from hashicorp/jbardin/s3-errors
...
retry on s3 backend internal errors
2017-10-04 09:26:26 -04:00
fba02f0bea
retry on s3 backend internal errors
...
Internal errors from S3 are usually transient, and can be immediately retried.
Make 2 attempts at retreiving the state object before returning an error.
2017-10-04 09:11:30 -04:00
91442b7146
Merge pull request #15680 from brunomcustodio/etcdv3-backend
...
[WIP] etcd v3 backend with lock support.
2017-10-03 14:15:58 -04:00
d477d1f6d4
Merge pull request #15553 from bonifaido/custom_s3_backend
...
Allow non-AWS S3 backends
2017-10-02 19:39:48 -04:00
524c3934c6
Add TLS support.
2017-09-09 08:03:59 +01:00
c8ff10f603
Reuse 'etcd' client.
2017-09-09 00:21:23 +01:00
6daf1d9d84
Allow for username and password to be read from envvars.
2017-09-08 23:41:27 +01:00
8f7b315037
Add documentation.
2017-09-08 23:40:05 +01:00
54dc50ec5c
Cleanup 'etcd' after every test.
2017-09-08 22:49:23 +01:00
3c21b9c56f
Get rid of 'keyEnvPrefix'.
2017-09-08 22:34:15 +01:00
6570948bea
Fixing the test suite.
2017-09-08 17:46:39 +01:00
038f5eb638
Remove 'lockSuffix' as not needed in 'etcd' v3.
2017-09-08 16:59:39 +01:00
bb4dec6032
Make sure we don't relock.
2017-09-08 16:22:14 +01:00
b8f4f6d3e2
Delete lock info when unlocking.
2017-09-08 15:21:06 +01:00
b896348230
Sort the result of 'Backend.States()'.
2017-09-08 12:25:15 +01:00
70aad79b6e
Make 'endpoints' a schema.TypeList.
2017-09-08 12:16:00 +01:00
52c97e9fc9
First steps towards an 'etcdv3' backend.
2017-09-08 09:43:33 +01:00
d074b0da29
Obtaining the current metadata before setting it
2017-09-06 12:41:05 -07:00
a10d23dd95
Removing dead code
2017-09-06 12:41:05 -07:00
f12a237747
Fix crash when using consul backend
2017-09-02 20:05:30 +09:00
76eb65c911
Fix crash in consul backend
...
A TLS config was being assigned to a Transport in a nil http.Client. The
Transport is built in the consul config by default, but the http.Client
is not built until later in NewClient.
2017-08-31 09:29:43 -04:00
21b287e919
backend/consul: allow specifying various Consul client security options
...
These new options are equivalent to the consul CLI arguments -ca-file, -client-cert and -client-key.
2017-08-23 09:47:21 -07:00
6b9b5ec297
backend/azure: update to latest SDK
2017-08-17 16:32:18 +01:00
f9e8e54835
backend: convert Azure remote state to a backend
...
Added locking support via blob leasing (requires that an empty state is
created before any lock can be acquired.
Added support for "environments" in much the same way as the S3 backend.
2017-08-17 16:32:17 +01:00
2bb5007690
Merge pull request #15683 from hashicorp/jbardin/remote-state-lineage
...
Remove strict lineage check in remote.State
2017-08-09 17:49:19 -04:00
4c7cd549cd
don't allow leading slashes in s3 remote state key
...
S3 accepts objects with a leading slash and strips them off. This works
fine except in our workspace hierarchy, which then can no longer find
suffixes matching the full key name.
2017-08-08 09:47:44 -04:00
c3e943bed2
add another failing test for remote.State lineage
...
Want to make sure we don't hit this again.
2017-08-01 19:34:21 -04:00
Florian Forster