108ccf0007
builtin: Refactor resource.Retry to clarify return
...
Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.
Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.
This makes it eminently clear whether or not a given error is
retryable from inside the client code.
Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
2016-03-09 17:37:56 -06:00
ab075bca60
Merge pull request #5193 from innossh/f-aws-instance-security-groups-updates
...
provider/aws: Support additional changes to security groups of instance without forcing new
2016-03-10 00:28:32 +01:00
7436cf7f89
Merge pull request #5376 from stack72/b-aws-ELBListner
...
provider/aws: Fixes the use of Uppercase chars in ELB Listeners
2016-03-09 23:18:56 +00:00
ffa5db4f52
Merge pull request #5538 from hashicorp/phinze/retryerror-pointers-are-evil
...
provider/aws: Fix all pointer RetryError returns
2016-03-09 16:53:19 -06:00
3f41515d2b
Fixing noop differences in aws_route.
2016-03-09 23:27:09 +01:00
16f94ed4b7
Added failing aws_route test that shows diff after apply.
2016-03-09 23:27:09 +01:00
f96ec46681
update comments
2016-03-09 15:50:01 -06:00
d14920adaf
Merge pull request #5515 from hashicorp/b-aws-acc-test-updates
...
provider/aws: Retry DB Creation on IAM propigation error
2016-03-09 15:08:13 -06:00
23c42cd6cf
Add test for flattenSecurityGroups
2016-03-09 15:00:30 -06:00
de656942ae
provider/aws: Fix all pointer RetryError returns
...
All of these RetryErrors were meant to fail right away, but instead
caused retry looping because the typecheck in the implementation of
`resource.Retry()` only catches the value type, and not the pointer
type.
Refs #5537
2016-03-09 14:59:55 -06:00
9e0bac6c9f
Terraform should keep track of the publicly accessible attribute
2016-03-09 13:33:00 -05:00
54cb5ffe00
provider/aws: Fix EC2 Classic SG Rule issue
...
Fixes an issue where security groups would fail to update after applying an
initial security_group, because we were improperly saving the id of the group
and not the name (EC2 Classic only).
This is a PR combining https://github.com/hashicorp/terraform/pull/4983 and
https://github.com/hashicorp/terraform/pull/5184 . It's majority
@ephemeralsnow's work.
2016-03-09 09:51:41 -06:00
4601d371e1
Merge pull request #5524 from stack72/f-aws-ecr-repository_name
...
provider/aws: `repository_url` is computed for `aws_ecr_repository`
2016-03-09 09:38:09 +00:00
7c5ab40b74
provider/aws: Add support for the `repository_url` to be computed for
...
ECR
2016-03-09 09:29:23 +00:00
b5e6cb5f88
Merge pull request #5520 from bsiegel/aws_rds_cluster_encryption
...
Add storage_encrypted as an optional parameter to aws_rds_cluster
2016-03-09 00:21:26 +00:00
cad550e63d
provider/aws: Add support for `description` to `aws_network_interface`
...
resource
2016-03-08 23:28:37 +00:00
fc7e9fcd53
Ensure aws_rds_cluster can have storage_encrypted set to true
2016-03-08 17:28:44 -05:00
0085bf6ae8
Ensure aws_rds_cluster has storage_encrypted set to false by default
2016-03-08 17:28:32 -05:00
b3864db462
fixup! Add storage_encrypted as an optional parameter to aws_rds_cluster
2016-03-08 17:15:01 -05:00
8aadf1d56d
Add storage_encrypted as an optional parameter to aws_rds_cluster
2016-03-08 16:48:04 -05:00
c29e1f24b8
provider/aws: Retry DB Creation on IAM propigation error
2016-03-08 14:09:42 -06:00
5dc387354d
provider/aws: Randomize tests more to reduce conflicts
...
- ASG placement tests
- Randomize DynamoDB names in tests
- tag the sg created in this test to help identify in the console
- randomize policy and role names
2016-03-08 09:56:14 -06:00
d4d20a9f5a
kms: Treat keys in PendingDeletion state as deleted
2016-03-08 09:30:47 +00:00
6f8a9c0f77
aws: kms_key - Add support for is_enabled + enable_key_rotation
2016-03-08 09:30:47 +00:00
347913a3be
aws: kms_key - Iterate over all aliases (not just 50)
2016-03-08 09:30:47 +00:00
ff2d040d28
aws: kms_key + kms_alias - Add acceptance tests
2016-03-08 09:30:47 +00:00
ccedb36a86
aws: kms_key - add forgotten policy read call + normalize
2016-03-08 09:30:47 +00:00
4c1f8db32d
aws: kms_key - Change field name (deletion_window -> deletion_window_in_days)
2016-03-08 09:30:47 +00:00
fccffbcbb1
aws: kms_alias - Remove unnecessary default ForceNew state
2016-03-08 09:30:47 +00:00
5c9fe668f5
aws: kms resources - Simplify error handling
2016-03-08 09:30:47 +00:00
2b244e21bc
aws: kms validation - Add missing placeholders for Errorf
2016-03-08 09:30:47 +00:00
5466d69450
aws: kms resources - gofmt all the code
2016-03-08 09:30:47 +00:00
5e18031367
Update AWS KMS with respect to key deletion features
2016-03-08 09:30:47 +00:00
6648df7acc
Added AWS KMS key & alias support
2016-03-08 09:30:47 +00:00
2c698d2cb0
Always transform aws_security_group protocol to lower case
...
fixes #5489
2016-03-07 22:40:29 +01:00
f0d3176999
provider/aws: Add Elastic Beanstalk Application, Configuration Template, and Environment
...
This adds support for Elastic Beanstalk Applications, Configuration Templates,
and Environments.
This is a combined work of @catsby, @dharrisio, @Bowbaq, and @jen20
2016-03-07 14:43:23 -06:00
46e4717428
Merge pull request #5474 from kjmkznr/skip-normalize-empty-policy
...
provider/aws: Fix error parsing JSON in S3 bucket policy
2016-03-07 18:53:51 +01:00
00288c36b9
fix indentation
2016-03-07 22:18:58 +09:00
8d1292d608
Return empty string when input empty S3 bucket policy
...
Before:
"" -> "Error parsing JSON: unexpected end of JSON input"
After:
"" -> ""
2016-03-07 09:31:33 +09:00
c6c2752211
provider/aws: Sort API Gateway resources alphabetically
2016-03-06 09:29:31 +00:00
fa0d6af524
provider/aws: Remove unnecessary GetChange in Delete funcs
2016-03-06 09:29:31 +00:00
a338eae72a
provider/aws: Guard APIGateway resource & REST API against deletion
2016-03-06 09:29:30 +00:00
ce5324b341
Merge pull request #4295 from nicolai86/feature/aws-api-gateway
...
provider/aws: API Gateway resources
2016-03-06 09:00:02 +00:00
6430fca7f6
Add aws_api_gateway_deployment resource
2016-03-05 23:21:58 +01:00
8c59d0861e
Add aws_api_gateway_api_key resource
2016-03-05 23:21:54 +01:00
b4c99f1009
Add aws_api_gateway_model resource
2016-03-05 23:21:51 +01:00
4da8b3d03a
Add aws_api_gateawy_integration_response resource
2016-03-05 23:21:48 +01:00
1593dbe9c8
Add aws_api_gateway_integration resource
2016-03-05 23:21:44 +01:00
91f5206f8d
Add aws_api_gateway_method_response resource
2016-03-05 23:21:41 +01:00
032e6081cb
Add aws_api_gateway_method resource
2016-03-05 23:21:38 +01:00
7ead800f6a
Add aws_api_gateway_resource resource
2016-03-05 23:21:35 +01:00
a73721d248
Add aws_api_gateway_rest_api resource
2016-03-05 23:13:38 +01:00
fdf0cfa66d
Vendor AWS APIGateway API
2016-03-05 23:12:19 +01:00
b66b9c92a2
Merge pull request #5401 from Originate/mb-fix-kinesis-stream-shard-count
...
provider/aws: Report the correct number of shards for Kinesis streams
2016-03-05 19:19:16 +01:00
d63166c025
provider/aws: Adding a test for AWS Kinesis Stream Shard Count
2016-03-05 18:40:47 +01:00
74de6531fe
Return an error when conflicting etag & kms_key_id parameters are provided and now with ServerSideEncryption we can go back to the higher level PutObject.
2016-03-04 09:22:43 -08:00
db91aebd8e
Added a kms_key_id parameter which will allow you to encrypt objects that are put into a bucket.
2016-03-03 16:20:01 -08:00
ae8627f92a
Report the correct number of shards
2016-03-01 10:46:39 -08:00
dc45f84a8f
Allow recovering from failed CW Event Target creation in state
2016-03-01 12:37:36 +00:00
5a786d52d9
Fix: Do not store ID of CW Event Target if creation fails
2016-03-01 12:35:15 +00:00
d3697fa50b
provider/aws: Combine AWS Metrics Collection resource and AWS
...
Autoscaling Group
2016-02-29 20:58:41 +00:00
4fc1391303
Scaffold the AWS Autoscaling Group Metrics Collection
2016-02-29 19:24:30 +00:00
ffbb59a73e
provider/aws: Fixes the use of Uppercase chars in ELB Listeners
2016-02-29 18:04:47 +00:00
e6f3fafcd6
Merge pull request #5361 from stack72/b-aws-es-tags
...
provider/aws: `aws_elastisearch_domain` tags not being set correctly.
2016-02-29 17:38:06 +00:00
0290884fdc
Lambda S3 object version defaults to '$LATEST' if unspecified
2016-02-29 14:31:47 +00:00
7b61567bf6
provider/aws: `aws_elastisearch_domain` tags not being set correctly.
...
The top level object was used not the tags within
2016-02-28 18:31:58 +00:00
a372800cd0
Merge pull request #5318 from stack72/f-aws-route53zone-updateComment
...
provider/aws: Add ability to update r53 zone comment
2016-02-26 19:43:13 +00:00
f249a432fc
Merge pull request #5329 from hashicorp/b-5310
...
provider/aws: Fix crash creating rules in aws SGs
2016-02-26 14:42:01 -05:00
5b4fccaa73
provider/aws: Add acceptance test for IAM Account Password Policy
2016-02-26 13:29:34 +00:00
d750d4d1cc
provider/aws: Add ability to update r53 zone comment
2016-02-26 13:26:25 +00:00
f7f3d95a9b
provider/aws: Add support for AWS Account Password Policy
2016-02-26 11:04:25 +00:00
5b548e938c
Merge pull request #5327 from Originate/s3-website-routing-rules
...
Added routing rules to s3 buckets
2016-02-25 14:43:55 -05:00
3adae0216c
provider/aws: Fix crash creating rules in aws SGs
...
This commit uses Group Name in preference to Group ID where appropriate
in the aws_security_group_rule resource. This fixes the crash reported
in #5310 .
Fixes #5310 .
2016-02-25 13:50:24 -05:00
ef50479e8a
added routing rules to s3 buckets
2016-02-25 10:19:23 -08:00
4b8726dc2b
Merge pull request #5305 from TimeIncOSS/f-s3-obj-update-and-versioning
...
provider/aws: Enable updates & versioning for s3_bucket_object
2016-02-25 12:19:34 +00:00
44246ca126
provider/aws: Add tests for s3_bucket_object w/ versioning enabled
2016-02-25 12:04:18 +00:00
ef85147559
provider/aws: Add tests for s3_bucket_object updates
2016-02-25 12:04:18 +00:00
9377b301ca
provider/aws: Cleanup s3_bucket_object acceptance tests
...
- the goal was to allow running tests in parallel and to get rid of global variables in the aws package
2016-02-25 12:04:18 +00:00
24ac996963
provider/aws: Add support for versioned objects
2016-02-25 12:04:18 +00:00
2f8b9edaf8
provider/aws: Add support for s3_bucket_object updates
2016-02-25 12:04:16 +00:00
74e5711f08
Merge pull request #5182 from Originate/mb-fix-lambda-vpc-implementation
...
provider/aws: Fixes terraform crash when lambda VpcId is nil
2016-02-24 17:52:38 -05:00
893bfb3ff4
provider/aws: Fix int overflow on 386 builds
...
386 architecture builds were failing with:
```
builtin/providers/aws/resource_aws_sns_topic_subscription.go:216: constant 60000000000 overflows int
```
2016-02-24 13:55:01 -06:00
cb8f0f04b5
fix go vet warnings
...
```
go tool vet -all .
builtin/providers/aws/resource_aws_elasticache_security_group.go:130: arg apierr.Code in printf call is a function value, not a function call
builtin/providers/aws/resource_aws_elasticache_subnet_group.go:155: arg apierr.Code in printf call is a function value, not a function call
```
2016-02-24 09:48:32 -06:00
ebf2fd54e5
provider/aws: Clean up whitespaces
2016-02-24 14:58:17 +00:00
70f045e46e
provider/aws: Breaking change - Trim off quotes for aws_s3_bucket_object.etag
2016-02-24 14:58:17 +00:00
f92b2b7c58
Also ignore empty VPC config after all
2016-02-23 12:56:46 -08:00
e454b21100
Merge pull request #5271 from stack72/f-aws-dynamodb-stream-arn
...
provider/aws: Enable DynamoDB Table to output `stream_arm` when streams are enabled
2016-02-23 17:27:22 +00:00
039065f63a
Merge pull request #5223 from stack72/f-aws-kinesis-retention-period
...
provider/aws: Implement RetentionPeriod Changes for Kinesis Stream
2016-02-23 17:26:12 +00:00
8d6cfe8e89
Implement RetentionPeriod Changes for AWS Kinesis Stream
2016-02-23 17:15:33 +00:00
0ce4aed52a
provider/aws: Enable DynamoDB Table to output `stream_arm` when streams
...
are enabled
2016-02-23 15:40:41 +00:00
b5e6a4fac7
Merge pull request #5101 from tpounds/fix-read-aws-asg-termination-policies
...
provider/aws: Fix reading auto scaling group termination policies
2016-02-23 08:03:18 -06:00
066a60debe
Add termination policies acceptance test.
2016-02-22 17:05:10 -08:00
b39cc55f37
Cleanup termination policy update logic.
2016-02-22 17:05:09 -08:00
44b00782c3
Fix termination policies read logic.
2016-02-22 17:05:09 -08:00
ce948c0dea
Merge pull request #5120 from paybyphone/paybyphone_igw_destroyfix
...
IGW detatch waiter tweak, 30 not found checks w/15 min max
2016-02-22 18:17:12 -06:00
9c0e52bc4b
Merge pull request #5100 from hashicorp/b-aws-sg-drift-updates
...
provider/aws: Security Group drift updates
2016-02-22 18:10:49 -06:00
57f58dec98
Merge pull request #5262 from stack72/b-aws-redshift-cluster-public
...
provider/aws: `aws_redshift_cluster` publicly_accessible now defaults true
2016-02-22 23:19:30 +00:00
e822d46843
provider/aws: `aws_redshift_cluster` publicly_accessible now defaults to
...
true
2016-02-22 23:11:55 +00:00
5528abb51e
Merge pull request #5255 from hashicorp/phinze/improve-vpc-cidr-errmsg
...
provider/aws: improve vpc cidr_block err message
2016-02-22 16:54:47 -06:00
ce74e3d8f0
provider/aws: improve vpc cidr_block err message
...
Pull CIDR block validation into a shared func ready to be used elsewhere
Example of new err message:
```
Errors:
* aws_vpc.foo: "cidr_block" must contain a valid network CIDR,
expected "10.0.0.0/16", got "10.0.1.0/16"
```
2016-02-22 16:44:33 -06:00
d5fb018250
Merge pull request #4945 from stack72/aws-rds-enhanced-monitoring
...
provider/aws: Enabled Enhanced Monitoring for RDS
2016-02-22 22:02:09 +00:00
a285ae1e2c
Fix format string making vet fail
2016-02-22 13:34:15 -05:00
16b18df1fd
Merge pull request #5238 from stack72/f-aws-redshift-calculate-cluster
...
provider/aws: Change Redshift Cluster cluster_type to be computed
2016-02-22 13:18:09 -05:00
30dcc45635
Merge pull request #5178 from hashicorp/f-aws-iam-server-updates
...
provider/aws: Update IAM Server Cert
2016-02-22 18:07:22 +00:00
c4dd1a9a64
Merge pull request #5197 from hashicorp/f-aws-db-snapshot-copy
...
provider/aws: Fix copy_tags_to_snapshot for DB Instance
2016-02-22 18:05:41 +00:00
0214319333
Merge pull request #4882 from stack72/f-aws-asg-getAutoscaleGroup
...
provider/aws: Autoscaling Group Code Refactor
2016-02-22 09:58:53 +00:00
f83c81dbb5
Change AWS ELB access_logs to list type.
...
There can only be a single access_log configuration per load balancer
so choosing to use a list over a set is only relevant when comparing
changes during a plan. A list makes it much easier to compare updates
since the index is stable (0 vs. computed hash).
2016-02-21 15:16:09 -08:00
1e7f10d3a3
Merge pull request #5066 from tpounds/fix-aws-elb-health-check-type
...
provider/aws: Change ELB health_check to list type
2016-02-21 22:38:10 +00:00
628fb1a37c
provider/aws: Add test to ECS Service to make sure deployment values are
...
set
2016-02-21 22:33:48 +00:00
5f7060e9f5
Merge branch 'ecs_service_deployment_cfg' of https://github.com/joshgarnett/terraform into joshgarnett-ecs_service_deployment_cfg
2016-02-21 22:09:20 +00:00
e6e18a4a9e
provider/aws: Change Redshift Cluster cluster_type to be computed
...
It will be based off the number of nodes. Can only be multi-node (>1
node) or single-node (nodes=1)
2016-02-21 19:42:02 +00:00
564dd360a2
provider/aws: Support additional changes to security groups of instance without forcing new
2016-02-21 14:24:33 +09:00
c91b648c15
core: Test fix for mismatched diffs from GH-4965
...
This test presents itself in an awkward manner as part of the AWS test
suite rather than the core test suite - this is because you cannot use
real providers in context tests because of circular references, and
simplistic test providers in that package do not demonstrate the issue.
In the interests of getting this fix in quickly and still having
regression coverage for it, it was agreed to include the change here
instead.
Running the test TestAccAWSVPC_coreMismatchedDiffs without the changes
in d95ab75d95ab75
2016-02-19 21:24:49 -05:00
280054a387
provider/aws: Security Rules drift and sorting changes
...
This commit adds failing tests to demonstrate the problem presented with AWS
aggregating the security group rules
2016-02-19 16:51:08 -06:00
12958fb5e7
Added support for the deployment configuration settings to the ecs service resource.
2016-02-19 15:32:39 -05:00
288ba868e4
Harden things around VPC config
2016-02-18 13:45:32 -08:00
ca29437581
provider/aws: Fix copy_tags_to_snapshot for DB Instance
2016-02-18 11:33:21 -06:00
f0f3c430a8
Generalize fix to ignore empty VPC config
2016-02-17 21:45:13 -05:00
eb2aaef016
VpcId can be nil in the wild
2016-02-17 20:06:18 -05:00
fce562ba0b
update name length
2016-02-17 17:03:31 -06:00
c8178ad31c
provider/aws: Update IAM Server Cert to allow name_prefix, auto generated namesprovider/aws: Update IAM Server Cert to allow name_prefix, auto generated namesdiff
2016-02-17 16:34:02 -06:00
f7504f7f9f
Merge branch 'master' of https://github.com/vincer/terraform into vincer-master
2016-02-17 13:16:16 -08:00
bc6107508d
Fix additional vet warnings
2016-02-17 11:59:50 -08:00
e130b2c2dc
Fix `go vet` printf verb warnings.
...
e.g. arg trail.LogFileValidationEnabled for printf verb %t of wrong type: *bool
2016-02-17 11:59:50 -08:00
37a708a2f0
Merge pull request #5155 from hashicorp/b-aws-route-error
...
provider/aws: Return an error if no route is found for an AWS Route
2016-02-17 10:02:48 -06:00
52e0cd82bd
Merge pull request #5116 from hashicorp/b-aws-acc-tests
...
provider/aws: Update some tests to introduce more randomization
2016-02-17 10:02:20 -06:00
35345c92af
fix: Return non-aws errors if bucket creation fails
2016-02-17 13:49:41 +00:00
cd28433c2a
Merge pull request #4826 from TimeIncOSS/f-aws-lambda-permission
...
[WIP] provider/aws: Add aws_lambda_permission
2016-02-17 13:31:29 +00:00
f8fac710ad
Randomize name of S3 bucket in acctest
2016-02-17 12:36:19 +00:00
db0d48eb84
Add retry-logic and mutexes to work around inconsistent nature of IAM
2016-02-17 11:38:24 +00:00
8481625596
Add retry logic to s3_bucket to prevent OperationAborted errors
2016-02-17 11:38:20 +00:00
ec0e445c25
Merge pull request #4973 from paultyng/pt/elasticsearch-tags
...
AWS - Tag support for Elasticsearch
2016-02-17 10:35:18 +00:00
a706b7c8a4
provider/aws: Return an error if no route is found for an AWS Route
2016-02-16 16:08:02 -06:00
77deff1194
Merge pull request #5135 from TimeIncOSS/f-aws-cloudtrail-tags
...
provider/aws: Add support for CloudTrail tags
2016-02-16 21:55:45 +00:00
3baabb0186
VPC config support in Lambda functions
...
fixes #5105
2016-02-16 10:43:51 -08:00
320dc3ddf4
provider/aws: Err on failure to attach elb in OpsWorks layer update
2016-02-16 10:31:30 -06:00
923f7dca37
Added error checking and removed debug statement
2016-02-16 09:44:15 -06:00
7293ab99d3
Added option to attach an ELB to Opsworks layer
2016-02-16 09:44:15 -06:00
b7a63c15f9
provider/aws: Add tests for new validators
2016-02-15 17:16:41 +00:00
d2a3799158
provider/aws: Add tests for aws_lambda_permission
2016-02-15 17:16:41 +00:00
64539d30bc
provider/aws: Add aws_lambda_permission
2016-02-15 17:16:41 +00:00
3f66347025
provider/aws: Add tests for CloudTrail tags
2016-02-15 14:10:36 +00:00
fb0838ce1b
provider/aws: Add support for CloudTrail tags
2016-02-15 14:10:19 +00:00
fdd9c3b2b8
Merge pull request #4711 from srikalyan/master
...
Added support for http/https endpoints that auto confirms SNS topic subscription.
2016-02-14 21:13:22 +00:00
345dbce77a
Made the necessary changes to ensure the variable name represents right value.
2016-02-13 12:15:29 -08:00
30082a4c85
provider/aws: Add acc tests for CloudWatch Event Target
2016-02-13 13:21:33 +00:00
61afc6d34d
provider/aws: Add CloudWatch Event Target
2016-02-13 13:21:33 +00:00
b5039dd897
provider/aws: Add acc tests for CloudWatch Event Rule
2016-02-13 13:21:33 +00:00
ab89e5e528
provider/aws: Add CloudWatch Event Rule
2016-02-13 13:21:32 +00:00
c24fbc3f24
IGW detatch waiter tweak, 30 not found checks w/15 min max
2016-02-12 17:31:49 -08:00
Paul Hinze