c030148259
helper/schema: allow pointer values to ResourceData.Set
2015-03-02 21:06:14 -08:00
2feaebdca5
config: substring containing computed value replaces element
2015-02-27 21:51:14 -08:00
c180487af6
helper/resource: allow configuration of not found checks in state change
2015-02-26 09:59:42 -08:00
0bc0c03fec
helper/schema: zero value set should set function [GH-1009]
2015-02-19 11:26:02 -08:00
9b8b38cbb1
helper/schema: test that set can be nil
2015-02-18 14:59:55 -08:00
e4f0f6b15d
helper/schema: more tests
2015-02-18 14:44:46 -08:00
dd00001c9a
helper/schema: tests that all pass as I was trying to track down a bug
2015-02-18 14:10:12 -08:00
17680bb7ff
helper/schema: some more test cases, revert some weird behavior from
...
dbfb95fcd5
2015-02-18 12:54:46 -08:00
659a77c6ae
helper/schema: validate subresources more effectively
2015-02-18 09:41:55 -08:00
fa7f496bef
helper/schema: zero value of a set should be empty
2015-02-17 16:58:47 -08:00
7d32c8946a
helper/schema: GetOk now only returns true if set to non-zero value
2015-02-17 16:55:39 -08:00
e04def93e6
Merge pull request #991 from hashicorp/b-autoscale-lc-update
...
providers/aws: allow in-place update of launch configuration
2015-02-17 16:29:56 -08:00
faec39b8c1
Merge pull request #990 from hashicorp/b-set-change
...
helper/schema: GetChange shouldn't return true when no change
2015-02-17 16:17:44 -08:00
5a64d0900b
providers/aws: test for allowing in-place lC update
2015-02-17 16:12:02 -08:00
66f7731995
helper/schema: GetChange shouldn't return true when no change
2015-02-17 15:43:19 -08:00
5c06cc386a
helper/schema: empty map values should show up in diff [GH-968]
2015-02-17 15:22:45 -08:00
e9778c85a5
helper/schema: clarify test
2015-02-17 14:46:24 -08:00
dbfb95fcd5
helper/schema: show in diff when no config is going to empty set
2015-02-17 14:45:18 -08:00
fd274d7328
helper/schema: update test desc
2015-02-17 13:17:23 -08:00
bcdec738d4
helper/schema: default the new value to zero only for the decode
2015-02-17 13:16:59 -08:00
ad6be99f5b
helper/schema: failing test
2015-02-17 13:15:30 -08:00
2ee2b9e26f
Merge pull request #986 from hashicorp/b-remove-set
...
helper/schema: Diff with set going to 0 elements removes it from state
2015-02-17 11:50:50 -08:00
2212d6895d
helper/schema: diff with set going to 0 elements removes it from state
2015-02-17 11:38:56 -08:00
c22ba7d3a8
helper/schema: fix test index
2015-02-17 11:14:04 -08:00
cbcfb26ec6
helper/schema: add test for sets
2015-02-17 11:12:45 -08:00
b778a65a83
helper/schema: diff of zero value in state with lack of value should not
...
diff
2015-02-17 11:10:45 -08:00
61215d8826
Merge pull request #919 from ceh/url-helper
...
helper/url: add "Windows-safe" URL Parse wrapper
2015-02-17 09:26:55 -08:00
4c7b732dad
typo
2015-02-11 14:49:50 -08:00
5602348695
formatting, cleanups
2015-02-11 11:40:49 -08:00
a5040ecc03
Update hashcode to always generate a positive
2015-02-11 10:59:21 -08:00
e7bbbfb098
helper/url: add Windows 'safe' URL Parse wrapper
...
Pull out the urlParse function, which was introduced in config/module,
into a helper package.
2015-02-05 11:16:54 +01:00
26156981d7
Merge pull request #917 from methane/fix-stringer
...
Fix stringer error on helper/schema/schema.go
2015-02-04 10:09:53 -06:00
4e8e3dad86
DiffFieldReader: filter all '#' fields from sets
...
Now that readMap filters out '#' fields, when maps are nested in sets,
we exposed a related bug where a set was iterating over nested maps and
expected the '#' key to be present in those nested maps.
By skipping _all_ count fields when iterating over set keys, all is
right with the world again.
2015-02-04 09:25:45 -06:00
219aa3e788
helper/schema: fix DiffFieldReader map handling
...
An `InstanceDiff` will include `ResourceAttrDiff` entries for the
"length" / `#` field of maps. This makes sense, since for something like
`terraform plan` it's useful to see when counts are changing.
The `DiffFieldReader` was not taking these entries into account when
reading maps out, and was therefore incorrectly returning maps that
included an extra `'#'` field, which was causing all sorts of havoc
for providers (extra tags on AWS instances, broken google compute
instance launch, possibly others).
* fixes #914 - extra tags on AWS instances
* fixes #883 - general core issue sprouted from #757
* removes the hack+TODO from #757
2015-02-03 20:17:57 -06:00
f6367a779a
regenerate with new stringer.
2015-02-04 01:54:14 +09:00
33aa9d3ee8
Fix stringer error on helper/schema/schema.go
2015-02-03 19:33:01 +09:00
aa2015ccd0
Fix failing tests
2015-01-28 16:20:14 -05:00
3cbf1a3230
Fix missing import of math
2015-01-28 15:39:32 -05:00
319933f551
Add some tests for TypeFloat
2015-01-28 15:22:47 -05:00
18c26cb2eb
Add some missing Float cases
2015-01-28 12:53:34 -05:00
5d4e69cc80
helper/schema: apply schema defaults at the field level when reading from config
...
We were waiting until the higher-level (m schemaMap) diffString method
to apply defaults, which was messing with set hashcode evaluation for
cases when a field with a default is included in the hash function.
fixes #824
2015-01-27 18:18:57 -06:00
0a7dea5532
Improve readability and purpose of multi-env default test
2015-01-22 16:09:25 -05:00
072a1cf353
Read the "standard" AWS environment variables
...
This is 100% backwards-compatible
2015-01-22 16:09:25 -05:00
466a54cfe4
Merge pull request #766 from hashicorp/f-exists-api
...
helper/schema: Exists API
2015-01-16 10:56:25 -08:00
41029f8daa
helper/schema: tests for EnvDefaultFunc
...
/cc @jefferai - In case you care
2015-01-16 10:54:43 -08:00
b3e77ef244
Merge pull request #825 from jefferai/envdefault
...
Move duplicated envDefaultFunc out of each provider and into Schema.
2015-01-16 10:50:43 -08:00
87948b68fc
helper/schema: use interface for equality check
...
/cc @svanharmelen
2015-01-16 09:32:15 -08:00
f2bd1f45ab
Move duplicated envDefaultFunc out of each provider and into Schema.
2015-01-16 17:25:39 +00:00
8cba4a40f5
Merge pull request #821 from svanharmelen/b-core-haschange-getchange
...
core: fixing two related bugs in HasChange and GetChange
2015-01-16 09:10:06 -08:00
e32cd396ad
helper/schema: add test for GH-814
2015-01-16 08:37:25 -08:00
c7550595a3
Fixing two related bugs in HasChange and GetChange
...
This was actually quite nasty as the first bug covered the second one…
The first bug is with HasChange. This function uses reflect.DeepEqual
to check if two instances are the same/have the same content. This
works fine for all types except for Set’s as they contain a function.
And reflect.DeepEqual will only say the functions are equal if they are
both nil (which they aren’t in a Set). So in effect it means that
currently HasChange will always say true for Set’s, even when they are
actually being equal.
As soon as you fix this problem, you will notice the second one (which
the added test is written for). Without saying you want the exact diff,
you will end up with a merged value which will (in most cases) be the
same.
Run all unit tests and a good part of the acc tests to verify this
works as expected and all look good.
2015-01-16 14:13:40 +01:00
2edfd0e89d
Just my OCD playing up 😉
2015-01-16 13:30:11 +01:00
2769d7cf9c
Fixes #813 : Ensuring set count (.#) is written to the state
2015-01-16 03:43:57 -08:00
f870eff5f9
core: fix for #813 - added a gaurd for interface conversion
2015-01-16 00:16:38 -08:00
448887f3c4
helper/schema: map counts in state
2015-01-15 14:12:24 -08:00
22436555a7
helper/schema: test setting computed value and retrieving it via state
2015-01-15 11:08:06 -08:00
4d067f4d6d
helper/schema: don't put things into the state that don't exist or are
...
computed [GH-805]
2015-01-15 10:35:44 -08:00
133a40d77f
Sets should init only once...
...
Currently the `sync.Once` call is only used to init a Set in the add()
func. So when you add a value to a Set that is the result of one of the
Set operations (i.e. union, difference, intersect) the Set will be
reinitialised and the exiting values will be lost.
I don’t have a clue why this is showing up in my ACC tests just now, as
this code is in there for quite some time already. Somehow it seems to
have something to do with the refactoring of the helper/schema done
last week, as I cannot reproduce this with
47f02f80bc
2015-01-15 15:33:52 +01:00
2abeb2d9ac
config: use new API
2015-01-14 22:03:15 -08:00
db02541d31
helper/schema: fix failing tests
...
/cc @svanharmelen - I think some logic changed after my refactor. I now
return Exists: true when Computed: true but the value might be blank to
note that the FieldReader FOUND a value, its just unknown. I think
before it didn't do that so the logic for GetOk has to be "does it exist
and is it _not_ computed"
Seems weird because I just realized there is no way to get the OLD value
of something if it is being computed now, but I looked and there are
tests that verify this and they're like... test #5 of Get. So, they're
not new meaning that must've been expected behavior? Hm. Let me know if
you find any other issues from acceptance tests
2015-01-14 15:38:18 -08:00
05de36b4ea
Merge pull request #796 from svanharmelen/f-test-issue-791
...
Adding a test for issue #791
2015-01-14 15:31:28 -08:00
d3c0543bf3
Merge pull request #797 from hashicorp/f-stronger-types
...
Force variables to be typed (internally)
2015-01-14 15:30:38 -08:00
e00ee1e5ee
helper/diff: fix failing test
2015-01-14 15:29:56 -08:00
dbe83af829
helper/schema: fix failing tests
2015-01-14 15:28:36 -08:00
cb37e10c6f
Adding a test for issue #791
...
Running this test on commit 47f02f80bc
2015-01-14 20:50:58 +01:00
241fc5bb39
helper/schema: diff floats properly
...
/cc @phinze - This is pretty straightforward, almost magically so. The
reason this works is because in `diffString` we use mapstructure[1] with
"weak decode mode" to just be responisble for turning anything into a
string.
[1]: https://github.com/mitchellh/mapstructure
2015-01-14 09:32:03 -08:00
6fadebc5d8
Merge pull request #769 from phinze/type-float-failing-diff-test
...
failing schema diff test for TypeFloat
2015-01-14 09:30:08 -08:00
5e8b300ca1
update CHANGELOG
2015-01-14 09:29:37 -08:00
2bc612e6f8
helper/schema: fix panic when validating composite type
...
Don't check if the root key is being computed for composite types.
Instead, continue recursing the composite type in order to check if
the sub-key, key.N, for each individual element is being computed.
Fixes a panic which occurs when validating a composite type where
the value is an unknown kind for the schema.
2015-01-13 06:59:05 +01:00
bcac8c64bd
failing schema diff test for TypeFloat
...
refs #768
2015-01-11 14:51:48 -06:00
1fcd24cf67
helper/schema: add float type
2015-01-10 16:04:01 -08:00
cf94a79955
helper/schema: add TypeFloat and Zero value
2015-01-10 15:57:06 -08:00
34617b337f
helper/schema: remove commit not for this branch
2015-01-10 15:53:29 -08:00
689cbc8b5b
helper/schema: generate strings for ValueType
2015-01-10 15:52:11 -08:00
48b9614556
helper/schema: Exists API
2015-01-10 15:39:29 -08:00
3cbcafe989
helper/schema: remove unused field
2015-01-10 12:50:53 -08:00
361d00347a
helper/schema: refactor tests for fieldreader to be common
2015-01-10 12:42:15 -08:00
9ab128899a
helper/schema: make the getSource enum easier
2015-01-10 12:25:34 -08:00
d89446391a
helper/schema: make the get API cleaner
2015-01-10 12:22:05 -08:00
3c1b55a75f
helper/schema: use the field reader/writer for state
2015-01-10 12:18:32 -08:00
f64b09a045
helper/schema: more tests
2015-01-10 11:49:37 -08:00
e77b2b17c4
helper/schema: remove unused method
2015-01-10 11:46:09 -08:00
03c6453a72
helper/schema: FieldWriter, replace Set
2015-01-10 11:44:26 -08:00
e9a4aaaca7
helper/schema: full object test for addrToSchema
2015-01-09 17:43:44 -08:00
e57f3f69b1
helper/schema: empty maps, support reading objects directly
2015-01-09 15:07:02 -08:00
f0af1c36f5
helper/schema: nested resource fields should be zero-valued on get
2015-01-09 11:51:29 -08:00
942a988ac2
helper/schema: zero value of a set should be a set
2015-01-08 18:48:03 -08:00
b4bf813151
helper/schema: too big to fail
2015-01-08 18:02:19 -08:00
864a8f24ec
helper/schema: GoString for Set
2015-01-08 11:33:15 -08:00
7e379cb1a1
helper/schema: field readers no longer take a schema as arg
2015-01-03 12:13:46 -05:00
3ff859d734
helper/schema: MultiLevelFieldReader
2015-01-03 10:32:24 -05:00
0b1da37b20
helper/schema: diff field reader should merge result with source
2015-01-03 09:55:38 -05:00
91a57b42e8
helper/schema: reading a diff with computed should return zero value
2015-01-03 12:02:49 +05:30
73726e83b2
helper/schema: DiffFieldReader for reading data from a diff
2014-12-20 02:17:35 +05:30
9447973015
helper/schema: ConfigFieldReader and generic helpers
2014-12-19 22:52:53 +05:30
5f063d321f
helper/schema: FieldReader needs to return computed status
2014-12-19 06:15:04 -05:00
f416e0edf0
helper/schema: FieldReader and MapFieldReader
2014-12-19 05:56:46 -05:00
e8ac16b2df
helper/schema: test for empty state
2014-12-16 15:56:40 -08:00
df05483cf6
helper/schema: test pass from SvH
2014-12-16 09:05:16 -08:00
913f9a923e
helper/schema: remove unnecessary code
2014-12-15 17:39:07 -08:00
Mitchell Hashimoto