Commit Graph

7026 Commits

Author SHA1 Message Date
Paul Hinze 193c0d80ad
provider/aws: Validate GovCloud KMS ARNs
Fixes validation errors in GovCloud when passing a KMS ARN for
`kms_key_id` in `s3_bucket_object` and `db_instance`.

The region is `us-gov-west-1` which breaks the regexp. Just added the
optional `gov-` in the right place.
2017-04-16 22:35:09 -07:00
Paul Tyng b8b896e11b Update go-newrelic vendor and use new field (#13158)
Fixes #12972
2017-04-17 01:59:11 +03:00
Kent Wang 8927ad5dce provider/alicloud: Fix allocate public ip error (#13267) (#13268)
Wait for instance to be in STOPPED or RUNNING state before invoking
AllocatePublicIP API.

* provider/alicloud: Wait for instance state before allocate public ip

* provider/alicloud: Fix test `TestAccAlicloudInstance_associatePublicIP`

* provider/alicloud: Update alicloud_instance document

Fixes: #13267
2017-04-17 01:52:39 +03:00
Joshua Spence 8d5fdeae57 Add `name_prefix` support to `aws_cloudwatch_log_group` (#13273) 2017-04-17 01:50:52 +03:00
Kit Ewbank da7041f4be Remove aws_network_acl_rule if not found. (#13608) 2017-04-17 01:39:42 +03:00
Tom Harvey f7f800bdfb provider/azurerm: VM Scale Sets - import support + fixes (#13464)
* Ensuring we base64 decode the custom data if it's base64 encoded

* Import support for VM Scale Sets

* Updating the docs to mention Import support

* Fixes #13009, where the SSH Keys would be set at the incorrect index

(leaving a null entry at the start, causing a crash on the second apply)

* Adding tests to cover the updating use-case

* Adding an import linux test

* Storing the base64 encoded value
Making custom_data a force new, since it an't be updated

* Updating the docs
2017-04-17 01:37:28 +03:00
Joe Topjian 1af649ed5a provider/openstack: Ignore fixed_ip when importing ports (#13563) 2017-04-17 01:36:15 +03:00
Kit Ewbank 5c3438e394 Remove aws_vpc_dhcp_options if not found. (#13610) 2017-04-17 01:31:43 +03:00
Kent Wang 4c25e1e269 provider/alicloud: Fix create PrePaid instance (#13661) (#13662)
Fixes: #13661
2017-04-17 01:26:06 +03:00
Gavin Williams c63ad9c0f8 state/remote/swift: Support Openstack request logging (#13583)
* provider/openstack: Expose LogRoundTripper fields externally

* state/remote/swift: Add support for debugging Openstack calls using
OS_DEBUG env variable.

* provider/openstack: Update LogRoundTripper to log headers aswell as body.

* Add `RedactHeaders` function in order to redact sensitive http Headers.
Refactor `logRequest` and `logResponse` to use `RedactHeaders` func.
2017-04-15 17:11:28 +03:00
Radek Simko 9504682831 aws: Increase default number of retries to 25 (#13673) 2017-04-15 07:56:41 +01:00
Sander van Harmelen 10c6c873ed provider/aws: add an option to skip getting the EC2 platforms (#13672)
* Add an option to skip getting the EC2 platforms

Even through this call fails silently in case of an error (usually lack of rights), it’s still a pretty extensive call.

In our region (eu-west-1) this can take up to 3 seconds. And since we have a system that involves doing much planning with the option `-refresh=false` these additional 3 seconds are really very annoying and totally not needed.

So being able to choose to skip them would make our lives a little better 😉

* Update the docs accordingly
2017-04-14 23:41:59 +02:00
Radek Simko 43d5b82f30 provider/aws: Use mutex & retry for WAF change operations (#13656) 2017-04-14 21:12:04 +01:00
clint shryock 46809cc2cc provider/aws: randomize ECS name 2017-04-14 14:13:09 -05:00
clint shryock 41baf7d811 provider/aws: Wait for snapshotting in delete of ElastiCache cluster 2017-04-14 12:54:38 -05:00
Jake Champlin ac379e19a7 Merge pull request #13279 from joshuaspence/db_param_group_name
Fix DB parameter group name property
2017-04-14 12:16:18 -04:00
Matthew Frahry 2ff8d58020 Merge pull request #13646 from hashicorp/p-aws-route53-test-fix
Update resource_aws_route53_zone_association_test.go
2017-04-14 08:23:53 -06:00
Josh VanderLinden 24e857ae96 azurerm_redis_cache resource missing hostname (#13650)
* Fix Azure Redis Cache hostname attribute

* Fix inaccurate Azure Redis Cache docs
2017-04-14 11:49:49 +03:00
Dana Hoffman ae5332b42c provider/google: Unset the id for resource_google_project if the create operation fails (#13644) 2017-04-13 16:16:47 -07:00
Matthew Frahry c394e5d653 Update resource_aws_route53_zone_association_test.go 2017-04-13 16:44:19 -06:00
Mathieu Herbert 25cbbdea8a provider/google: datasource subnetwork and network (#12442)
* first version of this datasource

* add network and subnetwork datasource and documentation

* modify sidebar reference in documentation

* fix elements after review on network and subnetwork datasources

* fix fmt on Google provider.go

* modify code with the review

* modify documentation layout order

* fix alphabetic order in provider.go

* fix rebase issue and documentation datasource => data
2017-04-13 13:25:29 -07:00
clint shryock aeb97165d6 Merge branch 'master' of github.com:hashicorp/terraform
* 'master' of github.com:hashicorp/terraform:
  provider/google: bump container cluster version in tests.
2017-04-13 15:24:28 -05:00
clint shryock 89edd2859c fix go fmt errors, my bad 2017-04-13 15:24:18 -05:00
Paddy a00dafd2c6 Merge pull request #13635 from hashicorp/paddy_fix_node_version
provider/google: bump container cluster version in tests.
2017-04-13 13:23:47 -07:00
clint shryock 923587a0c9 provider/aws: Randomize and fix Dynamo DB test table names 2017-04-13 15:17:48 -05:00
Clint baaf6f5de6 provider/aws: Fix some acc tests (more, again) (#13639)
* add check destroy to subnet data source tests

* provider/aws: Fix TestAccAWSElasticacheCluster_snapshotsWithUpdates by waiting for snapshots

* provider/aws: Fix TestAccAWSRDSCluster_takeFinalSnapshot

* provider/aws: Fix TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates by specifying instance type
2017-04-13 15:00:41 -05:00
Joe Topjian 6efd0640ec Openstack port update fixes (#13604)
* provider/openstack: Handle 409 Errors Upon Security Group Deletion

If a security group is currently in use, it will throw a 409 error.
This commit catches the 409, allowing other resources to finish
deleting.

* Update openstack_networking_port_v2 resource to pass empty arrays for AllowedAddressPairs and SecurityGroups if not specified. Fixes #13531

* provider/openstack: Port Update comment
2017-04-13 13:37:15 +02:00
Paddy d34006bbbf Merge pull request #13270 from JDiPierro/google_address_importability
Google address importability
2017-04-12 15:46:08 -07:00
Dana Hoffman 11a20ddb53 provider/google: Add node_pool field in resource_container_cluster. (#13402) 2017-04-12 12:57:53 -07:00
Paddy dea8b267a9 provider/google: bump container cluster version in tests.
The version we were using has been deprecated and is no longer
available, making the withVersion test no longer pass. I've bumped it to
the latest available version.
2017-04-12 12:38:45 -07:00
Clint 9ef9501e65 provider/aws: Fix EMR Bootstrap Action Ordering (#13580)
* provider/aws: Add failing test for EMR Bootstrap Actions

* aws_emr_cluster: Fix bootstrap action parameter ordering

* provider/aws: Fix EMR Bootstrap arguments

* provider/aws: Args needs to be ForceNew, because we can't update them
2017-04-12 14:19:38 -05:00
Jake Champlin e676a72d3b Merge pull request #13577 from hashicorp/f-add-codecommit-import
provider/aws: Add import to codecommit_repository
2017-04-12 14:51:52 -04:00
Paul Stack 00e8986357 provider/dnsimple: Handle 404 on DNSimple records (#13131)
When a record was manually deleted from the console, we got an error
saying 404 Record Not Found

//cc @weppos

This PR now handles the usecase:

```
% make testacc TEST=./builtin/providers/dnsimple
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/28 21:48:19 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/dnsimple -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDNSimpleRecord_Basic
--- PASS: TestAccDNSimpleRecord_Basic (1.81s)
=== RUN   TestAccDNSimpleRecord_CreateMxWithPriority
--- PASS: TestAccDNSimpleRecord_CreateMxWithPriority (1.32s)
=== RUN   TestAccDNSimpleRecord_Updated
--- PASS: TestAccDNSimpleRecord_Updated (4.46s)
=== RUN   TestAccDNSimpleRecord_disappears
--- PASS: TestAccDNSimpleRecord_disappears (1.20s)
=== RUN   TestAccDNSimpleRecord_UpdatedMx
--- PASS: TestAccDNSimpleRecord_UpdatedMx (2.91s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/dnsimple	11.723s
```
2017-04-12 20:49:04 +02:00
Jake Champlin 057c58ccd8 Merge pull request #13581 from hashicorp/b-fix-cloudinit-config-panic
provider/template: Fix panic in cloudinit config
2017-04-12 14:48:15 -04:00
Radek Simko 4606090c32 provider/aws: Add support for api_gateway_method_settings (#13542) 2017-04-12 16:13:33 +01:00
Jake Champlin 82a7d4b4a5
cleanup imports 2017-04-12 10:49:52 -04:00
Jake Champlin 53fe7c2293
provider/template: Fix panic in cloudinit config
Fixes an uncaught panic during an interface cast in the `template_cloudinit_config` data source.

Fixes: #13572

```
$ make test TEST=./builtin/providers/template TESTARGS="-v -run=TestRender_handlePanic"
==> Checking that code complies with gofmt requirements...
==> Checking AWS provider for unchecked errors...
==> NOTE: at this time we only look for uncheck errors in the AWS package
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/12 10:46:33 Generated command/internal_plugin_list.go
go test -i ./builtin/providers/template || exit 1
echo ./builtin/providers/template | \
                xargs -t -n4 go test -v -run=TestRender_handlePanic -timeout=60s -parallel=4
go test -v -run=TestRender_handlePanic -timeout=60s -parallel=4 ./builtin/providers/template
=== RUN   TestRender_handlePanic
--- PASS: TestRender_handlePanic (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/template       0.028s
```
2017-04-12 10:48:53 -04:00
Jake Champlin 3cd125a901
provider/aws: Add import to codecommit_repository
Adds import capability to the `aws_codecommit_repository` resource.

Also fixes an issue in the Read function where both `description` and `resource_name` attributes weren't being updated and set in the Schema.

Fixes: #13559

```
$ make testacc TEST=./builtin/providers/aws TESTARGS="-run=TestAccAWSCodeCommitRepository"
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/12 10:14:44 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCodeCommitRepository -timeout 120m
=== RUN   TestAccAWSCodeCommitRepository_importBasic
--- PASS: TestAccAWSCodeCommitRepository_importBasic (16.11s)
=== RUN   TestAccAWSCodeCommitRepository_basic
--- PASS: TestAccAWSCodeCommitRepository_basic (14.97s)
=== RUN   TestAccAWSCodeCommitRepository_withChanges
--- PASS: TestAccAWSCodeCommitRepository_withChanges (26.71s)
=== RUN   TestAccAWSCodeCommitRepository_create_default_branch
--- PASS: TestAccAWSCodeCommitRepository_create_default_branch (14.34s)
=== RUN   TestAccAWSCodeCommitRepository_create_and_update_default_branch
--- PASS: TestAccAWSCodeCommitRepository_create_and_update_default_branch (27.90s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    100.071s
```
2017-04-12 10:18:49 -04:00
Jake Champlin c5a87af219 Merge pull request #13548 from hashicorp/b-fix-route-table-panic
provider/aws: Fix panic on nil route configs
2017-04-12 09:25:05 -04:00
Jake Champlin 1cb1342a2b
Clarify test is for panic fix
point to github issue
2017-04-12 09:24:42 -04:00
Tom Harvey 8493155dd0 Merge pull request #13570 from hashicorp/azurerm-eventhub-location
provider/azurerm: Event Hubs making the Location field idempotent
2017-04-12 12:33:03 +01:00
Matthew Frahry a5bb9f1e74 Merge pull request #13554 from hashicorp/p-randomize-triton-tests
Fixes TestAccTritonMachine_addNIC and TestAccTritonMachine_nic
2017-04-12 05:25:34 -06:00
tombuildsstuff 70e69a7387 Ensuring we output the error when things fail 2017-04-12 11:44:07 +01:00
Radek Simko 5f02c0b61a provider/aws: Add support for api_gateway_stage (#13540) 2017-04-12 08:35:00 +01:00
Radek Simko 1cf0cd87cb provider/kubernetes: Add support for persistent_volume_claim (#13527) 2017-04-12 08:33:26 +01:00
tombuildsstuff 01c8b0197c Switching to use the locationSchema for Event Hub Consumer Groups 2017-04-12 00:25:30 +01:00
tombuildsstuff 27e1b28b34 Making use of the Location Schema 2017-04-12 00:11:46 +01:00
= 2e19cf5ad3 Fixes TestAccTritonMachine_addNIC and TestAccTritonMachine_nic 2017-04-11 15:10:13 -06:00
= 4369a6e728 Fixes TestAccDataSourceAwsSubnet 2017-04-11 13:43:21 -06:00
= 3421fa8217 Fixes TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging 2017-04-11 13:02:10 -06:00