Commit Graph

51 Commits

Author SHA1 Message Date
Paul Stack 5ecc8e3169 provider/aws: `aws_db_instance` now defaults `publicly_accessible` to (#7117)
false

Fixes #7035

A known issue in Terraform means that d.GetOk() on a bool which is false
will mean it doesn't get evaulated. Therefore, when people set
publicly_accessible to false, it will never get evaluated on the Create

We are going to make it default to false now
2016-06-10 23:55:36 +02:00
stack72 b3d680eee0 Merge branch 'master' of https://github.com/statoilfuelretail/terraform into statoilfuelretail-master 2016-06-02 18:06:37 +01:00
Paul Stack 890eebabc4 provider/aws: Add note to AWS DB Instance Documentation about skip_final_snapshot (#6799) 2016-05-20 12:33:25 -05:00
Paul Stack cf37c3adaa provider/aws: Add support for `kms_key_id` to `aws_db_instance` (#6651)
As requested in #4822, add support for a KMS Key ID (ARN) for Db
Instance

```
make testacc TEST=./builtin/providers/aws
TESTARGS='-run=TestAccAWSDBInstance_kmsKey' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v
-run=TestAccAWSDBInstance_kmsKey -timeout 120m
=== RUN   TestAccAWSDBInstance_basic
--- PASS: TestAccAWSDBInstance_basic (587.37s)
=== RUN   TestAccAWSDBInstance_kmsKey
--- PASS: TestAccAWSDBInstance_kmsKey (625.31s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    1212.684s
```
2016-05-13 11:20:29 -05:00
Paul Hinze 4e5429a140 provider/aws: ability to generate unique RDS identifier
Needed to truncate the identifier for SQL Server engines to keep it at
max 15 chars per the docs. Not a full UUID going into it, but should be
"unique enough" to not matter in practice.

Modified the basic test to use the generated value. Other tests are
still working w/ explicitly specified identifiers.
2016-03-18 16:07:37 -05:00
Andy Chan 1fb74416ac Added the missing tags params to the doc 2016-03-16 16:20:40 -07:00
stack72 e87d3bb711 Enabled Enhanced Monitoring for RDS 2016-02-03 00:14:24 +00:00
Lars Bahner 9e3cef3ce5 Fixed typo in documentation. 2016-01-27 21:20:18 +01:00
Lars Bahner 8f2d39be45 On Oracle RDS DB instances you can't change the encoding
of the database after creation. So we need to be able to
set the CharacterSetName on creation.
This is an option and will automagically default to
AL32UTF8.

The AWS SDK will give you an error message if you try to
apply this setting to other engines. The patch will only
report the character_set_name attribute, if CharacterSetName
is set on the instance.

Signed-off-by: Lars Bahner <lars.bahner@gmail.com>
2016-01-27 18:39:00 +01:00
Seth Vargo 8dbc43639d Use HTTPS + www. for links 2016-01-14 16:03:26 -05:00
Koen De Causmaecker 45ef11e59f provider/aws: aws_db_instance: unrequire fields
When spinning up from a snapshot or a read replica, these fields are
now optional:
* allocated_storage
* engine
* password
* username

Some validation logic is added to make these fields required when
starting a database from scratch.
The documentation is updated accordingly.
2016-01-13 15:40:15 +01:00
kozo yamagata 2a3c80461f Fix typo 'auto' => 'allow' 2015-12-30 16:58:23 +09:00
clint shryock a5efa4a1fa Better document RDS apply immediately 2015-12-18 11:24:59 -06:00
stack72 2b0c7aa4e9 Making the changes to db_instance skip_final_snapshot on the feedback from @catsby 2015-12-10 23:21:36 +00:00
stack72 5796b13373 Adding skip_final_snapshop bool to th db_instance. This will allow us to specify whether a snapshot is needed directly rather than checking for an empty string 2015-12-10 19:11:47 +00:00
Clint ced42342ff Merge pull request #4215 from hashicorp/pr-4207
Fix issue creating AWS RDS replicas across regions
2015-12-09 09:54:53 -06:00
clint shryock 0619898f6a provider/aws: Add arn to DB Instance output 2015-12-08 10:52:17 -06:00
stack72 a0a89ecde8 Documenting the version upgrade flags on db_instance 2015-12-08 14:13:26 +00:00
James Nugent ca442bf00b Merge pull request #3818 from ijin/patch-1
provider/aws: Document `license_model` as supported argument for db_instance
2015-11-10 17:40:15 -05:00
stack72 1abb0b19bf Changing the db_instance resource to mark the engine_version as Optional 2015-11-10 17:30:09 +00:00
Michael H. Oshita 22876be830 Document `license_model` as supported argument
Required for Oracle SE1
2015-11-10 14:31:55 +09:00
clint shryock 20bc0ca3cd document copy_tags 2015-10-16 11:20:24 -05:00
Mike Fiedler 10c96afa9b Update aws_db_instance `db_subnet_group_name`
When launching a new RDS instance in a VPC-default AWS account, trying to control which VPC the new RDS instance lands in is not apparent from the parameters available.
The following works:
```
resource "aws_db_subnet_group" "foo" {
  name = "foo"
  description = "DB Subnet for foo"
  subnet_ids = ["${aws_subnet.foo_1a.id}", "${aws_subnet.foo_1b.id}"]
}

resource "aws_db_instance" "bar" {
...
  db_subnet_group_name   = "${aws_db_subnet_group.foo.name}"
...
}
```

Hopefully this doc update will help others
2015-09-08 09:10:54 -04:00
Adam Enger d206d6d5d8 Adding snapshot_identifier to db_instance docs 2015-06-30 15:33:13 -05:00
Jason Gedge 11b136f503 Grammar fix in the aws_db_instance docs. 2015-06-15 13:32:30 -04:00
Andrew Langhorn 70c90f420e Clarify syntax for RDS maintenance window param
Closes #2069
2015-06-02 07:44:09 +01:00
Radek Simko ff2f446eb4 aws_db_instance docs updated per #2070 2015-05-26 00:14:44 +01:00
Radek Simko d569e14121 Merge pull request #2070 from managedbyq/master
providers/aws: Clarifies db_security_group usage docs.
2015-05-25 16:10:49 -07:00
Camilo Aguilar e94a8b2627 providers/aws: Adds link to AWS docs about RDS parameters. 2015-05-25 18:57:23 -04:00
Andrew Langhorn b451eed453 "More more" no more!
We don't need to say "for more for more" here, because it
doesn't make sense. Fixes this.
2015-05-25 15:37:49 +01:00
Clint Shryock 729238675b update docs 2015-05-21 15:06:22 -05:00
Clint Shryock 6de8f9d180 provider/aws: RDS Read Replica cleanups
remove typos, debugging, and try spelling things correctly
2015-05-21 09:49:46 -05:00
Clint Shryock d755fbd347 provider/aws: Add docs for AWS RDS Read Replicate 2015-05-20 08:24:36 -05:00
Nick HS 39598cf1fa Rename False to false in aws_db_instance
False isn't allowed in hcl, just fixing a typo
2015-04-03 15:19:41 -04:00
Clint Shryock e485767694 provider/aws: Add non-destructive updates to AWS RDS
This introduces non-destructive, in-place upgrades to MultiAZ and Engine Version
attributes of AWS RDS instances.
2015-03-31 09:41:37 -05:00
Clint Shryock 64f7e6a19c Update website docs on AWS RDS encryption field 2015-03-11 13:37:56 -05:00
Clint Shryock d79b0d7fd1 provider/aws: Convert AWS DB Instance over to awslabs/aws-sdk-go
- Remove check on password for AWS RDS Instance
- Update documentation on AWS RDS Instance regarding DB Security Groups
- Change error handling to check error code from AWS API [ci skip]
2015-02-24 16:51:47 -06:00
Phil Frost bfaf8ccee6 Support storage_type parameter for aws_db_instance
This allows provisioning "gp2" (general purpose SSD) storage for DB
instances.
2015-01-30 13:01:10 -05:00
Phil Frost 254b25a64f Fix aws_db_instance to not recreate each time
Several of the arguments were optional, and if omitted, they are
calculated. Mark them as such in the schema to avoid triggering an
update.

Go back to storing the password in the state file. Without doing so,
there's no way for Terraform to know the password has changed. It should
be hashed, but then interpolating the password yields a hash instead of
the password.

Make the `name` parameter optional. It's not required in any engine, and
in some (MS SQL Server) it's not allowed at all.

Drop the `skip_final_snapshot` argument. If `final_snapshot_identifier`
isn't specified, then don't make a final snapshot. As things were, it
was possible to create a resource with neither of these arguments
specified which would later fail when it was to be deleted since the RDS
API requires exactly one of the two.

Resolves issue #689.
2015-01-28 12:03:26 -05:00
Mitchell Hashimoto 577e2420b0 Revert "docs: consistent use of array configuration syntax"
This reverts commit 4893eb8b55.
2015-01-14 09:28:25 -08:00
Emil Hessman 4893eb8b55 docs: consistent use of array configuration syntax
The Terraform configuration syntax defines what arrays are.
Use the word array consistently throughout the documentation
instead of list.

The corresponding JSON datatype is called array as well, and
since the Terraform configuration syntax is interoperable with
JSON it makes sense to use the term array to describe them.
2015-01-13 06:59:12 +01:00
Rob Costanzo de16b10555 Added new aws_db_parameter_group resource for creating RDS DB Parameter Groups.
Added plumbing to allow an optional DBParameterGroupName to be passed when creating an RDS DB instance.
2014-11-05 11:03:06 -08:00
balser e915807efe Fix typo in aws_db_instance example 2014-10-27 17:48:03 -04:00
Seth Vargo 073a0f76c5 Add meta descriptions to all pages 2014-10-21 23:21:56 -04:00
Matthieu Fronton e7925bad15 website: fix misspelled argument name for aws_db_instance resource 2014-10-21 07:52:32 -04:00
Mitchell Hashimoto 6ddcc2ebf8 Merge pull request #309 from alekstorm/aws-db-instance-password
Store aws_db_instance.password in tfstate, change to AttrTypeCreate
2014-10-11 12:34:52 -07:00
cfortier2 77edd9d8d8 add subnet_group_name for aws db instance doc 2014-10-01 11:42:48 -04:00
Alek Storm c7f219a781 Store aws_db_instance.password in tfstate, change to AttrTypeCreate 2014-09-18 13:55:43 -07:00
Hector Castro 733f10d7b9 Add documentation for aws_db_instance/final_snapshot_identifer. 2014-08-01 11:34:46 -04:00
borgified b5590ee6da spellchecked all the *.markdown
ran this command:
find . -iname *.markdown -type f -exec aspell check {} \;
and manually checked each problem that aspell found
2014-07-28 23:51:24 -07:00