3901827b40
provider/aws: Validate `aws_iam_policy_attachment` Name parameter to stop being empty ( #8441 )
...
* provider/aws: Validate `aws_iam_policy_attachment` Name parameter to
stop being empty
Fixes #8368
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSPolicyAttachment_'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/24 11:46:01 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v
-run=TestAccAWSPolicyAttachment_ -timeout 120m
=== RUN TestAccAWSPolicyAttachment_basic
--- PASS: TestAccAWSPolicyAttachment_basic (44.67s)
=== RUN TestAccAWSPolicyAttachment_paginatedEntities
--- PASS: TestAccAWSPolicyAttachment_paginatedEntities (161.68s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 206.379s
```
* Update resource_aws_iam_policy_attachment.go
2016-08-24 21:28:41 +01:00
a99aaa5e85
provider/aws: Query all pages of policy attachment
...
This does not fix groups and users with more than 100 policies attached
2016-08-15 12:49:09 -07:00
108ccf0007
builtin: Refactor resource.Retry to clarify return
...
Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.
Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.
This makes it eminently clear whether or not a given error is
retryable from inside the client code.
Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
2016-03-09 17:37:56 -06:00
de656942ae
provider/aws: Fix all pointer RetryError returns
...
All of these RetryErrors were meant to fail right away, but instead
caused retry looping because the typecheck in the implementation of
`resource.Retry()` only catches the value type, and not the pointer
type.
Refs #5537
2016-03-09 14:59:55 -06:00
e87d3bb711
Enabled Enhanced Monitoring for RDS
2016-02-03 00:14:24 +00:00
5482e98927
Fix typo in error checking for IAM Policy Attachments
2015-11-18 13:48:46 -06:00
0c2f189d08
provider/aws: Update to aws-sdk 0.9.0 rc1
2015-08-17 13:27:16 -05:00
c1daf23a5d
provider/aws: Fix issues with TestAccAWSPolicyAttachment_basic
2015-08-06 09:47:35 -05:00
28506c3750
add composeErrors function to only expose errors that happened
2015-06-28 22:30:54 -04:00
0f5c9c012d
check length of slices instead of using incorrect type
2015-06-28 20:00:55 -04:00
c375a72f15
check for empty string instead of nil
2015-06-28 19:39:50 -04:00
3266c44b83
rename to more intuitive name and finish tests
2015-06-18 10:53:52 -04:00
Paul Stack