Commit Graph

116 Commits

Author SHA1 Message Date
Paul Stack 12546c6fca Merge pull request #5065 from tpounds/fix-aws-elb-access-logs-type
provider/aws: Change ELB access_logs to list type
2016-03-22 01:40:14 +00:00
Clint 239b3e4f5f Merge pull request #5533 from hashicorp/pr-5184
provider/aws: Fix EC2 Classic SG Rule issue
2016-03-10 08:56:29 -06:00
Paul Hinze 108ccf0007 builtin: Refactor resource.Retry to clarify return
Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.

Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.

This makes it eminently clear whether or not a given error is
retryable from inside the client code.

Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
2016-03-09 17:37:56 -06:00
ephemeralsnow 54cb5ffe00 provider/aws: Fix EC2 Classic SG Rule issue
Fixes an issue where security groups would fail to update after applying an
initial security_group, because we were improperly saving the id of the group
and not the name (EC2 Classic only).

This is a PR combining https://github.com/hashicorp/terraform/pull/4983 and
https://github.com/hashicorp/terraform/pull/5184 . It's majority
@ephemeralsnow's work.
2016-03-09 09:51:41 -06:00
Paul Stack 30dcc45635 Merge pull request #5178 from hashicorp/f-aws-iam-server-updates
provider/aws: Update IAM Server Cert
2016-02-22 18:07:22 +00:00
Trevor Pounds f83c81dbb5 Change AWS ELB access_logs to list type.
There can only be a single access_log configuration per load balancer
so choosing to use a list over a set is only relevant when comparing
changes during a plan. A list makes it much easier to compare updates
since the index is stable (0 vs. computed hash).
2016-02-21 15:16:09 -08:00
clint shryock c8178ad31c provider/aws: Update IAM Server Cert to allow name_prefix, auto generated namesprovider/aws: Update IAM Server Cert to allow name_prefix, auto generated namesdiff 2016-02-17 16:34:02 -06:00
Trevor Pounds 5624a33239 Change AWS ELB health_check to list type.
There can only be a single health_check configuration per load balancer
so choosing to use a list over a set is only relevant when comparing
changes during a plan. A list makes it much easier to compare updates
since the index is stable (0 vs. computed hash).
2016-02-08 23:08:35 -08:00
clint shryock 86ad4c4340 provider/aws: Retry Listener Creation for ELBs 2016-01-25 11:38:04 -06:00
Trevor Pounds 76e23a3b2e Fix ELB security groups read logic. 2016-01-09 16:09:14 -08:00
Trevor Pounds c34c2249e7 Support updating ELB availability zones. 2016-01-09 15:40:21 -08:00
Trevor Pounds f75c3168d7 Support updating ELB subnets. 2016-01-09 15:40:21 -08:00
Trevor Pounds 9541c37ef4 Fix ELB availability zones and subnets read logic. 2016-01-09 15:40:21 -08:00
Radek Simko a367886eaf provider/aws: Separate existing validate functions 2015-12-23 15:11:45 +01:00
Anthony Stanton 5753efa8af Skip SG ID determination logic for Classic ELBs 2015-11-26 15:34:28 +01:00
clint shryock 6fa69ede1c add debugging statements to add/remove listeners 2015-11-12 16:20:54 -06:00
clint shryock c60a963908 providers/aws: Retry deleting IAM Server Cert on dependency violation
This will retry deleting a server cert
if it throws an error about being in use with an ELB (that we've likely just
  deleted)

Includes test for ELB+IAM SSL cert bug dependency violation
2015-11-12 16:07:34 -06:00
clint shryock 8c32536f3d return err if we fail to set access_logs; other cleanups 2015-11-10 16:58:24 -06:00
clint shryock 0a1890c329 Merge branch 'master' into pr-3708
* master: (95 commits)
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  upgrade a warning to error
  add some logging around create/update requests for IAM user
  Update CHANGELOG.md
  Update CHANGELOG.md
  Build using `make test` on Travis CI
  Update CHANGELOG.md
  provider/aws: Fix error format in Kinesis Firehose
  Update CHANGELOG.md
  Changes to Aws Kinesis Firehouse Docs
  Update CHANGELOG.md
  modify aws_iam_user_test to correctly check username and path for initial and changed username/path
  Update CHANGELOG.md
  Update CHANGELOG.md
  Prompt for input variables before context validate
  Removing the AWS DBInstance Acceptance Test for withoutEngine as this is now part of the checkInstanceAttributes func
  Making engine_version be computed in the db_instance provider
  ...
2015-11-10 16:52:45 -06:00
clint shryock 7152674f9b upgrade a warning to error 2015-11-10 16:27:41 -06:00
clint shryock 9390674a05 providers/aws: Provide source security group id for ELBs 2015-11-05 16:43:49 -06:00
clint shryock 5f7254eb1a providers/aws: Add ELB Access Logs (continues #3708)
- continues #3708
- adds some tests
- other fixes I found along the way
2015-11-04 11:58:29 -06:00
clint shryock 2e03a7ebff go fmt after rebase 2015-11-03 16:30:18 -06:00
Trevor Pounds 4e3d0b5f6c Fix schema conversion. 2015-11-03 16:29:57 -06:00
Trevor Pounds 91b1d0c23d Can only set access logs once per ELB. 2015-11-03 16:29:57 -06:00
Trevor Pounds e8f1f57ead Fix int64 cast. 2015-11-03 16:29:57 -06:00
Florin Patan e173b60f10 Changes per feedback 2015-11-03 16:29:57 -06:00
Florin Patan e390d7ddf2 Add elb access logs setting 2015-11-03 16:29:57 -06:00
stack72 91274c9a90 Test spike to extract the function that does the validation for ELB Name. This will allow me to test this in isolation to make sure that the validation rules work as expected 2015-09-21 22:00:51 +01:00
Paul Hinze 55411d692d provider/aws: add value into ELB name validation message
makes debugging these validation errors much more straightforward
2015-08-13 16:31:18 -05:00
Clint Shryock 579ccbefea provider/aws: Update source to comply with upstream breaking change 2015-07-28 15:29:46 -05:00
Clint f979fd7dee Merge pull request #2571 from TimeIncOSS/f-aws-autogenerated-elb-name
provider/aws: Allow ELB name to be generated
2015-07-21 15:52:36 -05:00
Panagiotis Moustafellos 0cbb815d28 providers/aws: aws_elb: Allow alnum plus hyphen in name attribute 2015-07-01 09:16:32 +03:00
Radek Simko 676d490d40 provider/aws: Allow elb name to be generated 2015-06-30 13:13:51 +01:00
Radek Simko 60a7597a4c aws: Fix validation for aws_elb.name 2015-06-26 18:08:13 +01:00
Radek Simko 6f2fb0db38 provider/aws: Add validation for aws_elb.name 2015-06-26 15:08:00 +01:00
Paul Hinze f65cce478b provider/aws: fix case in ELB listener protocols
fixes #2242
2015-06-05 10:20:07 -05:00
Paul Hinze b71fa3d0ae provider/aws: handle upstream aws-sdk-go repo move
`awslabs/aws-sdk-go => aws/aws-sdk-go`

Congrats to upstream on the promotion. :)
2015-06-03 13:36:57 -05:00
Paul Hinze 31258e06c6 provider/aws: fix breakages from awserr refactor
This landed in aws-sdk-go yesterday, breaking the AWS provider in many places:

3c259c9586

Here, with much sedding, grepping, and manual massaging, we attempt to
catch Terraform up to the new `awserr.Error` interface world.
2015-05-20 06:21:23 -05:00
Clint Shryock f6bcc302d3 providers/aws+cloudflare+dnsimple: Increase some verbosity 2015-05-18 15:25:03 -05:00
Mitchell Hashimoto 4a61d0abc9 provider/aws: do connection draining stuff totally separate 2015-05-06 11:47:06 -07:00
Mitchell Hashimoto 5378d904a2 provider/aws: remove debug 2015-05-06 11:43:36 -07:00
Mitchell Hashimoto 74665f27c8 provider/aws: must set connection draining timeout separate frrom
enabled
2015-05-06 11:43:18 -07:00
Phil Frost 33183c078b Implement a hash function for string sets
Sets of strings are pretty common. Let's not duplicate the function
necessary to create a set of strings in so many places.
2015-05-05 12:47:18 -04:00
Mitchell Hashimoto 9ed909c8fe Merge pull request #1749 from nabeken/aws-proxy-protocol-policy
provider/aws: Add proxy protocol support in ELB
2015-05-04 14:04:53 -07:00
Radek Simko bafabf17be provider/aws: Expose zone_id from elb 2015-05-01 08:07:33 +01:00
Paul Hinze a9de720a4e Merge pull request #1708 from hashicorp/f-elb-source-security-group
providers/aws: add source_security_group to elb
2015-04-30 16:10:02 -05:00
TANABE Ken-ichi 9df2bf68cb providers/aws: use isLoadBalancerNotFound 2015-04-30 17:56:46 +09:00
Paul Hinze e4e6ac5d91 providers/aws: add source_security_group to elb 2015-04-28 09:40:19 -05:00
Gavin James c986c65238 update security groups in-place 2015-04-23 20:57:37 +01:00