70984526a4
Merge remote-tracking branch 'ctiwald/ct/fix-protocol-problem'
...
* ctiwald/ct/fix-protocol-problem:
aws: Document the odd protocol = "-1" behavior in security groups.
aws: Fixup structure_test to handle new expandIPPerms behavior.
aws: Add security group acceptance tests for protocol -1 fixes.
aws: error on expndIPPerms(...) if our ports and protocol conflict.
2015-05-07 17:13:21 -05:00
8705f0f78f
provider/aws: fix issue with reading VPC id in AWS Security Group
2015-05-06 16:54:43 -05:00
885efa0837
provider/aws: Add Security Group Rule as a top level resource
...
- document conflict with sg rules and sg in-line rules
- for this to work, ingress rules need to be computed
2015-05-05 16:56:39 -05:00
eb7c1bb218
fix go formatting
2015-05-05 16:42:08 -05:00
e9b08cf31f
revert the required part
2015-05-05 16:23:26 -05:00
85b1756c27
revise tests and check for vpc_id
2015-05-05 16:23:26 -05:00
8ded3c2d1b
Move block for deleing default rule into the create method; only invoke once
2015-05-05 16:23:26 -05:00
b145ce88b7
Document Egress+VPC change, update link
2015-05-05 16:23:26 -05:00
1558fd1c3e
provider/aws: Remove default egress rule from Security Group on creation
2015-05-05 16:23:25 -05:00
3ce3b7c516
provider/aws: Shorting retry timeout for Security Groups to 2 minutes, from 5
2015-05-05 11:07:16 -05:00
89bacc0b15
aws: error on expndIPPerms(...) if our ports and protocol conflict.
...
Ingress and egress rules given a "-1" protocol don't have ports when
Read out of AWS. This results in hashing problems, as a local
config file might contain port declarations AWS can't ever return.
Rather than making ports optional fields, which carries with it a huge
headache trying to distinguish between zero-value attributes (e.g.
'to_port = 0') and attributes that are simply omitted, simply force the
user to opt-in when using the "-1" protocol. If they choose to use it,
they must now specify "0" for both to_port and from_port. Any other
configuration will error.
2015-05-04 23:43:31 -04:00
079856620a
provider/aws: set default SG description
...
because requiring a SG description is annoying
2015-04-22 13:27:20 -05:00
33de319293
provider/aws: allow SG names to be generated
2015-04-22 12:56:06 -05:00
6da242de03
fixing sg refresh
2015-04-20 11:27:58 -04:00
3e6822ce08
more cleans ups of SDK reference
2015-04-16 15:28:18 -05:00
ba43b7c963
mass search-replace of ec2SDKconn
2015-04-16 15:05:55 -05:00
ffdd20133a
providers/aws: Convert AWS Security Group to upstream aws-sdk-go
...
Moves structure test lib too, to that `make test` actually runs it
2015-04-09 09:10:04 -05:00
eadc44d5f7
Merge pull request #1223 from hashicorp/b-fix-ingress-self-ommission
...
provider/aws: Fix issue with ignoring the 'self' attribute of a Security Group rule
2015-03-18 16:42:17 -05:00
d823a8cf81
providers/aws: fix security group self ingress rules on EC2-classic
2015-03-18 13:47:59 +00:00
7034619863
provider/aws: Fix issue where we ignored the 'self' attribute of a security group rule
2015-03-17 15:48:10 -05:00
28fbd971fc
Retire goamz
2015-03-13 09:42:50 -05:00
57556bba75
Replace tags files with tags_sdk, rename, and update
2015-03-12 16:43:08 -05:00
902ca25f36
Code cleanup
2015-03-11 08:30:43 -05:00
3977256c17
Cleansup: Restore expandIPPerms, remove flattenIPPerms
2015-03-10 16:35:49 -05:00
a22c23ad42
clean up debug output to make go vet happy
2015-03-10 15:55:49 -05:00
20b02cacd4
provider/aws: Convert AWS Security Group to aws-sdk-go
...
Convert security group test too
2015-03-09 11:45:58 -05:00
c7e536680d
Merge pull request #999 from TimeInc/clean-code
...
Clean code (get rid of go vet errors)
2015-02-18 12:28:12 -08:00
e149a97658
Make composite literals to use keyed fields
...
This will prevent following error:
- * composite literal uses unkeyed fields
2015-02-18 18:26:59 +00:00
fc7c859c8a
providers/aws: egress should be computed
2015-02-18 09:27:55 -08:00
5e8c3113b4
providers/aws: style change
2015-02-18 09:07:46 -08:00
c40238041c
providers/aws: fix bad arg giving wrong type [GH-992]
2015-02-17 16:39:51 -08:00
47b244d296
adding support for egress rules in AWS Security Groups
2015-01-23 09:46:20 -05:00
38697d6b4c
aws: Making security group ingress rules optional
2014-12-07 23:52:04 -08:00
d3e1a6678d
Making some last tweaks and fixing some acc tests
2014-11-24 21:22:18 +01:00
eccd5ad308
Refactored about 90%
...
Still need to update 2 resources and check the acceptance tests, but
overall we’re nearly there 😃
2014-11-21 17:58:34 +01:00
f63a5d24e9
helper/schema: diffs for sets should include the full set [GH-457]
...
Prior to this, the diff only contained changed set elements. The issue
with this is that `getSet`, the internal function that reads a set from
the ResourceData, expects that each level (state, config, diff, etc.)
has the _full set_ information. This change was done to fix merging
issues.
Because of this, we need to make sure the full set is visible in the
diff.
2014-10-21 10:49:53 -07:00
d5b418d82b
Merge pull request #402 from longnguyen11288/add-sg-tags
...
Added security group tagging
2014-10-20 23:18:22 -07:00
7c89fb06cc
providers/aws: only retry dependency violation for security groups
...
[GH-436]
2014-10-17 18:29:48 -07:00
10ce2b690c
providers/aws: retry deleting security group for some time [GH-436]
2014-10-17 18:21:18 -07:00
eef3197ba0
Added security group tagging
2014-10-14 17:11:09 -04:00
e4ec2eb0cf
providers/aws: security group VPC ID can be computed in a default VPC
2014-10-10 17:12:03 -07:00
3b2272c69f
providers/aws: read properly finds the Self
2014-09-30 14:26:01 -07:00
dbc890e401
providers/aws: add `self` to ingress [GH-219]
2014-09-30 14:19:16 -07:00
c5d6df692d
providers/aws: tests passing, compiles
2014-09-16 17:49:24 -07:00
56cf1e6faa
Fix go vet complaints
2014-08-24 21:50:35 -07:00
f26a2700a1
fmt
2014-08-22 08:46:03 -07:00
cdc2a53553
providers/aws: changing order of security group cidrs doesn't affect
...
things
2014-08-21 14:10:09 -07:00
5b620b76f5
providers/aws: update comment
2014-08-21 12:00:32 -07:00
200f7c4488
providers/aws: can add remove individual cidr/groups in security group
2014-08-21 11:59:03 -07:00
4015d942ab
providers/aws: security group ingress rules treated as set [GH-87]
...
/cc @pearkes - !!!
2014-08-20 22:24:13 -07:00
Clint Shryock