84b1db4505
Merge pull request #1021 from hashicorp/b-aws-instance-source-dest-check-on-create
...
providers/aws: fix source_dest_check on instance creation
2015-02-23 13:45:17 -08:00
f6249ff6db
Merge pull request #1018 from hashicorp/aws-go-autoscaling
...
Convert AWS AutoScalingGroup to awslabs/aws-sdk-go
2015-02-23 10:22:22 -06:00
473b03ccae
providers/aws: fix source_dest_check on instance creation
...
The `SourceDestCheck` attribute can only be changed via
`ModifyInstance`, so the AWS instance resource's `Create` function calls
out to `Update` before it returns to take care of applying
`source_dest_check` properly.
The `Update` function originally guarded against unnecessary API calls
with `GetOk`, which worked fine until #993 when we changed the `GetOk`
semantics to no longer distinguish between "configured and zero-value"
and "not configured".
I attempted in #1003 to fix this by switching to `HasChange` for the
guard, but this does not work in the `Create` case.
I played around with a few different ideas, none of which worked:
(a) Setting `Default: true` on `source_dest_check' has no effect
(b) Setting `Computed: true` on `source_dest_check' and adding a `d.Set`
call in the `Read` function (which will initially set the value to `true`
after instance creation). I really thought I could get this to work,
but it results in the following:
```go
d.Get('source_dest_check') // true
d.HasChange('source_dest_check') // false
d.GetChange('source_dest_check') // old: false, new: false
```
I couldn't figure out a way of coherently dealing with that result, so I
ended up throwing up my hands and giving up on the guard altogether.
We'll call `ModifyInstance` more than we have to, but this at least
yields expected behavior for both Creates and Updates.
Fixes #1020
2015-02-21 14:26:46 -06:00
5b35b85527
remove the rand, it's not helping like I thought
2015-02-20 15:49:51 -06:00
4326b6b8b5
cleanups after feedback
2015-02-20 14:28:14 -06:00
523639b5cd
fmt
2015-02-20 10:22:26 -08:00
cf5697ff32
providers/aws: if a VPC doesn't exist, then remove from state
2015-02-20 10:20:20 -08:00
d79ac17757
randomize ASG name in test, to get around slow AWS delete time
2015-02-20 11:40:47 -06:00
b38a3767eb
provider/aws: Convert AWS AutoScalingGroup to awslabs/aws-sdk-go
2015-02-20 11:28:20 -06:00
08949866c5
Merge config
2015-02-20 09:08:41 -06:00
57300d32c6
merge master
2015-02-20 08:55:54 -06:00
116e6cac33
provider/aws: Convert AWS S3 Bucket to awslabs/aws-sdk-go
2015-02-19 15:38:56 -06:00
94e7723370
provider/aws: Convert Route 53 Zone resource to use new awslabs/aws-sdk-go
...
library.
This commit updates the Route 53 Zone resource to use AWS Labs aws-sdk-go
library instead of mitchellh/goamz.
- hard code us-east-1 for Route53 region, since it's a global endpoint
- add some units test for CleanZoneID
2015-02-19 15:05:46 -06:00
e3b64f5bb5
providers/aws: style
2015-02-19 10:52:09 -08:00
cd1e70faab
providers/aws: acceptance test was too strict
2015-02-19 09:54:16 -08:00
448ebd1372
Merge pull request #1005 from hashicorp/f-fix-elb-subnet-test
...
Revert "Merge pull request #804 from PeoplePerHour/f-aws-elb-subnet"
2015-02-19 09:46:05 -08:00
39d28a9612
Merge pull request #1003 from hashicorp/b-aws-instance-source-dest-check
...
providers/aws: fix aws_instance source_dest_check
2015-02-19 09:37:13 -08:00
86a2449569
Revert "Merge pull request #804 from PeoplePerHour/f-aws-elb-subnet"
...
Unfortunately, the acceptance tests here were improperly passing, and
allowing Subnet updates on ELBs is not as straightfoward as simply
removing `ForceNew`.
Subnets on ELBs need to be managed by two explicit API calls:
* `AttachLoadBalancerToSubnets` - http://bit.ly/elbattachsubnet
* `DetachLoadBalanceFromSubnets` - http://bit.ly/elbdetachsubnet
We'll need to circle back and use these APIs to explicitly add support.
This fixes the failure of `TestAccAWSELB_AddSubnet` by removing the
test.
This reverts commit 61e91017be49b3afe452
2015-02-18 18:15:04 -06:00
3c4d1791e5
providers/aws: fix aws_instance source_dest_check
...
Was relying on old behavior of GetOk and therefore never properly seeing
a change from true -> false.
This fixes the acceptance test failure of
`TestAccAWSInstance_sourceDestCheck`.
2015-02-18 17:46:50 -06:00
434a9759a0
providers/aws: enhance root_block_device acceptance test
...
So that we have a test that will fail in case the flubbery of #1000
returns.
2015-02-18 17:28:28 -06:00
eca5fe3ff3
providers/aws: fix ELB acceptance test
2015-02-18 15:18:51 -08:00
05a34d7d77
providers/aws: root block device not being set properly
...
The value to set must not contain invalid fields.
2015-02-18 14:45:13 -08:00
c7e536680d
Merge pull request #999 from TimeInc/clean-code
...
Clean code (get rid of go vet errors)
2015-02-18 12:28:12 -08:00
73d20b4c58
providers/aws: add root_block_device to aws_instance
...
AWS provides a single `BlockDeviceMapping` to manage three different
kinds of block devices:
(a) The root volume
(b) Ephemeral storage
(c) Additional EBS volumes
Each of these types has slightly different semantics [1].
(a) The root volume is defined by the AMI; it can only be customized
with `volume_size`, `volume_type`, and `delete_on_termination`.
(b) Ephemeral storage is made available based on instance type [2]. It's
attached automatically if _no_ block device mappings are specified, and
must otherwise be defined with block device mapping entries that contain
only DeviceName set to a device like "/dev/sdX" and VirtualName set to
"ephemeralN".
(c) Additional EBS volumes are controlled by mappings that omit
`virtual_name` and can specify `volume_size`, `volume_type`,
`delete_on_termination`, `snapshot_id`, and `encryption`.
After deciding to ignore root block devices to fix #859 , we had users
with configurations that were attempting to manage the root block device chime
in on #913 .
Terraform does not have the primitives to be able to properly handle a
single collection of resources that is partially managed and partially
computed, so our strategy here is to break out logical sub-resources for
Terraform and hide the BlockDeviceMapping inside the provider
implementation.
Now (a) is supported by the `root_block_device` sub-resource, and (b)
and (c) are still both merged together under `block_device`, though I
have yet to see ephemeral block devices working properly.
Looking into possibly separating out `ephemeral_block_device` and
`ebs_block_device` sub-resources as well, which seem like the logical
next step. We'll wait until the next big release for this, though, since
it will break backcompat.
[1] http://bit.ly/ec2bdmap
[2] http://bit.ly/instancestorebytype
Fixes #913
Refs #858
2015-02-18 13:15:11 -06:00
e149a97658
Make composite literals to use keyed fields
...
This will prevent following error:
- * composite literal uses unkeyed fields
2015-02-18 18:26:59 +00:00
fc7c859c8a
providers/aws: egress should be computed
2015-02-18 09:27:55 -08:00
5e8c3113b4
providers/aws: style change
2015-02-18 09:07:46 -08:00
44c45994c8
Merge pull request #963 from julienba/master
...
providers/aws: vpc_peering_connection
2015-02-18 06:56:28 -08:00
372035368f
allow update
2015-02-18 10:45:12 +01:00
c40238041c
providers/aws: fix bad arg giving wrong type [GH-992]
2015-02-17 16:39:51 -08:00
e04def93e6
Merge pull request #991 from hashicorp/b-autoscale-lc-update
...
providers/aws: allow in-place update of launch configuration
2015-02-17 16:29:56 -08:00
5a64d0900b
providers/aws: test for allowing in-place lC update
2015-02-17 16:12:02 -08:00
b5df47efc9
providers/aws: support updating ASG launch config [GH-904]
2015-02-17 15:48:15 -08:00
66f7731995
helper/schema: GetChange shouldn't return true when no change
2015-02-17 15:43:19 -08:00
0feb29944c
Merge pull request #856 from CashStar/aws_egress
...
provider/aws: adding support for egress rules in AWS Security Groups
2015-02-17 13:59:47 -08:00
1752c93e0c
update CHANGELOG
2015-02-17 09:44:44 -08:00
9a19eb3110
Merge pull request #721 from robzienert/change-elb-listener-force-new
...
providers/aws: Changing AWS ELB to not ForceNew when listeners change
2015-02-17 09:43:46 -08:00
aad83447d2
Merge pull request #889 from bitglue/deleted_subnet
...
provider/aws: Fix error when refreshing on a deleted AWS subnet
2015-02-17 09:30:48 -08:00
c5e035361f
Merge pull request #896 from bitglue/storage_type
...
provider/aws: Support storage_type parameter for aws_db_instance
2015-02-17 09:30:03 -08:00
f63aa41d67
Merge pull request #897 from bitglue/apply_method
...
provider/aws: Implement apply_method for RDS parameters
2015-02-17 09:28:24 -08:00
fd01b01a9e
Merge pull request #923 from hashicorp/aws-read-termination-policies
...
providers/aws: read ASG termination policies
2015-02-17 09:25:16 -08:00
101f801846
add aws_vpc_peering_connection
2015-02-12 10:45:29 +01:00
1ee3d232a1
simplify HasSuffix check
2015-02-11 16:49:03 -08:00
90c8317899
Auto add full domain suffix if not present
2015-02-11 16:39:25 -08:00
3b0b41c9a1
allow vpc_peering_connection_id in aws_route_table
2015-02-10 17:50:29 +01:00
6f5234c52f
Merge pull request #916 from gosuri/aws-elb-update-issue
...
fix for #915 - aws_elb.health_check attributes does not update during update
2015-02-06 17:14:44 -06:00
481b3c7e3b
provider/aws: fix for #915 , disabling ForceNew while updating elb healthchecks
2015-02-06 15:03:52 -08:00
c21907850d
Merge pull request #921 from hashicorp/fix-diffreader-map-handling
...
helper/schema: fix DiffFieldReader map handling
2015-02-04 10:06:13 -06:00
926effb800
providers/aws: read ASG termination policies
...
Right now we yield a perpetual diff on ASGs because we're not reading
termination policies back out in the provider.
This depends on https://github.com/mitchellh/goamz/pull/218 and fixes
it.
2015-02-04 10:00:03 -06:00
219aa3e788
helper/schema: fix DiffFieldReader map handling
...
An `InstanceDiff` will include `ResourceAttrDiff` entries for the
"length" / `#` field of maps. This makes sense, since for something like
`terraform plan` it's useful to see when counts are changing.
The `DiffFieldReader` was not taking these entries into account when
reading maps out, and was therefore incorrectly returning maps that
included an extra `'#'` field, which was causing all sorts of havoc
for providers (extra tags on AWS instances, broken google compute
instance launch, possibly others).
* fixes #914 - extra tags on AWS instances
* fixes #883 - general core issue sprouted from #757
* removes the hack+TODO from #757
2015-02-03 20:17:57 -06:00
92335b742a
provider/aws: aws_main_route_table_association
...
This resource allows an existing Route Table to be assigned as the
"main" Route Table of a VPC. This means that the Route Table will be
used for any subnets within the VPC without an explicit Route Table
assigned [1].
This is particularly useful in getting an Internet Gateway in place as
the default for a VPC, since the automatically created Main Route Table
does not have one [2].
Note that this resource is an abstraction over an association and does not
map directly to a CRUD-able object in AWS. In order to retain a coherent
"Delete" operation for this resource, we remember the ID of the AWS-created
Route Table and reset the VPC's main Route Table to it when this
resource is deleted.
refs #843 , #748
[1] http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/VPC_Route_Tables.html#RouteTableDetails
[2] http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/VPC_Internet_Gateway.html#Add_IGW_Routing
2015-02-03 13:47:43 -06:00
04ac1ffd02
provider/aws: fix for #915 - aws_elb.health_check attributes does not update during update
2015-02-02 19:25:54 -08:00
863fd0c7d2
Avoid unnecessary updating of aws_subnet
...
If map_public_ip_on_launch was not specified, AWS picks a default of
"0", which is different than the "" in the state file, triggerinng an
update each time. Mark that parameter as Computed, avoiding the update.
2015-01-30 13:17:16 -05:00
8eb5418c4a
Implement apply_method for RDS parameters
...
This is necessary to support creating parameter groups with parameters
that require a reboot, since the RDS API will return an error when
attempting to set those parameters with ApplyMethod "immediate".
2015-01-30 13:06:15 -05:00
bfaf8ccee6
Support storage_type parameter for aws_db_instance
...
This allows provisioning "gp2" (general purpose SSD) storage for DB
instances.
2015-01-30 13:01:10 -05:00
04e86697fb
Fix error when refreshing on a deleted AWS subnet
...
If a subnet exists in the state file and a refresh is performed, the
read function for subnets would return an error. Now it updates the
state to indicate that the subnet no longer exists, so Terraform can
plan to recreate it.
2015-01-29 11:06:40 -05:00
254b25a64f
Fix aws_db_instance to not recreate each time
...
Several of the arguments were optional, and if omitted, they are
calculated. Mark them as such in the schema to avoid triggering an
update.
Go back to storing the password in the state file. Without doing so,
there's no way for Terraform to know the password has changed. It should
be hashed, but then interpolating the password yields a hash instead of
the password.
Make the `name` parameter optional. It's not required in any engine, and
in some (MS SQL Server) it's not allowed at all.
Drop the `skip_final_snapshot` argument. If `final_snapshot_identifier`
isn't specified, then don't make a final snapshot. As things were, it
was possible to create a resource with neither of these arguments
specified which would later fail when it was to be deleted since the RDS
API requires exactly one of the two.
Resolves issue #689 .
2015-01-28 12:03:26 -05:00
3cb5ba01a7
whitespace: fix mixed case indent
2015-01-28 05:16:04 -06:00
c88c4a33e1
providers/aws: ignore ec2 root devices
...
fixes #859
EC2 root block devices are attached automatically at launch [1] and show
up in DescribeInstances responses from then on. By skipping these when
recording state, Terraform can avoid thinking there should be block
device changes when there are none.
Note this requires that https://github.com/mitchellh/goamz/pull/214 land
first so the proper field is exposed.
[1] http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/RootDeviceStorage.html
2015-01-28 05:14:21 -06:00
918ba4c3be
Merge pull request #851 from hashicorp/sethvargo/aws_envvars
...
Use standard AWS environment variables
2015-01-25 13:29:32 -05:00
91378ce0af
Add test for launch configuration with spot price
2015-01-23 15:51:25 -06:00
47b244d296
adding support for egress rules in AWS Security Groups
2015-01-23 09:46:20 -05:00
072a1cf353
Read the "standard" AWS environment variables
...
This is 100% backwards-compatible
2015-01-22 16:09:25 -05:00
c9a0627f13
Add spot_price parameter to aws_launch_configuration resource
2015-01-21 22:48:04 -06:00
7759a28e9c
No longer needed after merging of PR 804.
2015-01-21 18:48:28 +11:00
df71834ff7
Merge pull request #831 from gulyasm/log-typo
...
Fixed wrong cross zone balancing error log.
2015-01-20 13:20:25 -08:00
0486dd0624
Fixed wrong cross zone balancing error log.
...
If updating the cross zone balancing in the aws elb resource fails, the
error log claimed that the health check configuration failed. Fixed.
2015-01-17 16:20:35 +01:00
f2bd1f45ab
Move duplicated envDefaultFunc out of each provider and into Schema.
2015-01-16 17:25:39 +00:00
61e91017be
Merge pull request #804 from PeoplePerHour/f-aws-elb-subnet
...
providers/aws: elb subnet change should not force a new resource
2015-01-16 08:33:32 -08:00
a49f1b5dd8
epic typo
2015-01-16 16:07:55 +02:00
cedf3a9415
providers/aws: elb subnet change acceptance test
...
add listeners
add orig subnet
2015-01-15 16:02:47 +02:00
c963793f3d
providers/aws: elb subnet change should not force a new resource
2015-01-15 10:43:26 +02:00
08813e6571
Merge branch 'add-ig-tags' of https://github.com/robzienert/terraform into robzienert-add-ig-tags
...
Conflicts:
builtin/providers/aws/resource_aws_internet_gateway_test.go
2015-01-10 15:28:14 -08:00
f800441fe1
provider/aws: fix aws_db_instance acceptance tests
...
- 5.6.17 is no longer a valid mysql engine version, bumping to 5.6.21
- updating security_group_names assertion to match new set structure
introduce in #663
2015-01-10 15:55:08 -06:00
cc0ee4a6bb
Merge pull request #731 from atlassian/tags
...
providers/aws: make tags not computed
2015-01-06 15:38:35 -08:00
eef75a7a2a
Merge pull request #695 from moredip/aws_key_pair-resource
...
add aws_key_pair resource
2015-01-06 10:46:58 -08:00
0ffc11c885
Merge pull request #704 from yahyapo/master
...
[AWS] Adding default network ACL ID and default security group ID to VPC reference attributes
2015-01-06 10:29:16 -08:00
11dc775c25
Merge pull request #701 from ceh/issue-687
...
builtin/providers/aws: acceptance tests for assigning private IPs on AWS instance
2015-01-05 11:41:15 -08:00
54ab857a54
Merge pull request #728 from atlassian/route_diff_fix
...
Route diff fix
2015-01-05 10:43:02 +01:00
7106917e98
Merge pull request #726 from atlassian/vgw_routes
...
Vgw routes
2015-01-05 10:39:42 +01:00
c738bf0477
builtin/providers/aws: remove unreachable code and skip unnecessary remote call
...
When DeleteInternetGateway is successful it returns a nil error value.
However, for a nil error value, the RetryFunc returns an error yielding a
unnecessary second call to DeleteInternetGateway in the retry logic.
The logic works because DeleteInternetGateway eventually returns an ec2.Error
with error code InvalidInternetGatewayID.NotFound since the internet gateway
has been deleted in the previous call. The return value of nil breaks the
retry logic and the deletion is deemed successful.
Fix the unnecessary second call to DeleteInternetGateway by short circuiting
with a nil error value when deletion of the internet gateway is successful on
the first try.
Add an acceptance test for internet gateway deletion and remove unreachable
code while here.
2015-01-03 21:56:44 +01:00
eb1776c7e3
"Computed" should be false
2015-01-03 18:33:18 +11:00
66159fd008
ignore routes originating from vgws
2015-01-02 19:17:52 +11:00
f6385215f6
Merge branch 'master' into route_diff_fix
2015-01-02 19:08:53 +11:00
9bdb2fb2d1
This change belongs in a branch
2015-01-02 19:08:33 +11:00
19c6d04928
Do store potentially empty values. Failing to do so will generate different hashes for identical route(s).
2015-01-02 19:03:13 +11:00
639e0c72b4
ignore routes originating from vgws
2014-12-31 10:23:34 +11:00
186af0bbb3
Changing AWS ELB to not ForceNew when listeners change
2014-12-27 22:33:33 -06:00
9fd59f09e2
Adding tags support to Internet Gateway resource
2014-12-27 22:05:15 -06:00
852e2f74ca
Fixing aws_elb schema
...
If not suppling the `availability_zones`, they will be computed
(meaning an update/refresh will retrieve the info and update the values
to the state file).
So without the `Computed = true` the diff will always flag this as a
change, even when it’s not.
2014-12-25 23:12:54 +01:00
57ae6a5da6
Fixing aws_instance schema
...
Some instance types have a block device by default. So when selecting
such an instance type, you will not set a config for the block device,
but the update/refresh func will notice one and update the state
nonetheless.
So in those cases the `block_device` becomes a `computed` field.
2014-12-25 21:58:26 +01:00
b96f373ee9
Fixing some logic issues with the aws-instance resource
...
1. The schema contained a few fields that where not marked as
`computed`, while they were updated inside the resource.
2. While updating the `volume_size` it was doing so with a `string`,
but in the schema this field is set as `int`.
3. The set func for calculating the hashes for the `block` set items,
also used computed values to calculate the hash. As these values will
not be in the config, but only in the state, this will always show as a
diff. The solution is to only use the fields that aren’t computed in
order to get consistent hashes.
These where all issues before, but weren’t visible as such. All should
be good again now.
2014-12-25 18:21:05 +01:00
7860dc1ef6
Adding default security group id attribute reference on creation of VPC. Fixes issue #466 .
2014-12-23 11:43:33 +05:30
634984532d
Adding default network acl id attribute reference on creation of VPC. Fixes issue #466 .
2014-12-22 23:08:15 +05:30
13f1f1f9ad
builtin/providers/aws: acceptance tests for assigning private IPs on AWS instance
2014-12-20 20:48:07 +01:00
5b66b9306e
add aws_key_pair resource
...
For now this only supports importing a key pair (by specifying a
public_key) property. In the future it'd be fairly trivial to support
key pair creation, with the private key returned as a computed property.
In real world usage you'd probably want to provide that public_key
property via a variable rather than hard-coding it into a terraform
config that'd end up in source control.
2014-12-18 01:27:06 -08:00
b58e468033
Updated the security_group attribute to use a set
...
This way the order returned by the API has no impact on the saved
state, preventing false positives when diffing.
2014-12-17 23:53:01 +01:00
4f3f85b165
builtin/providers/aws: vet fix
...
Fixes the following vet reports:
builtin/providers/aws/resource_aws_network_acl.go:191: wrong number of args for format in Errorf call: 2 needed but 3 args
builtin/providers/aws/resource_aws_network_acl.go:264: wrong number of args for format in Errorf call: 1 needed but 2 args
builtin/providers/aws/resource_aws_network_acl.go:268: wrong number of args for format in Errorf call: 1 needed but 2 args
builtin/providers/aws/resource_aws_network_acl.go:286: arg m[to_port].(int) for printf verb %s of wrong type: int
builtin/providers/aws/resource_aws_network_acl_test.go:277: arg r.NetworkAcls for printf verb %s of wrong type: []github.com/mitchellh/goamz/ec2.NetworkAcl
builtin/providers/aws/resource_aws_subnet_test.go:21: arg v.MapPublicIpOnLaunch for printf verb %s of wrong type: bool
2014-12-17 12:37:46 +01:00
9797881ed8
Updating the tests and refactoring the code a little
...
There was an error in the goamz package the prevented updating the
availability zones correctly. So PR #181 should be merged before this
one can be merged…
2014-12-16 15:21:25 +01:00
3aeba87e38
Updating the resource to use a set instead of a list
...
By using a set for the availability zones, you can use things like
`availability_zones = ["${aws_instance.web.*.availability_zone}"]`
where is very likely multiple of the same zones will be added to the
set. If you use a list here, the list will say it’s changed (even if
you add the same zone) which will force a new resource.
2014-12-16 13:13:59 +01:00
7e091dd7bd
Merge pull request #677 from svanharmelen/f-provider-aws-fix-route53-toggling
...
provider/aws: fixing the flipflop problem for the aws_route53 resource
2014-12-16 11:22:54 +01:00
a7667986f9
Updated the code so it makes use of the available functionality
...
The `helper/schema` package already knows how to create a set from a
slice with set items. So let’s use that functionality…
2014-12-16 11:14:33 +01:00
4f70630c52
Merge pull request #525 from pmoust/patch-2
...
provider/aws: update to support more regions
2014-12-15 16:40:35 -08:00
43a30e7d13
Finishing up the needed changes
...
Also executed the acceptance tests successfully now.
2014-12-16 00:59:47 +01:00
ee7b33acf4
Fixing the flipflop problem
...
Actually meant as a PoC, but it works perfectly so let’s just merge
this…
2014-12-16 00:40:43 +01:00
6a663796d5
Merge pull request #663 from svanharmelen/f-fix/change-set-logic
...
core: refactoring the way sets work internally v2
2014-12-15 13:38:00 -08:00
6098809ec5
Merge pull request #665 from gosuri/master
...
Fix for #664 , crashed due to ig.Attachements being 0
2014-12-14 18:15:27 -08:00
9b9d147585
Setting the VPC id to blank for unattached igws
2014-12-14 14:05:38 -08:00
27a97c4498
Small gofmt update...
2014-12-14 12:32:17 +01:00
d9af954c60
provider/aws: fixing the aws_internet_gateway resource
...
The resource is build so it can attach and detach the Internet Gateway
from a VPC, but as the schema has `Required` and `ForceNew` both set
to `true` for the vpc_id field it will never use these capabilities.
2014-12-14 12:20:59 +01:00
3883e47902
Fix for #664 , crashed due to ig.Attachements being 0
2014-12-13 22:14:23 -08:00
83c760fcb3
core: refactoring the way sets work internally v2
...
This is a refactored solution for PR #616 . Functionally this is still
the same change, but it’s implemented a lot cleaner with less code and
less changes to existing parts of TF.
2014-12-12 23:21:20 +01:00
cc4710c952
Fixing up the tests so they actually pass
...
Running the tests without these changes results in this error first:
```
--- FAIL: TestAccAWSNetworkAclsOnlyIngressRulesChange (24.92 seconds)
testing.go:121: Step 0 error: Check failed: Invalid number of ingress
entries found; count = %!s(int=3)
FAIL
exit status 1
FAIL github.com/hashicorp/terraform/builtin/providers/aws 24.974s
```
And after fixing that one you also get a few unexpected values due to
an expected order mismatch between the items in the set versus the
items in the config.
Those are also fixed, so the test is passing now.
2014-12-12 13:25:44 +01:00
7a3b4fa7ce
Merge pull request #648 from yahyapo/master
...
Adding tag support to AWS EC2 route table resource.
2014-12-10 19:24:38 -08:00
0ff62016ee
provider/aws: Fixing ASG handling of not found
2014-12-10 13:27:11 -08:00
633a08230e
Merge pull request #638 from snehaso/tag_for_acl
...
[AWS] added tags for aws_network_acl
2014-12-10 12:59:22 -08:00
9668c8292f
Merge pull request #637 from snehaso/vpc_tenanct
...
[AWS] added vpc instance_tenancy
2014-12-10 12:58:50 -08:00
8e32076d55
Merge pull request #635 from snehaso/cross_zone_lb
...
[AWS] enabled cross zone load balancing
2014-12-10 10:55:54 -08:00
b595c73d42
Adding tag support to AWS EC2 route table resource.
2014-12-11 00:03:13 +05:30
5e3e8562fc
added tags for aws_network_acl
2014-12-10 16:29:00 +05:30
89f1a38f5b
added vpc tenancy argument
2014-12-10 16:10:00 +05:30
1d3e30b353
enabled cross zone load balancing
2014-12-10 12:49:43 +05:30
82e60bb3cd
Merge pull request #631 from snehaso/network_acl
...
aws_network_acl: return error if rule protocol is invalid
2014-12-09 09:07:44 -08:00
aad594aed3
aws_network_acl: return error if protocol is invalid
2014-12-08 16:53:05 +05:30
38697d6b4c
aws: Making security group ingress rules optional
2014-12-07 23:52:04 -08:00
fae29f4685
Merge pull request #506 from muralimadhu/master
...
Support termination policies in aws auto scaling group
2014-12-07 23:35:33 -08:00
03d4a425b6
Merge pull request #623 from snehaso/network_acl
...
[AWS] added new resource aws_network_acl
2014-12-07 23:09:51 -08:00
4b154b8fe7
Fixed update of ingress/egress rules
2014-12-08 11:00:55 +05:30
7182e5618e
Merge pull request #612 from MerlinDMC/feature/aws_block_device_virtual_name
...
allow setting the block device virtual_name
2014-12-03 12:08:07 -08:00
a2c8859f04
Merge pull request #615 from Banno/fix-aws-instance-block-devices-index-range
...
fixing array length for aws instance volumes
2014-12-03 12:00:31 -08:00
c79e6ba08b
handled subnet and network acl association
2014-12-03 16:37:50 +05:30
86aafdb839
test for tenancy schema
2014-12-03 15:58:51 +05:30
cd0f9761da
rearranged the tests
2014-12-01 14:19:39 +05:30
f3ff4bece8
fixing array length for aws instance volumes
2014-11-30 08:24:23 -06:00
5eec8a531c
Added CRUD operations for network acl
2014-11-30 17:10:54 +05:30
d4a887278e
flatten/expand operations for network_acl
2014-11-30 17:09:37 +05:30
bd9e9ec0c4
Add support for network acls
2014-11-26 19:14:02 +05:30
dca2d9aa4c
acceptance test for creating network acl
2014-11-26 19:12:59 +05:30
cebea04cce
added provider for aws_network_acl
2014-11-26 19:12:39 +05:30
f63e032c23
Merge remote-tracking branch 'upstream/master'
2014-11-26 17:06:42 +05:30
ccf7f40711
Merge pull request #596 from svanharmelen/f-refactor-aws-provider
...
provider/aws: refactor to use the schema.Provider approach
2014-11-24 16:30:41 -08:00
d3e1a6678d
Making some last tweaks and fixing some acc tests
2014-11-24 21:22:18 +01:00
eb729d17c7
Merge pull request #546 from tmtk75/dev/enable-associate-public-ip
...
support associate_public_ip_address for aws_launch_configuration
2014-11-24 09:58:26 -05:00
0725486e89
Refactored the last two resources
2014-11-24 14:04:48 +01:00
db8256a4a7
add associate_public_ip_address attr to the acceptance test of aws_launch_configuration
2014-11-24 13:27:41 +09:00
1e3065ae11
allow setting the block device virtual_name
2014-11-22 09:50:22 +00:00
eccd5ad308
Refactored about 90%
...
Still need to update 2 resources and check the acceptance tests, but
overall we’re nearly there 😃
2014-11-21 17:58:34 +01:00
67b03247ec
Make Routes in RouteTable optional
...
Otherwise it is impossible to get simple configurations with the
"default" routing table, which is only the "local" route.
The following contents of main.tf expose the bug, and boots an instance
fine after this patch is applied:
variable aws_access_key {}
variable aws_secret_key {}
variable aws_ubuntu_ami {}
provider "aws" {
access_key = "${var.aws_access_key}"
secret_key = "${var.aws_secret_key}"
region = "us-east-1"
}
resource "aws_vpc" "default" {
cidr_block = "10.0.0.0/20"
}
resource "aws_route_table" "private" {
vpc_id = "${aws_vpc.default.id}"
# Note the lack of "route" sub-key here.
}
resource "aws_subnet" "private" {
vpc_id = "${aws_vpc.default.id}"
cidr_block = "10.0.1.0/24"
}
resource "aws_route_table_association" "private" {
subnet_id = "${aws_subnet.private.id}"
route_table_id = "${aws_route_table.private.id}"
}
# Demonstrate an instance can be booted fine in this fashion.
resource "aws_instance" "sample" {
ami = "${var.aws_ubuntu_ami}"
instance_type = "t2.micro"
subnet_id = "${aws_subnet.private.id}"
}
terraform.tfvars for completeness:
aws_access_key = "..."
aws_secret_key = "..."
# A public Trusty AMI
aws_ubuntu_ami = "ami-9aaa1cf2"
2014-11-19 22:04:44 -08:00
e53bf23c0c
provider/aws: Fixing merge conflict
2014-11-19 17:17:18 -08:00
735e83a146
Merge branch 'master' of https://github.com/serenitus/terraform into serenitus-master
2014-11-19 17:15:15 -08:00
41f2e7f98e
Merge pull request #545 from rcostanzo/f-parameter-group
...
Added new parameter_group_name parameter for creating an RDS DB instance
2014-11-19 16:01:11 -08:00
4303232533
Merge pull request #440 from buth/awsblockdevices
...
AWS Instance `block_device` Attribute
2014-11-19 15:52:00 -08:00
8446b036d7
Merge pull request #535 from ceh/vet-fixes
...
argument and verb formatting fixes reported by go vet
2014-11-19 15:46:01 -08:00
56defa346f
providers/aws: Route53 decrease MinTimeout interval
...
It get's a bit annoying when handling dozens of records to have the MinInterval for retries so high.
2014-11-13 17:52:10 +02:00
1170111c7e
support associate_public_ip_address for aws_launch_configuration
2014-11-06 21:00:48 +09:00
16b4dd44c1
Upped the RDS instance creation/destroy timeout to 20 minutes as it regularly takes 12+ minutes to create
2014-11-05 11:03:06 -08:00
a14da63a39
Fixed bug with final_snapshot_identifier and skip_final_snapshot and removed apply_method as an option for now and am only supporting immediate mode
2014-11-05 11:03:06 -08:00
0e3afa6d3d
Fixed incorrect ForcesNew settings for parameters and added better acceptance tests to ensure updates are working as expected
2014-11-05 11:03:06 -08:00
3b54001a1b
Added missing update support for new aws_db_parameter_group resource
2014-11-05 11:03:06 -08:00
de16b10555
Added new aws_db_parameter_group resource for creating RDS DB Parameter Groups.
...
Added plumbing to allow an optional DBParameterGroupName to be passed when creating an RDS DB instance.
2014-11-05 11:03:06 -08:00
750a36c51e
AWS instance resource now supports tenancy
2014-11-04 16:38:30 +05:30
31132f1ded
Add tag support to AWS subnets
2014-11-02 12:30:33 -08:00
4bfe18b40d
argument and verb formatting fixes reported by go vet
...
builtin/providers/aws/tags_test.go:56: unrecognized printf verb 'i'
builtin/providers/aws/tags_test.go:59: unrecognized printf verb 'i'
config/config_test.go:101: possible formatting directive in Fatal call
config/config_test.go:157: possible formatting directive in Fatal call
config/module/get_file_test.go:91: missing argument for Fatalf(%s): format reads arg 1, have only 0 args
helper/schema/schema.go:341: arg v.Type for printf verb %s of wrong type: schema.ValueType
helper/schema/schema.go:656: missing argument for Errorf(%s): format reads arg 2, have only 1 args
helper/schema/schema.go:912: arg schema.Type for printf verb %s of wrong type: schema.ValueType
terraform/context.go:178: arg v.Type() for printf verb %s of wrong type: github.com/hashicorp/terraform/config.VariableType
terraform/context.go:486: arg c.Operation for printf verb %s of wrong type: terraform.walkOperation
terraform/diff_test.go💯 arg actual for printf verb %s of wrong type: terraform.DiffChangeType
terraform/diff_test.go:235: arg actual for printf verb %s of wrong type: terraform.DiffChangeType
2014-11-02 13:56:44 +01:00
9fa25c40b2
tests for aws instance block_device
2014-10-31 16:25:16 -04:00
fc58d0a977
Merge branch 'master' of github.com:hashicorp/terraform into awsblockdevices
2014-10-31 15:41:30 -04:00
5bef93042b
Update to support more regions
...
Relates https://github.com/hashicorp/terraform/issues/524
Added `eu-central-1`, `cn-north-1` and `us-gove-west-1`(hi NSA)
I checked `goamz`, @mitchellh already has added support for those regions
2014-10-30 16:07:12 +02:00
5085e75f4a
Remove debug logs
2014-10-23 15:50:17 -07:00
7d4064ca03
Termination Policy Support
2014-10-23 14:58:54 -07:00
81913c58fb
providers/aws: fixing faililng test
2014-10-21 10:57:55 -07:00
f63a5d24e9
helper/schema: diffs for sets should include the full set [GH-457]
...
Prior to this, the diff only contained changed set elements. The issue
with this is that `getSet`, the internal function that reads a set from
the ResourceData, expects that each level (state, config, diff, etc.)
has the _full set_ information. This change was done to fix merging
issues.
Because of this, we need to make sure the full set is visible in the
diff.
2014-10-21 10:49:53 -07:00
d5b418d82b
Merge pull request #402 from longnguyen11288/add-sg-tags
...
Added security group tagging
2014-10-20 23:18:22 -07:00
590a635b70
providers/aws: ELB should treat subest as a set
2014-10-20 16:32:38 -07:00
7e2a421d87
providers/aws: ELB treats subnets as a set
2014-10-20 13:34:26 -07:00
b25a536299
providers/aws: disassociate EIP before destroying
2014-10-18 15:32:33 -07:00
895d978065
fmt
2014-10-18 10:59:23 -07:00
6eb409c00e
Merge pull request #449 from pmoust/subnet-destroy-retry
...
providers/aws: retry destroying subnet for some time [GH-449]
2014-10-18 10:56:21 -07:00
c459421892
providers/aws: retry destroying subnet for some time [GH-449]
2014-10-18 18:24:57 +03:00
f240c27e16
providers/aws: retry destroying internet gateway for some time [GH-447]
2014-10-18 11:47:33 +03:00
1912e9655d
providers/aws: if LC not found, delete it [GH-421]
2014-10-17 20:21:18 -07:00
f5c2aba215
providers/aws: drain autoscale groups before deleting [GH-435]
2014-10-17 20:11:00 -07:00
7c89fb06cc
providers/aws: only retry dependency violation for security groups
...
[GH-436]
2014-10-17 18:29:48 -07:00
10ce2b690c
providers/aws: retry deleting security group for some time [GH-436]
2014-10-17 18:21:18 -07:00
f10e84aa16
added block_device attribute
2014-10-17 12:12:45 -04:00
22fa84ebcb
Fix build breaks from latest goamz
2014-10-17 00:53:54 -04:00
05bfe85f9f
providers/aws: instances can be computed on an ELB
2014-10-16 18:24:58 -07:00
152d5b0c69
providers/aws: elb properly hashes listeners
2014-10-16 18:02:03 -07:00
1a2afdaa37
providers/aws: launch config and autoscale group load is correct
...
[GH-423]
2014-10-16 16:39:58 -07:00
eef3197ba0
Added security group tagging
2014-10-14 17:11:09 -04:00
e59e4a6bd9
providers/aws: fix compile error
2014-10-14 12:20:39 -07:00
ce997a9a33
providers/aws: fix test
2014-10-14 12:15:46 -07:00
3e16190e69
Expands AWS tagging to cover EC2 instances
2014-10-13 16:55:59 -04:00
d7786473df
fmt
2014-10-11 12:57:06 -07:00
6ddcc2ebf8
Merge pull request #309 from alekstorm/aws-db-instance-password
...
Store aws_db_instance.password in tfstate, change to AttrTypeCreate
2014-10-11 12:34:52 -07:00
d8c1ee655c
Merge pull request #308 from alekstorm/aws-db-instance-db-subnet-group-name
...
Rename aws_db_instance.subnet_group_name to db_subnet_group_name
2014-10-11 12:33:58 -07:00
bd0cf94e89
providers/aws: wait for LC to exist [GH-302]
2014-10-11 12:27:23 -07:00
35065fc8c8
providers/aws: properly report errors if DB instance destroy fails
...
[GH-310]
2014-10-11 11:02:11 -07:00
a362a97979
providers/aws: forcenew on SGs for now [GH-299]
2014-10-10 17:14:35 -07:00
e4ec2eb0cf
providers/aws: security group VPC ID can be computed in a default VPC
2014-10-10 17:12:03 -07:00
e827180887
providers/aws: main_route_table_id attribute for VPC [GH-193]
2014-10-10 16:57:32 -07:00
51d66b678d
providers/aws: resource ELB listeners [GH-314]
2014-10-10 16:35:52 -07:00
5eccbba606
providers/aws: support non-destructive update of desired_capacity for
...
ASG
2014-10-10 16:25:23 -07:00
36f225dea0
fmt
2014-10-10 14:50:35 -07:00
b43cfa3bb0
providers/aws: launch configuration in helper/schema
2014-10-10 14:50:23 -07:00
caaa9d145a
providers/aws: convert autoscaling group to helper/schema
2014-10-10 14:34:40 -07:00
281ba93d39
providers/aws: set the dns_name on create [GH-393]
2014-10-10 13:50:08 -07:00
b43ca0aa52
providers/aws: handle case where ELB is deleted manually [GH-304]
2014-10-10 10:35:34 -07:00
c5c72b1ce1
providers/aws: fix failing test
2014-10-10 10:26:48 -07:00
7dcb386e29
providers/aws: fix some computed attributes on ELB
2014-10-10 00:17:35 -07:00
dd2b1fe442
providers/aws: make health checks work
2014-10-10 00:07:08 -07:00
12ff354749
providers/aws: convert most of ELB to schema
2014-10-09 23:58:48 -07:00
539eca5ee6
Fix failing tests
2014-10-09 21:29:21 -07:00
3aa655ad3b
helper/schema: test schema diffs with the interpolation splits
2014-10-09 16:31:24 -07:00
6591e63138
providers/aws: should delete tags that are changing in-place
2014-10-09 10:47:33 -07:00
00bdef3093
providers/aws: test tag removal
2014-10-08 18:21:21 -07:00
6eafac8a34
providers/aws: aws_vpc supports tags
2014-10-08 17:54:00 -07:00
699b2efa1c
providers/aws: convert aws_vpc to helper/schema
2014-10-08 16:43:13 -07:00
9912ca70c6
Merge pull request #371 from xuwang/master
...
providers/aws: Add iam_instance_profile to resource_aws_launch_configuration
2014-10-08 10:53:26 -07:00
014bde64c4
providers/aws: not an error if route53 record is already destroy
...
[GH-342]
2014-10-07 21:55:40 -07:00
ca99811357
providers/aws: subnet retry destroy [GH-357]
2014-10-07 21:52:08 -07:00
df37e82f5b
Add optional param iam_instance_profile to resource_aws_launch_configuration to support role based AC
2014-10-06 20:46:25 -07:00
d01418270a
Add listener.ssl_certificate_id support to AWS ELB (@jpadvo [GH-176])
2014-10-02 05:19:36 +03:00
3b2272c69f
providers/aws: read properly finds the Self
2014-09-30 14:26:01 -07:00
dbc890e401
providers/aws: add `self` to ingress [GH-219]
2014-09-30 14:19:16 -07:00
6e02465be7
providers/aws: read internal for ELB
2014-09-30 13:37:04 -07:00
09ce13d040
Merge pull request #303 from buth/internalelbs
...
provider/aws: added missing internal ELB option
2014-09-30 13:29:35 -07:00
452cc07ce8
Merge pull request #307 from alekstorm/aws-db-instance-gone
...
providers/aws: don't error out when RDS DB instance disappears
2014-09-30 13:28:24 -07:00
a7c321a028
helper/scheam: support UI defaults
2014-09-29 14:00:35 -07:00
99044a1f14
Add descriptions for AWS inputs
2014-09-29 13:30:28 -07:00
459ffe9d2a
providers/*: fix compilation for input
2014-09-29 10:28:08 -07:00
3941dbac5d
fmt
2014-09-28 11:51:49 -07:00
9f91c4e8c3
Add IAM Instance profile support to AWS instance provider
2014-09-23 13:06:30 -05:00
bea81d7710
providers/aws: fix some broken tests
2014-09-22 08:57:17 -07:00
166847d5dc
Merge branch 'f-state'
...
Conflicts:
builtin/providers/aws/resource_aws_subnet.go
2014-09-22 08:55:44 -07:00
c7f219a781
Store aws_db_instance.password in tfstate, change to AttrTypeCreate
2014-09-18 13:55:43 -07:00
ba0591c85d
Force recreation when aws_instance.private_ip changes
2014-09-18 13:26:49 -07:00
f928829a1c
Don't error out when RDS DB instance disappears
2014-09-18 13:25:30 -07:00
5b806f0737
Rename aws_db_instance.subnet_group_name to db_subnet_group_name
2014-09-18 13:19:24 -07:00
9b2b3a963f
ResourceDiff => InstanceDiff
2014-09-17 16:33:24 -07:00
90b75b86c4
added missing internal ELB option
2014-09-17 17:56:27 -04:00
c5d6df692d
providers/aws: tests passing, compiles
2014-09-16 17:49:24 -07:00
002e640d0b
Merge pull request #259 from hden/vpc_zone_identifier
...
allow vpc_zone_identifier in aws_autoscaling_group
2014-09-16 10:44:32 -04:00
9fc775e41c
providers/aws: fix tests for subnet map_public_ip, add docs
...
This working depends on merging mitchellh/goamz#109
Related: #285
cc/ @hden
2014-09-16 10:37:22 -04:00
ee24fce321
Merge pull request #285 from hden/263
...
add MapPublicIpOnLaunch
2014-09-16 09:56:40 -04:00
dd434fb71b
providers/aws: add description to test
...
cc/ @buth
Looks like the schema was correctly defining description as required,
added it to the tests and it's passing now.
2014-09-16 09:44:32 -04:00
4cd11e4091
AWS DB Subnet Group resource and testing
2014-09-15 14:58:04 -04:00
d9665bad4e
add MapPublicIpOnLaunch
2014-09-10 13:13:16 +08:00
2317f7ea9b
providers/aws: proper DefaultFunc to return nil if no env
2014-09-09 21:46:50 -07:00
6a275d7bd0
providers/aws: convert validation to helper/schema
2014-09-09 21:44:31 -07:00
62e2743dcc
providers/aws: retry delete of eip [GH-276]
2014-09-09 14:18:53 -07:00
57f287c06d
providers/aws: check for non-exist on refresh
2014-09-09 14:15:33 -07:00
a5b85dd788
providers/aws: check if instance is set on eip
2014-09-09 14:15:08 -07:00
a5c884f5aa
fmt
2014-09-09 13:43:03 -07:00
ab5e07a1f9
providers/aws: use GetOk to check for value [GH-258]
2014-09-08 20:24:43 -07:00
634dd7e4a3
Merge pull request #260 from jkinred/master
...
providers/amazon: Allow building of EC2 instances with ebs_optimized flag
2014-09-07 16:01:59 -07:00
781e512dde
fix associate_public_ip_address parameter name
2014-09-03 20:54:36 +09:00
2b764de383
Allow building of EC2 instances with ebs_optimized flag
2014-09-03 20:18:40 +10:00
125977e075
allow vpc_zone_identifier in aws_autoscaling_group
2014-09-03 09:38:07 +08:00
3a3e3346d5
providers/aws: route53 record destroy in parallel works
2014-08-31 09:12:05 -07:00
c9a541d95b
helper/schema: generate a full diff in destroy/create cycle
2014-08-27 15:45:52 -07:00
b7e16c6b53
providers/aws: source_dest_check applies [GH-229]
2014-08-26 15:05:36 -07:00
56cf1e6faa
Fix go vet complaints
2014-08-24 21:50:35 -07:00
e530eea226
provider/aws: fix panic when user_data receives nil from StateFunc
2014-08-23 00:20:41 -07:00
623c635fb1
providers/aws: can create records with multiple values [GH-221]
2014-08-22 17:19:39 -07:00
c886148e15
providers/aws: use example.com for tests
2014-08-22 12:51:19 -07:00
ed99d2497b
providers/aws: retry route53 operations [GH-183]
2014-08-22 12:51:11 -07:00
8f70920c17
providers/aws: fix some other issues with aws_instance
2014-08-22 12:20:06 -07:00
ba68be5672
providers/aws: use StateFunc to process the user_data
2014-08-22 08:46:48 -07:00
f26a2700a1
fmt
2014-08-22 08:46:03 -07:00
7be2f1b091
helper/schema: add GetOk
2014-08-21 23:03:04 -07:00
2fd2470c92
providers/aws: resource_aws_instance partially to schema.Resource
2014-08-21 18:38:43 -07:00
b6c5e5bbf6
Allow aws_instance private IP's to be specified
2014-08-21 17:13:36 -07:00
cdc2a53553
providers/aws: changing order of security group cidrs doesn't affect
...
things
2014-08-21 14:10:09 -07:00
5b620b76f5
providers/aws: update comment
2014-08-21 12:00:32 -07:00
200f7c4488
providers/aws: can add remove individual cidr/groups in security group
2014-08-21 11:59:03 -07:00
4015d942ab
providers/aws: security group ingress rules treated as set [GH-87]
...
/cc @pearkes - !!!
2014-08-20 22:24:13 -07:00
6eb6d19384
providers/aws: vpc dns settings tests
...
cc/ @deoxxa see diff for how to add tests – quite straight forward.
Normally, I would like to add a check to ensure that the attribute
was updated remotely (by seeing what it's value with AWS is) but
I don't think we have that value returned.
2014-08-20 11:29:52 -07:00
53cdbcc9fa
providers/aws: security group ingress rules can be updated
2014-08-20 11:18:16 -07:00
a594ef9a28
providers/aws: expandIPPerms works again
2014-08-20 11:18:16 -07:00
33a7d32f40
Merge pull request #172 from deoxxa/add-vpc-dns-attributes
...
add vpc dns attribute support
2014-08-20 11:14:07 -07:00
97cae408b2
providers/aws: tests and document adding load balancers to autoscaling
...
cc/ @thatha
2014-08-20 10:42:14 -07:00
89041c0595
providers/aws: resource_aws_security_group using helper/schema
2014-08-20 10:40:18 -07:00
13b0e7ee2c
Allow 'load_balancers.*' to pass resource_aws_autoscaling_group_validation
2014-08-19 19:53:12 -07:00
d25747ba5c
providers/aws: cleaner detection of VPC [GH-122]
2014-08-19 17:22:25 -07:00
c4d261ac61
providers/aws: resource_aws_eip is in new framework
2014-08-19 16:56:23 -07:00
776bb22e4e
providers/aws: create an empty schema.Provider
2014-08-19 15:40:48 -07:00
d99e475ea2
Merge pull request #170 from alekstorm/aws-security-group-owner
...
Implement specification of AWS security groups in ingress rules as <owner>/<id>
2014-08-19 09:42:05 -07:00
4cdb95a6b2
Merge pull request #166 from alekstorm/aws-elb-subnets-security-groups
...
Add 'security_groups' and 'subnets' args to 'aws_elb'
2014-08-19 09:40:30 -07:00
ca5be43519
providers/aws: fix RDB test syntax error
2014-08-11 09:58:53 -07:00
8d97c3656c
Add listener.ssl_certificate_id support to AWS ELB
2014-08-10 17:16:53 -07:00
4405a8d974
add vpc dns attribute support
2014-08-09 22:43:00 +10:00
7109b8c770
Implement specification of AWS security groups in ingress rules as <owner>/<id>
2014-08-08 11:51:18 -07:00
5a84296c61
Add 'security_groups' and 'subnets' args to 'aws_elb'
2014-08-07 17:41:15 -07:00
46154ca1d3
Fixed a ton of typos in docs and comments
2014-08-07 00:19:56 -07:00
f869a077a2
Fix output of aws_db_instance port via endpoint
...
When trying to output the `endpoint` attribute of an `aws_db_instance`,
the port was not being emitted properly. Converting the port number from
an integer to a string has resolved the issue.
2014-08-01 17:13:26 -04:00
c6741cf1b5
providers/aws: add tests for instance availability zone
...
cc/ @dcosson here we go!
2014-07-31 20:35:31 -04:00
aa94e0c41a
Merge pull request #129 from dcosson/aws_availability_zone
...
Allow specifying the AWS availability zone on creation
2014-07-31 15:28:34 -04:00
e07dc8891d
providers/aws: db instance wait for destroy, allow destroy config
2014-07-31 15:22:14 -04:00
e838624468
Allow specifying the AWS availability zone on creation
2014-07-31 13:52:03 -04:00
0ca0b8dd62
providers/aws: remove password from resource diff to not trigger changes
...
cc/ @mitchellh
This one caught me a bit, and I'm not sure if there's another AttrType
that could be useful here – perhaps a AttrTypeHidden or something? I
don't know...this feels sloppy to have in the diff func.
2014-07-31 09:39:19 -04:00
9a2685cf13
providers/aws: db instances now depend on db security groups
2014-07-31 09:28:25 -04:00
bc79f15db3
providers/aws: require description in security groups. fixes #123
2014-07-30 17:15:51 -04:00
60ed50b4b6
providers/aws: allow "modifying" as pending state for db instances
...
fixes #119
2014-07-30 11:58:11 -04:00
7493ee31cb
Stop passing engine into EngineVersion
...
Fixes #95
2014-07-30 16:44:02 +01:00
7adc6162d8
providers/aws: add test for health check, save health check state
...
cc/ @vertis
I added an acceptance test here, as well as making it so we
saved the health check state on update_state.
2014-07-30 10:15:22 -04:00
0eed0908df
Add health_check to aws_elb resource
2014-07-30 21:46:51 +10:00
af62002c1b
go fmt
2014-07-29 19:09:55 -04:00
77697b9936
providers/aws: add failing test for aws region validation
...
cc/ @jorgeng87
2014-07-29 19:09:17 -04:00
aad0fec940
Update test with valid AWS region
2014-07-30 00:22:50 +02:00
5900b3f1c0
Add AWS region validation
2014-07-30 00:22:37 +02:00
15bdf8b5f9
Add user_data to aws_launch_configuration
2014-07-30 07:30:24 +10:00
cbcb559c0c
providers/aws: add failing test for reorder ingress rules bug
2014-07-29 15:03:51 -04:00
6653542466
providers/aws: fix order of ingress rules on security group
2014-07-29 12:45:57 -04:00
dbe6b74884
providers/aws: depend on security groups, failing test for #87
2014-07-29 12:15:42 -04:00
d47e3f76ea
providers/aws: fix spelling of desired_capacity
...
see #78
2014-07-29 10:43:18 -04:00
4f2026f6c6
providers/aws: only flatten cidr if they exist
...
fixes #87
2014-07-29 10:29:48 -04:00
86c7aeb8a6
providers/aws: use merged reosource state for associate_public_ip
...
cc/ @vertis
2014-07-29 10:23:48 -04:00
fa13a12a6e
Merge pull request #85 from vertis/aws_associate_public_ip_address
...
Add associate_public_ip_address as an attribute on the aws_instance resource
2014-07-29 10:15:32 -04:00
da4ddef136
providers/aws: fix assertion of non-required cidr blocks in sec groups
...
fixes #65 , #86
2014-07-29 10:05:32 -04:00
974074fee9
Add associate_public_ip_address as an attribute of the aws_instance resource
2014-07-29 22:06:53 +10:00
be1ae66d86
provider/aws: fixing tests
2014-07-28 13:27:55 -04:00
8c69536b3b
provider/aws: fixing security groups test
2014-07-28 13:14:24 -04:00
f6fa012e82
providers/aws: remove security_group_update
2014-07-28 13:13:29 -04:00
c2677b3c0a
provider/aws: More strict check
2014-07-28 12:50:19 -04:00
c8d5ea4d9d
provider/aws: fixing instance for EC2-VPC /cc:@pearkes
2014-07-28 12:47:40 -04:00
bc64366a92
provider/aws: Less aggressive API rate
2014-07-28 12:10:35 -04:00
ebd50ab6ff
provider/aws: Fixing EIP in EC2-VPC
2014-07-28 12:05:00 -04:00
c3b0417678
provider/aws: Fixing tests
2014-07-28 11:27:58 -04:00
e596feb42b
provider/aws: Fixing launch config depdency
2014-07-28 11:27:58 -04:00
7ef47671b0
providers/aws: only security group and instances if we have them
2014-07-27 21:20:03 -04:00
18333f149e
provider/aws: route53 zone detects deletion
2014-07-26 21:24:20 -04:00
b1fc87fe59
providers/aws/aws_eip: support update (reassociation)
...
/cc @pearkes - woot
2014-07-26 15:53:26 -07:00
298483131b
providers/aws: fixed tons of aws stuff
2014-07-24 18:50:33 -04:00
ca43c44a85
providers/aws: Re-order entries
2014-07-23 23:35:03 -04:00
5065aff158
provider/aws: Improve validation of configs
2014-07-23 15:14:35 -04:00
703d115638
providers/aws: remove logging
2014-07-23 09:16:23 -04:00
27fe1e0226
rds: fix engine version
2014-07-22 23:13:58 -04:00
b6503a7810
provider/aws: Adding route53 records support
2014-07-22 23:08:41 -04:00
b924151914
rds: add attribute checks
2014-07-22 22:54:18 -04:00
4da83b9eca
providers/aws: db sec group
2014-07-22 22:23:09 -04:00
dde83f7cdd
providers/aws: slow down the wait for state for dbinstance
2014-07-22 18:45:59 -04:00
12d54bd949
provider/aws: Slow down our r53 waits
2014-07-22 18:44:59 -04:00
8e7e65770d
provider/aws: Support for Route53 zones
2014-07-22 17:55:19 -04:00
2f26ac97c2
providers/aws: add rds
2014-07-22 16:26:58 -04:00
64f7a1dc89
provider/aws: Adding support for aws_s3_bucket
2014-07-21 14:34:50 -04:00
916ca711ad
providers/aws/aws_security_group: we need to check for one other error
2014-07-17 11:28:40 -07:00
99ac8fc68e
providers/aws/aws_security_group: wait for it to exist
2014-07-17 11:14:51 -07:00
388bcfa7b4
providers/aws: VPC assignment fix, and dependencies for destroy
2014-07-17 10:03:15 -07:00
24ecb1ae70
providers/aws/aws_vpc: fix error message referencing ELB
2014-07-17 09:46:31 -07:00
d956880e2f
providers/aws/aws_route_table: can set routes on instance_id
2014-07-17 09:21:55 -07:00
79dbd07679
providers/aws: no empty security groups when flattening ip perms
...
/cc @pearkes - A few things here:
First, this fixes the issue you mentioned to be in chat. Basically: if
there are no security groups, don't put it into flatten, because flatten
will include a "key.#" = "0".
Next, I transformed your test into a "table-driven" test which are really
nice to write and maintain. Basically, as you find bugs or edge cases, you can
just add to the table and you get the test for free. I recommend these
whereever you have a pure input to output sort of data transformation
function.
2014-07-16 18:32:36 -07:00
bcc6f884b1
providers/aws: actually return ingress rule on refresh, tests
2014-07-16 20:14:01 -04:00
a6bb0144a6
providers/aws: remove some debug
2014-07-16 16:46:28 -07:00
0d8f6645fa
providers/aws/aws_instance: user_data diffs properly
2014-07-16 16:41:20 -07:00
901785d04a
providers/aws: expand wildcard string lists
2014-07-16 18:51:50 -04:00
9ec1990608
providers/aws/aws_instance: fix security group and key name issues in count
2014-07-16 15:21:01 -07:00
1e81b13943
providers/aws: elb updates
2014-07-16 17:02:54 -04:00
082790c4c1
providers/aws: basic user data, doesn't fully work yet because diffs are broke
2014-07-16 09:01:56 -07:00
eafbc8d8c6
providers/aws: improve security group acc tests
2014-07-16 11:14:23 -04:00
0252b5e3e5
providers/aws: fix tests for aws_security_group
2014-07-16 10:50:52 -04:00
dff47bdbbe
providers/aws: fix eip test
2014-07-16 10:40:48 -04:00
3d91632e5b
Merge pull request #21 from hashicorp/f-ssh
...
Adding "remote-exec" provisioner
2014-07-15 22:02:33 -07:00
a55ee34aba
providers/aws: autoscaling updates, fix create for new goamz api
2014-07-15 17:20:54 -04:00
0d4fdfc6fd
providers/aws: no update for launch configuration
2014-07-15 16:00:12 -04:00
104b28e19e
terraform: Remove ResourceConnectionInfo, use raw map
2014-07-15 12:34:07 -07:00
9cd69a2b29
aws: Expose host in the ConnInfo
2014-07-15 12:34:07 -07:00
1d6dc475df
providers/aws: fix security group validations
2014-07-15 14:19:24 -04:00
ff0741a12e
providers/aws: security group validations
2014-07-15 12:40:20 -04:00
278dd49a4d
providers/aws: launch configuration validation
2014-07-15 12:36:29 -04:00
86e935bfd5
providers/aws: autoscaling group config validation
2014-07-15 12:31:49 -04:00
a87f2a7987
providers/aws: elb, eip config validations
2014-07-15 12:18:36 -04:00
3c3e584beb
providers/aws: ELB capitilization
2014-07-15 11:13:18 -04:00
95323b537d
providers/aws: fix elb tests
2014-07-15 08:49:40 -04:00
16c99e78b3
providers/aws: security_groups support
2014-07-14 21:56:37 -07:00
72b7e2c11a
providers/aws/aws_instance: key_name
2014-07-14 17:52:29 -07:00
735c909264
providers/aws/aws_instance: test modifying source_dest_check
2014-07-14 17:38:56 -07:00
0a6b7a9301
providers/aws: more elb test fixes
2014-07-14 18:57:04 -04:00
d8f5914ecb
providers/aws: elb tests
2014-07-14 18:48:22 -04:00
e71bc9d5a5
Merge branch 'acc-temp'
2014-07-14 18:31:10 -04:00
1bcdba6f84
providers/aws: tests for eip
2014-07-14 18:30:31 -04:00
b386717381
providers/aws: basic eip structure
2014-07-14 17:59:08 -04:00
2fa6ca1c4e
providers/aws/aws_instance: source_dest_check support
2014-07-14 14:16:59 -07:00
88dd1baafe
providers/aws/aws_instance: can bring up in VPC
2014-07-14 13:46:32 -07:00
7a1c40855e
providers/aws/aws_instance: add availability_zone to state
2014-07-14 13:30:01 -07:00
9f96fb4aac
providers/aws: basic aws_instance test
2014-07-14 13:28:00 -07:00
ac0168df68
providers/aws: add tests for autoscaling launch configuration
2014-07-14 14:10:13 -04:00
9ae89cf3c5
providers/aws: correct destroy func for autoscaling group test
2014-07-14 11:44:15 -04:00
e9dade6967
providers/aws: autoscaling check attr
2014-07-14 11:41:49 -04:00
b9dfe9dc38
providers/aws: autoscaling tests
2014-07-14 11:36:25 -04:00
bd2fe4d145
providers/aws: return proper internet gateway when attach fails
2014-07-13 11:16:59 -07:00
f085ae65fa
providers/aws: fix issue where default route was being added
2014-07-12 17:12:41 -07:00
e0bc61d414
providers/aws: route table association tests
2014-07-11 13:10:09 -07:00
450cbba11a
providers/aws: route table should delete any associations
2014-07-11 12:57:23 -07:00
6a3fa2f4db
providers/aws: aws_route_table_association
2014-07-10 17:17:01 -07:00
9afebeb07e
providers/aws: route table tests
2014-07-10 15:52:56 -07:00
265cc4fffa
providers/aws: extend InternetGateway timeout to be safe
2014-07-10 15:35:41 -07:00
71b30c633f
providers/aws: internetgateway timing tweaks
...
So I think the AWS API is just broken here. In the case that the state
doesn't update, just assume it did after 5 seconds.
2014-07-10 15:33:50 -07:00
af776da7a2
providers/aws: subnet tests
2014-07-10 15:10:05 -07:00
86c4678bee
providers/aws: test internet gateway changing the VPC addr
2014-07-10 14:51:23 -07:00
17b0280724
providers/aws: InternetGateway has to define the update function
2014-07-10 14:24:36 -07:00
2d34f8f209
providers/aws: internet gateway acceptance test
2014-07-10 14:11:45 -07:00
63ef4cf28a
helper/resource: stdlib to check resource attribute
2014-07-10 14:00:20 -07:00
3ff66b430f
providers/aws: check VPC cidr
2014-07-10 13:49:28 -07:00
e992d62717
providers/aws: use precheck for security group
2014-07-10 16:43:03 -04:00
2e767da3df
providers/aws: security group acceptance tests
2014-07-10 16:40:14 -04:00
ac0e29e98e
terraform: races in MockResourceProvider
2014-07-10 13:38:04 -07:00
83f73e63aa
helper/resource: add PreCheck
2014-07-10 13:12:47 -07:00
45d318f573
providers/aws: destroy for autoscaling and launch conf
2014-07-10 15:41:06 -04:00
4a5fb8c0b9
Merge pull request #17 from hashicorp/f-acceptance
...
Acceptance Test Framework
2014-07-10 11:52:11 -07:00
b3fd62beb0
providers/aws: basic VPC test
2014-07-10 11:31:16 -07:00
305994036d
providers/aws: add createlaunchocnfiguration
2014-07-10 14:15:58 -04:00
a98bcf5b06
providers/aws: create routes
2014-07-09 18:41:00 -07:00
e8494826e9
providers/aws: don't merge diff early
2014-07-09 18:13:11 -07:00
05fabb02bd
providers/aws: fix up the route table errors
2014-07-09 17:37:56 -07:00
9c93cfbf75
providers/aws: route tables maybe can make routes
2014-07-09 17:17:24 -07:00
930e3260ad
providers/aws: handle empty list configs, weird lb special case
2014-07-09 19:30:39 -04:00
62a311a341
providers/aws: add autoscalinggroup
2014-07-09 19:00:30 -04:00
d111a4c05d
providers/aws: fix syntax error
2014-07-09 09:51:52 -07:00
fdfed5000f
providers/aws: route table prepare for routes
2014-07-09 09:47:13 -07:00
cf3f26a1de
providers/aws: fix SG typo
2014-07-09 09:18:17 -07:00
a46cafc975
providers/aws: internet gateway is more robust
2014-07-09 09:16:47 -07:00
5ad8d418f2
providers/aws: sg flattening of refresh
2014-07-08 20:25:52 -04:00
251790f05a
terraform: add ID to diff implicitly
2014-07-08 16:58:31 -07:00
2fd5b36550
providers/aws: validation of route table
2014-07-08 16:17:30 -07:00
66c716540f
providers/aws: internet gateway delete is more flexible
2014-07-08 16:05:08 -07:00
5bec1ac383
providers/aws: gateway detach is idempotent
2014-07-08 16:02:01 -07:00
c9bb814917
providers/aws: basic route table creation
2014-07-08 15:56:19 -07:00
637d68140c
providers/aws: ingress and egress rules
2014-07-08 17:47:03 -04:00
47468c32a4
providers/aws: egress and ingress for sg
2014-07-08 16:34:10 -04:00
6368526ac3
providers/aws: security groups
2014-07-08 14:06:51 -04:00
e4a1b2485a
providers/aws: call ValidateResource on Map
...
/cc @pearkes - Here is the thing that hooks it up. Good to go!
2014-07-08 10:18:39 -07:00
f7b7c30055
providers/aws: internet gateway belongs to VPC
2014-07-07 21:03:53 -07:00
c0dbb8febd
providers/aws: much better logic for attaching/detaching internet gateways
2014-07-07 21:00:46 -07:00
037bed71ed
providers/aws: support attaching/detaching internet gateway
2014-07-07 20:51:45 -07:00
bdc2a53c9d
providers/aws: style
2014-07-07 17:12:22 -07:00
e33739209b
providers/aws: its okay to delete something that is already gone
2014-07-07 17:09:05 -07:00
5b95271819
providers/aws: clean up internet gateway code
2014-07-07 16:14:08 -07:00
42e999923a
providers/aws: aws_internet_gateway
2014-07-07 16:12:03 -07:00
2ef36e191b
providers/aws: wait for resource to be gon
2014-07-07 15:44:08 -07:00
65d959003f
providers/aws: setup subnet dependenyc on VPC
2014-07-07 15:38:24 -07:00
0319e89281
providers/aws: remove instance_id manual storage
2014-07-07 18:08:42 -04:00
10e3cad5ce
providers/aws: fix error message for aws_subnet
2014-07-07 15:03:18 -07:00
a31c4e8788
providers/aws: aws_subnet
2014-07-07 14:46:18 -07:00
fac9c6bf10
providers/aws: eip use retrieval helper
2014-07-07 17:42:20 -04:00
e83e0f72b2
providers/aws: eip retrieve func, elb fix state saves after create
2014-07-07 17:38:35 -04:00
feb32e6f8a
providers/aws: add refresh, refactor duplication in retrieve
2014-07-07 17:32:00 -04:00
56e5d20b40
providers/aws: use the proper ID field for vpc
2014-07-07 14:20:36 -07:00
4f2388f787
providers/aws: eip destroy and drefresh
2014-07-07 15:37:38 -04:00
6deea2a93b
providers/aws: handle eventual consistency of AWS in aws_vpc
2014-07-07 12:23:27 -07:00
4f10569037
providers/aws: add EIP provider
...
resource "aws_eip" "public_web" {
instance = "${aws_instance.web.instance_id}"
# Defaults to false
# vpc = "true"
}
2014-07-07 15:20:17 -04:00
e51bdc92fa
providers/aws: aws_vpc
2014-07-07 12:16:58 -07:00
20198cb7aa
providers/aws: ABC, Its as Easy as 123
...
https://www.youtube.com/watch?v=I8GvDLDYhNM&feature=kp
2014-07-07 11:25:54 -07:00
553e0a5d9a
providers/aws: elb destroy
2014-07-07 14:03:40 -04:00
69acd6272a
providers/aws: elb instance registration
2014-07-07 10:07:06 -04:00
d484ebadcd
providers/aws: update
2014-07-07 10:07:06 -04:00
0f64ff9387
providers/aws: availability_zones and expandList
2014-07-07 10:07:06 -04:00
1b6faa0eb9
providers/aws: helper for expanding listeners
2014-07-07 10:07:06 -04:00
339355b2f1
providers/aws: elb hack
2014-07-07 10:07:06 -04:00
5d25de017c
providers/aws: fix for latest ResourceBuilder API
2014-07-07 10:07:06 -04:00
a2815e50eb
providers/aws: first pass at elb support
2014-07-07 10:07:06 -04:00
fd4eeac7dc
providers/aws: timeout in state change conf
2014-07-07 10:07:06 -04:00
2663bb993a
providers/aws: use wait helper
2014-07-07 10:07:06 -04:00
a6d4acaa15
providers/aws: use mitchellh/goamz
2014-07-07 10:07:06 -04:00
4c9a4ad041
providers/aws: add elb layout, move instance into it's own namespace
2014-07-07 10:07:06 -04:00
5dbfed31b6
providers/aws: compile
2014-07-03 13:06:24 -07:00
92e1e09a69
main: fix the help output to show up
2014-06-26 10:24:51 -07:00
6e995feb5e
providers/aws: if no reservations, no instance
2014-06-26 09:58:38 -07:00
fa3ac806cc
providers/aws: use one resourcestate so we don't lose attributes
2014-06-25 23:21:46 -07:00
e8035a5c96
providers/aws: properly create an i nstance after destroy
2014-06-25 18:49:30 -07:00
bd0f23ce25
Move diff to helper/diff, helper/resource knows about it
2014-06-24 10:27:39 -07:00
938b4da8a5
providers/aws: comments
2014-06-24 10:23:09 -07:00
ae142efff7
providers/aws: know how to destroy things
2014-06-24 10:22:22 -07:00
1df3297601
providers/aws: if terminated, no longer exists
2014-06-24 10:15:08 -07:00
391e9fd250
providers/aws: implement Refresh for aws_instance
2014-06-23 19:56:22 -07:00
e91d8643dc
providers/aws: create things
2014-06-23 19:50:19 -07:00
543e70aab1
helper/resource: nice helper for resourceprovider impl
2014-06-23 19:32:49 -07:00
c556e2ad48
providers/aws: start filling out
2014-06-23 19:01:57 -07:00
9b4b89c16c
diff: don't magically put ID in there, assumed if not set
2014-06-23 13:14:08 -07:00
7fa9bedefd
providers/aws: adhere to interface
2014-06-20 11:52:21 -07:00
6618f39797
providers/aws: diff properly
2014-06-19 14:08:48 -07:00
965d403d3d
providers/aws: Apply
2014-06-18 16:52:21 -07:00
4711850cf3
providers/aws: generate diff
2014-06-18 09:33:13 -07:00
0d557a605f
providers/aws: use new diff package
2014-06-17 19:14:44 -07:00
847cd7ac51
diff: lazy resource map
2014-06-17 19:06:13 -07:00
9751878513
terraform: helpers on ResourceConfig
2014-06-12 23:08:47 -07:00
0b9542c5b9
providers/aws: compile
2014-06-12 22:39:29 -07:00
00a8c4f2ca
providers/aws: get tests passing
2014-06-12 22:15:36 -07:00
fa6a87e819
providers/aws: some mock data
2014-06-10 11:34:14 -07:00
54f3ff33b9
providers/aws: pass tests
2014-06-06 20:17:38 -07:00
0c1a341d90
terraform: Resources method for providers
2014-06-03 14:26:31 -07:00
d6d5a97ec9
providers/aws: add the main binary
2014-05-29 17:28:38 -07:00
Mitchell Hashimoto