Commit Graph

16 Commits

Author SHA1 Message Date
Sean Knox a087b29504 Fix contradictory aws_autoscaling_group doc
- Fixes https://github.com/hashicorp/terraform/issues/5457
2016-03-10 22:41:25 -08:00
stack72 d3697fa50b provider/aws: Combine AWS Metrics Collection resource and AWS
Autoscaling Group
2016-02-29 20:58:41 +00:00
Paul Hinze c70eab6500 aws: undeprecate min_elb_capacity; restore min capacity waiting
It was a mistake to switched fully to `==` when activating waiting for
capacity on updates in #3947. Users that didn't set `min_elb_capacity ==
desired_capacity` and instead treated it as an actual "minimum" would
see timeouts for every create, since their target numbers would never be
reached exactly.

Here, we fix that regression by restoring the minimum waiting behavior
during creates.

In order to preserve all the stated behavior, I had to split out
different criteria for create and update, criteria which are now
exhaustively unit tested.

The set of fields that affect capacity waiting behavior has become a bit
of a mess. Next major release I'd like to rework all of these into a
more consistently named block of config. For now, just getting the
behavior correct and documented.

(Also removes all the fixed names from the ASG tests as I was hitting
collision issues running them over here.)

Fixes #4792
2016-01-27 13:30:44 -06:00
Paul Hinze 319f7d77a0 Merge pull request #3947 from hashicorp/phinze/asg-wait-on-update
provider/aws: wait for ASG capacity on update
2016-01-06 15:55:43 -06:00
Paul Hinze 709d1f3599 Merge pull request #3704 from dayer4b/add-placement-group
added placement group as an option for autoscaling groups
2015-12-03 18:05:01 -06:00
Paul Hinze 7f9360797c provider/aws: wait for ASG capacity on update
It's a bit confusing to have Terraform poll until instances come up on
ASG creation but not on update. This changes update to also poll if
min_size or desired_capacity are changed.

This changes the waiting behavior to wait for precisely the desired
number of instances instead of that number as a "minimum". I believe
this shouldn't have any undue side effects, and the behavior can still
be opted out of by setting `wait_for_capacity_timeout` to 0.
2015-11-17 10:25:41 -06:00
Sunil K Chopra 16b0e0d619 documentation, thanks again to stack72 2015-11-02 09:44:29 -06:00
stack72 69b905fb92 Making the AutoScalingGroup name optiona 2015-10-31 09:24:46 +00:00
Paul Hinze 07a9c34e02 Merge pull request #3339 from stack72/aws-asg-docs-3327
docs: Updating the ASG docs to suggest health_check_grace_period is a required field under certain circumstances
2015-10-30 15:46:31 -05:00
Paul Hinze 5f6c03f515 Merge pull request #3191 from hashicorp/f-asg-wait-config
provider/aws: configurable capacity waiting duration
2015-10-14 10:34:55 -05:00
Paul Hinze a811a72f11 provider/aws: fix force_delete on ASGs
The `ForceDelete` parameter was getting sent to the upstream API call,
but only after we had already finished draining instances from
Terraform, so it was a moot point by then.

This fixes that by skipping the drain when force_delete is true, and it
also simplifies the field config a bit:

 * set a default of false to simplify the logic
 * remove `ForceNew` since there's no need to replace the resource to
   flip this value
 * pull a detail comment from code into the docs
2015-10-12 17:10:01 -05:00
stack72 dc27e3d10b Adding a node to AWS AutoScale docs to make it clear that health_check_grace_period is a required field when setting ELB as the health_check_type 2015-09-28 10:51:36 +01:00
Paul Hinze 506aae2f28 provider/aws: configurable capacity waiting duration
move wait for capacity timeout from a constant to a configurable
2015-09-08 13:22:42 -05:00
Dave York 6c6793a260 use name instead of id
- launch configs use the name and not ID
2015-08-17 10:24:25 -04:00
Clint Shryock 55a1a31c2b provider/aws: document that availability zones are now optional in ASGs 2015-07-14 10:24:16 -05:00
Radek Simko ef92a03a9b Docs: Fix name according to reality (autoscaling->autoscaling_group) 2015-05-30 15:50:56 +01:00