Commit Graph

28 Commits

Author SHA1 Message Date
Phil Frost 254b25a64f Fix aws_db_instance to not recreate each time
Several of the arguments were optional, and if omitted, they are
calculated. Mark them as such in the schema to avoid triggering an
update.

Go back to storing the password in the state file. Without doing so,
there's no way for Terraform to know the password has changed. It should
be hashed, but then interpolating the password yields a hash instead of
the password.

Make the `name` parameter optional. It's not required in any engine, and
in some (MS SQL Server) it's not allowed at all.

Drop the `skip_final_snapshot` argument. If `final_snapshot_identifier`
isn't specified, then don't make a final snapshot. As things were, it
was possible to create a resource with neither of these arguments
specified which would later fail when it was to be deleted since the RDS
API requires exactly one of the two.

Resolves issue #689.
2015-01-28 12:03:26 -05:00
Sander van Harmelen 0725486e89 Refactored the last two resources 2014-11-24 14:04:48 +01:00
Sander van Harmelen eccd5ad308 Refactored about 90%
Still need to update 2 resources and check the acceptance tests, but
overall we’re nearly there 😃
2014-11-21 17:58:34 +01:00
Rob Costanzo 16b4dd44c1 Upped the RDS instance creation/destroy timeout to 20 minutes as it regularly takes 12+ minutes to create 2014-11-05 11:03:06 -08:00
Rob Costanzo a14da63a39 Fixed bug with final_snapshot_identifier and skip_final_snapshot and removed apply_method as an option for now and am only supporting immediate mode 2014-11-05 11:03:06 -08:00
Rob Costanzo de16b10555 Added new aws_db_parameter_group resource for creating RDS DB Parameter Groups.
Added plumbing to allow an optional DBParameterGroupName to be passed when creating an RDS DB instance.
2014-11-05 11:03:06 -08:00
Mitchell Hashimoto 6ddcc2ebf8 Merge pull request #309 from alekstorm/aws-db-instance-password
Store aws_db_instance.password in tfstate, change to AttrTypeCreate
2014-10-11 12:34:52 -07:00
Mitchell Hashimoto d8c1ee655c Merge pull request #308 from alekstorm/aws-db-instance-db-subnet-group-name
Rename aws_db_instance.subnet_group_name to db_subnet_group_name
2014-10-11 12:33:58 -07:00
Mitchell Hashimoto 35065fc8c8 providers/aws: properly report errors if DB instance destroy fails
[GH-310]
2014-10-11 11:02:11 -07:00
Mitchell Hashimoto 452cc07ce8 Merge pull request #307 from alekstorm/aws-db-instance-gone
providers/aws: don't error out when RDS DB instance disappears
2014-09-30 13:28:24 -07:00
Mitchell Hashimoto 166847d5dc Merge branch 'f-state'
Conflicts:
	builtin/providers/aws/resource_aws_subnet.go
2014-09-22 08:55:44 -07:00
Alek Storm c7f219a781 Store aws_db_instance.password in tfstate, change to AttrTypeCreate 2014-09-18 13:55:43 -07:00
Alek Storm f928829a1c Don't error out when RDS DB instance disappears 2014-09-18 13:25:30 -07:00
Alek Storm 5b806f0737 Rename aws_db_instance.subnet_group_name to db_subnet_group_name 2014-09-18 13:19:24 -07:00
Mitchell Hashimoto 9b2b3a963f ResourceDiff => InstanceDiff 2014-09-17 16:33:24 -07:00
Mitchell Hashimoto c5d6df692d providers/aws: tests passing, compiles 2014-09-16 17:49:24 -07:00
Eric Buth 4cd11e4091 AWS DB Subnet Group resource and testing 2014-09-15 14:58:04 -04:00
Mitchell Hashimoto 56cf1e6faa Fix go vet complaints 2014-08-24 21:50:35 -07:00
Hector Castro f869a077a2 Fix output of aws_db_instance port via endpoint
When trying to output the `endpoint` attribute of an `aws_db_instance`,
the port was not being emitted properly. Converting the port number from
an integer to a string has resolved the issue.
2014-08-01 17:13:26 -04:00
Jack Pearkes e07dc8891d providers/aws: db instance wait for destroy, allow destroy config 2014-07-31 15:22:14 -04:00
Jack Pearkes 0ca0b8dd62 providers/aws: remove password from resource diff to not trigger changes
cc/ @mitchellh

This one caught me a bit, and I'm not sure if there's another AttrType
that could be useful here – perhaps a AttrTypeHidden or something? I
don't know...this feels sloppy to have in the diff func.
2014-07-31 09:39:19 -04:00
Jack Pearkes 9a2685cf13 providers/aws: db instances now depend on db security groups 2014-07-31 09:28:25 -04:00
Jack Pearkes 60ed50b4b6 providers/aws: allow "modifying" as pending state for db instances
fixes #119
2014-07-30 11:58:11 -04:00
John Wards 7493ee31cb Stop passing engine into EngineVersion
Fixes #95
2014-07-30 16:44:02 +01:00
Jack Pearkes b924151914 rds: add attribute checks 2014-07-22 22:54:18 -04:00
Jack Pearkes 4da83b9eca providers/aws: db sec group 2014-07-22 22:23:09 -04:00
Jack Pearkes dde83f7cdd providers/aws: slow down the wait for state for dbinstance 2014-07-22 18:45:59 -04:00
Jack Pearkes 2f26ac97c2 providers/aws: add rds 2014-07-22 16:26:58 -04:00