Commit Graph

17766 Commits

Author SHA1 Message Date
dannytrigo 92cda8f75d Do not error if compute volume attachment is missing (#13342)
https://github.com/hashicorp/terraform/issues/13334
2017-04-05 06:43:16 +01:00
Brandon Galbraith d310670550 Specify that only elastic load balancers can be defined for `load_balancers` (#13344) 2017-04-04 17:03:20 -05:00
Jake Champlin cc872f9132 Update CHANGELOG.md 2017-04-04 17:04:36 -04:00
Jake Champlin 74a53f71b1 Merge pull request #13261 from harijayms/whiskeyjay/9198fix
provider/azurerm: Fixing crash when importing Local Network Gateways #13301
2017-04-04 17:03:10 -04:00
James Bardin 37e2c23eb9 Merge pull request #13222 from hashicorp/jbardin/init-locks
Fix some backend locking issues
2017-04-04 16:53:21 -04:00
Martin Atkins f57cf5cc05 website: note that destroy provisioners can't run if resource removed
This addresses (via documentation) the issue raised in #13097.
2017-04-04 13:37:37 -07:00
Jake Champlin fed7b6e781 Merge pull request #13129 from tombuildsstuff/validation
provider/azurerm: Moving Reused JSON Validation -> Core
2017-04-04 16:11:13 -04:00
Martin Atkins 9f9fac58e0 Update CHANGELOG.md 2017-04-04 12:17:20 -07:00
Martin Atkins 28d6d913e4 core: basic test of EvalVariableBlock
This previously lacked tests altogether. This new test verifies the
"happy path", ensuring that both literal and computed values pass through
correctly into the VariableValues map.
2017-04-04 12:16:19 -07:00
Martin Atkins c1c5c9a2f6 core: fix crash when computed nested map given in module block
This crash resulted because the type switch checked for either of two
types but the type assertion within it assumed only one of them.

A straightforward (if inelegant) fix is to simply duplicate the relevant
case block and change the type assertion, thus allowing the types to match
up in all cases.

This fixes #13297.
2017-04-04 12:16:19 -07:00
James Bardin fb4a365d12 noop migrate copy, add -lock and -input
A couple commits got rebased together here, and it's easier to enumerate
them in a single commit.

Skip copying of states during migration if they are the same state. This
can happen when trying to reconfigure a backend's options, or if the
state was manually transferred. This can fail unexpectedly with locking
enabled.

Honor the `-input` flag for all confirmations (the new test hit some
more). Also unify where we reference the Meta.forceInitCopy and transfer
the value to the existing backendMigrateOpts.force field.
2017-04-04 14:54:48 -04:00
James Bardin aad143b6d1 set stateLock to true when building meta flagSet
Any commands that use `stateLock` should have a flag to set that
value, but set a failsafe to true just in case.
2017-04-04 14:44:58 -04:00
James Bardin 54aa466b74 initialize the s3 lock path in one place 2017-04-04 14:44:58 -04:00
James Bardin 6980e14191 Update CHANGELOG.md 2017-04-04 14:32:34 -04:00
James Bardin d059939f88 Merge pull request #13262 from hashicorp/jbardin/lock-timeouts
lock timeouts
2017-04-04 14:30:20 -04:00
James Bardin 7cfb515a03 update command docs 2017-04-04 13:50:38 -04:00
Martin Atkins 736ad1e9d8 Update CHANGELOG.md 2017-04-04 10:33:36 -07:00
Martin Atkins dd8af65c82 core: Input walk shouldn't clobber dynamic provider config
During the input walk we stash the values resulting from user input
(if any) in the eval context for use when later walks need to resolve
the provider config.

However, this repository of input results is only able to represent
literal values, since it does not retain the record of which of the keys
have values that are "computed".

Previously we were blindly stashing all of the results, failing to
consider that some of them might be computed. That resulted in the
UnknownValue placeholder being misinterpreted as a literal value when
the data is used later, which ultimately resulted in it clobbering the
actual expression evaluation result and thus causing the provider to
fail to configure itself.

Now we are careful to only retain in this repository the keys whose values
are known statically during the input phase. This eventually gets merged
with the dynamic evaluation results on subsequent walks, with the dynamic
keys left untouched due to their absence from the stored input map.

This fixes #11264.
2017-04-04 10:31:42 -07:00
Matthew Frahry c3175a556f Merge pull request #13337 from hashicorp/p-aws-iam-keybase-test
Removed newline from keybase username
2017-04-04 09:55:39 -06:00
= 92e75ff2cb Removed newline from keybase username 2017-04-04 09:33:49 -06:00
Paul Stack 543c0f4144 Update CHANGELOG.md 2017-04-04 16:21:35 +01:00
Paul Stack 2686768802 provider/aws: Recreate opsworks_stack on change of service_role_arn (#13325)
Fixes: #13305

From the docs - http://docs.aws.amazon.com/cli/latest/reference/opsworks/update-stack.html

```
--service-role-arn (string)

Do not use this parameter. You cannot update a stack's service role.
```
2017-04-04 16:20:53 +01:00
Radek Simko bd78546578 Update CHANGELOG.md 2017-04-04 15:46:52 +01:00
Radek Simko 77fe5f8746 provider/aws: Increase AMI retry timeouts (#13324) 2017-04-04 15:46:14 +01:00
Radek Simko df30bcbb64 Update CHANGELOG.md 2017-04-04 15:45:12 +01:00
Radek Simko 275972ca59 provider/aws: Increase timeout for deploying cloudfront distribution (#13319) 2017-04-04 15:44:17 +01:00
Radek Simko 26b9d0f191 Update CHANGELOG.md 2017-04-04 15:43:32 +01:00
Radek Simko fc72a20c66 command/hook_ui: Increase max length of state IDs (#13317) 2017-04-04 15:41:54 +01:00
Radek Simko 0dddb48239 provider/aws: Improve logging & docs for caller_identity (#13316) 2017-04-04 15:41:30 +01:00
Matthew Frahry 8e470fc01c Merge pull request #13178 from hashicorp/p-aws-randomize-test-names2
provider/aws: Randomize test names
2017-04-04 08:33:24 -06:00
Paul Stack bc4b105e70 Update CHANGELOG.md 2017-04-04 15:33:11 +01:00
Jasmin Gacic 6c40112946 Changed output type of ips variable of ip_block ProfitBricks resource (#13290) 2017-04-04 15:28:02 +01:00
Jake Champlin eb249693c9 Merge pull request #13326 from marccardinal/patch-1
Fixed typo
2017-04-04 09:32:25 -04:00
Marc Vieira-Cardinal (VA2MVC) 82af03aca5 Fixed typo 2017-04-04 08:57:16 -04:00
Paul Stack ffa5fc3361 Update CHANGELOG.md 2017-04-04 11:30:25 +01:00
Paul Stack 6025967c95 provider/aws: Support ip_address_type for aws_alb (#13227)
Fixes: #11429

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSALB_updatedIpAddressType'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/31 20:12:20 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSALB_updatedIpAddressType -timeout 120m
=== RUN   TestAccAWSALB_updatedIpAddressType
--- PASS: TestAccAWSALB_updatedIpAddressType (284.42s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	284.447s
```
2017-04-04 11:29:47 +01:00
Radek Simko 2697532c8f
aws: Randomize IAM policy name in acc test 2017-04-04 11:07:55 +01:00
Tom Harvey 3ec16e7aeb provider/aws: Updating the Elastic MapReduce Cluster Instance Group Docs (#13286)
* Updating the AWS EMR Instance Group docs to fix #13272

* Required -> Optional
2017-04-04 10:27:56 +03:00
Casey Leask e3d4c237a9 Add `min_size` and `max_size` ASG fields (#13312)
These are required fields
```
$ terraform plan
2 error(s) occurred:

* aws_autoscaling_group.bar: "max_size": required field is not set
* aws_autoscaling_group.bar: "min_size": required field is not set
```
2017-04-04 10:24:01 +03:00
Martin Atkins b1fd1c0ba3 Update CHANGELOG.md 2017-04-03 15:18:59 -07:00
Martin Atkins 638038428a Merge #13188: aws_subnet_ids data source 2017-04-03 15:17:15 -07:00
= 35ceeb15f4 final fix after merge with master 2017-04-03 13:27:43 -06:00
James Bardin af2e289212 remove Sleep from TestLockWithContext 2017-04-03 14:46:22 -04:00
Jake Champlin c68675bc4f Update CHANGELOG.md 2017-04-03 14:30:11 -04:00
Jake Champlin 5cce6b9966 Merge pull request #13092 from hashicorp/f-update-sts-caller-identity
provider/aws: Update calling_identity
2017-04-03 14:29:28 -04:00
Jake Champlin 5bf77a6f1d Merge pull request #13226 from hashicorp/f-add-import-id-prefix
core: Add ImportStateIdPrefix field for testing
2017-04-03 14:29:16 -04:00
James Bardin f7776e7e1c Merge pull request #13258 from hashicorp/jbardin/local-init
don't delete local state on a local backend
2017-04-03 14:23:36 -04:00
Jake Champlin 83afa7bf88
add bullets to website docs 2017-04-03 14:15:01 -04:00
Jake Champlin 75e61606bb
dont dereference pointers on Set 2017-04-03 14:10:57 -04:00
Jake Champlin fad0a87f07 Merge pull request #13295 from pradeepbhadani/issue-13294
Issue 13294
2017-04-03 13:59:30 -04:00