Commit Graph

3102 Commits

Author SHA1 Message Date
Paul Hinze b351524367 Merge pull request #4495 from hashicorp/plan3-fixing_heroku_organization_app_read
Heroku Organization App Improvements
2016-01-06 09:18:11 -06:00
Paul Hinze e7057805af Merge pull request #4520 from lwander/b-gcp-acctest-hardcode-name
provider/google: Limit hardcoded test resource names
2016-01-05 22:39:42 -06:00
James Nugent d3f8e1f8e3 Merge pull request #4522 from hashicorp/b-azure-acceptance-tests
provider/azure: Fix up acctest destroy checks
2016-01-05 19:21:20 -06:00
James Nugent 42a3800ec2 provider/azure: Fix up acctest destroy checks
Some resources can only be queried via the network configuration - if
the network configuration does not exist we were failing, however that
is a desirable state since without a network configuration for the
subscription the resources in question cannot exist.
2016-01-05 19:07:12 -06:00
Lars Wander 9a0ecd05eb provider/google: limit hardcoded test resource names 2016-01-05 19:49:06 -05:00
Paul Hinze a8d2ad3ebe refactor s3 bucket test to expect non-empty plan
pushing to master but paging @catsby for post-hoc review
2016-01-05 17:38:38 -06:00
Clint 5b3ef43b1c Merge pull request #4518 from hashicorp/b-aws-resources-tests
providers/aws: Update VPN Gateway test
2016-01-05 16:43:14 -06:00
James Nugent 6364cfe834 Merge pull request #4517 from hashicorp/f-azurerm-register-providers
provider/azurerm: Register needed Azure providers
2016-01-05 16:42:59 -06:00
clint shryock 055482a9f5 providers/aws: Update VPN Gateway test 2016-01-05 16:16:32 -06:00
Lars Wander fb80ec8d33 provider/google: remove conflicting names from acceptance tests 2016-01-05 16:57:24 -05:00
James Nugent a48e713fe0 provider/azurerm: Register needed Azure providers 2016-01-05 16:43:52 -05:00
Clint efeb9b02e6 Merge pull request #4511 from hashicorp/b-aws-resources-tests
provider/aws: More Acc test updates
2016-01-05 14:14:09 -06:00
Paul Hinze 8677f8eea7 provider/google: Collision fixes in compute backend service tests 2016-01-05 12:39:30 -06:00
Paul Hinze c4aff4a585 provider/google: Some more collision avoidance test tweaks 2016-01-05 12:26:44 -06:00
clint shryock 449ffe027f fix error with undefined err 2016-01-05 11:35:21 -06:00
clint shryock 312f2dd6e3 document why we retry in lambda source mapping 2016-01-05 11:27:49 -06:00
clint shryock 6b733a09eb provider/aws: more retrying with Lambda 2016-01-05 11:22:57 -06:00
Paul Hinze 3f697d5b12 Merge pull request #4512 from lwander/b-gcp-fix-sshkey-metadata
provider/google: Fix project metadata sshkeys from showing up
2016-01-05 11:13:14 -06:00
Paul Hinze 0ee57c2d13 Merge pull request #4509 from hashicorp/phinze/google-storage-test-collisions
provider/google: enchance storage acctests to avoid collisions
2016-01-05 11:13:00 -06:00
Lars Wander a006a6a399 provider/google: Fix project metadata sshkeys from showing up 2016-01-05 11:37:52 -05:00
Clint dedc17072e Merge pull request #4510 from hashicorp/b-aws-resources-tests
provider/aws:Updating AWS Acceptance tests
2016-01-05 10:24:39 -06:00
clint shryock 89ca1bc86f Merge branch 'pr-4316' into b-aws-resources-tests
* pr-4316:
  Retry InvalidParameterValueException errors due to newly created resources
2016-01-05 10:17:40 -06:00
clint shryock f0d1193f8f provider/aws: Update Lambda create error handling to be more flexible 2016-01-05 10:17:20 -06:00
clint shryock 1510277f45 update AWS Service Directory delete method and test 2016-01-05 09:33:34 -06:00
Paul Hinze e916bd1527 provider/google: enchance storage acctests to avoid collisions
Generate bucket names and object names per test instead of once at the
top level. Should help avoid failures like this one:

https://travis-ci.org/hashicorp/terraform/jobs/100254008

All storage tests checked on this commit:

```
TF_ACC=1 go test -v ./builtin/providers/google -run TestAccGoogleStorage
=== RUN   TestAccGoogleStorageBucketAcl_basic
--- PASS: TestAccGoogleStorageBucketAcl_basic (8.90s)
=== RUN   TestAccGoogleStorageBucketAcl_upgrade
--- PASS: TestAccGoogleStorageBucketAcl_upgrade (14.18s)
=== RUN   TestAccGoogleStorageBucketAcl_downgrade
--- PASS: TestAccGoogleStorageBucketAcl_downgrade (12.83s)
=== RUN   TestAccGoogleStorageBucketAcl_predefined
--- PASS: TestAccGoogleStorageBucketAcl_predefined (4.51s)
=== RUN   TestAccGoogleStorageObject_basic
--- PASS: TestAccGoogleStorageObject_basic (3.77s)
=== RUN   TestAccGoogleStorageObjectAcl_basic
--- PASS: TestAccGoogleStorageObjectAcl_basic (4.85s)
=== RUN   TestAccGoogleStorageObjectAcl_upgrade
--- PASS: TestAccGoogleStorageObjectAcl_upgrade (7.68s)
=== RUN   TestAccGoogleStorageObjectAcl_downgrade
--- PASS: TestAccGoogleStorageObjectAcl_downgrade (7.37s)
=== RUN   TestAccGoogleStorageObjectAcl_predefined
--- PASS: TestAccGoogleStorageObjectAcl_predefined (4.16s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 68.275s
```
2016-01-05 09:07:45 -06:00
Paul Hinze 5c6304ed57 provider/google: skip remainder of metadata tests
Any of the tests can fail due to
https://github.com/hashicorp/terraform/issues/4504
2016-01-05 08:29:59 -06:00
Paul Hinze c57aae34c1 provider/google: skip failing test so build can go green
Failure reason filed as
https://github.com/hashicorp/terraform/issues/4504, fixing PR can unskip
test as it resolve the underlying issue.
2016-01-04 19:00:53 -06:00
Paul Hinze 4c6c5f5798 provider/google: Fix collisions in SQL instance acctests 2016-01-04 18:04:55 -06:00
clint shryock dd3a2aa4e9 provider/aws: Dynamo DB test/destroy updates 2016-01-04 16:57:31 -06:00
Paul Hinze adf4280aff provider/digitalocean: prevent collision on domain acctest 2016-01-04 16:36:07 -06:00
Paul Hinze 983b34291d provider/google: fix InstanceGroupManager CheckDestroy in tests
Nil check was just backwards. Vetted by comparing to other tests with
similar CheckDestroy implementations
2016-01-04 16:29:31 -06:00
Paul Hinze c52765417a provider/heroku: add acctest covering orgs; fixup issues
Switching up ResourceData interaction to not reach into the internal
dot-notation nesting.
2016-01-04 16:13:52 -06:00
Jakub Janczak 81779aa1d4 Fixing the situation when you've got an organization app, and want to have it in a private area instead 2016-01-04 16:13:52 -06:00
Paul Hinze 7326633060 Merge pull request #4500 from hashicorp/b-route-table-nat-gateway
provider/aws: Don't set NatGatewayId with no value
2016-01-04 16:10:47 -06:00
Paul Hinze 6aadf1489c Merge pull request #4502 from hashicorp/phinze/do-acctest-fixes
provider/digitalocean: acctest improvements
2016-01-04 15:58:21 -06:00
Paul Hinze 028664a015 provider/digitalocean: acctest improvements
* Add SSH Keys to all droplets in tests, this prevents acctests from
   spamming account owner email with root password details
 * Add a new helper/acctest package to be a home for random string / int
   implementations used in tests.
 * Insert some random details into record tests to prevent collisions
 * Normalize config style in tests to hclfmt conventions
2016-01-04 15:30:35 -06:00
James Nugent c519ea74c5 provider/aws: Don't set NatGatewayId with no value
This fixes create aws_route_table resources in regions which do not
support the NAT Gateway yet (e.g. eu-central) - unless a value is
explicitly set in which case the API call will fail until such time as
NAT Gateway is supported.

Fixes #4499.
2016-01-04 16:14:30 -05:00
Clint 89f71d4ec4 Merge pull request #4497 from hashicorp/b-aws-iam-role-test-fix
provider/aws: Update some IAM tests
2016-01-04 14:55:29 -06:00
clint shryock c94815d56d provider/aws: Update some IAM tests 2016-01-04 14:19:12 -06:00
Paul Hinze 5e9e22d4fd provider/google: Allow acctests to set credentials via file
Makes things easier on Travis.
2016-01-04 13:20:21 -06:00
James Nugent 7b9f6e5128 Merge pull request #4490 from hashicorp/b-rds-unexpected-state
provider/aws: Fix RDS unexpected state config
2016-01-04 14:20:13 -05:00
James Nugent 3c330f6e19 provider/aws: Fix RDS unexpected state config
This commit adds the various states (taken from the RDS documentation
here: http://amzn.to/1OHqi6g) to the list of allowable pending states
when creating an RDS instance.

In particular, `resetting-master-credentials` is returned when creating
an `aws_db_instance` from a snapshot. Fixes #4477.
2016-01-04 13:24:29 -05:00
Clint 25238ec7c5 Merge pull request #4427 from hashicorp/b-aws-r53-weights
provider/aws: Fix issue with Route53 and zero weighted records
2016-01-04 10:05:18 -06:00
Colin Hebert ad0a763661 Convert v to string 2016-01-01 10:12:43 +01:00
Colin Hebert 32ce8fbcb4 Add network_mode support to docker 2016-01-01 09:57:21 +01:00
James Nugent 9da5dec5e7 Merge pull request #4342 from aznashwan/f-azure-localnets
provider/azure: added local network gateway resource
2015-12-31 09:52:05 -05:00
James Nugent f5f49be019 provider/azure: Track upstream library changes
vmutils.ConfigureDeploymentFromVMImage has been changed to
vmutils.ConfigureDeploymentFromPublishedVMImage in the upstream library
- this allows us to build.
2015-12-30 14:10:16 -05:00
James Nugent 008dc970b6 provider/azurerm: Fix up network gateway tests
This diff represents the changes  necessary to make local network
gateway tests pass:

- Parse the resource ID instead of relying on attributes
- Remove unecessary logging (which is handled via the autorest wrapper)
- Resource GUID is removed - if this is actually required for anything
  we may need to find a way to supress it during apply, as we get
  spurious diffs in plans otherwise.
- Various typos fixed.
2015-12-23 18:49:21 +02:00
Nashwan Azhari 1eb129a99b provider/azure: added local network gateway resource 2015-12-23 18:49:21 +02:00
Radek Simko d853d2cc93 aws: Add validation for ECR repository name 2015-12-23 16:07:53 +01:00
Radek Simko a367886eaf provider/aws: Separate existing validate functions 2015-12-23 15:11:45 +01:00
Radek Simko b7ed0e1c80 Revert "provider/aws: fix ECS service CheckDestroy in tests"
This reverts commit 47f8b0cd79.

cc @phinze
2015-12-23 11:35:30 +01:00
Radek Simko 9a625427ca aws: Add regression acc test for ecs svc lb changes 2015-12-23 10:43:37 +01:00
Radek Simko 95367bc0fc aws: Fix CheckDestroy for ecs service 2015-12-23 10:17:52 +01:00
James Nugent 6b5c1d50e7 provider/azure: Copy settings file into variable 2015-12-22 17:32:58 -05:00
clint shryock f68a351fba provider/aws: Fix issue with Route53 and zero weighted records 2015-12-22 16:23:08 -06:00
James Nugent 2a7576068f provider/azure: Allow AZURE_SETTINGS_FILE for tests 2015-12-22 17:16:31 -05:00
Paul Hinze 0d895ffa96 provider/aws: mention us-east-1 in ECR docs and tests
ECR is only available in us-east-1 for now.

Also added missing sidebar links for ECR resources.

/cc @nextrevision
2015-12-22 16:00:21 -06:00
James Nugent 4d74bc789e provider/azure: Fix vetting error 2015-12-22 16:55:01 -05:00
Clint c49802de87 Merge pull request #4422 from hashicorp/b-vpc-endpoint-updates
VPC Endpoint test updates
2015-12-22 15:46:59 -06:00
Paul Hinze 0616c51aa2 Merge pull request #4415 from nextrevision/provider/aws-ecr
provider/aws: ecr resources
2015-12-22 15:34:27 -06:00
James Nugent 5c1a246e42 Merge pull request #4426 from hashicorp/b-azure-provider-test
provider/azure: Remove obsolete tests
2015-12-22 16:13:18 -05:00
James Nugent 8aa991cb5d provider/azure: Remove obsolete tests 2015-12-22 16:06:12 -05:00
clint shryock 363defb548 provider/aws: Update Route53 Zone tests 2015-12-22 14:58:43 -06:00
Radek Simko f8bb48b287 aws: Wait for ECS service to be drained before deletion 2015-12-22 21:11:16 +01:00
Radek Simko 583c0a54c4 aws: Fix bug w/ changing ECS service LB association
- fixes #3444
 - fixes #4227
2015-12-22 21:10:23 +01:00
clint shryock 558e839bf2 vpc vpn connection test fixes 2015-12-22 12:53:42 -06:00
clint shryock 70bb536be1 skip TestAccAWSVPCPeeringConnection_tags for now 2015-12-22 12:18:22 -06:00
clint shryock c3d987ab18 VPC Endpoint test updates 2015-12-22 12:12:25 -06:00
Clint 791b2f0ccd Merge pull request #4392 from hashicorp/b-vpc-endpoint-updates
provider/aws: Update VPC Endpoint to correctly set route table ids, a…
2015-12-22 11:44:49 -06:00
Clint 86776e8b42 Merge pull request #4417 from hashicorp/b-aws-elasticache-testupdates
provider/aws: Updates for ElastiCache, ElastiSearch tests
2015-12-22 11:25:20 -06:00
Clint 3fc370285b Merge pull request #4420 from hashicorp/b-aws-s-test-updates
provider/aws: Update tests destroy checks
2015-12-22 11:25:06 -06:00
Paul Hinze b9ea8d8698 provider/aws: fix CheckDestroy for ProtocolPolicy tests
Can only assert that the load balancer is gone, since the test suite
deletes everything, and the load balancer is the way you get to the
proxy protocol policy.
2015-12-22 11:18:11 -06:00
clint shryock 1c2c1a5edb provider/aws: Update tests destroy checks 2015-12-22 11:08:09 -06:00
clint shryock 84fe0b15fd provider/aws: Update ElastiCache tests to verify delete
provider/aws: update elasticache search domain to only save access policies if not empty
2015-12-22 10:21:40 -06:00
Paul Hinze 88b2b86978 Merge pull request #4416 from hashicorp/phinze/aws-network-acl-fixes
provider/aws: fixes for Network ACL Rules
2015-12-22 10:21:05 -06:00
Paul Hinze df0f65502f provider/aws: fix CheckDestroy on placement_group tests 2015-12-22 10:20:28 -06:00
nextrevision 27b8dd08e7 Check for ecr repository and policy removal 2015-12-22 11:18:14 -05:00
Paul Hinze 7f62a49ebd provider/aws: fixes for Network ACL Rules
* Fixup Exists and CheckDestroy assertions
 * Make ingress/egress computed on network_acl, otherwise you could
   never use network_acl_rule with a managed network_acl without a
   perpetual diff.
2015-12-22 09:58:22 -06:00
nextrevision 6a3ed429ad Adding AWS ECR provider resources
Adds ECR aws_ecr_repository and aws_ecr_repository_policy resources to
the AWS provider.
2015-12-22 10:31:30 -05:00
Paul Hinze b7e87bbf16 provider/aws: fix CheckDestroy for main_route_table_association tests 2015-12-22 09:02:01 -06:00
Paul Hinze c8319d3b72 provider/aws: fix CheckDestroy on aws_instance tests 2015-12-22 08:49:50 -06:00
Paul Hinze fd528df002 provider/aws: fix CheckDestroy for iam_group_policy tests 2015-12-22 08:05:37 -06:00
Paul Hinze c8e88ed1b4 provider/aws: fix CheckDestroy for group_membership test 2015-12-22 08:00:55 -06:00
Paul Hinze da2c545c8c Merge pull request #4370 from TimeIncOSS/b-cloudformation-params-fix
provider/aws: CloudFormation - Use body or URL for all updates
2015-12-22 07:56:23 -06:00
Paul Hinze bf40c48075 provider/aws: fix ELB acc tests
* LB Name test could end up too long and fail
 * CheckDestroy was looking for the wrong error code
2015-12-22 07:41:24 -06:00
Paul Hinze 10cc513ae0 provider/aws: fix CheckDestroy for aws_eip tests 2015-12-22 07:34:06 -06:00
Paul Hinze 51732ac9eb provider/aws: fix CheckDestroy for codedeploy_app tests 2015-12-22 07:22:06 -06:00
Paul Hinze 02f14ae34a provider/aws: fix CheckDestroy on glacier vault 2015-12-22 07:17:35 -06:00
Paul Hinze 7d6b98060a provider/aws: fix CheckDestroy on a bunch of resources 2015-12-21 21:43:42 -06:00
Paul Hinze 1d5c65fa86 provider/aws: fix cookie stickiness policy test destroys 2015-12-21 21:23:57 -06:00
Paul Hinze 67832f6bd0 provider/aws: fix cache SG tests
* CheckDestroy should handle not found error
 * Pin provider in config to region most likely to have EC2 Classic
2015-12-21 21:12:47 -06:00
Paul Hinze 47f8b0cd79 provider/aws: fix ECS service CheckDestroy in tests 2015-12-21 21:10:13 -06:00
Paul Hinze f473c2a6d4 provider/aws: don't set static ELB names in tests
Prevents ELB name collisions during test runs
2015-12-21 17:41:55 -06:00
Paul Hinze 3dd8bea986 provider/aws: route table test; use standard account id env var
also moves the env var check inside the PreCheck, which makes it a
little simpler
2015-12-21 15:09:12 -06:00
Paul Hinze 092c268681 provider/aws: kinesis firehose stream: retry through IAM propagation
As I was fixing up the AccTests to not depend on a single existing IAM
role (which this commit does), I noticed that without some sleeping that
the kinesis_firehose_delivery_stream would often come back with:

```
msg: Firehose is unable to assume role {{arn}}. Please check the role provided.
code: InvalidArgumentException
```

Similar to the strategy taken in aws_instance with IAM Instance Profile errors,
I dropped in a simple retry loop which seemed to take care of the issue. Seems
that the same permission propagation delays apply here too.
2015-12-21 14:46:25 -06:00
Simon Thulbourn 3701342716 Alters template provider to use a fork of multipart.
Signed-off-by: Simon Thulbourn <simon+github@thulbourn.com>
2015-12-21 13:32:26 -05:00
Simon Thulbourn 33d2afc26d Add headers to output
The original implmentation was missing headers to denote mime version &
content transfer encoding, this caused issues with EC2.

Signed-off-by: Simon Thulbourn <simon+github@thulbourn.com>
2015-12-21 13:32:26 -05:00
James Nugent ba9c7323a9 Remove unnecessary commented imports 2015-12-21 13:32:26 -05:00
James Nugent abffa67a49 Rename resource.go -> resource_template_file.go
This is necessitated by new resources being added to the template
provider.
2015-12-21 13:32:26 -05:00