Paul Hinze
65d0707d0a
Merge pull request #5717 from hashicorp/phinze/fix-rds-cluster-instance-disappears-crash
...
provider/aws: fix crash when Aurora instance disappears
2016-03-18 13:00:07 -05:00
Paul Hinze
17775205f7
provider/aws: fix crash when Aurora instance disappears
...
Usage of a helper function was assuming that an error would be returned
in a not found condition, when in fact a nil pointer was
returned.
Attached test crashes w/o fix, passes with it.
Fixes #5350
Refs #5418
2016-03-18 12:27:57 -05:00
Bill Fumerola
86bf978550
google_compute_instance_group: Correct error message for invalid instances
2016-03-18 09:25:28 -07:00
Paul Hinze
07caec0d14
Merge pull request #5194 from objectpartners/f-github-provider
...
GitHub Organization Provider
2016-03-17 10:53:13 -05:00
stack72
4db3242c53
provider/azurerm: Scaffolding the AzureRM Virtual Machine Test framework
2016-03-17 15:08:59 +00:00
stack72
cb109043f2
Scaffold the Azure RM Virtual Machine resource
2016-03-17 15:08:59 +00:00
Maxime Bury
ec749d964f
Correctly handle missing lambda function
2016-03-16 14:26:14 -04:00
Paul Hinze
25fce81bfc
provider/aws: log HTTP req/resp at DEBUG level
...
This should be quite helpful in debugging aws-sdk-go operations.
Required some tweaking around the `helper/logging` functions to expose an
`IsDebugOrHigher()` helper for us to use.
2016-03-14 12:26:37 -05:00
Paul Hinze
fff441b4ac
provider/aws: send Terraform version in User-Agent
2016-03-14 12:16:49 -05:00
Paul Hinze
60b239d7d1
provider/aws: Switch to session.Copy to build up configs
...
Found this function which makes the config setup much nicer - looks like
it's meant to be used for the very thing we're doing, which is starting
w/ a base config and customizing it slightly.
https://docs.aws.amazon.com/sdk-for-go/api/aws/session/Session.html#Copy-instance_method
This will make the User-Agent setting code to follow much simpler.
2016-03-14 11:42:37 -05:00
Paul Hinze
76377c9883
Merge pull request #5577 from hashicorp/phinze/remote-exec-empty-file
...
provisioner/remote-exec: Clear out scripts after uploading
2016-03-14 09:54:13 -05:00
Paul Stack
908a2cc178
Merge pull request #5588 from hashicorp/b-digital-ocean-droplet-panic
...
Fix panic in digital_ocean_droplet if resp is nil
2016-03-14 12:37:29 +00:00
Pierre Carrier
a8865b8901
provider/aws: optional fields in aws_autoscaling_lifecycle_hook
...
See hashicorp/terraform/issues/5614
2016-03-14 11:45:17 +00:00
Radek Simko
189e9b5ceb
Merge pull request #5605 from nicolai86/bugfix/verify-ecs-elb-count
...
provider/aws validate number of load_balancers before creating aws_ecs_service
2016-03-13 15:15:00 +00:00
Raphael Randschau
fc0c2c0ea7
Validate number of load_balancers
...
see #5336
2016-03-13 12:51:51 +01:00
Oleg Chunikhin
25383ad5a3
aws: Fix CloudFormation update for parameters & capabilities if not modified
2016-03-13 08:10:57 +00:00
Radek Simko
8612cc3373
aws: Improve acceptance test for CloudFormation w/ all attributes
2016-03-13 08:10:54 +00:00
clint shryock
66eb7c6055
provider/aws: Guard against Nil Reference in Redshift Endpoints
2016-03-11 12:16:29 -06:00
Radek Simko
d8b36532ef
Merge pull request #5239 from TimeIncOSS/f-aws-lambda-func-updates
...
provider/aws: Add support for updating Lambda function
2016-03-11 16:59:18 +00:00
Paul Hinze
96ebf0af0e
provisioner/remote-exec: Clear out scripts after uploading
...
Prevents residual script contents from remaining on machine.
Fixes #482
2016-03-11 10:25:11 -06:00
James Nugent
d9d8208a91
Fix panic in digital_ocean_droplet if resp is nil
...
Fixes #5583 .
2016-03-11 16:00:13 +00:00
Joe Topjian
edb30d52c6
Merge pull request #5557 from pfrybar/master
...
provider/openstack: Fix create/delete statuses in load balancing resources for openstack provider.
2016-03-10 22:46:36 -07:00
Paul Hinze
82765ea589
Merge pull request #5453 from bigkraig/aws-s3-kms-key
...
provider/aws: Support KMS encryption of S3 objects
2016-03-10 15:44:10 -06:00
Paul Hinze
5ce68fd1bd
Merge pull request #5571 from hashicorp/revert-5193-f-aws-instance-security-groups-updates
...
Revert "provider/aws: Support additional changes to security groups of instance without forcing new"
2016-03-10 15:09:16 -06:00
Clint
7c58f145fd
Merge pull request #5570 from hashicorp/b-aws-acc-test-updates
...
provider/aws: More Acc test updates
2016-03-10 15:04:33 -06:00
Paul Hinze
e9c4d4f6d5
Revert "provider/aws: Support additional changes to security groups of instance without forcing new"
2016-03-10 14:51:30 -06:00
clint shryock
02ba1bf2d4
provider/aws: More Acc test updates
...
Working on the green
- randomize some Autoscaling lifecycle hook test names
- use vpc_security_group_ids for this test
2016-03-10 14:33:54 -06:00
Lars Wander
0254f95cc9
Merge pull request #5564 from lwander/b-gcp-route-network
...
provider/google: Mark next_hop_network as read only.
2016-03-10 14:38:08 -05:00
Paul Hinze
4e9e0ec5ca
Merge pull request #5563 from hashicorp/phinze/deprecate-template-path
...
provider/template: warn when template specified as path
2016-03-10 13:30:23 -06:00
Lars Wander
f8784df82b
provider/google: Mark next_hop_network as read only.
2016-03-10 13:58:09 -05:00
Paul Hinze
0036db8f82
provider/template: warn when template specified as path
...
Turns out the BC code allowed users to move from `filename` to
`template` to squash the warning without having to switch from template
paths to template contents.
Here we warn when `template` is specified as a path so we can remove the
functionality in the future and remove this source of confusion.
refs #3732
2016-03-10 12:34:56 -06:00
Martin Atkins
2e33f5311c
Treat each consul key as having its own lifecycle
...
Previously this resource managed the set of keys as a whole rather than
the individual keys, and so it was unable to recognize when a particular
managed key is removed and delete just that one key from Consul.
Here this is addressed by recognizing that each key actually has its own
lifecycle, and detecting when individual keys are added and removed
without replacing the entire consul_keys instance.
Additionally this restores the behavior of updating the "value" attribute
on read, but restricts it only to blocks that already had a value so as
to avoid the quirkiness seen previously when we updated blocks that were
intended to be read-only. Updating the value is important now, because we
rely on this to detect and repair discrepancies between values stored in
Consul and values given in the configuration.
This change produces a change in the handling of the "delete" attribute.
Before it was considered only when the entire consul_keys resource was
deleted, but now it is considered also when a particular key block is
removed from within a resource.
2016-03-10 07:52:43 -08:00
Martin Atkins
df2ce588bc
Specialized client for interacting with Consul keys
...
This deals with some of the quirks of interacting with the Consul API,
with the goal of making the consul_keys resource implementation, and
later the consul_keys data source, less noisy to read.
2016-03-10 07:51:27 -08:00
Paul Frybarger
d8c9e448d4
Fix create/delete statuses in load balancing resources for openstack provider.
2016-03-10 09:35:38 -06:00
Clint
99ddea503d
Merge pull request #5495 from nicolai86/bugfix/aws_security_group-protocol-case-sensitivity
...
provider/aws Always transform aws_security_group protocol to lower case
2016-03-10 09:34:55 -06:00
Clint
239b3e4f5f
Merge pull request #5533 from hashicorp/pr-5184
...
provider/aws: Fix EC2 Classic SG Rule issue
2016-03-10 08:56:29 -06:00
Radek Simko
d777141a7b
provider/aws: Add tests for Lambda function updates
2016-03-10 12:31:35 +00:00
Radek Simko
fdc21aad25
provider/aws: Simplify update logic for Lambda function
2016-03-10 12:31:35 +00:00
Chris Marchesi
b5c7521f52
aws_lambda_function: Force code update on SHA sum mismatch
2016-03-10 12:31:35 +00:00
Rob Zienert
4aeb5bb8e9
Adding support for Lambda function updates
2016-03-10 12:31:35 +00:00
Kraig Amador
76b3c74a58
Providing a more informative error message when combining kms_key_id and etag as well as using aws_kms_key to test aws_s3_bucket's kms_key_id.
2016-03-09 19:06:36 -08:00
Paul Hinze
5ece31dc88
Merge pull request #5501 from evandbrown/vpnval
...
provider/google: Validate VPN tunnel peer_ip
2016-03-09 18:55:10 -06:00
Paul Hinze
c1f8dda863
Merge pull request #5497 from evandbrown/flakeygcs
...
provider/google: Address flaky GCS acceptance tests.
2016-03-09 18:48:44 -06:00
Paul Hinze
d12944797a
Merge pull request #3928 from TimeIncOSS/aws-kms
...
provider/aws: Add support for KMS
2016-03-09 18:30:06 -06:00
Paul Hinze
108ccf0007
builtin: Refactor resource.Retry to clarify return
...
Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.
Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.
This makes it eminently clear whether or not a given error is
retryable from inside the client code.
Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
2016-03-09 17:37:56 -06:00
Paul Stack
ab075bca60
Merge pull request #5193 from innossh/f-aws-instance-security-groups-updates
...
provider/aws: Support additional changes to security groups of instance without forcing new
2016-03-10 00:28:32 +01:00
James Nugent
7436cf7f89
Merge pull request #5376 from stack72/b-aws-ELBListner
...
provider/aws: Fixes the use of Uppercase chars in ELB Listeners
2016-03-09 23:18:56 +00:00
Paul Hinze
ffa5db4f52
Merge pull request #5538 from hashicorp/phinze/retryerror-pointers-are-evil
...
provider/aws: Fix all pointer RetryError returns
2016-03-09 16:53:19 -06:00
Brad Sickles
3f41515d2b
Fixing noop differences in aws_route.
2016-03-09 23:27:09 +01:00
Brad Sickles
16f94ed4b7
Added failing aws_route test that shows diff after apply.
2016-03-09 23:27:09 +01:00