787e3d4ff3
Merge pull request #4460 from kozo002/fix_typo_in_website_aws_db_instance
...
Fix typo 'auto' => 'allow'
2015-12-30 14:30:20 -05:00
2503f0b01d
provider/openstack: Ensure valid Security Group Rule attribute combination
...
This commit ensures that a valid combination of security group rule attributes
is set before creating the security group.
2015-12-30 18:44:56 +00:00
fc39334b52
update docs to reflect that the allocation ID is exported as the attribute 'id'
2015-12-30 17:50:22 +00:00
a018195645
Remove recommendation to use create_before_destroy-hook in autoscaling group
...
Only use the create_before_destroy-hook in launch configurations. The autoscaling group must not use the create_before_destroy-hook, because it can be updated (and not destroyed + re-created). Using the create_before_destroy-hook in autoscaling group also leads to unwanted cyclic dependencies.
2015-12-30 10:46:32 +01:00
2a3c80461f
Fix typo 'auto' => 'allow'
2015-12-30 16:58:23 +09:00
bf7220aa53
Update outputs.html.md
...
Fixes small syntax error
2015-12-29 17:21:58 -07:00
9fb631a076
Update Build documentation to use t2.micro
...
This just helps it stay consistent across the doc.
2015-12-29 15:23:38 -08:00
52aea649e4
Update lb_pool_v1.html.markdown
...
updating docs to match behavior of the code for admin_state_up
2015-12-28 11:25:46 -08:00
59bfa636c0
Adding a link to the runtime options for the AWS Lambda functions
2015-12-27 21:38:45 +00:00
b6788479de
Add Terraform/Remote State documentation to provider/resource section.
...
Issue #2074
2015-12-27 19:04:27 +01:00
8eb65bec95
Merge pull request #4425 from sethbergman/patch-1
...
Update install.html.markdown to include examples for $PATH
2015-12-24 17:51:36 -05:00
1eb129a99b
provider/azure: added local network gateway resource
2015-12-23 18:49:21 +02:00
6017d0bf97
Merge pull request #4432 from TimeIncOSS/f-aws-ecr-docs-fix
...
docs/aws: Fix highlighting of ECR in sidebar
2015-12-23 11:16:08 -05:00
6fb4c6f91b
Merge pull request #4433 from betawaffle/packet-docs
...
Clarify the docs for Packet a bit.
2015-12-23 11:15:20 -05:00
ae7dcfcf1b
docs/aws: Fix highlighting of ECR in sidebar
2015-12-23 16:21:22 +01:00
00da717302
docs/aws: Whitespaces removed
2015-12-23 16:19:28 +01:00
787340f801
make note of -1 value for r53 record
2015-12-22 16:47:57 -06:00
0d895ffa96
provider/aws: mention us-east-1 in ECR docs and tests
...
ECR is only available in us-east-1 for now.
Also added missing sidebar links for ECR resources.
/cc @nextrevision
2015-12-22 16:00:21 -06:00
0616c51aa2
Merge pull request #4415 from nextrevision/provider/aws-ecr
...
provider/aws: ecr resources
2015-12-22 15:34:27 -06:00
47ea43394f
Update install.html.markdown
...
Added example commands for setting environment paths in Linux/Unix and Windows.
2015-12-22 14:18:29 -06:00
6a3ed429ad
Adding AWS ECR provider resources
...
Adds ECR aws_ecr_repository and aws_ecr_repository_policy resources to
the AWS provider.
2015-12-22 10:31:30 -05:00
d9b83ada39
Update ebs_volume.html.md
...
add default value of volume type
2015-12-22 17:27:44 +03:00
b2964a6443
Merge branch 'lusis-artifactory-remote-state'
2015-12-21 17:48:53 -05:00
562b7dfab7
Add documentation for Artifactory remote state
2015-12-21 17:46:55 -05:00
399db54f03
Merge pull request #4405 from hashicorp/b-aws-docs
...
provider/aws: Update docs with t1 instance for accounts with EC2 Classic
2015-12-21 16:35:26 -05:00
3cdcaf5321
Merge pull request #4095 from hashicorp/cloudinit-provider
...
New resource: Cloudinit Multipart Configuration
2015-12-21 13:40:17 -05:00
a4568c596e
Fix CloudInit doc format and give better example
2015-12-21 13:32:26 -05:00
16c8750bab
Make minor alterations to the cloudinit docs
2015-12-21 13:32:26 -05:00
a926fa6fdd
Adds template_cloudinit_config resource to template
...
This adds a new resource to template to generate multipart cloudinit
configurations to be used with other providers/resources.
The resource has the ability gzip and base64 encode the parts.
2015-12-21 13:32:26 -05:00
c94b7c4584
provider/aws: Update docs with t1 instance for accounts with EC2 Classic
2015-12-21 10:00:34 -06:00
bf03752552
Adding the documentation for the AWS Redshift Subnet Group resource
...
also removed the notion of tags from the redshift security group and
parameter group documentation until that has been implemented
Redshift Cluster CRUD and acceptance tests
Removing the Acceptance test for the Cluster Updates. You cannot delete
a cluster immediately after performing an operation on it. We would need
to add a lot of retry logic to the system to get this test to work
Adding some schema validation for RedShift cluster
Adding the last of the pieces of a first draft of the Redshift work - this is the documentation
2015-12-20 20:20:05 +00:00
48091e37c7
Adding the documentation for the Redshift Parameter Groups
...
Changed the aws_redshift_security_group and aws_redshift_parameter_group
to remove the tags from the schema. Tags are a little bit more
complicated than originally though - I will revisit this later
Then added the schema, CRUD functionality and basic acceptance tests for
aws_redshift_subnet_group
Adding an acceptance test for the Update of subnet_ids in AWS Redshift Subnet Group
2015-12-20 20:20:03 +00:00
249e7df76c
Adding the documentation for the Redshift security groups
...
Creation of the schema, CRUD and acceptance tests for Redshift Parameter Group
2015-12-20 20:20:01 +00:00
e86104fc35
cleanup footer hashicorp logo
2015-12-20 11:49:02 -08:00
ec0582d5b4
capital C in by hashicorp lockup
2015-12-19 21:33:48 -08:00
c90d1b074e
Merge pull request #4386 from hashicorp/b-aws-rds-notes
...
Better document RDS `apply_immediately`
2015-12-19 10:51:59 -05:00
d932d99679
Adds documentation for the AWS Network ACL Rule resource
2015-12-18 23:17:08 +00:00
48bfd67296
Add support for creating connectors to aws_directory_service_directory
...
This adds support for creating AD Connectors. It is pretty close to the
same as creating AD and simple directories so we reuse the resource.
2015-12-18 21:42:54 +00:00
0bdf249f2c
provider/aws: Add aws_nat_gateway Resource
2015-12-18 14:12:27 -05:00
82fe67f7fc
Add support for creating Managed Microsoft Active Directory in AWS
...
This action is almost exactly the same as creating a SimpleAD so we
reuse this resource and allow the user to specify the type when creating
the directory (ignoring the size if the type is MicrosoftAD).
2015-12-18 18:24:51 +00:00
93b63cc42d
document for ElastiCache cluster, and fix link
2015-12-18 11:43:33 -06:00
a5efa4a1fa
Better document RDS apply immediately
2015-12-18 11:24:59 -06:00
8d5a2d05a4
provider/openstack: Load Balancing Member Resource
...
This commit adds the openstack_lb_member_v1 resource. This resource models a
load balancing member which was previously coupled to the openstack_lb_pool_v1
resource.
By creating an actual member resource, load balancing members can now be
dynamically managed through terraform.
2015-12-17 07:29:58 +00:00
ef0b870425
Merge pull request #4356 from lowescott/issue-4319
...
provider/openstack: Add section on referencing security groups by name
2015-12-16 22:16:44 -07:00
a9d97708ee
mysql provider and mysql_database resource.
...
Allows databases on pre-existing MySQL servers to be created and managed
by Terraform.
2015-12-16 17:59:35 -08:00
e8eb2e3573
Changing the ingress structure to be required in DB Security Group - this was marked as optional in the docs whereas the schema has it as required
2015-12-17 01:18:53 +01:00
1a9eab2cbe
Add section on referencing security groups by name
...
Added new section to end of Markdown file for OpenStack security groups,
recommending that security groups are referenced by the name attribute
instead of by the ID attribute.
2015-12-16 16:36:00 -07:00
03a7926198
Merge pull request #4298 from jtopjian/jtopjian-openstack-devstack
...
provider/openstack: DevStack Deploy Script
2015-12-16 11:44:12 -07:00
f353f5c62d
Clarify the docs for Packet a bit.
2015-12-16 09:57:58 -05:00
805c4896bd
provider/azurerm: Clean up work for base provider
...
- Add documentation for resources
- Rename files to match standard patterns
- Add acceptance tests for resource groups
- Add acceptance tests for vnets
- Remove ARM_CREDENTIALS file - as discussed this does not appear to be
an Azure standard, and there is scope for confusion with the
azureProfile.json file which the CLI generates. If a standard emerges
we can reconsider this.
- Validate credentials in the schema
- Remove storage testing artefacts
- Use ARM IDs as Terraform IDs
- Use autorest hooks for logging
2015-12-15 18:31:02 -05:00
35a69fd322
fix whitespace
2015-12-15 16:20:24 -06:00
e59f39df5f
other m1/ami-1234 clean ups
2015-12-15 16:12:31 -06:00
6236e8d720
Update doc to use valid AMI and t2.micro instance types
2015-12-15 15:58:28 -06:00
64bded6269
Merge pull request #4268 from duggan/route53-health-check-doc-fix
...
Change wording of aws_route53_health_check
2015-12-15 14:51:22 -06:00
a4d9ae3fa5
Merge pull request #3735 from lwander/b-gcp-container-cluster-document-scopes
...
provider/google: Improve Container Scope Example Documentation
2015-12-15 13:03:05 -05:00
64482422b5
Merge pull request #4146 from hashicorp/b-aws-ebs-validate
...
providers/aws: Validate IOPs for EBS Volumes
2015-12-15 11:33:49 -06:00
41cd85c7d8
Merge pull request #3892 from lwander/b-gcp-instance-group-restart
...
provider/google: Fix instance group manager instance restart policy
2015-12-15 11:38:12 -05:00
c72342eefc
Add SSH agent support for Windows
...
The Windows support is limited to the Pageant SSH authentication agent.
This fixes #3423
2015-12-15 16:39:23 +01:00
d489206530
smaller font-size in doc headers for readability with var names as titles
2015-12-14 12:40:21 -08:00
764ea7f39c
Documentation for the Chef provider.
2015-12-13 15:09:17 -08:00
7cbd18a88d
provider/openstack: DevStack Deploy Script
...
This commit includes a script to deploy a standardized devstack environment
for use with development and testing.
2015-12-13 02:58:29 +00:00
c0b91689cc
fix typo in snapshot_retention_limit
2015-12-12 14:22:40 -08:00
19ea14bf8d
Merge pull request #4256 from stack72/aws-asg-scheduled-actions
...
provider/aws: Autoscaling Group Scheduled Actions
2015-12-11 16:54:13 -05:00
c965d2278e
Adding a resource for aws_autoscaling_schedule
2015-12-11 18:43:38 +00:00
b2724d2cb8
Merge pull request #4270 from lwander/b-gcp-service-account-docs
...
provider/google: Update docs for acquiring service account credentials
2015-12-11 13:43:36 -05:00
1549adfccd
Change wording of aws_route53_health_check
...
Both may be specified, which enables health checking of an IP address
with the Host header specified.
Defined in the API documentation:
http://docs.aws.amazon.com/Route53/latest/APIReference/API_GetHealthCheck.html
2015-12-11 18:32:22 +00:00
cda549ab17
provider/google: Update docs for acquiring service account credentials
2015-12-11 13:27:26 -05:00
a1a5788ed8
provider/google: provide assigned_nat_ip as well as nat_ip
2015-12-11 12:57:18 -05:00
eceb8c88f7
Merge branch 'pr-4258'
...
* pr-4258:
update docs for updated us-east AMIs
Trivial change for AWS upgraded T2 instance type and AMI ami-5189a661
2015-12-11 10:07:19 -06:00
f0ceb7fb9d
update docs for updated us-east AMIs
2015-12-11 10:07:06 -06:00
8b21f284b4
Merge pull request #4259 from stack72/aws-db_parameter_group-tags
...
provider/aws: Adding Tag support for DB Param Groups
2015-12-11 08:58:26 -06:00
5b2230588a
Merge pull request #4260 from stack72/aws-db_security_group-tags
...
provider/aws: Adding support for Tags to DB SecurityGroup
2015-12-11 08:48:59 -06:00
dec5a27f19
Adding the ARN as an output of the DB Subnet Group
2015-12-11 12:39:15 +00:00
474d6080f0
Adding support for Tags to the DB Security Group
2015-12-11 12:28:24 +00:00
67c1971e63
Adding support to DB Parameter Group for Tags
2015-12-11 12:07:50 +00:00
a7c8d0714e
Trivial change for AWS upgraded T2 instance type and AMI ami-5189a661
2015-12-11 01:24:04 -08:00
fb4878cf37
Merge pull request #3853 from stack72/f-aws-db-instance-omit-snapshot
...
provider/aws: add DB Instance skip_final_snapshot
2015-12-10 18:38:11 -05:00
2b0c7aa4e9
Making the changes to db_instance skip_final_snapshot on the feedback from @catsby
2015-12-10 23:21:36 +00:00
c5d066b828
provider/aws: Add note about cluster size reduction
2015-12-10 15:35:46 -05:00
5796b13373
Adding skip_final_snapshop bool to th db_instance. This will allow us to specify whether a snapshot is needed directly rather than checking for an empty string
2015-12-10 19:11:47 +00:00
231f0cb474
Merge pull request #4035 from rakutentech/fix-ipv6-bug
...
provider/vsphere: Change ip_address parameter for ipv6 support
2015-12-10 12:02:11 -06:00
68ac4bceaf
provider/vsphere: Change ip_address parameter to ipv4_address and ipv6_address for ipv6 support
2015-12-10 18:28:24 +09:00
5b036fbf4f
provider/dyn: Add Dyn to the documentation sidebar
2015-12-09 14:05:18 -06:00
9cc5e52cf0
Merge pull request #4167 from stack72/aws-security_group_name_prefix
...
provider/aws: securitygroup name_prefix
2015-12-09 11:42:34 -06:00
e065bec624
Merge pull request #3939 from matt-deboer/master
...
vsphere-provider: Added folder handling for folder-qualified vm names
2015-12-09 09:55:06 -06:00
ced42342ff
Merge pull request #4215 from hashicorp/pr-4207
...
Fix issue creating AWS RDS replicas across regions
2015-12-09 09:54:53 -06:00
67bfc2faef
Added folder handling for folder-qualified vm names
...
Added acceptance test for creation in folders
Added 'baseName' as computed schema attribute for convenience
Added 'base_name' computed attribute for convenience
Added new vsphere folder resource
Fixed folder behavior
Assure test folders are properly removed
Avoid creating recreating search index in loop
Fix typeo in vsphere.createFolder
Updated website documentation
Renamed test folders to be unique across tests
Fixes based on acc test findings; code cleanup
Added combined folder and vm acc test
Restored newline; fixed skipped acc tests
Marked 'existing_path' as computed only
Removed debug logging from tests
Changed folder read to return error
2015-12-08 20:35:27 -08:00
3041920d37
Merge pull request #4183 from rakutentech/docs-default-example
...
provider/vsphere: Update a default example in VMware vSphere provider
2015-12-08 18:44:03 -06:00
5884323c99
Merge pull request #4208 from stack72/aws-dynamodb_streams
...
provider/aws: DynamoDB Table StreamSpecifications
2015-12-08 18:42:48 -06:00
0619898f6a
provider/aws: Add arn to DB Instance output
2015-12-08 10:52:17 -06:00
a0a89ecde8
Documenting the version upgrade flags on db_instance
2015-12-08 14:13:26 +00:00
d46348c233
Adding support for AWS DynamoDB Table for StreamSpecifications
2015-12-08 14:07:11 +00:00
6e7c7b6a0b
Move pricing_plan and replication_type in documentation to "settings" sublist as that is where the code looks for those options
2015-12-07 11:40:41 -05:00
fae25a9ed8
Update a default example in VMware vSphere provider
2015-12-07 10:49:04 +09:00
82e502359c
Fix minor spacing inconsistency
2015-12-05 16:51:05 -05:00
b7acbd7887
Fix typo 'storaege' → 'storage'
2015-12-05 14:20:24 -05:00
283a838b58
Merge #3930 : tls_locally_signed_cert resource
2015-12-04 13:30:37 -08:00
c05b0a5a0d
Merge pull request #4147 from hashicorp/b-aws-dynamo-gsi-docs
...
providers/aws: Update Dynamo DB docs for GSI hash_key
2015-12-04 14:55:26 -06:00
56339332dd
Merge pull request #4166 from hashicorp/phinze/consul-remote-state-basic-auth
...
core: support HTTP basic auth in consul remote state
2015-12-04 11:39:00 -06:00
bb52d70089
Merge pull request #4159 from turtlemonvh/patch-1
...
Update downloads.html.erb
2015-12-04 09:09:18 -06:00
30a87be969
Merge pull request #4150 from svanharmelen/f-cloudstack-performance
...
provider/cloudstack: performance improvements
2015-12-04 09:07:10 -06:00
3a08cc9334
provider/vsphere: Add allow_unverified_ssl flag for unverified SSL requests
2015-12-04 08:49:22 -06:00
6817e0d144
Adding the ability to generate a securitygroup name-prefix
2015-12-04 09:21:08 -05:00
2a49ebb448
Merge pull request #4153 from lwander/gcp-pubsub-docs-update
...
provider/google: Added missing pubsub documentation
2015-12-04 09:01:00 -05:00
1a19f43ee1
core: support HTTP basic auth in consul remote state
...
Closes #1663
2015-12-04 07:15:18 -06:00
e1eef15646
postgresql provider with "database" and "role" resources
2015-12-03 23:44:20 -08:00
ef0b02ede3
Update downloads.html.erb
...
Its a PGP key, not a GPG key.
2015-12-03 23:21:35 -05:00
709d1f3599
Merge pull request #3704 from dayer4b/add-placement-group
...
added placement group as an option for autoscaling groups
2015-12-03 18:05:01 -06:00
9e68c34abe
Merge pull request #3785 from hmrc/master
...
VMWare vCloud Director Support
2015-12-03 15:51:47 -06:00
738ad14ebb
provider/google: Added missing pubsub documentation
2015-12-03 15:42:41 -05:00
16016b8866
fix typo
2015-12-03 14:24:35 -06:00
b8f3417e79
Change all firewall related resources to take a cidr_list
...
Also some additional tweaks to improve performance and add in a little
concurrency to speed things up a little.
2015-12-03 15:34:53 +01:00
7a24764c15
provider/docker: Add hosts parameter for containers
2015-12-03 10:32:41 +00:00
78929df2a1
providers/aws: Update Dynamo DB docs for GSI hash_key
2015-12-02 16:05:45 -06:00
d1bba3095b
providers/aws: Validate IOPs for EBS Volumes
2015-12-02 15:20:11 -06:00
d6ae527159
Merge pull request #3671 from 22Acacia/google-pubsub-clean
...
Google Cloud: PubSub Topic and Subscription resources
2015-12-02 15:37:23 -05:00
4216a8d1e1
Merge pull request #3718 from rakutentech/rename-config-parameters
...
provider/vsphere: rename vcenter_server config parameter to something clearer
2015-12-02 14:04:52 -06:00
6c76984419
Merge pull request #3867 from chrislovecnm/vsphere-custom-vm-params
...
vSphere custom vm params
2015-12-02 14:00:30 -06:00
6f7ef2fadd
golang pubsub SDK has been released. moved topics/subscriptions to use that
...
Conflicts:
builtin/providers/google/provider.go
builtin/providers/google/resource_subscription.go
builtin/providers/google/resource_subscription_test.go
golang pubsub SDK has been released. moved topics/subscriptions to use that
Conflicts:
builtin/providers/google/provider.go
builtin/providers/google/resource_subscription.go
builtin/providers/google/resource_subscription_test.go
file renames and add documentation files
remove typo'd merge and type file move
add to index page as well
only need to define that once
remove topic_computed schema value
I think this was used at one point but is no longer. away.
cleanup typo
adds a couple more config values
- ackDeadlineSeconds: number of seconds to wait for an ack
- pushAttributes: attributes of a push subscription
- pushEndpoint: target for a push subscription
rearrange to better match current conventions
respond to all of the comments
2015-12-02 10:36:00 -08:00
50d7abcd8a
Merge pull request #3761 from ryane/f-provider-docker-improvements
...
provider/docker: support additional arguments for `docker_container` resource
2015-12-02 11:46:29 -05:00
35b18ceb29
providers/aws: Update Security Group docs
2015-12-02 10:28:17 -06:00
f1f214f03d
v0.6.8
2015-12-02 15:06:55 +00:00
3cbe014e31
Add missing documentation link for #4093
2015-12-01 08:47:12 -05:00
9987f36d86
Merge pull request #4093 from paybyphone/master
...
provider/aws: New resource `aws_lambda_event_source_mapping`
2015-12-01 08:36:45 -05:00
6a031af0ba
change get -u option get -update
...
get -u does not work the name is -update.
2015-11-30 19:43:54 +01:00
85627630bd
New resource (AWS provider) - aws_lambda_event_source_mapping
2015-11-30 07:45:38 -08:00
72b8c82c08
Merge pull request #4106 from stack72/statuscake-documentation
...
provider/statuscake: Adding some documentation
2015-11-30 12:49:31 +00:00
3ecf722b77
Adding some documentation for the StatusCake provider
2015-11-30 10:44:21 +00:00
d0548a8165
Changing aws_route from Route53 layout to VPC layout
2015-11-29 14:49:45 +00:00
b07356ba95
docs: Correct mistype
2015-11-28 14:10:47 +09:00
c8bd5c0d74
Merge pull request #4074 from stack72/aws-spot-instance-block-duration-minutes
...
provider/aws: aws_spot_instance block_duration_minutes
2015-11-26 21:18:24 +00:00
632a9147cc
Adding support for Block_Durations to AWS Spot instance
2015-11-26 11:56:04 +00:00
8cdfe152d6
Adding the documentation of aws_instance tenancy
2015-11-26 10:21:06 +00:00
d70cdde233
merging in upstream, because rebase was insane
2015-11-25 00:44:27 -07:00
09bd4e7b00
Merge pull request #3195 from bensojona/f-change-artifact-type
...
Change amazon.ami to amazon.image
2015-11-24 16:57:55 -06:00
d3f41320e8
provider/aws: Update Instance/Spot docs for IP information
2015-11-24 10:10:12 -06:00
bd23ab35bf
docs: update template_file examples
...
Use the new non-deprecated style.
refs #4025
2015-11-24 09:01:11 -06:00
09a4fdfc3d
Merge branch 'mvermaes-doc-fix'
2015-11-24 13:43:34 +02:00
f0292d420f
Update template example for new syntax
2015-11-24 13:42:37 +02:00
5290365238
Merge pull request #4038 from milkcocoa/fix-removing-locale-identifier
...
Remove locale identifier from links to the AWS document.
2015-11-24 13:25:51 +02:00
1cde2e64a0
Merge pull request #3748 from stack72/do-floatingips
...
provider/digitalocean : New Resource for Floating IPs
2015-11-24 13:16:24 +02:00
3fc9107333
Using the laterst version of the DO API to get the Assign of an IP working without a time.Sleep
2015-11-24 11:08:43 +00:00
1c37e908c7
Remove locale identifier from links to the AWS document.
2015-11-24 19:25:43 +09:00
e9cf7f5f00
fix edit this page stacking
2015-11-23 23:51:02 -05:00
a61c375115
Capital 'C' /cc @mitchellh
2015-11-23 21:31:28 -05:00
b7c41aed92
v0.6.7
2015-11-23 18:16:01 +00:00
3809315af9
Upped default maxRetryTimeout from 30s -> 60s
2015-11-23 11:45:16 +00:00
9cec40ea3c
Add missing error-checks from code review
...
Some error-checking was omitted.
Specifically, the cloudTrailSetLogging call in the Create function was
ignoring the return and cloudTrailGetLoggingStatus could crash on a
nil-dereference during the return. Fixed both.
Fixed some needless casting in cloudTrailGetLoggingStatus.
Clarified error message in acceptance tests.
Removed needless option from example in docs.
2015-11-22 12:54:11 -07:00
484887c0c5
Change default for logging in CloudTrail to true
...
The default for `enable_logging`, which defines whether CloudTrail
actually logs events was originally written as defaulting to `false`,
since that's how AWS creates trails.
`true` is likely a better default for Terraform users.
Changed the default and updated the docs.
Changed the acceptance tests to verify new default behavior.
2015-11-22 10:47:23 -07:00
49195f8b77
Added docs for maxRetryTimeout
2015-11-21 12:55:07 +00:00
f98dbbb580
Tests and docs for AWS CloudTrail "enable_logging"
...
Add acceptance tests for creation, enable, and disable logging.
Add option to docs and example.
2015-11-21 00:18:38 -07:00
7bda855590
Adding the work to assign a Floating IP to a Droplet
2015-11-20 19:12:31 +02:00
ed3f54cc47
Add AWS Classiclink for AWS VPC resource
2015-11-20 16:48:48 +01:00
7bf02243a1
rename vcenter_server config parameter to something clearer
2015-11-20 20:37:49 +09:00
98167cea79
merging upstream master
2015-11-18 16:09:05 -07:00
815ff7ac63
Merge branch 'terraform' into hmrc
2015-11-18 17:56:28 +00:00
b177370bdc
Merge pull request #3962 from miguelaferreira/patch-1
...
provider/cloudstack docs: use underscore in virtual machine attribute
2015-11-18 17:14:58 +02:00
ce1bcd7ccc
Merge pull request #3959 from chrislovecnm/vsphere-ipv4-documentation-updates
...
Update docs to reflect vsphere provider only supporting IPv4 addresses
2015-11-18 17:11:37 +02:00
9e42207fee
Use underscore in virtual machine attribute
2015-11-18 14:47:21 +01:00
9de7319b63
Update virtual_machine.html.markdown
...
Typo
2015-11-17 21:56:58 -07:00
2d0ceb51c4
updating documenation that vsphere provider only supports ipv4 addressing
2015-11-17 21:53:55 -07:00
f23a4994ae
docs: fix template_file syntax error
2015-11-17 16:45:08 -06:00
7f9360797c
provider/aws: wait for ASG capacity on update
...
It's a bit confusing to have Terraform poll until instances come up on
ASG creation but not on update. This changes update to also poll if
min_size or desired_capacity are changed.
This changes the waiting behavior to wait for precisely the desired
number of instances instead of that number as a "minimum". I believe
this shouldn't have any undue side effects, and the behavior can still
be opted out of by setting `wait_for_capacity_timeout` to 0.
2015-11-17 10:25:41 -06:00
cc54785b1c
Merge branch 'terraform' into hmrc
2015-11-17 10:13:53 +00:00
7e59d7f67c
Merge pull request #3901 from hashicorp/phinze/google-credentials
...
provider/google: read credentials as contents instead of path
2015-11-16 17:57:54 -06:00
010293992a
Merge pull request #3899 from hashicorp/phinze/azure-publish-settings
...
provider/azure: read publish_settings as contents instead of path
2015-11-16 17:54:43 -06:00
fb0dc4951d
provider/azure: read publish_settings as contents instead of path
...
Building on the work in #3846 , shifting the Azure provider's
configuration option from `settings_file` to `publish_settings`.
2015-11-16 17:47:56 -06:00
0346c66d1c
Merge pull request #3839 from hashicorp/new_header
...
New header/footer redesign
2015-11-16 16:05:37 -06:00
eb9a93862b
provider/google: read credentials as contents instead of path
...
Building on the work in #3846 , shifting the Google provider's
configuration option from `account_file` to `credentials`.
2015-11-16 15:14:32 -06:00
993ec0a320
Merge pull request #3909 from hashicorp/phinze/template-file-contents
...
template_file: source contents instead of path
2015-11-16 14:50:45 -06:00
0cdc81f390
Merge pull request #3896 from hashicorp/phinze/chef-keys-as-contents
...
chef: read key contents instead of paths
2015-11-16 21:44:09 +01:00
afb416fba4
Merge pull request #2807 from dwradcliffe/f-dyn-provider
...
add Dyn provider
2015-11-16 13:53:44 -06:00
874bddd84c
website: add `` to format documentation env vars
...
this consistently formats the `TF_*` variables referenced in
documentation and also improves readability.
2015-11-16 11:23:43 -05:00
309e697a52
provider/tls: add locally signed certificates
...
This allows you to generate and sign certificates using a local CA.
2015-11-15 20:23:40 -05:00
880002fe15
Small update to packet.net docs for project
2015-11-15 10:55:42 -08:00
432cab51a7
Merge pull request #3917 from grothja/patch-1
...
Correct argument reference for `certificate`
2015-11-14 09:29:13 +00:00
8491f0883d
Correct argument reference for `certificate`
2015-11-13 17:13:20 -05:00
6d13b9296b
updating documentation
2015-11-13 12:49:40 -07:00
928f534cfc
template_file: source contents instead of path
...
Building on the work of #3846 , deprecate `filename` in favor of a
`template` attribute that accepts file contents instead of a path.
Required a bit of work in the interpolation code to prevent Terraform
from assuming that template interpolations were resource variables that
needed to be resolved. Leaving them as "Unknown Variables" prevents
interpolation from happening early and lets the `template_file` resource
do its thing.
2015-11-13 11:24:20 -06:00
edd8e722bf
provider/openstack: Make Networking Port attributes more intuitive
...
This commit makes some quick updates to the port attributes to make them
more intuitive:
* `security_groups` to `security_group_ids`: since the port is expecting
IDs and not security group names like in other areas of OpenStack.
* `admin_state_up`: change to Boolean to match this same attribute on
other resources.
* `fixed_ips` to `fixed_ip`: while multiple `fixed_ip` blocks can be
specified, only one fixed IP can be specified in each block.
2015-11-13 04:46:12 +00:00
3a1a242a7a
provider/openstack: Allow port_id for router interface
2015-11-13 03:13:12 +00:00
73ce6d184a
chef: read key contents instead of paths
...
Builds on the work of #3846 , shifting the Chef provisioner's
configuration options from `secret_key_path` and `validation_key_path`
over to `secret_key` and `validation_key`.
2015-11-12 16:11:44 -06:00
7ffa66d1a5
ssh: accept private key contents instead of path
...
We've been moving away from config fields expecting file paths that
Terraform will load, instead prefering fields that expect file contents,
leaning on `file()` to do loading from a path.
This helps with consistency and also flexibility - since this makes it
easier to shift sensitive files into environment variables.
Here we add a little helper package to manage the transitional period
for these fields where we support both behaviors.
Also included is the first of several fields being shifted over - SSH
private keys in provisioner connection config.
We're moving to new field names so the behavior is more intuitive, so
instead of `key_file` it's `private_key` now.
Additional field shifts will be included in follow up PRs so they can be
reviewed and discussed individually.
2015-11-12 14:59:14 -06:00
7be90215bc
provider/google: Fix instance group manager instance restart policy
2015-11-12 15:44:31 -05:00
fddafd2b96
providers/aws: Document and validate ELB ssl_cert and protocol requirements
2015-11-12 14:25:50 -06:00
9d27504133
Merge pull request #3866 from br0ch0n/sqs_queue_doc_example
...
Add example of redrive_policy to docs.
Fixes #2711 .
2015-11-12 11:04:55 -06:00
cbbe06388f
Merge pull request #3883 from lwander/f-gcp-https-health-checks
...
provider/google: HTTPS Health Checks Resource + Tests & Documentation
2015-11-12 10:02:39 -06:00
28819603ba
provider/google: HTTPS health checks resource + tests & documentation
2015-11-12 10:48:26 -05:00
90d70786ac
Align IAM version number to the current version (2012-10-17)
2015-11-13 00:32:45 +09:00
5bdba00082
add example of redrive_policy #2711
...
Change-Id: Ia1b26bf32d16628c3ef5cf99745ba7c222d3251e
2015-11-11 13:50:54 -08:00
d309f8b82b
Update remote-config.html.markdown
...
Replace "shared storaged" with "shared storage". (Very minor change.)
2015-11-11 13:09:26 -06:00
5df9d22a6a
Minor doc updates
2015-11-11 07:43:36 +00:00
0a1890c329
Merge branch 'master' into pr-3708
...
* master: (95 commits)
Update CHANGELOG.md
Update CHANGELOG.md
Update CHANGELOG.md
Update CHANGELOG.md
upgrade a warning to error
add some logging around create/update requests for IAM user
Update CHANGELOG.md
Update CHANGELOG.md
Build using `make test` on Travis CI
Update CHANGELOG.md
provider/aws: Fix error format in Kinesis Firehose
Update CHANGELOG.md
Changes to Aws Kinesis Firehouse Docs
Update CHANGELOG.md
modify aws_iam_user_test to correctly check username and path for initial and changed username/path
Update CHANGELOG.md
Update CHANGELOG.md
Prompt for input variables before context validate
Removing the AWS DBInstance Acceptance Test for withoutEngine as this is now part of the checkInstanceAttributes func
Making engine_version be computed in the db_instance provider
...
2015-11-10 16:52:45 -06:00
a05ff89a7d
Changed documentation to better show what can be done with firewall rules
2015-11-10 22:49:38 +00:00
ca442bf00b
Merge pull request #3818 from ijin/patch-1
...
provider/aws: Document `license_model` as supported argument for db_instance
2015-11-10 17:40:15 -05:00
bea8e0b14f
Merge pull request #3780 from hashicorp/b-aws-elb-source-sg-id
...
providers/aws: Provide source security group id for ELBs
2015-11-10 16:38:55 -06:00
51fd5fafef
Merge pull request #3744 from stack72/f-aws-db-instance
...
provider/aws: Changing the db_instance resource to mark the engine_version as Optional
2015-11-10 15:48:06 -06:00
7c50e3ed65
Merge pull request #3833 from stack72/aws-kinesis-firehose
...
provider/aws: Add Kinesis Firehose resource
2015-11-10 16:04:48 -05:00
77bad2c946
Changes to Aws Kinesis Firehouse Docs
...
Changing the AWS Kinesis Firehose docs as per @jen20's feedback
2015-11-10 20:59:01 +00:00
5708457610
Merge pull request #3802 from pforman/2911-lc-prefix
...
provider/aws: add name_prefix option to launch config
2015-11-10 14:43:08 -06:00
5453506335
fix font legibility
2015-11-10 10:34:57 -08:00
1abb0b19bf
Changing the db_instance resource to mark the engine_version as Optional
2015-11-10 17:30:09 +00:00
255486857e
Changing the Firehose documentation to note the regions is is available for and also that s3 is the only destination involved right now
2015-11-10 16:45:46 +00:00
8c68cb1080
Adding the documentation for the Kinesis Firehose Delivery Stream
2015-11-10 16:43:34 +00:00
54c722f2e8
final cleanup
2015-11-09 22:25:03 -08:00
81b0e020f0
use 300 for weight in both header/footer
2015-11-09 22:23:30 -08:00
8d847a9ac4
fix sticker footer
2015-11-09 22:21:39 -08:00
348fd81b75
terraform hover update
2015-11-09 22:17:57 -08:00
25faa1d97f
add padding to homepage footer
2015-11-09 22:12:00 -08:00
ebec7e2bc2
use more atomic styles for header/footer classes. use page url to determin class names
2015-11-09 22:11:00 -08:00
22876be830
Document `license_model` as supported argument
...
Required for Oracle SE1
2015-11-10 14:31:55 +09:00
64d982ac9e
Change the docs as the token can be explicitly set
...
This tripped me up today when I was trying to connect using MFA. I had a look at the source and found the token property, tested it out and low and behold it worked!
Hopefully this saves someone else going through the same pain
2015-11-10 11:27:45 +13:00
6906dc1b2b
Merge pull request #3822 from ijin/patch-2
...
Add db_subnet_group_name to aws_rds_cluster docs
2015-11-09 14:11:16 -06:00
988baa584b
Merge #3814 : 'coalesce' interpolation func
2015-11-09 09:31:18 -08:00
796fdeef53
Update rds_cluster.html.markdown
...
I needed `db_subnet_group_name` in the rds_cluster resource as well when creating on a non-default VPC.
https://github.com/hashicorp/terraform/pull/2935#issuecomment-133481106
2015-11-10 01:42:59 +09:00
13e862673f
Fix spelling mistake in aws iam saml title
2015-11-09 10:52:09 -05:00
87e384dc97
Fix spelling mistake in aws saml example
...
Example resource name is `aws_iam_saml_provider` instead of `aws_saml_provider`.
2015-11-09 09:56:38 -05:00
7e676a672f
provider/openstack: extend documentation of Neutron::FloatingIP
2015-11-08 20:43:34 +01:00
6ecec7fe83
Add coalesce func
2015-11-08 19:34:56 +13:00
4d640c6528
providers/aws: add name_prefix option to launch config
...
See #2911 .
This adds a `name_prefix` option to `aws_launch_configuration` resources.
When specified, it is used instead of `terraform-` as the prefix for the
launch configuration. It conflicts with `name`, so existing
functionality is unchanged. `name` still sets the name explicitly.
Added an acceptance test, and updated the site documentation.
2015-11-07 01:29:16 -07:00
b33c3fcd0d
whitespace
2015-11-06 21:01:14 -08:00
a727b0c415
add closing quote
2015-11-06 19:02:05 -08:00
7f53f82f0d
responsive tweak
2015-11-06 16:06:48 -08:00
8a1bf06815
responsive cleanup
2015-11-06 16:01:39 -08:00
2d30d8f483
fix incorrect link
2015-11-06 15:45:02 -08:00
a5f8ecfdd8
header styles complete + subpage
2015-11-06 15:41:23 -08:00
91aeba48ff
Merge pull request #3795 from willrstern/aws-rds-typo
...
Typo in docs - AWS RDS config
2015-11-06 17:08:52 -06:00
d6f6a3b3f5
Merge branch 'master' of github.com:hashicorp/terraform
...
* 'master' of github.com:hashicorp/terraform:
Update CHANGELOG.md
Adding S3 support for Lambda provider
2015-11-06 16:55:32 -06:00
ccd37796ec
Merge branch 'pr-3707'
...
* pr-3707:
config updates for ElastiCache test
Removing the instance_type check in the ElastiCache cluster creation. We now allow the error to bubble up to the userr when the wrong instance type is used. The limitation for t2 instance types now allowing snapshotting is also now documented
Making the changes to the snapshotting for Elasticache Redis as per @catsby's findings
Added an extra test for the Elasticache Cluster to show that updates work. Also added some debugging to show that the API returns the Elasticache retention period info
When I was setting the update parameters for the Snapshotting, I didn't update the copy/pasted params
Adding the ability to specify a snapshot window and retention limit for Redis ElastiCache clusters
2015-11-06 16:55:16 -06:00
327bd4f9c0
Adding S3 support for Lambda provider
2015-11-06 15:57:18 -06:00
1ab69ab638
typo in cluster_identifier
2015-11-06 15:55:58 -06:00
1269d2a156
shared styles update
2015-11-06 12:45:10 -08:00
39cbc56161
in progress header redesign
2015-11-06 12:35:24 -08:00
c284f31570
Merge pull request #3626 from wojtekmach/patch-1
...
digitalocean: update index docs for do_token var
2015-11-06 11:32:09 -06:00
ea3fc69f67
Merge pull request #3789 from stack72/f-aws-rds-cluster-instance-docs
...
provider/aws: RDS Cluster Instance Docs Update
2015-11-06 11:30:22 -06:00
1656e2837c
Merge pull request #3772 from Fodoj/add-fixed-ips-to-openstack-ports
...
provider/openstack: Add fixed ips to openstack ports
2015-11-06 10:21:20 -07:00
83ae6fe410
document source_security_group_id for ELB
2015-11-06 11:20:30 -06:00
e8a411ce5f
Fixing the RDS Cluster Instance docs to show that either an instance must be set as public OR have a db_subnet_group_name set
2015-11-06 16:10:21 +00:00
350f91ec06
Removing the instance_type check in the ElastiCache cluster creation. We now allow the error to bubble up to the userr when the wrong instance type is used. The limitation for t2 instance types now allowing snapshotting is also now documented
2015-11-06 11:16:51 +00:00
bda4ef7e7c
Merge branch 'terraform' into hmrc
2015-11-06 10:22:25 +00:00
cb52e23226
Merge pull request #3757 from stack72/f-aws-rds-cluster-backup
...
provider/aws: RDS Cluster additions
2015-11-05 14:28:18 -06:00
d347b9d8e5
Merge pull request #3729 from hashicorp/docs-vmware-vsphere
...
docs: Change vSphere to VMware vSphere
2015-11-05 13:07:50 -06:00
e85a618d67
Merge pull request #3717 from rakutentech/improve-acceptance-test
...
provider/vsphere: Fix acceptance tests for using optional parameters
2015-11-05 13:07:20 -06:00
3a63b48f97
provider/openstack: fixed_ips implementation for ports
2015-11-05 19:23:05 +01:00
cb90e6c037
Merge branch 'master' into hmrc
2015-11-05 16:35:27 +00:00
72c86a62c0
support for log driver + config in docker container
2015-11-04 15:52:16 -05:00
4531866d8d
add label support to docker container resource
2015-11-04 15:52:15 -05:00
6842c32d03
add basic runtime constraints to docker_container
2015-11-04 15:52:15 -05:00
17d185808e
restart policy support for docker_container
2015-11-04 15:52:15 -05:00
0ded14f160
entrypoint support for docker_container resource
2015-11-04 15:52:15 -05:00
e3be1d5f10
update elb access logs docs
2015-11-04 14:15:40 -06:00
02ee437328
Add website docs.
2015-11-04 14:14:51 -06:00
1d0dbc5d19
Adding backup_retention_period, preferred_backup_window and preferred_maintenance_window to RDS Cluster
2015-11-04 19:40:22 +00:00
bb5eb4ff46
Merge pull request #3702 from lwander/f-gcp-global-forwarding-rule
...
provider/google: global forwarding rule tests & documentation
2015-11-03 13:41:08 -05:00
d344d3e39a
provider/google: global forwarding rule tests & documentation
2015-11-03 13:31:46 -05:00
d11524682a
provider/google: Target HTTPS proxy resource + tests & documentation
2015-11-03 12:34:13 -05:00
0097d7105b
Merge pull request #3727 from lwander/f-gcp-target-http-proxy
...
provider/google: Target HTTP proxy resource + tests & documentation
2015-11-03 12:12:01 -05:00
843c04e917
provider/google: Improve Container Scope Example Documentation
2015-11-03 10:30:36 -05:00
e7ebb0ac40
provider/google: target http proxies resource + tests & documentation
2015-11-03 08:54:30 -05:00
312d371ce9
provider/openstack: Additions to the OpenStack Port resource
...
This commit adds further work to the OpenStack port resource:
* Makes relevant fields computed
* Adds state change functions
* Adds acceptance tests
* Adds Documentation
2015-11-03 06:07:32 +00:00
352d6abfd7
Merge pull request #3232 from jtopjian/openstack-bootfromvolume-image-fixes
...
provider/openstack: Boot From Volume and Image Handling Fixes
2015-11-03 13:57:18 +09:00
05a0a41236
vSphere occurrences in vsphere_virtual_machine resource page
2015-11-02 18:27:22 -08:00
d99b9aaa6f
vSphere occurrence in layout
2015-11-02 18:25:05 -08:00
964c9cd7e8
Change all occurrences of 'vSphere' to 'VMware vSphere'
2015-11-02 18:21:08 -08:00
519756c42a
Merge pull request #3722 from lwander/f-gcp-url-maps
...
provider/google: Added url map resource + tests & documentation
2015-11-02 17:29:29 -05:00
ccb3f92bd1
provider/google: Added url map resource + tests & documentation
2015-11-02 17:12:41 -05:00
cb8962a6c6
Merge pull request #3710 from stack72/f-aws-asg-generated-name
...
provider/aws: Making the AutoScalingGroup name optional
2015-11-02 16:07:49 -06:00
232a538c14
Merge pull request #3723 from lwander/f-gcp-ssl-certs
...
provider/google: SSL Certificates resource + tests & documentation
2015-11-02 14:44:19 -05:00
f70d4079c1
provider/google: SSL Certificates resource + tests & documentation
2015-11-02 14:35:51 -05:00
fc7dcb824f
Minor change to documentation
2015-11-02 19:22:48 +00:00
6ac8290f12
Merge pull request #3701 from lwander/f-gcp-global-address
...
provider/google: global address + tests & documentation
2015-11-02 13:29:36 -05:00
16b0e0d619
documentation, thanks again to stack72
2015-11-02 09:44:29 -06:00
8376a5a160
Merge branch 'terraform'
2015-11-02 13:57:44 +00:00
8780bd269a
Added vCloud Director provider with tests and provider documentation
2015-11-02 13:39:25 +00:00
94456dd20c
Merge pull request #3713 from lwander/b-gcp-backend-region
...
provider/google: Region attribute wasn't wrapped in quotes
2015-11-02 10:47:27 +00:00
12fc9a1d78
Fix acceptance tests for using optional parameters at different environment
2015-11-01 13:04:56 +09:00
7596e64570
provider/openstack: Documentation update for Security Group "self"
...
This commit adds a note about `cidr` and `from_group_id` being ignored
if `self` is set to true.
Fixes #3448
2015-11-01 01:24:38 +00:00
4a5cd0b415
provider/openstack: Fixing Image ID/Name areas
...
This commit cleans up areas that configure the image_id and image_name.
It enables the ability to not have to specify an image_id or image_name
when booting from a volume.
It also prevents Terraform from reporting an error when an image name is no
longer able to be resolved from an image ID. This usually happens when the
image has been deleted, but there are still running instances that were based
off of it.
The image_id and image_name parameters no longer immediately take a default
value from the OS_IMAGE_ID and OS_IMAGE_NAME environment variables. If no other
resolution of an image_id or image_name were found, then these variables will
be referenced. This further supports booting from a volume.
Finally, documentation was updated to take into account booting from a volume.
2015-10-31 22:45:34 +00:00
966b5c9f02
provider/google: Region attribute wasn't wrapped in quotes
2015-10-31 09:52:50 -04:00
cc2b3677e6
Merge pull request #3091 from berendt/openstack_subnet_ip_default
...
provider/openstack: use '4' as default for ip_version of subnet
2015-10-31 22:15:48 +09:00
fa6df71b70
Merge pull request #3126 from jtopjian/openstack-icmp-documentation
...
provider/openstack: ICMP Documentation
2015-10-31 22:06:06 +09:00
69b905fb92
Making the AutoScalingGroup name optiona
2015-10-31 09:24:46 +00:00
7dd15469a5
Adding the ability to specify a snapshot window and retention limit for Redis ElastiCache clusters
2015-10-31 00:09:20 +00:00
3a7fa866c1
Merge pull request #3274 from stack72/aws-codecommit
...
provider/aws: CodeCommit - Currently only in us-east-1
2015-10-30 17:41:28 -05:00
4ec1da4c86
provider/google: global address + tests & documentation
2015-10-30 17:57:09 -04:00
14604e432e
Added the documentation for the CodeCommit repository
2015-10-30 21:39:16 +00:00
8ff8f17add
Merge pull request #3667 from lwander/f-gcp-instance-template-preemptible
...
provider/google: Added `preemtible` flag to `instance_template`
2015-10-30 17:38:15 -04:00
f562d17a13
Merge pull request #3617 from lwander/f-gcp-sql-instance
...
provider/google: SQL instance & database tests & documentation
2015-10-30 17:36:28 -04:00
07a9c34e02
Merge pull request #3339 from stack72/aws-asg-docs-3327
...
docs: Updating the ASG docs to suggest health_check_grace_period is a required field under certain circumstances
2015-10-30 15:46:31 -05:00
2da1ba0118
provider/google: Added `preemtible` flag to `instance_template`
2015-10-30 16:07:11 -04:00
07de5e7260
provider/google: SQL instance & database tests & documentation
2015-10-30 15:35:29 -04:00
4db8ef4a45
Merge pull request #3529 from hashicorp/b-aws-rds-copy-tags-to-snapshots
...
provider/aws: Add configuration to enable copying RDS tags to final snapshot
2015-10-30 09:09:41 -05:00
bf09edc642
provider/Azure: fixes:
...
added wait on instance deletion for associated blob deletion.
added guarding Mutex for secgroup-rule-related concurrent operations.
added usage warning on secgroup rules.
2015-10-30 02:57:47 +02:00
5c3c1e2327
Merge pull request #3548 from MDL/aws_route
...
provider/aws: add aws_route resource (finish)
2015-10-29 17:06:56 -05:00
0b28cceaf7
Trailing slash
2015-10-29 16:22:34 -04:00
79e6f2fc9d
Merge pull request #3683 from hashicorp/phinze/doc-vsphere-acctests
...
website: document vsphere acctest instructions
2015-10-29 14:53:47 -05:00
b1cf7f4841
Merge pull request #3682 from f440/update-logging-option
...
docs: Correct logging option example
2015-10-29 14:53:31 -05:00
32ae193e94
Merge pull request #2778 from apparentlymart/tls
...
TLS utility provider
2015-10-29 14:51:06 -05:00
cc0b941ba2
Merge pull request #3685 from stack72/f-aws-s3bucket-arn
...
Adding a computed ARN for the S3 Bucket as per #3666
2015-10-29 11:09:54 -05:00
8eec0c896f
Adding a computed ARN for the S3 Bucket as per #3666
2015-10-29 13:33:35 +00:00
James Nugent