Commit Graph

27689 Commits

Author SHA1 Message Date
James Bardin 2016b6bd1c validate is no longer called from there 2020-12-02 13:59:19 -05:00
James Bardin 8b08ebc4b5 consistent recievers 2020-12-02 13:59:19 -05:00
James Bardin 6f577abc72 unused 2020-12-02 13:59:19 -05:00
James Bardin f521fcca97 cleanup error handling and some for loops 2020-12-02 13:59:19 -05:00
James Bardin 96436f526a unused err value and nil context
Incorrect err assignment had no effect.

Never use a nil context.
2020-12-02 13:59:19 -05:00
James Bardin d2c2d58f09 unused 2020-12-02 13:59:19 -05:00
James Bardin ddb5b9ee53 fix break from switch in loop 2020-12-02 13:59:19 -05:00
James Bardin 44ccb94e2e remove unused 2020-12-02 13:59:18 -05:00
James Bardin bdfea50cc8 remove unused 2020-12-02 13:59:18 -05:00
James Bardin 1e8537b8d4 remove unused 2020-12-02 13:59:18 -05:00
James Bardin 1b530b7d9d remove unused 2020-12-02 13:59:18 -05:00
James Bardin 11e5ab0376 unchecked error
We don't need the nil checks if we check the error
2020-12-02 13:59:18 -05:00
James Bardin 810ab0386f remove unused 2020-12-02 13:59:18 -05:00
James Bardin 729c9b6f10 consistent reciever names 2020-12-02 13:59:18 -05:00
James Bardin c5299b5745 consistent reciever names 2020-12-02 13:59:18 -05:00
James Bardin b2d0e20759
Merge pull request #27078 from hashicorp/jbardin/remove-netrpc-plugin
Remove netrpc plugin
2020-12-02 13:23:29 -05:00
James Bardin 0c107e502f
Merge pull request #27077 from hashicorp/jbardin/internal-provisioners
Internal, in-process provisioners
2020-12-02 13:23:13 -05:00
James Bardin f2c5aa6d28
Merge pull request #27076 from hashicorp/jbardin/legacy-cleanup
Legacy types cleanup
2020-12-02 13:22:41 -05:00
James Bardin 381cc0b5d6
Merge pull request #26961 from hashicorp/jbardin/internal-legacy-packages
Move deprecated packages to internal/legacy
2020-12-02 13:19:50 -05:00
James Bardin df56a5f8ae remove dead code from tf provider 2020-12-02 13:07:10 -05:00
James Bardin 6aae0a94bd remove netrpc plugins
Provisioner plugins were the last remaining use of the legacy netrpc
plugin interface (even though it was wrapped in shimmed into the grpc
protocol). Now that these types are no longer being used, we can remove
the old code from the plugin package entirely.
2020-12-02 13:07:10 -05:00
James Bardin 85b7027048 File no longer exists to be formatted
Were no longer generating the internal plugins list which needs to be
formatted.
2020-12-02 12:45:00 -05:00
James Bardin 1032db4f9d remove generate-plugins script and test
We no longer use internal plugins.
2020-12-02 12:45:00 -05:00
James Bardin f8ccbcd3bb Add e2e test for provisioner plugin
Ensure we can still execute a 3rd party provisioner binary, using the
legacy plugin discovery location of the configuration root directory.
2020-12-02 12:45:00 -05:00
James Bardin 76cb40005a add grpcwrap.Provisioner
Rename grpcwrap.New() to grpcwrap.Provider()
Add a grpcwrap function to create a test proivisioner plugin.
2020-12-02 12:45:00 -05:00
James Bardin 5e089c2c09 run built-in provisioners in-process
Use the new provisioner interfaces, and run the built-in provisioners
in-process.
2020-12-02 12:45:00 -05:00
James Bardin 256a7ec95a rewrite file as an internal provisioner 2020-12-02 12:45:00 -05:00
James Bardin 1ec8d921d4 rewrite remote-exec as an internal provisioner 2020-12-02 12:45:00 -05:00
James Bardin d130add682 udpate communicator package to use new types 2020-12-02 12:45:00 -05:00
James Bardin 22a5641c79 update winrm communicator to use new types
remove the legacy types and mapstructure from the winrm communicator
2020-12-02 12:45:00 -05:00
James Bardin 5cc3fd60d9 update ssh communicator to use new types
remove the legacy types and mapstructure from the ssh communicator
2020-12-02 12:45:00 -05:00
James Bardin 987df2003a move connection block schema out of terraform core
This way it can be used to handle connection values in the communicators
directly without importing terraform.
2020-12-02 12:45:00 -05:00
James Bardin 9adfaa9b5d rewrite local-exec to run internally
Use the new interface directly, so that there are no shims or plugins
involved with the execution of the provisioner.
2020-12-02 12:45:00 -05:00
James Bardin dc9ded8618 remove old version call site 2020-12-02 12:45:00 -05:00
James Bardin 2eb8278a0f remove unused provisioners main pkgs 2020-12-02 12:45:00 -05:00
James Bardin 03d11f988e remove old test provider 2020-12-02 12:45:00 -05:00
James Bardin e4c72015a3 remove old test provider from e2e tests 2020-12-02 12:45:00 -05:00
James Bardin eee581ae54 simple provider for internal testing
Simple is a minimal provider implementation using the grpcwrap package,
intended for use in internal tests.
2020-12-02 12:44:59 -05:00
James Bardin 65340f51be wrap the terraform provider for grpc tests 2020-12-02 12:44:59 -05:00
James Bardin b1c104834e grpcwrap: convert provider interface to grpcserver
grpcwrap wraps a core providers.Interface and converts it to a
tfplugin5.ProviderServer to allow for easier protocol testing.
2020-12-02 12:44:59 -05:00
James Bardin de5b022a3b legacy types in backend/local 2020-12-02 12:33:18 -05:00
James Bardin 82529324e6 remove unused ResourceMode 2020-12-02 12:33:18 -05:00
James Bardin 89ae4e503f remove unused InstanceType 2020-12-02 12:33:18 -05:00
James Bardin 74818ba865 remove legacy resource address types 2020-12-02 12:33:18 -05:00
James Bardin 2d71f54fc0 remove legacy diff types 2020-12-02 12:33:18 -05:00
James Bardin e998882824 remove legacy types from command package 2020-12-02 12:33:18 -05:00
James Bardin c33b8c7faa re-add orphan transformer tests that still apply 2020-12-02 12:33:18 -05:00
James Bardin 14dedf295b remove legacy state types 2020-12-02 12:33:18 -05:00
James Bardin 943ef51d67 remove legacy import mock 2020-12-02 12:33:17 -05:00
James Bardin 8a325ea54b remove legacy provisioner types 2020-12-02 12:33:17 -05:00