579680cebc
provisioner/remote-exec: Move script cleanup after command wait
...
The script cleanup step added in #5577 was positioned before the
`cmd.Wait()` call to ensure the command completes. This was causing
non-deterministic failures, especially for longer running scripts.
Fixes #5699
Fixes #5737
2016-03-21 10:49:32 -05:00
96ebf0af0e
provisioner/remote-exec: Clear out scripts after uploading
...
Prevents residual script contents from remaining on machine.
Fixes #482
2016-03-11 10:25:11 -06:00
b82bd0c280
Condense switch fallthroughs into expr lists
2015-05-26 21:52:36 -04:00
41748003c0
Updated the PR according to the review comments
...
* We now return an error when you set the script_path to
C:\Windows\Temp explaining this is currently not supported
* The fix in PR #1588 is converted to the updated setup in this PR
including the unit tests
Last thing to do is add a few tests for the WinRM communicator…
2015-05-01 18:52:01 +02:00
b1c6a3f63f
Few small fixes to make the last tests also pass
...
The reason why the shebang is removed from these tests, is because the
shebang is only needed for SSH/Linux connections. So in the new setup
the shebang line is added in the SSH communicator instead of in the
resource provisioner itself…
2015-05-01 18:48:54 +02:00
c9e9e374bb
Adding some abstractions for the communicators
...
This is needed as preperation for adding WinRM support. There is still
one error in the tests which needs another look, but other than that it
seems like were now ready to start working on the WinRM part…
2015-05-01 18:48:54 +02:00
de8666a5fa
helper/ssh: add random number to script [GH-1545]
2015-04-18 16:09:08 -07:00
05407296c6
Add cleanup function to close SSHAgent
2015-03-20 18:18:35 -07:00
164f303da4
Add SSH Agent support
2015-03-15 16:12:59 -07:00
539eca5ee6
Fix failing tests
2014-10-09 21:29:21 -07:00
a154520ce8
provisioners/remote-exec: output
2014-10-05 23:23:30 -07:00
e5868ebdd9
provisioners/*: new interface
2014-10-04 16:29:33 -07:00
c452579512
provisioners/*: compiling, tests passing
2014-09-16 17:08:27 -07:00
4a53f38d3a
Update resource_provisioner.go
...
Better variable name.
2014-08-25 17:39:46 -04:00
b2ff49be2e
More descriptive variable names for pipes.
2014-08-25 12:39:07 -04:00
6da9a2d49d
Use scanner instead of buffer read line
...
Supported in Go 1.1 http://golang.org/pkg/bufio/#Scanner
2014-08-25 11:58:14 -04:00
46154ca1d3
Fixed a ton of typos in docs and comments
2014-08-07 00:19:56 -07:00
8720d2465e
builtin/provisioners/*: new API
2014-07-22 10:38:39 -07:00
b84814539f
Refactor shared SSH setup code
2014-07-16 10:33:44 -07:00
2c3e619960
Removing unused constants
2014-07-16 10:33:44 -07:00
8691a3ce91
Refactor helper methods out of provisioner
2014-07-16 10:33:44 -07:00
104b28e19e
terraform: Remove ResourceConnectionInfo, use raw map
2014-07-15 12:34:07 -07:00
de8ee65b2b
provisioner/remote-exec: Retry SSH connections
2014-07-15 12:34:07 -07:00
2b6d7dc0b9
provisioner/remote-exec: Adding retry logic
2014-07-15 12:34:07 -07:00
389d9ba2fc
provisioner/remote-exec: First pass at copy+exec
2014-07-15 12:34:07 -07:00
f215d31df4
provisioner/remote-exec: Collect scripts to upload
2014-07-15 12:34:07 -07:00
cd3170b906
provisioner/remote-exec: Working on SSH configuration
2014-07-15 12:34:07 -07:00
5023b896ab
provisioner/remote-exec: Enforce XOR of command and inline
2014-07-15 12:34:07 -07:00
6381fbd226
provisioner/remote-exec: Adding initial skeleton
2014-07-15 12:34:06 -07:00
Paul Hinze