Commit Graph

7740 Commits

Author SHA1 Message Date
James Nugent 288e568272 Merge pull request #4024 from rjeczalik/nil-deref-fix
provider/aws: fix for https://github.com/aws/aws-sdk-go/issues/452
2015-11-24 11:52:33 +02:00
Rafal Jeczalik 9e66e18334 provider/aws: fix for https://github.com/aws/aws-sdk-go/issues/452 2015-11-24 09:30:21 +01:00
Mitchell Hashimoto 0e8ef19f56 Merge pull request #4028 from hashicorp/edit-page-link
fix edit this page stacking
2015-11-23 21:15:31 -08:00
captainill e9cf7f5f00 fix edit this page stacking 2015-11-23 23:51:02 -05:00
Seth Vargo a61c375115 Capital 'C' /cc @mitchellh 2015-11-23 21:31:28 -05:00
clint shryock 73e1f4ce52 release: clean up after v0.6.7 2015-11-23 15:46:11 -06:00
clint shryock b7c41aed92
v0.6.7 2015-11-23 18:16:01 +00:00
clint shryock 7e0cbb4da7 Update Vagrant file to use Go 1.5.1 2015-11-23 11:11:55 -06:00
Paul Hinze c524682f2d Update CHANGELOG.md 2015-11-23 09:02:45 -06:00
Paul Hinze 8ee8d384aa Merge pull request #4021 from hashicorp/b-require-vpc-for-subnet
provider/aws: Make VPC ID required on subnets
2015-11-23 09:02:23 -06:00
James Nugent 99e3d62cd8 provider/aws: Make VPC ID required on subnets 2015-11-23 16:53:49 +02:00
James Nugent 6543b944b7 Update CHANGELOG.md 2015-11-23 16:33:31 +02:00
Clint c74145f711 Update CHANGELOG.md 2015-11-23 08:23:10 -06:00
Clint 82050ff832 Merge pull request #4005 from hashicorp/b-aws-iam-user-delete
provider/aws: Fix issue deleting users who are attached to a group
2015-11-23 08:22:48 -06:00
Clint 38a5502efb Update CHANGELOG.md 2015-11-23 08:22:33 -06:00
Clint 7772a66b2f Merge pull request #3940 from hashicorp/b-aws-spot-instance-updates
providers/aws: Update Spot Instance request to provide connection information
2015-11-23 08:22:07 -06:00
James Nugent b044340e75 Merge pull request #4017 from hashicorp/b-vars-refresh
core: Validate context after input of vars on refresh
2015-11-23 16:19:36 +02:00
Paul Hinze fd2c62b3c7 Update CHANGELOG.md 2015-11-23 08:19:23 -06:00
Paul Hinze 3afe350c28 Merge pull request #4002 from hashicorp/phinze/skip-statefunc-for-nils
helper/schema: skip StateFunc when value is nil
2015-11-23 08:12:13 -06:00
James Nugent 1f5de8ee43 Update CHANGELOG.md 2015-11-23 15:10:38 +02:00
James Nugent 1fa44b4796 Merge pull request #4020 from stack72/f-aws-elasticache-cluster-maintenance-window
provider/aws:Elasticache maintenance_window forces lowercase
2015-11-23 15:02:21 +02:00
stack72 150e997a96 Changing the AWS ElastiCache cluster maintenance_window to enforce lowercase 2015-11-23 12:54:56 +00:00
Brett Mack 5dde514281 Merge pull request #1 from hmrc/timeout
Make maxRetryTimeout (in seconds) configurable
2015-11-23 11:47:58 +00:00
Nicki Watt 3809315af9 Upped default maxRetryTimeout from 30s -> 60s 2015-11-23 11:45:16 +00:00
James Nugent b4725d4fa3 Merge pull request #4018 from hashicorp/f-ignore-test-files
Ignore .test files generated by some editors
2015-11-23 12:42:40 +02:00
James Nugent 0375c5a4ab Ignore .test files generated by some editors
Seems like Emacs is generating .test files when saving _test.go files -
we don't need these in the repo.
2015-11-23 10:40:38 +02:00
James Nugent 50b5e7c1a5 Validate context after input of vars on refresh
Fixes #4013.
2015-11-23 10:33:40 +02:00
James Nugent 890e214c00 Add failing test replicating #4013 2015-11-23 10:32:46 +02:00
Radek Simko ddc98d7733 Update CHANGELOG.md 2015-11-23 08:00:49 +00:00
Radek Simko 749fcd4931 Merge pull request #4010 from pforman/cloudtrail-enable
provider/aws:  Add "enable_logging" to CloudTrail resource
2015-11-23 07:59:29 +00:00
Paul Forman 52aad04930 Mistake in type refactor in cloudTrailGetLoggingStatus
When adjusting the types to prevent casting, I didn't change the error
message to handle the pointer change.  "go tool vet" caught this.
2015-11-22 13:23:08 -07:00
Paul Forman 9cec40ea3c Add missing error-checks from code review
Some error-checking was omitted.

Specifically, the cloudTrailSetLogging call in the Create function was
ignoring the return and cloudTrailGetLoggingStatus could crash on a
nil-dereference during the return.  Fixed both.

Fixed some needless casting in cloudTrailGetLoggingStatus.
Clarified error message in acceptance tests.
Removed needless option from example in docs.
2015-11-22 12:54:11 -07:00
Paul Forman 484887c0c5 Change default for logging in CloudTrail to true
The default for `enable_logging`, which defines whether CloudTrail
actually logs events was originally written as defaulting to `false`,
since that's how AWS creates trails.

`true` is likely a better default for Terraform users.

Changed the default and updated the docs.
Changed the acceptance tests to verify new default behavior.
2015-11-22 10:47:23 -07:00
Sander van Harmelen ef4726bd50 Change Set internals and make (extreme) performance improvements
Changing the Set internals makes a lot of sense as it saves doing
conversions in multiple places and gives a central place to alter
the key when a item is computed.

This will have no side effects other then that the ordering is now
based on strings instead on integers, so the order will be different.
This will however have no effect on existing configs as these will
use the individual codes/keys and not the ordering to determine if
there is a diff or not.

Lastly (but I think also most importantly) there is a fix in this PR
that makes diffing sets extremely more performand. Before a full diff
required reading the complete Set for every single parameter/attribute
you wanted to diff, while now it only gets that specific parameter.

We have a use case where we have a Set that has 18 parameters and the
set consist of about 600 items (don't ask 😉). So when doing a diff
it would take 100% CPU of all cores and stay that way for almost an
hour before being able to complete the diff.

Debugging this we learned that for retrieving every single parameter
it made over 52.000 calls to `func (c *ResourceConfig) get(..)`. In
this function a slice is created and used only for the duration of the
call, so the time needed to create all needed slices and on the other
hand the time the garbage collector needed to clean them up again caused
the system to cripple itself. Next to that there are also some expensive
reflect calls in this function which also claimed a fair amount of CPU
time.

After this fix the number of calls needed to get a single parameter
dropped from 52.000+ to only 2! 😃
2015-11-22 14:21:28 +01:00
James Nugent 774ed1ded8 Merge pull request #4012 from rakutentech/rename-function
provider/vsphere: Rename create* functions
2015-11-22 11:34:42 +02:00
Paul Forman c9eeb161e0 Add a comment in tests
The purpose of the first test of enable_logging wasn't quite clear.

It's future-proofing against the assumptions made about AWS behavior.
2015-11-21 14:55:08 -07:00
Martin Atkins 11190144f0 AWS Opsworks tests bring their own IAM objects.
Previously we assumed the existence of some default objects that most
Opsworks users have because the Opsworks console creates them by default
when a new stack is created.

However, that meant that these tests wouldn't work correctly for anyone
who either had never used Opsworks via the UI or who had never accepted
the default of having the console create some predefined IAM objects to
use. It may also have led to some weird failures if a particular user had
customized the settings for these default objects.

Now the tests create suitable IAM roles, a policy and an instance profile
and use these when creating Opsworks stacks, avoiding any dependency
on any pre-existing objects.

This fixes #3998.
2015-11-21 11:13:25 -08:00
Nicki Watt 49195f8b77 Added docs for maxRetryTimeout 2015-11-21 12:55:07 +00:00
Nicki Watt f1c2be9772 Make maxRetryTimeout (in seconds) configurable 2015-11-21 12:54:59 +00:00
Paul Forman f98dbbb580 Tests and docs for AWS CloudTrail "enable_logging"
Add acceptance tests for creation, enable, and disable logging.

Add option to docs and example.
2015-11-21 00:18:38 -07:00
Paul Forman 52db098292 Add enable_logging to AWS CloudTrail
The AWS CloudTrail resource is capable of creating CloudTrail resources,
but AWS defaults the actual logging of the trails to `false`, and
Terraform has no method to enable or monitor the status of logging.

CloudTrail trails that are inactive aren't very useful, and it's a
surprise to discover they aren't logging on creation.

Added an `enable_logging` parameter to resource_aws_cloudtrail to enable
logging.  This requires some extra API calls, which are wrapped in new
internal functions.

For compatibility with AWS, the default of `enable_logging` is set to
`false`.
2015-11-21 00:18:38 -07:00
clint shryock 233aab6e0a provider/aws: Fix issue deleting users who are attached to a group
If you want to delete an IAM user, that user must not belong to any groups
2015-11-20 16:54:26 -06:00
Clint cf87ede5dd Update CHANGELOG.md 2015-11-20 14:50:41 -06:00
Clint cc70d25dc5 Merge pull request #3898 from hashicorp/b-aws-elb-iam-cert-delete
providers/aws: Retry deleting IAM Server Cert on dependency violation
2015-11-20 14:50:18 -06:00
Clint f26be08091 Update CHANGELOG.md 2015-11-20 14:49:24 -06:00
Clint 9edbf6a7fc Merge pull request #3908 from hashicorp/b-elb-cookie-fix
provider/aws: Fix issue with LB Cookie Stickiness and empty expiration period
2015-11-20 14:49:00 -06:00
Paul Hinze c7dc1c10a3 helper/schema: skip StateFunc when value is nil
This takes the nil checking burden off of StateFunc.

fixes #3586, see that issue for further discussion
2015-11-20 14:07:18 -06:00
Paul Hinze 5ec446718a Merge pull request #4000 from hashicorp/phinze/keys-for-schema-test-cases
helper/schema: name test cases w/ strings
2015-11-20 14:06:37 -06:00
Paul Hinze 938281024f helper/schema: name test cases w/ strings
I promised myself that next time I jumped in this file I'd fix this up.
Now we don't have to manually index the file with comments, we can just
add descriptive names to the test cases!
2015-11-20 13:51:34 -06:00
Clint ed3399593a Merge pull request #3996 from hashicorp/b-aws-test-fixes
Adjustments for AWS Acceptance tests
2015-11-20 13:28:25 -06:00