Commit Graph

27359 Commits

Author SHA1 Message Date
Paul Hinze 0fff7d1673 core: validate graph w/ diff during plan phase
This reimplements my prior attempt at nipping issues where a plan did
not yield the same cycle an apply did. My prior attempt was to have
ctx.Validate generate a "Verbose" worst-case graph. It turns out that
skipping PruneDestroyTransformer to generate this graph misses important
heuristics that prevent cycles by dropping destroy nodes that are
determined to be unused.

This resulted in Validate improperly failing in scenarios where these
heuristics would have broken the cycle.

We detected the problem during the work on #1781 and worked around the
issue by reverting to the non-Verbose graph in Validate.

This commit accomplishes the original goal in a better way - by
generating the full graph and checking it once Plan has calculated the
diff. This guarantees that any graph issue that would be caught by Apply
will be caught by Plan.
2015-05-05 17:24:44 -05:00
Clint df7603520b Update CHANGELOG.md
provider/aws: Add Security Group Rule as a top level resource #1620
2015-05-05 17:13:44 -05:00
Clint 9510c716aa Merge pull request #1620 from hashicorp/f-aws-security-group-rule-resource
provider/aws: Add Security Group Rule as a top level resource
2015-05-05 17:12:15 -05:00
Clint Shryock 885efa0837 provider/aws: Add Security Group Rule as a top level resource
- document conflict with sg rules and sg in-line rules
- for this to work, ingress rules need to be computed
2015-05-05 16:56:39 -05:00
Clint 96e91c1cbd Update CHANGELOG.md 2015-05-05 16:48:48 -05:00
Clint a4000941c2 Merge pull request #1765 from hashicorp/f-aws-security-group-remove-default-egress
provider/aws: Remove default egress rule from Security Group on creation
2015-05-05 16:47:23 -05:00
Mitchell Hashimoto febc8643af website: add prpogating_vgws 2015-05-05 14:44:07 -07:00
Mitchell Hashimoto 9161454e78 update CHANGELOG 2015-05-05 14:43:23 -07:00
Mitchell Hashimoto fb4ac42c65 Merge pull request #1516 from henrikhodne/aws-propagating-vgws
provider/aws: add propagating_vgws to route tables
2015-05-05 14:42:45 -07:00
Clint Shryock eb7c1bb218 fix go formatting 2015-05-05 16:42:08 -05:00
Clint Shryock e9b08cf31f revert the required part 2015-05-05 16:23:26 -05:00
Clint Shryock 1ed81da9a9 update ENI test for SG egress constraint 2015-05-05 16:23:26 -05:00
Clint Shryock 85b1756c27 revise tests and check for vpc_id 2015-05-05 16:23:26 -05:00
Clint Shryock 8ded3c2d1b Move block for deleing default rule into the create method; only invoke once 2015-05-05 16:23:26 -05:00
Clint Shryock ee65684abe Add spec for removing default egress rule 2015-05-05 16:23:26 -05:00
Clint Shryock b145ce88b7 Document Egress+VPC change, update link 2015-05-05 16:23:26 -05:00
Clint Shryock 1558fd1c3e provider/aws: Remove default egress rule from Security Group on creation 2015-05-05 16:23:25 -05:00
Mitchell Hashimoto 27a616ade1 update cHANGELOG 2015-05-05 13:30:57 -07:00
Mitchell Hashimoto b40c87391b update cHANGELOG 2015-05-05 13:29:22 -07:00
Mitchell Hashimoto 412a2dca0b Merge pull request #1575 from freshbooks/aws-eni-route
provider/aws: Add Elastic Network Interfaces as route destination
2015-05-05 13:28:48 -07:00
Mitchell Hashimoto d582d0eb13 update CHANGELOG 2015-05-05 13:26:29 -07:00
Mitchell Hashimoto 379895931d website: network interface for EIP 2015-05-05 13:25:45 -07:00
Mitchell Hashimoto 7a22376742 Merge branch 'jstremick-f-aws-associate-eip-to-eni' 2015-05-05 13:24:58 -07:00
Mitchell Hashimoto 1c2d5fbd0a Merge branch 'f-aws-associate-eip-to-eni' of https://github.com/jstremick/terraform into jstremick-f-aws-associate-eip-to-eni 2015-05-05 13:24:50 -07:00
Mitchell Hashimoto c8635654cb Merge pull request #1781 from hashicorp/b-module-deps
Flatten modules into main graph
2015-05-05 13:19:41 -07:00
Clint ad539d3c96 Update CHANGELOG.md 2015-05-05 15:10:34 -05:00
Mitchell Hashimoto a07f07bbf2 Merge pull request #1813 from svanharmelen/b-aws-creds-fix
Fixing PR #1804
2015-05-05 13:05:35 -07:00
Mitchell Hashimoto 0f40cebc0f Merge pull request #1814 from svanharmelen/b-fix-small-vet-warning
Fixing a small vet warning introduced by PR #1796
2015-05-05 13:05:11 -07:00
Clint 18b43b78cb Merge pull request #939 from bitglue/iam
Implement a subset of IAM resources
2015-05-05 15:05:05 -05:00
Mitchell Hashimoto 8c34e9a36a terraform: provisionedby prefixed 2015-05-05 13:04:27 -07:00
Clint Shryock 7b082d007e Merge commit '33183c0'
* commit '33183c0':
  Implement a hash function for string sets
2015-05-05 15:01:02 -05:00
Sander van Harmelen 3881c81a66 Added the exit code as well... 2015-05-05 21:56:20 +02:00
Mitchell Hashimoto d503cc2d82 terraform: flattenable graphNodeMissingProvisioner 2015-05-05 12:45:28 -07:00
Sander van Harmelen 48f4d499f9 Fixing a small vet warning introduced by PR #1796
While fixing the vet warning also tried to improve any feedback by
showing the actual output/error instead of just the error code.

While testing this I noticed only adding stderr output is not enough as
not all error info is send to stderr, but sometimes also to stdout.
2015-05-05 21:26:28 +02:00
Mitchell Hashimoto 6d4969f64c terraform: run prune destroy on validate 2015-05-05 12:11:49 -07:00
Sander van Harmelen 897bf5e53d Added `SharedCredentialsProvider` and `EC2RoleProvider` as well... 2015-05-05 20:38:35 +02:00
Sander van Harmelen 5435815524 Fixing PR #1804 2015-05-05 20:30:35 +02:00
Mitchell Hashimoto 1045fb9eac Merge pull request #1811 from hashicorp/b-aws-auth
providers/aws: chain credentials
2015-05-05 10:55:40 -07:00
Mitchell Hashimoto 803348d05f Merge pull request #1797 from hashicorp/b-flatten-modules-cycle
core: failing test for a bad module cycle
2015-05-05 10:54:57 -07:00
Mitchell Hashimoto 7a5499d4f7 providers/aws: chain credentials 2015-05-05 10:44:19 -07:00
Mitchell Hashimoto 094c859f2c Update CHANGELOG.md 2015-05-05 10:32:32 -07:00
Mitchell Hashimoto 639f310ae6 Merge pull request #1805 from dupuy/openstack-resource-docs
Openstack resource docs
2015-05-05 10:25:30 -07:00
Christopher Tiwald d76719bbb8 Add docs for various iam_* resources. 2015-05-05 12:47:20 -04:00
John Engelman 6ee17a8e9e Add acceptance tests 2015-05-05 12:47:20 -04:00
Phil Frost b082117e92 Implement AWS IAM resources
- Users
- Groups
- Roles
- Inline policies for the above three
- Instance profiles
- Managed policies
- Access keys

This is most of the data types provided by IAM. There are a few things
missing, but the functionality here is probably sufficient for 95% of
the cases. Makes a dent in #28.
2015-05-05 12:47:20 -04:00
Phil Frost 33183c078b Implement a hash function for string sets
Sets of strings are pretty common. Let's not duplicate the function
necessary to create a set of strings in so many places.
2015-05-05 12:47:18 -04:00
Clint Shryock 272415303d provider/aws: Shorting retry timeout for Subnets to 2 minutes, from 5 2015-05-05 11:20:29 -05:00
Clint Shryock 3ce3b7c516 provider/aws: Shorting retry timeout for Security Groups to 2 minutes, from 5 2015-05-05 11:07:16 -05:00
Clint 7c62329506 Merge pull request #1809 from hashicorp/f-aws-auto-vpc-peer-julienba
provider/aws: Add auto accept option for VPC peering
2015-05-05 10:49:56 -05:00
Clint Shryock 4b160dd28e minor cleanups 2015-05-05 10:45:30 -05:00