Sean Chittenden
bfc2a2d42f
Commit WIP re: updated postgresql_role provider.
...
*Read() and *Update() still need to be updated.
2016-12-10 12:32:20 +11:00
Sean Chittenden
2e529146a5
Remove unused code.
2016-12-10 12:32:20 +11:00
Sean Chittenden
6b540ecb55
Don't use d.GetOk() when the zero value is a required attribute.
...
Add "pathological" test.
2016-12-10 12:32:20 +11:00
Sean Chittenden
37fdc958b3
Always remove the IS_TEMPLATE attribute before dropping a database.
2016-12-10 12:32:20 +11:00
Sean Chittenden
e9b2b38288
Remove SetId() call from *Read(), this isn't required for import to work.
2016-12-10 12:32:20 +11:00
Sean Chittenden
f253fc9eff
Commit miss earlier, fix syntax from unstaged commit.
2016-12-10 12:32:20 +11:00
Sean Chittenden
5280c37bea
`postgresql_database` resource provider should now be feature complete.
...
* Add support to import databases. See docs.
* Add support for renaming databases
* Add support for all known PostgreSQL database attributes, including:
* "allow_connections"
* "lc_ctype"
* "lc_collate"
* "connection_limit"
* "encoding"
* "is_template"
* "owner"
* "tablespace_name"
* "template"
2016-12-10 12:32:20 +11:00
Sean Chittenden
59f4ad6fd1
Alpha sort the resources in the PostgreSQL map.
2016-12-10 12:32:19 +11:00
Sean Chittenden
300ef2bc97
Add `connect_timeout` support to the PostgreSQL provider.
2016-12-10 12:32:19 +11:00
Sean Chittenden
3750bf7af2
Depreciate the PostgreSQL provider's `ssl_mode` option in favor of `sslmode`.
...
Both libpq(3) and github.com/lib/pq both use `sslmode`. Prefer this vs
the non-standard `ssl_mode`. `ssl_mode` is supported for compatibility
but should be removed in the future.
Changelog: yes
2016-12-10 12:32:19 +11:00
Sean Chittenden
a200899d93
Allow the PostgreSQL provider to talk to a non-default database.
2016-12-10 12:32:19 +11:00
Sean Chittenden
602a908d7b
Add a `fallback_application_name` to the PostgreSQL DSN.
2016-12-10 12:32:19 +11:00
Sean Chittenden
44d907a3de
Revert "Prefer PGHOSTADDR over PGHOST, if set." lib/pq doesn't support PGHOSTADDR.
...
d8eeeb8bae/conn.go (L1851)
This reverts commit 26a2a974f2b2f2cefd41b426b8469fa3ea72b33e.
2016-12-10 12:32:19 +11:00
Sean Chittenden
55061d190a
Prefer PGHOSTADDR over PGHOST, if set.
2016-12-10 12:32:19 +11:00
Sean Chittenden
3779dfffa9
Use a string instead of the `%t` modifier for printing a bool in SQL
2016-12-10 12:32:19 +11:00
Sean Chittenden
5b66bf0745
ForceNew is required when changing the locale, ctype, and encoding.
...
This will cause someone some grief. TODO: Figure out how to prevent
someone from blowing off their foot if they twiddle this after the
fact.
2016-12-10 12:32:18 +11:00
Sean Chittenden
547dcf27e1
Decorate the computed attribute where appropriate
2016-12-10 12:32:18 +11:00
Sean Chittenden
242405bdf1
Factor out the validate function for connection limits
2016-12-10 12:32:18 +11:00
Sean Chittenden
02dea2edd9
Add missing descriptions to owner and name
2016-12-10 12:32:18 +11:00
Sean Chittenden
deb91f61ce
Update the descriptions to mostly match the official PostgreSQL docs.
2016-12-10 12:32:18 +11:00
Sean Chittenden
68cadd3c2a
Update the FIXME/TODO style to match Google style guides
2016-12-10 12:32:18 +11:00
Sean Chittenden
f3add9e7ef
Flesh out the CREATE DATABASE for PostgreSQL.
2016-12-10 12:32:18 +11:00
Sean Chittenden
2aee081e4b
Eh, specify default values lib/pq zero initializes itself
2016-12-10 12:32:17 +11:00
Sean Chittenden
7e5ccc089b
Spell `ssl_mode` like `sslmode`
2016-12-10 12:32:17 +11:00
Sean Chittenden
655617ed6a
Remove the PGPASSWORD requirement for tests.
...
If they're required and the value is missing, the test will fail. There's
no need to enforce that in the test itself.
2016-12-10 12:32:17 +11:00
Sean Chittenden
ec130d538c
Add comments requesting that the testing-specific environment variables
...
can be removed in Terraform 0.8.0
2016-12-10 12:32:17 +11:00
Sean Chittenden
b68ef2c40b
Fall through to using the defaults from github.com/lib/pq
2016-12-10 12:32:17 +11:00
Sean Chittenden
f31ebff10e
Change the PostgreSQL PGSSLMODE option to sslmode to match PostgreSQL idioms.
...
Also don't specify the default and rely on github.com/lib/pq (which uses "required"
and is different than what libpq(3) uses, which is "preferred" and unsupported by
github.com/lib/pq).
2016-12-10 12:32:17 +11:00
Sean Chittenden
df7a15fff9
Complete the docs for Consul Prepared Query.
...
While here add an additional example of a standard prepared query in
addition to the prepared query template that was already present.
2016-12-10 12:28:06 +11:00
Mitchell Hashimoto
808f09f01f
terraform: user friendly error when using old map overrides
...
Related to #8036
We have had this behavior for a _long_ time now (since 0.7.0) but it
seems people are still periodically getting bit by it. This adds an
explicit error message that explains that this kind of override isn't
allowed anymore.
2016-12-09 15:58:24 -05:00
Clint
1f5b940f3f
Merge pull request #10175 from hashicorp/b-aws-elasticache-updates
...
[WIP] provider/aws: Update Elasticache docs for corrections, clarity
2016-12-09 14:56:26 -06:00
James Bardin
626ad57546
Merge pull request #10643 from hashicorp/jbardin/GH-10640
...
Disaply interpolation strings for computed fields
2016-12-09 15:31:42 -05:00
Mitchell Hashimoto
4a38f5f534
Merge pull request #10642 from hashicorp/b-num-id
...
config: allow names to start with numbers
2016-12-09 14:42:21 -05:00
James Bardin
fc13a1b814
Disaply interpolation strings for computed fields
...
Displaying interpolations strings when possible for computed fields in
the plan output makes for a nicer UX
2016-12-09 13:30:00 -05:00
Paul Stack
e9896be90e
Update CHANGELOG.md
2016-12-09 17:57:42 +00:00
Paul Stack
c69e325a1a
provider/aws: Add support for AWS Lightsail Domain ( #10637 )
...
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLightsailDomain_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/09 15:19:58 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v
-run=TestAccAWSLightsailDomain_ -timeout 120m
=== RUN TestAccAWSLightsailDomain_basic
--- PASS: TestAccAWSLightsailDomain_basic (16.28s)
=== RUN TestAccAWSLightsailDomain_disappears
--- PASS: TestAccAWSLightsailDomain_disappears (12.71s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws29.015s
```
2016-12-09 17:56:48 +00:00
Clint
640530e76f
Update CHANGELOG.md
2016-12-09 11:52:00 -06:00
Clint
e705cd9a93
Merge pull request #10635 from dougneal/import_vpc_peerconn_accepter_fix
...
provider/aws: aws_vpc_peering_connection: import fix
2016-12-09 11:50:55 -06:00
Mitchell Hashimoto
148b8a12ea
website: remove BC from upgrade guide
2016-12-09 12:42:18 -05:00
Mitchell Hashimoto
cd1cd1cb7d
vendor: update HIL
2016-12-09 12:40:34 -05:00
Mitchell Hashimoto
b5f1738e17
config: allow IDs to start with numbers
2016-12-09 12:35:23 -05:00
Mitchell Hashimoto
7f87a0109b
command/plan: user friendly error if plan file given to plan command
2016-12-09 11:34:38 -05:00
Paul Stack
15814c3ecc
Update CHANGELOG.md
2016-12-09 15:51:38 +00:00
Tom Wilkie
dd39296d6c
Allow import of aws_security_groups with more than one source_security_group_id rule ( #9477 )
...
* Allow import of aws_security_groups with more than one source_security_group_id rule
* Add acceptable test for security group with multiple source rules.
2016-12-09 15:50:51 +00:00
Clint
e902ff320c
Update CHANGELOG.md
2016-12-09 08:44:21 -06:00
Clint
5f765d9de6
Merge pull request #10624 from hashicorp/pr-9891
...
provider/aws: Add aws_snapshot_create_volume_permission resource (contd. #9891 )
2016-12-09 08:43:18 -06:00
clint shryock
c54dba65b0
document snapshot_create_volume_permissions
2016-12-09 08:36:40 -06:00
Clint
e2fc12c38f
Update CHANGELOG.md
2016-12-09 08:29:12 -06:00
Clint
0766074289
Merge pull request #10583 from hashicorp/f-lightsail-key-pair
...
provider/aws: Add Lightsail Key Pair resource
2016-12-09 08:26:00 -06:00
Doug Neal
24baa38408
provider/aws: aws_vpc_peering_connection: import fix
...
When importing an `aws_vpc_peering_connection`, the code assumes that
the account under Terraform control is the initiator (requester) of the
VPC peering request. This holds true when the peering connection is
between two VPCs in the same account, or when the peering connection has
been initiated from the controlled account to another.
However, when the peering connection has been initiated from a foreign
account towards the account under management, importing the peering
connection into the statefile results in values of `peer_vpc_id` and
`vpc_id` being the opposite way round to what they should be, and in the
`peer_owner_id` being set to the managed account's ID rather than the
foreign account's ID.
This patch checks the Accepter and Requester Owner IDs against the AWS
connection's reported owner ID, and reverses the mapping if it is
determined that the VPC peering connection is owned by the foreign
account.
2016-12-09 12:05:06 +00:00