59349cca11
helper/schema: sets must be treated atomically within ResourceData
...
This fixes a seemingly minor issue (GH-255) around plans showing changes
when in fact there are none. But in reality this turned out to uncover a
really terrible bug.
The effect of what was happening was that multiple items in a set were
being merged. Now, they were being merged in the right order, so if you
didn't have rich types (lists in a set) then you never saw the effect
since the later value would overwrite the earlier. But with lists (such
as in security groups), you would end up with the lists merging. So, if
you had one ingress rule with CIDR blocks and one with SGs, then after
the merge both ingress rules would have BOTH CIDR and SGs, resulting in
an incorrect plan (GH-255).
This fixes the issue by introducing a `getSourceExact` bitflag to the
ResourceData source. When this is set, ALL data must come from this
level, instead of merging lower levels. In the case of sets and diffs,
this is exactly what you want: "Get me the set 'foo' from the config and
the config ONLY (not the state or diff or w/e)".
Andddddd its fixed.
GH-255
2014-10-11 10:40:54 -07:00
3a107d2e50
helper/schema: set the field to empty if it is a list and computed
2014-10-10 15:58:38 -07:00
e5d64318bf
helper/schema: don't say that a set is computed if it exists
2014-10-10 15:46:24 -07:00
36f225dea0
fmt
2014-10-10 14:50:35 -07:00
e0994c717d
helper/schema: fix issues around computed sets
2014-10-10 09:13:04 -07:00
539eca5ee6
Fix failing tests
2014-10-09 21:29:21 -07:00
dcaf653d6f
helper/schema: properly detect that a list is computed
2014-10-09 19:09:06 -07:00
3aa655ad3b
helper/schema: test schema diffs with the interpolation splits
2014-10-09 16:31:24 -07:00
753f6c6f8e
helper/schema: fix failing tests
2014-10-08 18:25:31 -07:00
00bdef3093
providers/aws: test tag removal
2014-10-08 18:21:21 -07:00
6eafac8a34
providers/aws: aws_vpc supports tags
2014-10-08 17:54:00 -07:00
f43528957e
helper/schema: support top-level TypeMap
2014-10-08 17:35:14 -07:00
0db9d98fff
helper/schema: can set Partial(true) multiple times
2014-10-08 16:35:14 -07:00
ef62fa80db
helper/resource: add Retry function
2014-10-07 21:44:51 -07:00
a7c321a028
helper/scheam: support UI defaults
2014-09-29 14:00:35 -07:00
99044a1f14
Add descriptions for AWS inputs
2014-09-29 13:30:28 -07:00
901c1448b4
command: make the UI a look nicer
2014-09-29 13:12:06 -07:00
d9596fa4d0
helper/schema: don't ask for input on fields that have a value
2014-09-29 11:16:19 -07:00
5aed997223
helper/schema: Input support
2014-09-29 10:25:43 -07:00
9ba39d93b7
helper/resource: compile
2014-09-24 14:23:29 -07:00
9b2b3a963f
ResourceDiff => InstanceDiff
2014-09-17 16:33:24 -07:00
81d9d70296
helper/schema: conforms to new API, tests pass
2014-09-16 17:07:13 -07:00
0bcbccf046
helper/resource: compiles, fails because Context doesn't work, probably
2014-09-16 17:02:05 -07:00
90dd00ee3c
helper/diff: InstanceState conversion
2014-09-16 16:56:31 -07:00
f117e33c9d
helper/ssh: convert to InstanceState
2014-09-16 16:55:02 -07:00
0250c17d6e
helper/schema: DefaultFunc for dynamic defaults
...
/cc @c4milo - This might be useful to you as well.
2014-09-09 21:33:08 -07:00
5919637456
helper/schema: Defaults [GH-245]
2014-09-09 21:17:29 -07:00
3a6940d715
helper/schema: test cases around unknown variable values
2014-08-30 17:03:01 -07:00
faa4e75960
helper/schema: Get on computed diff should be empty
2014-08-27 15:45:52 -07:00
c9a541d95b
helper/schema: generate a full diff in destroy/create cycle
2014-08-27 15:45:52 -07:00
9d239eea60
helper/schema: detect no change computed for sets/lists properly
2014-08-27 15:03:42 -07:00
0c9b65f3f4
helper/schema: documentation
2014-08-26 21:52:09 -07:00
87a488092c
helper/schema: support partial states
2014-08-26 20:19:44 -07:00
40e5608fa9
helper/schema: return the prior state if Data is an error
2014-08-26 15:50:31 -07:00
56cf1e6faa
Fix go vet complaints
2014-08-24 21:50:35 -07:00
95bd64132b
helper/schema: update docs
2014-08-24 16:53:42 -07:00
31cc3ffca1
helper/schema: one of Optional, Required, Computed must be set
2014-08-24 16:53:41 -07:00
eff8306a6c
helper/schema: don't mark things computed if an ID is set
2014-08-22 12:18:08 -07:00
9ed601d541
helper/schema: store state with processed properly
2014-08-22 12:09:06 -07:00
50026a6d5c
helper/schema: When having a StateFunc, make sure NewExtra contains
...
original
2014-08-22 08:57:44 -07:00
d009ea800a
helper/schema: add support for StateFunc
2014-08-22 08:45:54 -07:00
7be2f1b091
helper/schema: add GetOk
2014-08-21 23:03:04 -07:00
37cf52fa27
helper/schema: if no ID is set then return nil
2014-08-21 22:19:33 -07:00
3d3789920d
helper/schema: can set conninfo
2014-08-21 22:15:47 -07:00
efaedbabb0
fmt
2014-08-20 22:24:35 -07:00
4015d942ab
providers/aws: security group ingress rules treated as set [GH-87]
...
/cc @pearkes - !!!
2014-08-20 22:24:13 -07:00
3db41fe9f6
helper/hashcode for generating hashcodes
2014-08-20 22:09:40 -07:00
e9cc09a886
helper/schema: improve InternalValidate for sets
2014-08-20 21:13:18 -07:00
9ab5577beb
helper/schema: set diff tests
2014-08-20 21:09:07 -07:00
475528adc3
helper/schema: Set operations
2014-08-20 21:09:06 -07:00
ca18e971d1
helper/schema: can set sets
2014-08-20 21:09:06 -07:00
9fe21f0423
helper/schema: verify that sets remove duplicates
2014-08-20 21:09:06 -07:00
56dde5c0c1
helper/schema: can read and get the state of sets
2014-08-20 21:09:06 -07:00
a7e1154a0f
helper/schema: remove swap tracking
2014-08-20 18:11:40 -07:00
312acf3e40
helper/schema: track map of swaps
2014-08-20 18:11:40 -07:00
5e975e47cf
helper/schema: diffing should use ResourceData for guidance
2014-08-20 18:11:40 -07:00
5fc41cc272
helper/schema: properly put "id" into attributes
2014-08-20 10:38:51 -07:00
021a23fe99
helper/schema: if update sets the ID to blank, it deletes the resource
2014-08-20 10:38:51 -07:00
ee0acc4a5d
helper/schema: support bools
2014-08-19 16:46:36 -07:00
968a567499
helper/schema: ability to force set Meta
2014-08-19 15:26:31 -07:00
e2abcb9c14
Merge pull request #163 from desimone/patch-4
...
helper/ssh: style
2014-08-19 12:48:18 -07:00
2606ef8853
Remove extraneous trailing bit in the import URL
2014-08-19 12:27:01 -07:00
3374f310f8
Replace implementation with Mitchell's go-homedir
2014-08-19 12:21:01 -07:00
f48b888477
Merge branch 'master' into expand-user-path
2014-08-19 12:19:16 -07:00
2444986fe8
helper/schema: nice error if update isn't supported
2014-08-19 09:26:48 -07:00
c4664a81e6
helper/schema: show computed lists in diffs
2014-08-18 21:22:27 -07:00
ba819d1f37
helper/schema: don't include zero count in state
2014-08-18 19:12:49 -07:00
5a5ef67d87
helper/schema: don't forward computing onto elements
2014-08-18 19:08:32 -07:00
801b220dc7
helper/schema: can diff lists more correctly
2014-08-18 16:54:30 -07:00
e70522f4ca
helper/schema: if you can't find the list, just fall through to return
...
nil
2014-08-18 15:46:26 -07:00
1b85f3a565
helper/schema: SetDependencies
2014-08-18 15:41:12 -07:00
dfede5791c
helper/schema: use reflection to set maps
2014-08-18 15:17:18 -07:00
3800dffdeb
helper/schema: computed values should not be Get-able
2014-08-18 15:10:53 -07:00
4ae1673580
helper/schema: support for NewRemoved
2014-08-18 15:07:09 -07:00
ce42845acd
helper/schema: use reflection to build []interface{}
2014-08-18 14:24:04 -07:00
17d29f7949
helper/schema: use reflection to verify list
2014-08-18 14:21:36 -07:00
4c9271160e
helper/schema: can handle maps
2014-08-18 14:00:03 -07:00
66d7003e6f
helper/schema: HasChange
2014-08-18 10:00:41 -07:00
f1f4836c99
helper/schema: GetChange
2014-08-18 09:58:44 -07:00
513596cc37
providers/heroku: Heroku app is mostly converted
2014-08-18 09:32:40 -07:00
3943bf5d8c
helper/schema: README
2014-08-17 20:51:09 -07:00
539e4da03f
helper/schema: more tests
2014-08-17 20:48:50 -07:00
d321240042
helper/schema: Provider implements ResourceProvider
2014-08-17 20:23:25 -07:00
c418681cc3
helper/schema: create/update/delete should work for Resource
2014-08-17 20:20:11 -07:00
894187ec18
helper/schema: Resource.Refresh
2014-08-17 19:45:26 -07:00
7db585c257
helper/schema: fix test
2014-08-17 19:32:11 -07:00
afd3a7b811
helper/schema: Provider.Resources
2014-08-17 15:07:01 -07:00
eaac13dd9b
helper/schema: ResourceProvider.Configure
2014-08-17 15:01:27 -07:00
51a44db6c2
helper/schema: move InternalValidate to schemaMap
2014-08-17 14:50:44 -07:00
e5e4437351
helper/schema: start Provider
2014-08-17 14:45:43 -07:00
a33e4bcdf0
helper/schema: properly validate sub-resources
2014-08-17 14:33:54 -07:00
c3f1f49640
helper/schema: final state for lists/objects works
2014-08-17 14:12:54 -07:00
06d30a559a
helper/schema: Set object
2014-08-17 11:38:16 -07:00
2d74a3cadd
helper/schema: basic set
2014-08-16 15:02:51 -07:00
bf6ad07505
helper/schema: ResourceData.Get can get the full object
2014-08-16 13:55:10 -07:00
43e4921bd9
helper/schema: more tests, todo tests for computedwhen
2014-08-16 13:32:21 -07:00
7bc0be4b81
helper/schema: couple more tests around Computed (+ fix)
2014-08-16 09:49:22 -07:00
3a46d21527
helper/schema: computed fields cannot be set
2014-08-16 09:18:45 -07:00
90f462e609
helper/schema: detect invalid/unknown keys
2014-08-15 22:15:10 -07:00
4af387b986
helper/schema: validation
2014-08-15 22:00:16 -07:00
b54acf4a0b
helper/schema: better docs
2014-08-15 17:46:05 -07:00
1d9528e595
helper/schema: ResourceData.Get works in most cases
2014-08-15 17:39:08 -07:00
31067ee8f6
helper/schema: ResourceData, starting tests
2014-08-15 16:32:43 -07:00
660dc68a86
helper/schema: more tests
2014-08-15 10:39:40 -07:00
d05b9d6193
helper/schema: can diff complex resource
2014-08-15 10:25:25 -07:00
878d844f5c
helper/schema: comment
2014-08-14 23:33:30 -07:00
7f14708e71
helper/schema: list ForceNew
2014-08-14 23:32:20 -07:00
22e286ffd5
helper/schema: diff-ing lists at a basic level
2014-08-14 23:17:53 -07:00
46d911325a
helper/schema: Bools and ints can decode
2014-08-14 20:02:52 -07:00
efa2335886
helper/schema: start the Diff function
2014-08-14 19:55:47 -07:00
01b6b5f48e
helper/schema: initial work
2014-08-13 14:23:22 -07:00
d578031831
Added a second test for the other form of tilde paths
2014-08-11 14:57:13 -07:00
e85b89d7fb
Added a test and fixed a typo
2014-08-11 11:47:56 -07:00
9d6e0e4e83
Fixes #179 -- expand ~'s in the path to a key file
2014-08-11 11:39:29 -07:00
1244bff399
Merge pull request #162 from desimone/patch-3
...
Update communicator.go
2014-08-07 15:19:08 -04:00
462bbece95
Update communicator.go
...
If block ends in a return statement. Personal preference. It's less explicit, but more concise to drop the else and outdent the return.
2014-08-07 14:29:02 -04:00
0cb0c412c3
Update communicator.go
...
typo
2014-08-07 14:19:08 -04:00
08c1a19cbf
Merge pull request #161 from desimone/patch-2
...
helper/ssh: equivalent loop
2014-08-07 11:15:44 -07:00
dbe946a97a
Update communicator.go
...
Naming convention consistencies.
2014-08-07 13:53:18 -04:00
b55ab5d5b4
Update password.go
...
Loop is equivalent.
2014-08-07 13:41:41 -04:00
fd60ddaacd
Update provisioner.go
...
Comment should be capitalized to match exported function "VerifySSH"
2014-08-07 13:19:03 -04:00
46154ca1d3
Fixed a ton of typos in docs and comments
2014-08-07 00:19:56 -07:00
a74775d077
helper/ssh: error if private key on SSH [GH-73]
2014-08-05 09:53:02 -07:00
d28e5a1638
dos2unix
2014-07-28 10:43:00 -07:00
b8660c2a65
helper/diff: ComputedAttrsUpdate
2014-07-24 20:25:00 -07:00
c6474b3e5c
terraform: more test cases
2014-07-22 08:27:16 -07:00
d7ecc76148
helper/resource: refactor wait a bit and introduce delay/mintimeout
2014-07-17 11:03:30 -07:00
c89e02c545
helper/diff: fix problems with PreProcess
2014-07-16 16:41:19 -07:00
2cfad3fa71
helper/diff: can specify PreProcess functions
2014-07-16 16:41:18 -07:00
9ec1990608
providers/aws/aws_instance: fix security group and key name issues in count
2014-07-16 15:21:01 -07:00
e8eae17cc9
helper/config: clean up validation to work with nested items
...
/cc @pearkes
2014-07-16 15:08:35 -07:00
b84814539f
Refactor shared SSH setup code
2014-07-16 10:33:44 -07:00
2c3e619960
Removing unused constants
2014-07-16 10:33:44 -07:00
8691a3ce91
Refactor helper methods out of provisioner
2014-07-16 10:33:44 -07:00
b56a7d6957
helper/ssh: Adding Connect function
2014-07-15 12:34:07 -07:00
9ad4531d10
helper/ssh: Importing SSH stuff from Packer
2014-07-15 12:34:06 -07:00
35071f0328
helper/config: can validate array configurations
2014-07-14 18:22:05 -07:00
f8b974c9aa
helper/resource: never use an interval more than 10 seconds on wait
2014-07-14 13:28:48 -07:00
4f798fdec6
helper/diff: if attribute is set and also computed, don't mark computed
2014-07-11 11:46:21 -07:00
f93c9c23d5
helper/diff: don't delete keys from diff if computed
2014-07-11 11:36:44 -07:00
91ad873113
helper/resource: improve logging and output for tests
2014-07-11 11:20:18 -07:00
0b2860fafc
helper/config: more correct logic with regards to nested things
2014-07-10 17:05:40 -07:00
dbe5a1254a
helper/resource: better error if config doesn't validate
2014-07-10 17:01:21 -07:00
9ab4a5bf88
helper/resource: exponential backoff
2014-07-10 14:40:18 -07:00
63ef4cf28a
helper/resource: stdlib to check resource attribute
2014-07-10 14:00:20 -07:00
4a3d51f40e
helper/resource: can compose TestCheckFuncs
2014-07-10 13:29:38 -07:00
8229758806
helper/resource: refresh during test
2014-07-10 13:21:34 -07:00
83f73e63aa
helper/resource: add PreCheck
2014-07-10 13:12:47 -07:00
bc146d21a3
helper/resource: persist state, log
2014-07-10 11:31:07 -07:00
be82499f3c
helper/resource: remove debugging stuff
2014-07-10 10:31:06 -07:00
55c1bf7f79
helper/resource: more tests
2014-07-10 10:30:41 -07:00
e0fbd48afd
helper/resource: Acceptance test framework
2014-07-10 10:20:21 -07:00
96e09440d4
helper/diff: mark removed keys as removed
2014-07-09 09:51:36 -07:00
2d97738636
helper/diff: calculate removed keys
2014-07-09 09:47:21 -07:00
fa3e9fab42
helper/resource: wait 2 seconds between each
2014-07-09 09:16:46 -07:00
b700eee3e0
helper/diff: don't output ID anymore since Terraform does it
2014-07-08 16:59:58 -07:00
663be265dc
helper/config: can validate nested structures
...
/cc @pearkes - See docs
2014-07-08 11:14:53 -07:00
7c588eca58
add readme to helper dir
2014-07-08 10:20:44 -07:00
0c812ba9e8
helper/resource: automatically validate resources
...
/cc @pearkes - So, just set a ConfigValidator struct up on your
resources and it'll now automatically validate.
2014-07-08 10:17:36 -07:00
50b8e761f1
helper/config: Validator
...
/cc @pearkes - Here is the beginning of that helper. It can't really validate
deeper keys (i.e. listeners in ELB), but my goal is for it to support that
soon. Working on it.
2014-07-08 10:02:02 -07:00
f1d782031b
helper/resource: don't assign to nil map
2014-07-07 20:45:09 -07:00
1c725896ca
helper/resource: support waiting on absense of thing
2014-07-07 15:38:26 -07:00
8acd3a6373
helper/resource: set to valid ID
2014-07-07 15:06:17 -07:00
21539d08a8
helper/resource: add id to attributes
2014-07-07 15:00:13 -07:00
177f8c094d
helper/diff: add ID to diff
2014-07-07 14:57:41 -07:00
5ae69778a1
helper/resource: wait should return obj
2014-07-07 10:07:06 -04:00
eb7c8c07c8
helpers/resource: add wait helper
2014-07-07 10:07:06 -04:00
947fa4e669
terraform: Context introduction
2014-07-03 10:14:17 -07:00
6b42d3d9a5
helper/resource: basic tests
2014-07-02 17:36:07 -07:00
cc9ef7a0d3
helper/resource: add UpdateFunc
2014-07-02 17:31:58 -07:00
37995e7ff8
helper/diff: work with complex data types
2014-07-01 16:06:06 -07:00
b6a02e473d
helper/resource: destroy on requiresNew
2014-06-25 18:41:40 -07:00
e392c349ef
helper/resource: clearer destroy logic
2014-06-24 12:59:50 -07:00
cb591ab2df
helper/resource: Destroy is called if destroy is set on diff
2014-06-24 12:55:59 -07:00
d54034d0b5
helper/diff: comment
2014-06-24 10:33:03 -07:00
bd0f23ce25
Move diff to helper/diff, helper/resource knows about it
2014-06-24 10:27:39 -07:00
ae142efff7
providers/aws: know how to destroy things
2014-06-24 10:22:22 -07:00
543e70aab1
helper/resource: nice helper for resourceprovider impl
2014-06-23 19:32:49 -07:00
c556e2ad48
providers/aws: start filling out
2014-06-23 19:01:57 -07:00
Mitchell Hashimoto