d60bf93b4d
Merge pull request #5723 from hashicorp/phinze/rds-instance-generate-identifier
...
provider/aws: ability to generate unique RDS identifier
2016-03-18 16:16:35 -05:00
4e5429a140
provider/aws: ability to generate unique RDS identifier
...
Needed to truncate the identifier for SQL Server engines to keep it at
max 15 chars per the docs. Not a full UUID going into it, but should be
"unique enough" to not matter in practice.
Modified the basic test to use the generated value. Other tests are
still working w/ explicitly specified identifiers.
2016-03-18 16:07:37 -05:00
0a0ccb84f2
Add DefaultOs on Stack creation (fix Windows stack issue)
2016-03-18 17:51:25 -03:00
12ac0761b7
provider/aws: Modify `aws_redshift_cluster` now allows
...
`publicly_accessible` to be changed
Also updated the AWS Go SDK from 1.1.9 -> 1.1.12 as this was required to
allow the new behavior for the Redshift API
2016-03-19 01:05:09 +05:30
65d0707d0a
Merge pull request #5717 from hashicorp/phinze/fix-rds-cluster-instance-disappears-crash
...
provider/aws: fix crash when Aurora instance disappears
2016-03-18 13:00:07 -05:00
17775205f7
provider/aws: fix crash when Aurora instance disappears
...
Usage of a helper function was assuming that an error would be returned
in a not found condition, when in fact a nil pointer was
returned.
Attached test crashes w/o fix, passes with it.
Fixes #5350
Refs #5418
2016-03-18 12:27:57 -05:00
86bf978550
google_compute_instance_group: Correct error message for invalid instances
2016-03-18 09:25:28 -07:00
07caec0d14
Merge pull request #5194 from objectpartners/f-github-provider
...
GitHub Organization Provider
2016-03-17 10:53:13 -05:00
4db3242c53
provider/azurerm: Scaffolding the AzureRM Virtual Machine Test framework
2016-03-17 15:08:59 +00:00
cb109043f2
Scaffold the Azure RM Virtual Machine resource
2016-03-17 15:08:59 +00:00
210eb3571e
Provide iops when changing storage type to io1
2016-03-16 18:32:11 -04:00
ec749d964f
Correctly handle missing lambda function
2016-03-16 14:26:14 -04:00
af93183459
provider/aws: Add validation for CW Log Metric Filter
2016-03-15 15:01:21 +00:00
7eba8f6f66
provider/aws: Add tests for CloudWatch Log Metric Filter
2016-03-15 15:01:20 +00:00
3bfcd47238
provider/aws: Add support for CloudWatch Log Metric Filter
2016-03-15 15:01:20 +00:00
25fce81bfc
provider/aws: log HTTP req/resp at DEBUG level
...
This should be quite helpful in debugging aws-sdk-go operations.
Required some tweaking around the `helper/logging` functions to expose an
`IsDebugOrHigher()` helper for us to use.
2016-03-14 12:26:37 -05:00
fff441b4ac
provider/aws: send Terraform version in User-Agent
2016-03-14 12:16:49 -05:00
60b239d7d1
provider/aws: Switch to session.Copy to build up configs
...
Found this function which makes the config setup much nicer - looks like
it's meant to be used for the very thing we're doing, which is starting
w/ a base config and customizing it slightly.
https://docs.aws.amazon.com/sdk-for-go/api/aws/session/Session.html#Copy-instance_method
This will make the User-Agent setting code to follow much simpler.
2016-03-14 11:42:37 -05:00
76377c9883
Merge pull request #5577 from hashicorp/phinze/remote-exec-empty-file
...
provisioner/remote-exec: Clear out scripts after uploading
2016-03-14 09:54:13 -05:00
908a2cc178
Merge pull request #5588 from hashicorp/b-digital-ocean-droplet-panic
...
Fix panic in digital_ocean_droplet if resp is nil
2016-03-14 12:37:29 +00:00
a8865b8901
provider/aws: optional fields in aws_autoscaling_lifecycle_hook
...
See hashicorp/terraform/issues/5614
2016-03-14 11:45:17 +00:00
71d93d2e5c
provider/vsphere: provide `host` to provisioner connections
2016-03-14 13:37:45 +09:00
189e9b5ceb
Merge pull request #5605 from nicolai86/bugfix/verify-ecs-elb-count
...
provider/aws validate number of load_balancers before creating aws_ecs_service
2016-03-13 15:15:00 +00:00
fc0c2c0ea7
Validate number of load_balancers
...
see #5336
2016-03-13 12:51:51 +01:00
25383ad5a3
aws: Fix CloudFormation update for parameters & capabilities if not modified
2016-03-13 08:10:57 +00:00
8612cc3373
aws: Improve acceptance test for CloudFormation w/ all attributes
2016-03-13 08:10:54 +00:00
66eb7c6055
provider/aws: Guard against Nil Reference in Redshift Endpoints
2016-03-11 12:16:29 -06:00
d8b36532ef
Merge pull request #5239 from TimeIncOSS/f-aws-lambda-func-updates
...
provider/aws: Add support for updating Lambda function
2016-03-11 16:59:18 +00:00
96ebf0af0e
provisioner/remote-exec: Clear out scripts after uploading
...
Prevents residual script contents from remaining on machine.
Fixes #482
2016-03-11 10:25:11 -06:00
d9d8208a91
Fix panic in digital_ocean_droplet if resp is nil
...
Fixes #5583 .
2016-03-11 16:00:13 +00:00
63008b857f
Make name optional on cloudstack_instance resource
...
This commit matches the behaviour of the cloudstack_instance resource to
the documentation at [1], which indicates that the virtual machine name
is optional. This also changes the update logic to allow it to be
updated as described in [2].
[1] http://cloudstack.apache.org/api/apidocs-4.8/domain_admin/deployVirtualMachine.html
[2] http://cloudstack.apache.org/api/apidocs-4.8/domain_admin/updateVirtualMachine.html
2016-03-11 15:59:40 +00:00
edb30d52c6
Merge pull request #5557 from pfrybar/master
...
provider/openstack: Fix create/delete statuses in load balancing resources for openstack provider.
2016-03-10 22:46:36 -07:00
82765ea589
Merge pull request #5453 from bigkraig/aws-s3-kms-key
...
provider/aws: Support KMS encryption of S3 objects
2016-03-10 15:44:10 -06:00
5ce68fd1bd
Merge pull request #5571 from hashicorp/revert-5193-f-aws-instance-security-groups-updates
...
Revert "provider/aws: Support additional changes to security groups of instance without forcing new"
2016-03-10 15:09:16 -06:00
7c58f145fd
Merge pull request #5570 from hashicorp/b-aws-acc-test-updates
...
provider/aws: More Acc test updates
2016-03-10 15:04:33 -06:00
e9c4d4f6d5
Revert "provider/aws: Support additional changes to security groups of instance without forcing new"
2016-03-10 14:51:30 -06:00
02ba1bf2d4
provider/aws: More Acc test updates
...
Working on the green
- randomize some Autoscaling lifecycle hook test names
- use vpc_security_group_ids for this test
2016-03-10 14:33:54 -06:00
0254f95cc9
Merge pull request #5564 from lwander/b-gcp-route-network
...
provider/google: Mark next_hop_network as read only.
2016-03-10 14:38:08 -05:00
4e9e0ec5ca
Merge pull request #5563 from hashicorp/phinze/deprecate-template-path
...
provider/template: warn when template specified as path
2016-03-10 13:30:23 -06:00
f8784df82b
provider/google: Mark next_hop_network as read only.
2016-03-10 13:58:09 -05:00
0036db8f82
provider/template: warn when template specified as path
...
Turns out the BC code allowed users to move from `filename` to
`template` to squash the warning without having to switch from template
paths to template contents.
Here we warn when `template` is specified as a path so we can remove the
functionality in the future and remove this source of confusion.
refs #3732
2016-03-10 12:34:56 -06:00
2e33f5311c
Treat each consul key as having its own lifecycle
...
Previously this resource managed the set of keys as a whole rather than
the individual keys, and so it was unable to recognize when a particular
managed key is removed and delete just that one key from Consul.
Here this is addressed by recognizing that each key actually has its own
lifecycle, and detecting when individual keys are added and removed
without replacing the entire consul_keys instance.
Additionally this restores the behavior of updating the "value" attribute
on read, but restricts it only to blocks that already had a value so as
to avoid the quirkiness seen previously when we updated blocks that were
intended to be read-only. Updating the value is important now, because we
rely on this to detect and repair discrepancies between values stored in
Consul and values given in the configuration.
This change produces a change in the handling of the "delete" attribute.
Before it was considered only when the entire consul_keys resource was
deleted, but now it is considered also when a particular key block is
removed from within a resource.
2016-03-10 07:52:43 -08:00
df2ce588bc
Specialized client for interacting with Consul keys
...
This deals with some of the quirks of interacting with the Consul API,
with the goal of making the consul_keys resource implementation, and
later the consul_keys data source, less noisy to read.
2016-03-10 07:51:27 -08:00
d8c9e448d4
Fix create/delete statuses in load balancing resources for openstack provider.
2016-03-10 09:35:38 -06:00
99ddea503d
Merge pull request #5495 from nicolai86/bugfix/aws_security_group-protocol-case-sensitivity
...
provider/aws Always transform aws_security_group protocol to lower case
2016-03-10 09:34:55 -06:00
239b3e4f5f
Merge pull request #5533 from hashicorp/pr-5184
...
provider/aws: Fix EC2 Classic SG Rule issue
2016-03-10 08:56:29 -06:00
d777141a7b
provider/aws: Add tests for Lambda function updates
2016-03-10 12:31:35 +00:00
fdc21aad25
provider/aws: Simplify update logic for Lambda function
2016-03-10 12:31:35 +00:00
b5c7521f52
aws_lambda_function: Force code update on SHA sum mismatch
2016-03-10 12:31:35 +00:00
4aeb5bb8e9
Adding support for Lambda function updates
2016-03-10 12:31:35 +00:00
76b3c74a58
Providing a more informative error message when combining kms_key_id and etag as well as using aws_kms_key to test aws_s3_bucket's kms_key_id.
2016-03-09 19:06:36 -08:00
5ece31dc88
Merge pull request #5501 from evandbrown/vpnval
...
provider/google: Validate VPN tunnel peer_ip
2016-03-09 18:55:10 -06:00
c1f8dda863
Merge pull request #5497 from evandbrown/flakeygcs
...
provider/google: Address flaky GCS acceptance tests.
2016-03-09 18:48:44 -06:00
d12944797a
Merge pull request #3928 from TimeIncOSS/aws-kms
...
provider/aws: Add support for KMS
2016-03-09 18:30:06 -06:00
108ccf0007
builtin: Refactor resource.Retry to clarify return
...
Change the `RetryFunc` from a plain `error` return type to a
specialized `RetryError` which must decide whether it is
retryable or not.
Add `RetryableError` / `NonRetryableError` factory functions that
callers are meant to use to build up these errors.
This makes it eminently clear whether or not a given error is
retryable from inside the client code.
Goal here is to _not_ change any behavior, simply reflect the
existing behavior with the new, clearer, API.
2016-03-09 17:37:56 -06:00
ab075bca60
Merge pull request #5193 from innossh/f-aws-instance-security-groups-updates
...
provider/aws: Support additional changes to security groups of instance without forcing new
2016-03-10 00:28:32 +01:00
7436cf7f89
Merge pull request #5376 from stack72/b-aws-ELBListner
...
provider/aws: Fixes the use of Uppercase chars in ELB Listeners
2016-03-09 23:18:56 +00:00
ffa5db4f52
Merge pull request #5538 from hashicorp/phinze/retryerror-pointers-are-evil
...
provider/aws: Fix all pointer RetryError returns
2016-03-09 16:53:19 -06:00
3f41515d2b
Fixing noop differences in aws_route.
2016-03-09 23:27:09 +01:00
16f94ed4b7
Added failing aws_route test that shows diff after apply.
2016-03-09 23:27:09 +01:00
f96ec46681
update comments
2016-03-09 15:50:01 -06:00
d14920adaf
Merge pull request #5515 from hashicorp/b-aws-acc-test-updates
...
provider/aws: Retry DB Creation on IAM propigation error
2016-03-09 15:08:13 -06:00
23c42cd6cf
Add test for flattenSecurityGroups
2016-03-09 15:00:30 -06:00
de656942ae
provider/aws: Fix all pointer RetryError returns
...
All of these RetryErrors were meant to fail right away, but instead
caused retry looping because the typecheck in the implementation of
`resource.Retry()` only catches the value type, and not the pointer
type.
Refs #5537
2016-03-09 14:59:55 -06:00
9e0bac6c9f
Terraform should keep track of the publicly accessible attribute
2016-03-09 13:33:00 -05:00
54cb5ffe00
provider/aws: Fix EC2 Classic SG Rule issue
...
Fixes an issue where security groups would fail to update after applying an
initial security_group, because we were improperly saving the id of the group
and not the name (EC2 Classic only).
This is a PR combining https://github.com/hashicorp/terraform/pull/4983 and
https://github.com/hashicorp/terraform/pull/5184 . It's majority
@ephemeralsnow's work.
2016-03-09 09:51:41 -06:00
b0d53a99c2
Merge pull request #4834 from erobert-c/gce_instance_template_preemptible
...
Fix Google instance template creation for preemptible VM
2016-03-09 10:34:20 -05:00
4601d371e1
Merge pull request #5524 from stack72/f-aws-ecr-repository_name
...
provider/aws: `repository_url` is computed for `aws_ecr_repository`
2016-03-09 09:38:09 +00:00
7c5ab40b74
provider/aws: Add support for the `repository_url` to be computed for
...
ECR
2016-03-09 09:29:23 +00:00
b5e6cb5f88
Merge pull request #5520 from bsiegel/aws_rds_cluster_encryption
...
Add storage_encrypted as an optional parameter to aws_rds_cluster
2016-03-09 00:21:26 +00:00
cad550e63d
provider/aws: Add support for `description` to `aws_network_interface`
...
resource
2016-03-08 23:28:37 +00:00
fc7e9fcd53
Ensure aws_rds_cluster can have storage_encrypted set to true
2016-03-08 17:28:44 -05:00
0085bf6ae8
Ensure aws_rds_cluster has storage_encrypted set to false by default
2016-03-08 17:28:32 -05:00
b3864db462
fixup! Add storage_encrypted as an optional parameter to aws_rds_cluster
2016-03-08 17:15:01 -05:00
c1b373ad5f
Add Github Organization provider.
...
Allows for managing organization membership, teams, team membership, and
team repositories.
2016-03-08 23:06:30 +01:00
8aadf1d56d
Add storage_encrypted as an optional parameter to aws_rds_cluster
2016-03-08 16:48:04 -05:00
c29e1f24b8
provider/aws: Retry DB Creation on IAM propigation error
2016-03-08 14:09:42 -06:00
92d535267c
Fix Google instance template creation for preemptible VM
2016-03-08 16:18:23 +00:00
5dc387354d
provider/aws: Randomize tests more to reduce conflicts
...
- ASG placement tests
- Randomize DynamoDB names in tests
- tag the sg created in this test to help identify in the console
- randomize policy and role names
2016-03-08 09:56:14 -06:00
d4d20a9f5a
kms: Treat keys in PendingDeletion state as deleted
2016-03-08 09:30:47 +00:00
6f8a9c0f77
aws: kms_key - Add support for is_enabled + enable_key_rotation
2016-03-08 09:30:47 +00:00
347913a3be
aws: kms_key - Iterate over all aliases (not just 50)
2016-03-08 09:30:47 +00:00
ff2d040d28
aws: kms_key + kms_alias - Add acceptance tests
2016-03-08 09:30:47 +00:00
ccedb36a86
aws: kms_key - add forgotten policy read call + normalize
2016-03-08 09:30:47 +00:00
4c1f8db32d
aws: kms_key - Change field name (deletion_window -> deletion_window_in_days)
2016-03-08 09:30:47 +00:00
fccffbcbb1
aws: kms_alias - Remove unnecessary default ForceNew state
2016-03-08 09:30:47 +00:00
5c9fe668f5
aws: kms resources - Simplify error handling
2016-03-08 09:30:47 +00:00
2b244e21bc
aws: kms validation - Add missing placeholders for Errorf
2016-03-08 09:30:47 +00:00
5466d69450
aws: kms resources - gofmt all the code
2016-03-08 09:30:47 +00:00
5e18031367
Update AWS KMS with respect to key deletion features
2016-03-08 09:30:47 +00:00
6648df7acc
Added AWS KMS key & alias support
2016-03-08 09:30:47 +00:00
23af84ca09
provider/google: Validate VPN tunnel peer_ip
2016-03-07 21:35:08 -08:00
aa5099fe9b
provider/google: Address flaky GCS acceptance tests.
...
Acceptance tests for GCS that do rapid create/delete/create
on GCS buckets using the same name sometimes fail as the
bucket namespace is eventually consistent. This change makes
tests use a random bucket name for each test (adapted from
the existing ACL tests).
2016-03-07 14:26:19 -08:00
2c698d2cb0
Always transform aws_security_group protocol to lower case
...
fixes #5489
2016-03-07 22:40:29 +01:00
f0d3176999
provider/aws: Add Elastic Beanstalk Application, Configuration Template, and Environment
...
This adds support for Elastic Beanstalk Applications, Configuration Templates,
and Environments.
This is a combined work of @catsby, @dharrisio, @Bowbaq, and @jen20
2016-03-07 14:43:23 -06:00
46e4717428
Merge pull request #5474 from kjmkznr/skip-normalize-empty-policy
...
provider/aws: Fix error parsing JSON in S3 bucket policy
2016-03-07 18:53:51 +01:00
122e9ac42a
Merge pull request #5476 from nicolai86/feature/docker-tag-handling
...
provider/docker fix image test assertions
2016-03-07 18:52:03 +01:00
00288c36b9
fix indentation
2016-03-07 22:18:58 +09:00
8d1292d608
Return empty string when input empty S3 bucket policy
...
Before:
"" -> "Error parsing JSON: unexpected end of JSON input"
After:
"" -> ""
2016-03-07 09:31:33 +09:00
f7d4aca965
Fix docker test assertions regarding latest tag
2016-03-06 16:45:06 +01:00
Paul Hinze