Commit Graph

66 Commits

Author SHA1 Message Date
Radek Simko 10f53e3471 Add links to details about sensitive data in state (#13145) 2017-03-29 10:37:36 +01:00
jonatanblue 62098886be add note about default storage for aws_db_instance (#10513)
* fixed broken link

* update one more link

* explicitly define map and change ami to trusty

* remove map definition

* added note about default storage type for aws_db_instance

* added note about default storage type for aws_db_instance

* revert changes to conform with master
2017-03-16 21:10:24 +00:00
Clint 2fe5976aec helper/schema: Add configurable Timeouts (#12311)
* helper/schema: Add custom Timeout block for resources

* refactor DefaultTimeout to suuport multiple types. Load meta in Refresh from Instance State

* update vpc but it probably wont last anyway

* refactor test into table test for more cases

* rename constant keys

* refactor configdecode

* remove VPC demo

* remove comments

* remove more comments

* refactor some

* rename timeKeys to timeoutKeys

* remove note

* documentation/resources: Document the Timeout block

* document timeouts

* have a test case that covers 'hours'

* restore a System default timeout of 20 minutes, instead of 0

* restore system default timeout of 20 minutes, refactor tests, add test method to handle system default

* rename timeout key constants

* test applying timeout to state

* refactor test

* Add resource Diff test

* clarify docs

* update to use constants
2017-03-02 11:07:49 -06:00
George Christou 61277c0dbd website/docs: Run `terraform fmt` on code examples (#12075)
* docs/vsphere: Fix code block

* docs: Convert `...` to `# ...` to allow `terraform fmt`ing

* docs: Trim trailing whitespace

* docs: First-pass run of `terraform fmt` on code examples
2017-02-19 00:48:50 +02:00
Paul Stack ced96aa90b provider/aws: Set aws_db_cluster to snapshot by default (#11668)
As requested in #11448

Terraform didn't snapshot AWS DB Instances by default. We are going to
change that behaviour going forward.
2017-02-03 17:21:25 +00:00
clint shryock 549fd22c87 provider/aws: Add support for setting MSSQL Timezone in aws_db_instance 2017-01-18 08:39:18 -06:00
Ninir 5481e9ecb3 provider/aws: Enforced kms_key_* attributes to be ARNs (#10356)
* Added kms_key_* validation to force ARNs

* Added Redshift Cluster KMS key test

* Added cloudtrail kms key test

* Added EBS volume kms key

* Added Elastic Transcoder Pipeline kms key arn test
2016-11-30 13:50:26 +02:00
James Gregory ea658635fe Point to CreateDBInstance docs for more info
The docs for the CreateDBInstance API call include quite a bit more information about each individual option, (for example `Engine` has each of the possible options listed, whilst the cli reference doesn't).
2016-11-21 10:01:17 +11:00
Paul Stack 73e191442d docs/aws: Rename zone_id to hosted_zone_id for aws_db_instance (#10010) 2016-11-10 06:50:02 +00:00
Michel Rasschaert 9774fcdbb0 documentation for db_instance.zone_id. 2016-11-09 20:40:40 +01:00
Krzysztof Wilczynski 263b1467a8
Remove references to documentation localised in French.
Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
2016-10-24 11:59:03 +01:00
Paul Stack 0adc1fc4b2 provider/aws: Allow `aws_rds_instance` to upgrade the major version (#8471)
Fixes #8468

If a user wished to bump the `engine_version` of an RDS instance,
Terraform was not sending `allow_major_version_upgrade` to the API
*unless* that value also changed at the same time. This caused the
following error from RDS API:

```
* aws_db_instance.bar: Error modifying DB Instance
* tf-20160825101420910562798obb: InvalidParameterCombination: The
* AllowMajorVersionUpgrade flag must be present when upgrading to a new
* major version.
    status code: 400, request id: 20e36364-6ab0-11e6-b794-51f12f4135f1
```

This change will always send the `allow_major_version_upgrade` flag to
the API when the `engine_version` changes.

This still relies on the user setting the correct value i.e. if they are
upgrading from postgres 0.4.7 -> 9.5.2 then the config will need to set
the `allow_major_version_upgrade` flag to be `true`
2016-08-25 13:54:40 +01:00
Michael Blakeley 03bc37edcb apostrophe police
Sorry, my OCD kicked in.

Use `it's` when you mean `it is`.
Use `its` when you mean something belongs to `it`.
2016-08-11 09:32:54 -07:00
Paul Stack 5f6ea8b18e documentation/aws: More additions of Import documention to the AWS (#7729)
resources
2016-07-20 23:28:59 +01:00
Justin Nauman 110714acc5 - Adding option_group_name to docs for db_instance (#7310) 2016-06-24 09:15:01 +01:00
Paul Stack 5ecc8e3169 provider/aws: `aws_db_instance` now defaults `publicly_accessible` to (#7117)
false

Fixes #7035

A known issue in Terraform means that d.GetOk() on a bool which is false
will mean it doesn't get evaulated. Therefore, when people set
publicly_accessible to false, it will never get evaluated on the Create

We are going to make it default to false now
2016-06-10 23:55:36 +02:00
stack72 b3d680eee0 Merge branch 'master' of https://github.com/statoilfuelretail/terraform into statoilfuelretail-master 2016-06-02 18:06:37 +01:00
Paul Stack 890eebabc4 provider/aws: Add note to AWS DB Instance Documentation about skip_final_snapshot (#6799) 2016-05-20 12:33:25 -05:00
Paul Stack cf37c3adaa provider/aws: Add support for `kms_key_id` to `aws_db_instance` (#6651)
As requested in #4822, add support for a KMS Key ID (ARN) for Db
Instance

```
make testacc TEST=./builtin/providers/aws
TESTARGS='-run=TestAccAWSDBInstance_kmsKey' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v
-run=TestAccAWSDBInstance_kmsKey -timeout 120m
=== RUN   TestAccAWSDBInstance_basic
--- PASS: TestAccAWSDBInstance_basic (587.37s)
=== RUN   TestAccAWSDBInstance_kmsKey
--- PASS: TestAccAWSDBInstance_kmsKey (625.31s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    1212.684s
```
2016-05-13 11:20:29 -05:00
Paul Hinze 4e5429a140 provider/aws: ability to generate unique RDS identifier
Needed to truncate the identifier for SQL Server engines to keep it at
max 15 chars per the docs. Not a full UUID going into it, but should be
"unique enough" to not matter in practice.

Modified the basic test to use the generated value. Other tests are
still working w/ explicitly specified identifiers.
2016-03-18 16:07:37 -05:00
Andy Chan 1fb74416ac Added the missing tags params to the doc 2016-03-16 16:20:40 -07:00
stack72 e87d3bb711 Enabled Enhanced Monitoring for RDS 2016-02-03 00:14:24 +00:00
Lars Bahner 9e3cef3ce5 Fixed typo in documentation. 2016-01-27 21:20:18 +01:00
Lars Bahner 8f2d39be45 On Oracle RDS DB instances you can't change the encoding
of the database after creation. So we need to be able to
set the CharacterSetName on creation.
This is an option and will automagically default to
AL32UTF8.

The AWS SDK will give you an error message if you try to
apply this setting to other engines. The patch will only
report the character_set_name attribute, if CharacterSetName
is set on the instance.

Signed-off-by: Lars Bahner <lars.bahner@gmail.com>
2016-01-27 18:39:00 +01:00
Seth Vargo 8dbc43639d Use HTTPS + www. for links 2016-01-14 16:03:26 -05:00
Koen De Causmaecker 45ef11e59f provider/aws: aws_db_instance: unrequire fields
When spinning up from a snapshot or a read replica, these fields are
now optional:
* allocated_storage
* engine
* password
* username

Some validation logic is added to make these fields required when
starting a database from scratch.
The documentation is updated accordingly.
2016-01-13 15:40:15 +01:00
kozo yamagata 2a3c80461f Fix typo 'auto' => 'allow' 2015-12-30 16:58:23 +09:00
clint shryock a5efa4a1fa Better document RDS apply immediately 2015-12-18 11:24:59 -06:00
stack72 2b0c7aa4e9 Making the changes to db_instance skip_final_snapshot on the feedback from @catsby 2015-12-10 23:21:36 +00:00
stack72 5796b13373 Adding skip_final_snapshop bool to th db_instance. This will allow us to specify whether a snapshot is needed directly rather than checking for an empty string 2015-12-10 19:11:47 +00:00
Clint ced42342ff Merge pull request #4215 from hashicorp/pr-4207
Fix issue creating AWS RDS replicas across regions
2015-12-09 09:54:53 -06:00
clint shryock 0619898f6a provider/aws: Add arn to DB Instance output 2015-12-08 10:52:17 -06:00
stack72 a0a89ecde8 Documenting the version upgrade flags on db_instance 2015-12-08 14:13:26 +00:00
James Nugent ca442bf00b Merge pull request #3818 from ijin/patch-1
provider/aws: Document `license_model` as supported argument for db_instance
2015-11-10 17:40:15 -05:00
stack72 1abb0b19bf Changing the db_instance resource to mark the engine_version as Optional 2015-11-10 17:30:09 +00:00
Michael H. Oshita 22876be830 Document `license_model` as supported argument
Required for Oracle SE1
2015-11-10 14:31:55 +09:00
clint shryock 20bc0ca3cd document copy_tags 2015-10-16 11:20:24 -05:00
Mike Fiedler 10c96afa9b Update aws_db_instance `db_subnet_group_name`
When launching a new RDS instance in a VPC-default AWS account, trying to control which VPC the new RDS instance lands in is not apparent from the parameters available.
The following works:
```
resource "aws_db_subnet_group" "foo" {
  name = "foo"
  description = "DB Subnet for foo"
  subnet_ids = ["${aws_subnet.foo_1a.id}", "${aws_subnet.foo_1b.id}"]
}

resource "aws_db_instance" "bar" {
...
  db_subnet_group_name   = "${aws_db_subnet_group.foo.name}"
...
}
```

Hopefully this doc update will help others
2015-09-08 09:10:54 -04:00
Adam Enger d206d6d5d8 Adding snapshot_identifier to db_instance docs 2015-06-30 15:33:13 -05:00
Jason Gedge 11b136f503 Grammar fix in the aws_db_instance docs. 2015-06-15 13:32:30 -04:00
Andrew Langhorn 70c90f420e Clarify syntax for RDS maintenance window param
Closes #2069
2015-06-02 07:44:09 +01:00
Radek Simko ff2f446eb4 aws_db_instance docs updated per #2070 2015-05-26 00:14:44 +01:00
Radek Simko d569e14121 Merge pull request #2070 from managedbyq/master
providers/aws: Clarifies db_security_group usage docs.
2015-05-25 16:10:49 -07:00
Camilo Aguilar e94a8b2627 providers/aws: Adds link to AWS docs about RDS parameters. 2015-05-25 18:57:23 -04:00
Andrew Langhorn b451eed453 "More more" no more!
We don't need to say "for more for more" here, because it
doesn't make sense. Fixes this.
2015-05-25 15:37:49 +01:00
Clint Shryock 729238675b update docs 2015-05-21 15:06:22 -05:00
Clint Shryock 6de8f9d180 provider/aws: RDS Read Replica cleanups
remove typos, debugging, and try spelling things correctly
2015-05-21 09:49:46 -05:00
Clint Shryock d755fbd347 provider/aws: Add docs for AWS RDS Read Replicate 2015-05-20 08:24:36 -05:00
Nick HS 39598cf1fa Rename False to false in aws_db_instance
False isn't allowed in hcl, just fixing a typo
2015-04-03 15:19:41 -04:00
Clint Shryock e485767694 provider/aws: Add non-destructive updates to AWS RDS
This introduces non-destructive, in-place upgrades to MultiAZ and Engine Version
attributes of AWS RDS instances.
2015-03-31 09:41:37 -05:00